kriegaex commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1837317841
> I was solely refering to the fact that this `@Parameter` is read-only
Hm, right. Maybe it should not be read-only.
> but some don't say that the user can change i
michael-o commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1837267557
> @michael-o, the way I understand it, the description applies to what I
call the _base_ directory, i.e. the `${project.reporting.outputDirectory}` in
case of site generation.
kriegaex commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1833228927
@michael-o, the way I understand it, the description applies to what I call
the _base_ directory, i.e. the `${project.reporting.outputDirectory}` in case
of site generation. AF
michael-o commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1830036015
@kriegaex, look what I have found:
*
https://maven.apache.org/plugins/maven-site-plugin/examples/configuring-reports.html:
> Note: Many report plugins provide a parameter
michael-o commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1818989581
> Was the documentation updated to reflect this change?
This hasn't been merged yet since I need to test this through all of our
reporting plugins first. If this gets me
cowwoc commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1818973142
Was the documentation updated to reflect this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
michael-o commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1807216517
I have pushed two more pending commits are the prerequisite to this one.
Let's see how our plugins work now.
--
This is an automated message from the Apache Git Service.
To
michael-o commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1806810243
> > I still stand with `reports`.
>
> I rebased and force-pushed the PR with the updated directory.
>
> > Though, I need to test the entire chain first.
>
>
kriegaex commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1806677901
> I still stand with `reports`.
I rebased and force-pushed the PR with the updated directory.
> Though, I need to test the entire chain first.
I am not sure
michael-o commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1805231560
I still stand with `reports`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
kriegaex commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1804970463
> Even if a plugin uses a subdir in the shared one, there are still assets
from the skin which need to be present to properly render the report in the
browser.
Then, I t
michael-o commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1798296831
> > would you keep it in the build output dir directory? What is your
opinion on the clutter?
>
> Good catch! My use case with AspectJ reporting is a multi-page report,
kriegaex commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1797056331
> would you keep it in the build output dir directory? What is your opinion
on the clutter?
My use case with AspectJ reporting is a multi-page report, for which always
a
michael-o commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1796462318
@kriegaex I have rebased this PR.
Here is the output when there is no subdir:
```
D:\Entwicklung\Projekte\maven-reporting-impl [patch-1 ≡ +2 ~0 -0 !]> ls
D:\Entwicklun
michael-o commented on code in PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#discussion_r1375425144
##
src/main/java/org/apache/maven/reporting/AbstractMavenReport.java:
##
@@ -74,11 +74,16 @@
*/
public abstract class AbstractMavenReport extends Abstrac
michael-o commented on code in PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#discussion_r1375425144
##
src/main/java/org/apache/maven/reporting/AbstractMavenReport.java:
##
@@ -74,11 +74,16 @@
*/
public abstract class AbstractMavenReport extends Abstrac
michael-o commented on code in PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#discussion_r1372885052
##
src/main/java/org/apache/maven/reporting/AbstractMavenReport.java:
##
@@ -74,11 +74,16 @@
*/
public abstract class AbstractMavenReport extends Abstrac
kriegaex commented on code in PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#discussion_r1371585628
##
src/main/java/org/apache/maven/reporting/AbstractMavenReport.java:
##
@@ -74,11 +74,16 @@
*/
public abstract class AbstractMavenReport extends Abstract
michael-o commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1777999520
@hboutemy, WDYT? Build directory or rather a subdir? I tend to a subdir for
consistency reasons.
--
This is an automated message from the Apache Git Service.
To respond to t
michael-o commented on code in PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#discussion_r1370778946
##
src/main/java/org/apache/maven/reporting/AbstractMavenReport.java:
##
@@ -74,11 +74,16 @@
*/
public abstract class AbstractMavenReport extends Abstrac
kriegaex commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1774586030
@michael-o: MSHARED-1327 created and force-pushed commit with issue ID
prefix and corrected `use-as-direct-mojo*` ITs.
--
This is an automated message from the Apache Git Ser
kriegaex commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1774568959
OK, if you wish to handle it separately from
[MSHARED-1326)(https://issues.apache.org/jira/browse/MSHARED-1326), I can do
that.
--
This is an automated message from the Apac
22 matches
Mail list logo
