michael-o commented on PR #26:
URL: 
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1837267557

   > @michael-o, the way I understand it, the description applies to what I 
call the _base_ directory, i.e. the `${project.reporting.outputDirectory}` in 
case of site generation. AFAIR, that one can also be adjusted, if a user wants 
to change it. In case of stand-alone execution, the default base directory 
should be `${project.build.directory}` so as not to interfere with the site 
base directory. That is the whole point of this PR.
   > 
   > The description IMO says nothing whatsoever about the plugin-specific 
report output directory, e.g. `apidocs` or `surefire-reports`. Those are inside 
the base directories and there is no reason for them not to be adjustable too.
   > 
   > Of course, `outputDirectory` is only relevant for stand-alone execution, 
because otherwise Maven Site determines the base directory. Actually, I see 
nothing in that text contradicting with what I suggested.
   
   You completely misunderstood what I was trying to say. I was solely refering 
to the fact that this `@Parameter` is read-only, but some don't say that the 
user can change its value during standalone execution which is not correct. 
Personally. I do not know wether it makes sense to make this shared output dir 
for **standalone**  execution configurable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to