cstamas commented on PR #437:
URL: https://github.com/apache/maven-resolver/pull/437#issuecomment-1973537521
While all this is nice and dandy, I agree with @gnodet
* this PR clearly shows signs of "being tailored" for current Maven3 use case
* what consumer project should do instead, i
cstamas closed pull request #437: [MRESOLVER-502] Install/Deploy at session end
URL: https://github.com/apache/maven-resolver/pull/437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
cstamas commented on PR #437:
URL: https://github.com/apache/maven-resolver/pull/437#issuecomment-1971738341
> I'm not really convinced. I don't think the logic in the resolver is very
different from the one in the install/deploy plugin
Is a LOT different. Here, it is really plain str
cstamas commented on PR #437:
URL: https://github.com/apache/maven-resolver/pull/437#issuecomment-1971723082
> Another question, given this is a global flag on the session, how can the
install/deploy plugin set it ?
Unsure I get the question, so let me ask back: why would this be set
gnodet commented on PR #437:
URL: https://github.com/apache/maven-resolver/pull/437#issuecomment-1971528168
Another question, given this is a global flag on the session, how can the
install/deploy plugin set it ?
--
This is an automated message from the Apache Git Service.
To respond to t
gnodet commented on PR #437:
URL: https://github.com/apache/maven-resolver/pull/437#issuecomment-1971524721
> Benefits are manifold, but let me turn around the thing: I don't see any
benefit in "failing the build/processing in usual way" by maven. In fact, there
is only one (easily fixable)
cstamas commented on code in PR #437:
URL: https://github.com/apache/maven-resolver/pull/437#discussion_r1507441938
##
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:
##
@@ -83,6 +86,30 @@
@Singleton
@Named
public class DefaultDeployer
michael-o commented on code in PR #437:
URL: https://github.com/apache/maven-resolver/pull/437#discussion_r1507432682
##
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultInstaller.java:
##
@@ -64,6 +68,30 @@
@Singleton
@Named
public class DefaultInsta
cstamas opened a new pull request, #437:
URL: https://github.com/apache/maven-resolver/pull/437
Now that Resolver got session lifecycle, it can
do interesting things.
---
https://issues.apache.org/jira/browse/MRESOLVER-502
--
This is an automated message from the Apache Gi
