cstamas commented on PR #437:
URL: https://github.com/apache/maven-resolver/pull/437#issuecomment-1971738341
   > I'm not really convinced. I don't think the logic in the resolver is very 
different from the one in the install/deploy plugin
   
   Is a LOT different. Here, it is really plain straight forward, while in 
plugins it does hoops and loops to:
   * figure out "is it end" (w/ respect of multi module builds, parallel 
builds, etc)?
   * figure modules in reactor that may not use install plugin and consider 
them as well
   * keep state and do something wildly different if "not end"
   * etc.
   
   Here, Installer/Deployer simply gets the "done done" list of artifacts that 
are to be installed. And done.
   
   And plugins just "install/deploy", no logic, they are no brainer, and IMHO 
corresponding logic (here in this PR) is also much much simpler. 
   
   Btw, it is a sign that "deploy at end" was not solved properly for so long...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to