Re: [PR] [MPOM-453] Disable annotation processing by compiler [maven-parent]

2025-03-06 Thread via GitHub
jira-importer commented on PR #157: URL: https://github.com/apache/maven-parent/pull/157#issuecomment-2703320372 Resolve #316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [MPOM-453] Disable annotation processing by compiler [maven-parent]

2024-07-02 Thread via GitHub
gemmellr commented on code in PR #157: URL: https://github.com/apache/maven-parent/pull/157#discussion_r1654716939 ## pom.xml: ## @@ -945,6 +945,8 @@ under the License. 8 ${javaVersion} ${javaVersion} + +none Review Comment: Unfortunate. Will likely ju

Re: [PR] [MPOM-453] Disable annotation processing by compiler [maven-parent]

2024-07-02 Thread via GitHub
slawekjaranowski commented on code in PR #157: URL: https://github.com/apache/maven-parent/pull/157#discussion_r1653276430 ## pom.xml: ## @@ -945,6 +945,8 @@ under the License. 8 ${javaVersion} ${javaVersion} + +none Review Comment: ups ... ```

Re: [PR] [MPOM-453] Disable annotation processing by compiler [maven-parent]

2024-01-27 Thread via GitHub
slawekjaranowski merged PR #157: URL: https://github.com/apache/maven-parent/pull/157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] [MPOM-453] Disable annotation processing by compiler [maven-parent]

2024-01-25 Thread via GitHub
kwin commented on code in PR #157: URL: https://github.com/apache/maven-parent/pull/157#discussion_r1466289438 ## pom.xml: ## @@ -945,6 +945,7 @@ under the License. 8 ${javaVersion} ${javaVersion} +none Review Comment: maybe a small comment would help here

Re: [PR] [MPOM-453] Disable annotation processing by compiler [maven-parent]

2024-01-20 Thread via GitHub
slawekjaranowski commented on PR #157: URL: https://github.com/apache/maven-parent/pull/157#issuecomment-1902068691 - m-compiler-p `proc` parameter doesn't have a property - we can use property which can be overridded by empty value, to achieve default behavior, in child project -- Th

Re: [PR] [MPOM-453] Disable annotation processing by compiler [maven-parent]

2024-01-19 Thread via GitHub
bmarwell commented on PR #157: URL: https://github.com/apache/maven-parent/pull/157#issuecomment-190747 We could introduce a property, eg `maven.compiler.apt.default` or similar. Easy to override per project via `.mvn/jvm.options`. I think the way to go is to introduce a new defa

Re: [PR] [MPOM-453] Disable annotation processing by compiler [maven-parent]

2024-01-16 Thread via GitHub
slawekjaranowski commented on PR #157: URL: https://github.com/apache/maven-parent/pull/157#issuecomment-1893332054 I need more tests ... like possibility to override -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [MPOM-453] Disable annotation processing by compiler [maven-parent]

2024-01-15 Thread via GitHub
kwin commented on PR #157: URL: https://github.com/apache/maven-parent/pull/157#issuecomment-1892766720 I think it is best practice to only enable annotation processors by their fully qualified class name. This is possible by setting https://maven.apache.org/plugins/maven-compiler-plugin/co

Re: [PR] [MPOM-453] Disable annotation processing by compiler [maven-parent]

2024-01-15 Thread via GitHub
cstamas commented on PR #157: URL: https://github.com/apache/maven-parent/pull/157#issuecomment-1892757366 With a grain of salt... I'd rather define `compiler.proc=none` property and allow that property to be changed, than this. As if project DOES need annotation processing, and is below Ja

Re: [PR] [MPOM-453] Disable annotation processing by compiler [maven-parent]

2024-01-14 Thread via GitHub
slawekjaranowski commented on PR #157: URL: https://github.com/apache/maven-parent/pull/157#issuecomment-1891022896 We use `sisu-maven-plugin` for generating list of components, so should be ok. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] [MPOM-453] Disable annotation processing by compiler [maven-parent]

2024-01-14 Thread via GitHub
cstamas commented on PR #157: URL: https://github.com/apache/maven-parent/pull/157#issuecomment-1891022212 This can be a problem, as now way to override this later (only in java 20? "full"?) @bmarwell will tell :smile: -- This is an automated message from the Apache Git Service. To respo