jira-importer commented on PR #157:
URL: https://github.com/apache/maven-parent/pull/157#issuecomment-2703320372
Resolve #316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
gemmellr commented on code in PR #157:
URL: https://github.com/apache/maven-parent/pull/157#discussion_r1654716939
##
pom.xml:
##
@@ -945,6 +945,8 @@ under the License.
8
${javaVersion}
${javaVersion}
+
+none
Review Comment:
Unfortunate. Will likely ju
slawekjaranowski commented on code in PR #157:
URL: https://github.com/apache/maven-parent/pull/157#discussion_r1653276430
##
pom.xml:
##
@@ -945,6 +945,8 @@ under the License.
8
${javaVersion}
${javaVersion}
+
+none
Review Comment:
ups ...
```
slawekjaranowski merged PR #157:
URL: https://github.com/apache/maven-parent/pull/157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
kwin commented on code in PR #157:
URL: https://github.com/apache/maven-parent/pull/157#discussion_r1466289438
##
pom.xml:
##
@@ -945,6 +945,7 @@ under the License.
8
${javaVersion}
${javaVersion}
+none
Review Comment:
maybe a small comment would help here
slawekjaranowski commented on PR #157:
URL: https://github.com/apache/maven-parent/pull/157#issuecomment-1902068691
- m-compiler-p `proc` parameter doesn't have a property
- we can use property which can be overridded by empty value, to achieve
default behavior, in child project
--
Th
bmarwell commented on PR #157:
URL: https://github.com/apache/maven-parent/pull/157#issuecomment-190747
We could introduce a property, eg `maven.compiler.apt.default` or similar.
Easy to override per project via `.mvn/jvm.options`.
I think the way to go is to introduce a new defa
slawekjaranowski commented on PR #157:
URL: https://github.com/apache/maven-parent/pull/157#issuecomment-1893332054
I need more tests ... like possibility to override
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kwin commented on PR #157:
URL: https://github.com/apache/maven-parent/pull/157#issuecomment-1892766720
I think it is best practice to only enable annotation processors by their
fully qualified class name. This is possible by setting
https://maven.apache.org/plugins/maven-compiler-plugin/co
cstamas commented on PR #157:
URL: https://github.com/apache/maven-parent/pull/157#issuecomment-1892757366
With a grain of salt... I'd rather define `compiler.proc=none` property and
allow that property to be changed, than this. As if project DOES need
annotation processing, and is below Ja
slawekjaranowski commented on PR #157:
URL: https://github.com/apache/maven-parent/pull/157#issuecomment-1891022896
We use `sisu-maven-plugin` for generating list of components, so should be
ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
cstamas commented on PR #157:
URL: https://github.com/apache/maven-parent/pull/157#issuecomment-1891022212
This can be a problem, as now way to override this later (only in java 20?
"full"?) @bmarwell will tell :smile:
--
This is an automated message from the Apache Git Service.
To respo
12 matches
Mail list logo
