gemmellr commented on code in PR #157:
URL: https://github.com/apache/maven-parent/pull/157#discussion_r1654716939
##########
pom.xml:
##########
@@ -945,6 +945,8 @@ under the License.
<javaVersion>8</javaVersion>
<maven.compiler.source>${javaVersion}</maven.compiler.source>
<maven.compiler.target>${javaVersion}</maven.compiler.target>
+ <!-- in order to restore default annotation processing behaviour, please
override with empty value -->
+ <maven.compiler.proc>none</maven.compiler.proc>
Review Comment:
Unfortunate. Will likely just need to avoid maven.compiler.proc=none for any
projects that do want to do some annotation processing, as its likely to be
some time before requiring Maven 4 is viable for some of them.
I did think of an ugly alternative that seems like it may actually work:
defining annotationProcessorPaths in the parent pom with a path that _doesnt_
have any annotation processor, thus stopping it finding any unless
annotationProcessorPaths is updated. Then use annotationProcessorPaths
definitions with combine.children="append" (or perhaps combine.self="override"
when sure there are no other potential processors...in my case there are) to
add all the actual processor paths when/where needed. Stops implicit search of
all the deps, and stops the warnings on JDK21/22.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
