Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas merged PR #2117: URL: https://github.com/apache/maven/pull/2117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967550310 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +130,133 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967550310 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +130,133 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967550310 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +130,133 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967550310 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +130,133 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967539205 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +130,133 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

gnodet commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967512317 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/ShellInvoker.java: ## @@ -132,16 +134,28 @@ public boolean isCommandOrScript(String command) {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

gnodet commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967511670 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnenc/EncryptInvoker.java: ## @@ -78,8 +78,8 @@ protected int execute(EncryptContext context) throws Excep

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967483883 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +129,133 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967411276 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +129,133 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967411276 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +129,133 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967411276 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +129,133 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

gnodet commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967410126 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +129,133 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967407763 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +129,133 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967403213 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +129,133 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967383733 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -75,15 +75,14 @@ private BuiltinShellCommandRe

Re: [PR] [MNG-8587] mvnsh navigation [maven]

gnodet commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967365909 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -75,15 +75,14 @@ private BuiltinShellCommandReg

Re: [PR] [MNG-8587] mvnsh navigation [maven]

gnodet commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967365909 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -75,15 +75,14 @@ private BuiltinShellCommandReg

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967339320 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +129,133 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967334982 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +129,133 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967332588 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -75,15 +75,14 @@ private BuiltinShellCommandRe

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967332588 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -75,15 +75,14 @@ private BuiltinShellCommandRe

Re: [PR] [MNG-8587] mvnsh navigation [maven]

gnodet commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967327771 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +129,133 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

gnodet commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967327771 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +129,133 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

gnodet commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967319388 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +129,133 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

gnodet commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967314416 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +129,133 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

gnodet commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1967309050 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -75,15 +75,14 @@ private BuiltinShellCommandReg

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1966884710 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +129,140 @@ public String name() {

Re: [PR] [MNG-8587] mvnsh navigation [maven]

slawekjaranowski commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1966516389 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnsh/builtin/BuiltinShellCommandRegistryFactory.java: ## @@ -130,53 +129,140 @@ public String nam

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on PR #2117: URL: https://github.com/apache/maven/pull/2117#issuecomment-2675734931 Anyone? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on PR #2117: URL: https://github.com/apache/maven/pull/2117#issuecomment-2674216789 Applied proposed changes. And some explanations: * removing special handling for ".." and simplified things * we deal with 3 paths: installationDir, userDir and CWD. Former two are nev

Re: [PR] [MNG-8587] mvnsh navigation [maven]

gnodet commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1964040830 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/Directory.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] [MNG-8587] mvnsh navigation [maven]

gnodet commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1964040830 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/Directory.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] [MNG-8587] mvnsh navigation [maven]

gnodet commented on code in PR #2117: URL: https://github.com/apache/maven/pull/2117#discussion_r1964029761 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/Directory.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] [MNG-8587] mvnsh navigation [maven]

cstamas commented on PR #2117: URL: https://github.com/apache/maven/pull/2117#issuecomment-2667969667 @gnodet help needed, tried to implement the "shell" command as usually done with `!`, but for some reason did not work, `!ls` invoked the `ls` command (the `!` got removed for some reason).