Re: [PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-21 Thread via GitHub
cstamas merged PR #2116: URL: https://github.com/apache/maven/pull/2116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

Re: [PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-21 Thread via GitHub
cstamas commented on code in PR #2116: URL: https://github.com/apache/maven/pull/2116#discussion_r1965638585 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/BaseParser.java: ## @@ -350,10 +350,26 @@ protected Map populateSystemProperties(LocalContext context) {

Re: [PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-21 Thread via GitHub
gnodet commented on code in PR #2116: URL: https://github.com/apache/maven/pull/2116#discussion_r1965576998 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/BaseParser.java: ## @@ -350,10 +350,26 @@ protected Map populateSystemProperties(LocalContext context) {

Re: [PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-21 Thread via GitHub
Bukama commented on code in PR #2116: URL: https://github.com/apache/maven/pull/2116#discussion_r1965470575 ## api/maven-api-core/src/main/java/org/apache/maven/api/Constants.java: ## @@ -30,9 +30,57 @@ public final class Constants { * * @since 3.0.0 */ -@C

Re: [PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-20 Thread via GitHub
gnodet commented on code in PR #2116: URL: https://github.com/apache/maven/pull/2116#discussion_r1964025913 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/BaseParser.java: ## @@ -352,6 +352,22 @@ protected Map populateSystemProperties(LocalContext context) {

Re: [PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-18 Thread via GitHub
slawekjaranowski commented on PR #2116: URL: https://github.com/apache/maven/pull/2116#issuecomment-2666204450 > @gnodet @slawekjaranowski given `maven.version.major` "does the job" (for use case explained above) am tinkering to we want maybe to lower what we expose here? Is minor/patch/sna

Re: [PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-18 Thread via GitHub
Bukama commented on PR #2116: URL: https://github.com/apache/maven/pull/2116#issuecomment-2666184357 > @gnodet @slawekjaranowski given `maven.version.major` "does the job" (for use case explained above) am tinkering to we want maybe to lower what we expose here? Is minor/patch/snap really n

Re: [PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-18 Thread via GitHub
cstamas commented on PR #2116: URL: https://github.com/apache/maven/pull/2116#issuecomment-2665953230 @gnodet @slawekjaranowski given `maven.version.major` "does the job" (for use case explained above) am tinkering to we want maybe to lower what we expose here? Is minor/patch/snap really ne

Re: [PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-17 Thread via GitHub
Bukama commented on code in PR #2116: URL: https://github.com/apache/maven/pull/2116#discussion_r1959054213 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/BaseParser.java: ## @@ -352,6 +352,22 @@ protected Map populateSystemProperties(LocalContext context) {

Re: [PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-17 Thread via GitHub
gnodet commented on code in PR #2116: URL: https://github.com/apache/maven/pull/2116#discussion_r1958793700 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/BaseParser.java: ## @@ -352,6 +352,22 @@ protected Map populateSystemProperties(LocalContext context) {

Re: [PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-17 Thread via GitHub
Bukama commented on code in PR #2116: URL: https://github.com/apache/maven/pull/2116#discussion_r1958480925 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/BaseParser.java: ## @@ -352,6 +352,22 @@ protected Map populateSystemProperties(LocalContext context) {

Re: [PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-17 Thread via GitHub
cstamas commented on PR #2116: URL: https://github.com/apache/maven/pull/2116#issuecomment-2663314810 Example with this merged: * maven3: profile with property activation like `!maven.version.major` -- not even defined => this is Maven3 or older * maven4: profile with property action

Re: [PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-17 Thread via GitHub
cstamas commented on PR #2116: URL: https://github.com/apache/maven/pull/2116#issuecomment-2663299031 IMO not needed, that one is used for "programmatic access" and there caller can do with version string whatever he wants. The main idea behind this PR is to be able to create profile in POM

Re: [PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-17 Thread via GitHub
slawekjaranowski commented on PR #2116: URL: https://github.com/apache/maven/pull/2116#issuecomment-2663292666 What do you think about to add to `org.apache.maven.rtinfo.RuntimeInformation` -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] [MNG-8586] Expose Maven version segments as properties [maven]

2025-02-17 Thread via GitHub
cstamas opened a new pull request, #2116: URL: https://github.com/apache/maven/pull/2116 Expose version segments. --- https://issues.apache.org/jira/browse/MNG-8586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi