elharo merged PR #211:
URL: https://github.com/apache/maven-jlink-plugin/pull/211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@mav
matriv commented on PR #211:
URL:
https://github.com/apache/maven-jlink-plugin/pull/211#issuecomment-2552053917
> Need to remove commons-lang3 from pom.xml
>
> Error: Unused declared dependencies found: Error:
org.apache.commons:commons-lang3:jar:3.8.1:compile
apologies, done!
matriv commented on code in PR #211:
URL:
https://github.com/apache/maven-jlink-plugin/pull/211#discussion_r1884068265
##
src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java:
##
@@ -193,4 +190,18 @@ private int executeCommand(Commandline cmd) throws
matriv commented on code in PR #211:
URL:
https://github.com/apache/maven-jlink-plugin/pull/211#discussion_r1884066634
##
src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java:
##
@@ -172,7 +169,7 @@ private int executeCommand(Commandline cmd) throws
matriv commented on code in PR #211:
URL:
https://github.com/apache/maven-jlink-plugin/pull/211#discussion_r1884064755
##
src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java:
##
@@ -193,4 +190,18 @@ private int executeCommand(Commandline cmd) throws
matriv commented on code in PR #211:
URL:
https://github.com/apache/maven-jlink-plugin/pull/211#discussion_r1884064755
##
src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java:
##
@@ -193,4 +190,18 @@ private int executeCommand(Commandline cmd) throws
elharo commented on code in PR #211:
URL:
https://github.com/apache/maven-jlink-plugin/pull/211#discussion_r1866304579
##
src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java:
##
@@ -172,7 +169,7 @@ private int executeCommand(Commandline cmd) throws
matriv opened a new pull request, #211:
URL: https://github.com/apache/maven-jlink-plugin/pull/211
Dependency to commons-lang3 has been removed earlier on, but still there
were usages of `StringUtils` & `SystemUtils` which lead to the plugin requiring
the dependency to be added explicitly w
