elharo commented on code in PR #211:
URL:
https://github.com/apache/maven-jlink-plugin/pull/211#discussion_r1866304579
##########
src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java:
##########
@@ -172,7 +169,7 @@ private int executeCommand(Commandline cmd) throws
MojoExecutionException {
StringBuilder msg = new StringBuilder("\nExit code: ");
msg.append(exitCode);
- if (StringUtils.isNotEmpty(err.getOutput())) {
+ if (!err.getOutput().isBlank()) {
Review Comment:
This requires Java 11. I think we want to allow Java 8.
##########
src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java:
##########
@@ -193,4 +190,18 @@ private int executeCommand(Commandline cmd) throws
MojoExecutionException {
throw new MojoExecutionException("Unable to execute jlink command:
" + e.getMessage(), e);
}
}
+
+ private static boolean isOSWindows() {
+ String osName;
Review Comment:
Move this and more into the try block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
