YaSuenag commented on code in PR #503:
URL:
https://github.com/apache/maven-jlink-plugin/pull/503#discussion_r1967171544
##
src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java:
##
@@ -368,6 +368,14 @@ public class JLinkMojo extends AbstractJLinkMojo {
@Parameter
YaSuenag commented on code in PR #503:
URL:
https://github.com/apache/maven-jlink-plugin/pull/503#discussion_r1967142498
##
src/it/projects/GH-502_zipDirPrefix/src/main/java/module-info.java:
##
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
YaSuenag commented on code in PR #503:
URL:
https://github.com/apache/maven-jlink-plugin/pull/503#discussion_r1967139989
##
src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java:
##
@@ -368,6 +368,14 @@ public class JLinkMojo extends AbstractJLinkMojo {
@Parameter
bmarwell commented on code in PR #503:
URL:
https://github.com/apache/maven-jlink-plugin/pull/503#discussion_r1967117965
##
src/it/projects/GH-502_zipDirPrefix/src/main/java/module-info.java:
##
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
YaSuenag commented on PR #503:
URL:
https://github.com/apache/maven-jlink-plugin/pull/503#issuecomment-2677301103
All of tests on Windows were hanged due to new tests for this PR. I think
the cause of the hang is `unzip` command is unavailable on Windows GHA runner
or the test did not add
YaSuenag commented on PR #503:
URL:
https://github.com/apache/maven-jlink-plugin/pull/503#issuecomment-2676927505
@elharo
Thanks for your review!
I updated testcase to extract ZIP which contains prefix, and execute the
launcher. It works fine on Linux, but it might not work on Wi
YaSuenag opened a new pull request, #503:
URL: https://github.com/apache/maven-jlink-plugin/pull/503
I would like to introduce `zipDirPrefix` to add prefix to zip entries. See
#502 for details.
Following this checklist to help us incorporate your
contribution quickly and easily:
