bmarwell commented on code in PR #503: URL: https://github.com/apache/maven-jlink-plugin/pull/503#discussion_r1967117965
########## src/it/projects/GH-502_zipDirPrefix/src/main/java/module-info.java: ########## @@ -0,0 +1,21 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +module com.corporate.project { +} Review Comment: Probably doesn't matter, but maybe we can find another example module ########## src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java: ########## @@ -368,6 +368,14 @@ public class JLinkMojo extends AbstractJLinkMojo { @Parameter private List<Resource> additionalResources; + /** + * Add prefix to all of zip entries. It would be treated as a directory if the prefix ends with "/". Review Comment: I think this comment needs clarification, as it goes into the docs (site). * If it does not end with `/`, what will happen? * Isn't the prefix always supposed to be a directory? * What does the default do (explain to users)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
