Re: [PR] Bump org.apache.maven.shared:maven-dependency-analyzer from 1.15.1 to 1.16.0 [maven-dependency-plugin]

2025-05-12 Thread via GitHub
talios commented on PR #520: URL: https://github.com/apache/maven-dependency-plugin/pull/520#issuecomment-2874966231 > This update looks too complex for dependabot and needs to be handled manually. See my related PR (basically a dupe) and comments I added to #524 - whilst the depend

Re: [I] Analyzing a project with Java 24 as a compilation target doesn't work [maven-dependency-plugin]

2025-05-12 Thread via GitHub
talios commented on issue #524: URL: https://github.com/apache/maven-dependency-plugin/issues/524#issuecomment-2874959115 It looks like updating the analyzer works, but also fails one IT test, I'm unfamiliar with either code base but will try and see if I can spot whats changed/broken.

[PR] Update maven-dependency-analyzer to support Java24 [maven-dependency-plugin]

2025-05-12 Thread via GitHub
talios opened a new pull request, #528: URL: https://github.com/apache/maven-dependency-plugin/pull/528 This commit updates the analyser version which supports reading byte code generated by Java 24. Fixes #524 Following this checklist to help us incorporate your contributio

Re: [I] Analyzing a project with Java 24 as a compilation target doesn't work [maven-dependency-plugin]

2025-05-12 Thread via GitHub
talios commented on issue #524: URL: https://github.com/apache/maven-dependency-plugin/issues/524#issuecomment-2874930744 Would love to see this updated - looking at the projects `pom.xml`, I see this is likely fixed in `maven-dependency-analyer`, which had a recent release (last month), s

[PR] Bump jetty9Version from 9.4.56.v20240826 to 12.0.21 [maven]

2025-05-12 Thread via GitHub
dependabot[bot] opened a new pull request, #2329: URL: https://github.com/apache/maven/pull/2329 Bumps `jetty9Version` from 9.4.56.v20240826 to 12.0.21. Updates `org.eclipse.jetty:jetty-server` from 9.4.56.v20240826 to 12.0.21 Updates `org.eclipse.jetty:jetty-security` from 9.4.56.v

Re: [PR] [POC] Migrate `JUnit` asserts to `AssertJ` - impl [maven]

2025-05-12 Thread via GitHub
elharo commented on PR #2307: URL: https://github.com/apache/maven/pull/2307#issuecomment-2874086355 JUnit has a lot more than assertTrue. There's assertEquals, assertNull, assertSame, etc. I'm OK with things JUnit doesn't have like assertContains, but I don't want to replace things JUnit a

Re: [PR] [MNG-8727] Prepare for Java 24 [maven]

2025-05-12 Thread via GitHub
cstamas commented on code in PR #2328: URL: https://github.com/apache/maven/pull/2328#discussion_r2085492979 ## its/core-it-suite/src/test/resources/mng-7045/pom.xml: ## @@ -43,13 +43,13 @@ javax.enterprise.inject.Instance.class.getDeclaredMethod("stream")]]>

Re: [PR] [MNG-8727] Prepare for Java 24 [maven]

2025-05-12 Thread via GitHub
cstamas commented on code in PR #2328: URL: https://github.com/apache/maven/pull/2328#discussion_r2085492979 ## its/core-it-suite/src/test/resources/mng-7045/pom.xml: ## @@ -43,13 +43,13 @@ javax.enterprise.inject.Instance.class.getDeclaredMethod("stream")]]>

Re: [PR] [MNG-8727] Prepare for Java 24 [maven]

2025-05-12 Thread via GitHub
cstamas commented on code in PR #2328: URL: https://github.com/apache/maven/pull/2328#discussion_r2085481175 ## its/core-it-suite/src/test/resources/mng-7045/pom.xml: ## @@ -43,13 +43,13 @@ javax.enterprise.inject.Instance.class.getDeclaredMethod("stream")]]>

Re: [PR] [POC] Migrate `JUnit` asserts to `AssertJ` - impl [maven]

2025-05-12 Thread via GitHub
gnodet commented on PR #2307: URL: https://github.com/apache/maven/pull/2307#issuecomment-2874024591 > Hard no. I'm happy with JUnit and don't see a need to complicate matters and churn the code by using a different way to say the same things. There is a benefit: the message when an

Re: [PR] [MNG-8727] Prepare for Java 24 [maven]

2025-05-12 Thread via GitHub
michael-o commented on code in PR #2328: URL: https://github.com/apache/maven/pull/2328#discussion_r2085452335 ## its/core-it-suite/src/test/resources/mng-7045/pom.xml: ## @@ -43,13 +43,13 @@ javax.enterprise.inject.Instance.class.getDeclaredMethod("stream")]]>

Re: [PR] [MNG-8727] Prepare for Java 24 [maven]

2025-05-12 Thread via GitHub
michael-o commented on code in PR #2328: URL: https://github.com/apache/maven/pull/2328#discussion_r2085425311 ## impl/maven-executor/src/main/java/org/apache/maven/cling/executor/internal/ToolboxTool.java: ## @@ -142,7 +142,7 @@ private String validateOutput(boolean shave, Byt

Re: [PR] [MNG-8727] Prepare for Java 24 [maven]

2025-05-12 Thread via GitHub
cstamas commented on code in PR #2328: URL: https://github.com/apache/maven/pull/2328#discussion_r2085418836 ## impl/maven-executor/src/main/java/org/apache/maven/cling/executor/internal/ToolboxTool.java: ## @@ -142,7 +142,7 @@ private String validateOutput(boolean shave, ByteA

Re: [PR] [MNG-8727] Prepare for Java 24 [maven]

2025-05-12 Thread via GitHub
michael-o commented on code in PR #2328: URL: https://github.com/apache/maven/pull/2328#discussion_r2085415382 ## impl/maven-executor/src/main/java/org/apache/maven/cling/executor/internal/ToolboxTool.java: ## @@ -142,7 +142,7 @@ private String validateOutput(boolean shave, Byt

Re: [PR] [MNG-8727] Prepare for Java 24 [maven]

2025-05-12 Thread via GitHub
cstamas commented on code in PR #2328: URL: https://github.com/apache/maven/pull/2328#discussion_r2085383430 ## pom.xml: ## @@ -796,6 +796,17 @@ under the License. + + org.apache.maven.plugins + maven-pmd-plugin Revi

Re: [PR] Resolve `feature envy` in `DefaultPluginXmlFactory` [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on PR #2326: URL: https://github.com/apache/maven/pull/2326#issuecomment-2873893011 sacrifice/spike architectural design again, in sake to increment code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Resolve `feature envy` in `DefaultPluginXmlFactory` [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on code in PR #2326: URL: https://github.com/apache/maven/pull/2326#discussion_r2085375181 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java: ## @@ -35,70 +27,19 @@ import org.apache.maven.api.services.xml.XmlReaderRequest;

Re: [PR] [MNG-8727] Prepare for Java 24 [maven]

2025-05-12 Thread via GitHub
cstamas commented on code in PR #2328: URL: https://github.com/apache/maven/pull/2328#discussion_r2085383430 ## pom.xml: ## @@ -796,6 +796,17 @@ under the License. + + org.apache.maven.plugins + maven-pmd-plugin Revi

Re: [PR] [MNG-8727] Prepare for Java 24 [maven]

2025-05-12 Thread via GitHub
cstamas commented on code in PR #2328: URL: https://github.com/apache/maven/pull/2328#discussion_r2085383430 ## pom.xml: ## @@ -796,6 +796,17 @@ under the License. + + org.apache.maven.plugins + maven-pmd-plugin Revi

Re: [PR] [MNG-8727] Prepare for Java 24 [maven]

2025-05-12 Thread via GitHub
cstamas commented on code in PR #2328: URL: https://github.com/apache/maven/pull/2328#discussion_r2085383430 ## pom.xml: ## @@ -796,6 +796,17 @@ under the License. + + org.apache.maven.plugins + maven-pmd-plugin Revi

Re: [PR] [MNG-8727] Prepare for Java 24 [maven]

2025-05-12 Thread via GitHub
gnodet commented on code in PR #2328: URL: https://github.com/apache/maven/pull/2328#discussion_r2085380486 ## pom.xml: ## @@ -796,6 +796,17 @@ under the License. + + org.apache.maven.plugins + maven-pmd-plugin Revie

Re: [PR] Resolve `feature envy` in `DefaultPluginXmlFactory` [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on PR #2326: URL: https://github.com/apache/maven/pull/2326#issuecomment-2873857919 > It really does not make any sense to me to wrap the request (immutable data object) into another object, just for the sake of having methods collocated with the data. we can inli

Re: [PR] Resolve `feature envy` in `DefaultPluginXmlFactory` [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on PR #2326: URL: https://github.com/apache/maven/pull/2326#issuecomment-2873836165 https://refactoring.guru/design-patterns/factory-method Considering factory adhering to creational design pattern its supposed to `create` (what) stuff like shown in pr, not to `do`

[jira] [Updated] (MNG-8728) Bump Eclipse Sisu from 0.9.0.M3 to XXX and use Java 24 on CI

2025-05-12 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8728: - Summary: Bump Eclipse Sisu from 0.9.0.M3 to XXX and use Java 24 on CI (was: Eclipse Sisu upgrade a

[jira] [Created] (MNG-8728) Eclipse Sisu upgrade and Java 24

2025-05-12 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MNG-8728: Summary: Eclipse Sisu upgrade and Java 24 Key: MNG-8728 URL: https://issues.apache.org/jira/browse/MNG-8728 Project: Maven Issue Type: Task Repor

Re: [PR] [POC] `rewrite-maven-plugin`: Introduce OpenRewrite by Moderne (RemoveUnusedPrivateMethods) [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on PR #2322: URL: https://github.com/apache/maven/pull/2322#issuecomment-2873791586 > * I don't want to introduce additional plugins into the build. > * Format is limited to cosmetics. Check is just file parser too, therefore very limited. Ideally, we wou

[jira] [Assigned] (MNG-8727) Prepare for Java 24

2025-05-12 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8727: Assignee: Tamas Cservenak > Prepare for Java 24 > --- > > Ke

[PR] [MNG-8727] Prepare for Java 24 [maven]

2025-05-12 Thread via GitHub
cstamas opened a new pull request, #2328: URL: https://github.com/apache/maven/pull/2328 Simple changes that makes build/ITs work with Java 24. PR does not contains: * action addition of Java 24 to CI * updated Eclipse Sisu version (needed for that above) --- https:

Re: [PR] Bump org.wiremock:wiremock from 3.12.1 to 3.13.0 [maven-dist-tool]

2025-05-12 Thread via GitHub
slawekjaranowski merged PR #107: URL: https://github.com/apache/maven-dist-tool/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] Remove branch after merge [maven]

2025-05-12 Thread via GitHub
slawekjaranowski merged PR #2323: URL: https://github.com/apache/maven/pull/2323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mave

Re: [PR] Resolve `feature envy` in `DefaultPluginXmlFactory` [maven]

2025-05-12 Thread via GitHub
gnodet commented on PR #2326: URL: https://github.com/apache/maven/pull/2326#issuecomment-2873714730 It really does not make any sense to me to wrap the request (immutable data object) into another object, just for the sake of having methods collocated with the data. -- This is an automa

[jira] [Created] (MNG-8727) Prepare for Java 24

2025-05-12 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MNG-8727: Summary: Prepare for Java 24 Key: MNG-8727 URL: https://issues.apache.org/jira/browse/MNG-8727 Project: Maven Issue Type: Task Reporter: Tamas Cs

Re: [PR] Bump org.apache.maven:maven-parent from 43 to 44 [maven-enforcer]

2025-05-12 Thread via GitHub
dependabot[bot] closed pull request #361: Bump org.apache.maven:maven-parent from 43 to 44 URL: https://github.com/apache/maven-enforcer/pull/361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump org.apache.maven:maven-parent from 43 to 44 [maven-enforcer]

2025-05-12 Thread via GitHub
Bukama commented on PR #361: URL: https://github.com/apache/maven-enforcer/pull/361#issuecomment-2873639420 @dependabot close -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Update parent to 44 [maven-enforcer]

2025-05-12 Thread via GitHub
Bukama merged PR #365: URL: https://github.com/apache/maven-enforcer/pull/365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.a

Re: [PR] [POC] `rewrite-maven-plugin`: Introduce OpenRewrite by Moderne (RemoveUnusedPrivateMethods) [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on PR #2322: URL: https://github.com/apache/maven/pull/2322#issuecomment-2873629051 > As an alternative, could open rewrite be setup to comment on PRs ? of course, this is aimed happy path for easy integration and wide acceptance. Its easy to apply then, but

Re: [I] master branch breaks on Maven 4.0.0-rc3 on Windows [maven-enforcer]

2025-05-12 Thread via GitHub
Bukama commented on issue #364: URL: https://github.com/apache/maven-enforcer/issues/364#issuecomment-2873609518 > The dependency tree has slightly changed between in Maven 4, so I suspect it comes from that. If that's the case (you may want to diff the dependency tree), that's not a bug an

Re: [PR] GitHub action set fail-fast to false [maven-javadoc-plugin]

2025-05-12 Thread via GitHub
slawekjaranowski commented on PR #366: URL: https://github.com/apache/maven-javadoc-plugin/pull/366#issuecomment-2873596369 looks like all JDKs are ok ... so close it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] GitHub action set fail-fast to false [maven-javadoc-plugin]

2025-05-12 Thread via GitHub
slawekjaranowski closed pull request #366: GitHub action set fail-fast to false URL: https://github.com/apache/maven-javadoc-plugin/pull/366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [MNG-8686] Add `SourceRoot.matcher(boolean)` method [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on PR #2236: URL: https://github.com/apache/maven/pull/2236#issuecomment-2873551134 > useless disagree, its called best practise for reason. agree, with help of rewrite, we can get benefits for free. Enforcing really strong coding guidelines. -- This is

Re: [PR] [POC] `rewrite-maven-plugin`: Introduce OpenRewrite by Moderne (RemoveUnusedPrivateMethods) [maven]

2025-05-12 Thread via GitHub
gnodet commented on PR #2322: URL: https://github.com/apache/maven/pull/2322#issuecomment-2873545295 As an alternative, could open rewrite be setup to comment on PRs ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [I] master branch breaks on Maven 4.0.0-rc3 on Windows [maven-enforcer]

2025-05-12 Thread via GitHub
gnodet commented on issue #364: URL: https://github.com/apache/maven-enforcer/issues/364#issuecomment-2873540958 The dependency tree has slightly changed between in Maven 4, so I suspect it comes from that. If that's the case (you may want to diff the dependency tree), that's not a bug and

Re: [I] master branch breaks on Maven 4.0.0-rc3 on Windows [maven-enforcer]

2025-05-12 Thread via GitHub
Bukama commented on issue #364: URL: https://github.com/apache/maven-enforcer/issues/364#issuecomment-2873499765 On Maven 3.9.8 it's working fine. [2025-05-12_master_Maven3.9.8.log](https://github.com/user-attachments/files/20170042/2025-05-12_master_Maven3.9.8.log) -- This is an a

[I] master branch breaks on Maven 4.0.0-rc3 on Windows [maven-enforcer]

2025-05-12 Thread via GitHub
Bukama opened a new issue, #364: URL: https://github.com/apache/maven-enforcer/issues/364 ### Affected version 3.6.0-SNAPSHOT (master - f6c114b7d7f8035c152af0efe955d71c12870222) ### Bug description The master branch breaks on Maven 4.0.0-rc3 on Windows (with admin rights)

[jira] [Updated] (ARCHETYPE-674) Generating a partial archetype has an API incompatibility with Maven 4

2025-05-12 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/ARCHETYPE-674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated ARCHETYPE-674: -- Fix Version/s: 3.4.0 > Generating a partial archetype has an API incompatibi

Re: [PR] [MNG-8686] Add `SourceRoot.matcher(boolean)` method [maven]

2025-05-12 Thread via GitHub
gnodet commented on PR #2236: URL: https://github.com/apache/maven/pull/2236#issuecomment-2873221299 > rewrite would make the boilerplate way i would prefer silent PMD. > > > > https://adabeat.com/fp/immutability-in-functional-programming/ > > > > We make everywh

[jira] [Assigned] (ARCHETYPE-674) Generating a partial archetype has an API incompatibility with Maven 4

2025-05-12 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/ARCHETYPE-674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned ARCHETYPE-674: - Assignee: Slawomir Jaranowski > Generating a partial archetype has an

[jira] [Commented] (ARCHETYPE-692) Get rid of components.xml

2025-05-12 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/ARCHETYPE-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951009#comment-17951009 ] Slawomir Jaranowski commented on ARCHETYPE-692: --- Can not be easy deleted

Re: [I] Description of "javadoc-no-fork" goal on introduction page mentions test-sources [maven-javadoc-plugin]

2025-05-12 Thread via GitHub
Bukama closed issue #367: Description of "javadoc-no-fork" goal on introduction page mentions test-sources URL: https://github.com/apache/maven-javadoc-plugin/issues/367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Correct javadoc-no-fork description on index-page [maven-javadoc-plugin]

2025-05-12 Thread via GitHub
Bukama merged PR #368: URL: https://github.com/apache/maven-javadoc-plugin/pull/368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

Re: [PR] Enable Githuss Issues for Archiver, Common Artifact Filters, Dependency Tree and Filtering [maven-site]

2025-05-12 Thread via GitHub
Bukama merged PR #779: URL: https://github.com/apache/maven-site/pull/779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach

Re: [PR] Enable GitHub Issues (3.x) [maven-archiver]

2025-05-12 Thread via GitHub
Bukama merged PR #93: URL: https://github.com/apache/maven-archiver/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apa

Re: [PR] Enable GitHub Issues [maven-archiver]

2025-05-12 Thread via GitHub
Bukama merged PR #92: URL: https://github.com/apache/maven-archiver/pull/92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apa

Re: [PR] Enable Github Issues (3.x) [maven-filtering]

2025-05-12 Thread via GitHub
Bukama merged PR #155: URL: https://github.com/apache/maven-filtering/pull/155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

Re: [PR] Enable Github Issues [maven-filtering]

2025-05-12 Thread via GitHub
Bukama merged PR #154: URL: https://github.com/apache/maven-filtering/pull/154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

Re: [PR] Github issues [maven-dependency-tree]

2025-05-12 Thread via GitHub
Bukama merged PR #53: URL: https://github.com/apache/maven-dependency-tree/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ma

Re: [PR] Enable Github Issues [maven-common-artifact-filters]

2025-05-12 Thread via GitHub
Bukama merged PR #38: URL: https://github.com/apache/maven-common-artifact-filters/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

Re: [PR] Bump org.apache.maven.resolver:maven-resolver-api from 1.9.22 to 1.9.23 [maven-clean-plugin]

2025-05-12 Thread via GitHub
Bukama merged PR #251: URL: https://github.com/apache/maven-clean-plugin/pull/251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mav

Re: [PR] Bump resolverVersion from 1.9.22 to 1.9.23 [maven-install-plugin]

2025-05-12 Thread via GitHub
Bukama merged PR #346: URL: https://github.com/apache/maven-install-plugin/pull/346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

Re: [PR] Fix for Java 24 w/ upcoming new Eclipse Sisu [maven]

2025-05-12 Thread via GitHub
cstamas commented on PR #2311: URL: https://github.com/apache/maven/pull/2311#issuecomment-2872919108 ITs seems fixed, full-build still plagued by PMD issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [MNG-8686] Add `SourceRoot.matcher(boolean)` method [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2084843978 ## impl/maven-impl/src/main/java/org/apache/maven/impl/PathSelector.java: ## @@ -0,0 +1,620 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Fix for Java 24 w/ upcoming new Eclipse Sisu [maven]

2025-05-12 Thread via GitHub
cstamas commented on code in PR #2311: URL: https://github.com/apache/maven/pull/2311#discussion_r2084767433 ## impl/maven-executor/src/main/java/org/apache/maven/cling/executor/internal/ToolboxTool.java: ## @@ -122,27 +122,29 @@ private ExecutorRequest.Builder mojo(ExecutorReq

Re: [PR] Fix for Java 24 w/ upcoming new Eclipse Sisu [maven]

2025-05-12 Thread via GitHub
cstamas commented on code in PR #2311: URL: https://github.com/apache/maven/pull/2311#discussion_r2084759497 ## impl/maven-executor/src/main/java/org/apache/maven/cling/executor/internal/ToolboxTool.java: ## @@ -122,27 +122,29 @@ private ExecutorRequest.Builder mojo(ExecutorReq

Re: [PR] Fix for Java 24 w/ upcoming new Eclipse Sisu [maven]

2025-05-12 Thread via GitHub
slawekjaranowski commented on code in PR #2311: URL: https://github.com/apache/maven/pull/2311#discussion_r2084753265 ## impl/maven-executor/src/main/java/org/apache/maven/cling/executor/internal/ToolboxTool.java: ## @@ -122,27 +122,29 @@ private ExecutorRequest.Builder mojo(Ex

Re: [PR] Fix for Java 24 w/ upcoming new Eclipse Sisu [maven]

2025-05-12 Thread via GitHub
slawekjaranowski commented on PR #2311: URL: https://github.com/apache/maven/pull/2311#issuecomment-2872681931 maybe it is time for: - https://github.com/apache/maven-parent/issues/254 or even though - https://github.com/apache/maven-parent/issues/238 -- This is an automated messa

Re: [PR] Fix for Java 24 w/ upcoming new Eclipse Sisu [maven]

2025-05-12 Thread via GitHub
cstamas commented on PR #2311: URL: https://github.com/apache/maven/pull/2311#issuecomment-2872664518 The IT failures: ``` [ERROR] Errors: [ERROR] MavenITmng7045DropUselessAndOutdatedCdiApiTest.testShouldNotLeakCdiApi:41 ยป Verification Exit code was non-zero: 1; command line and

Re: [PR] Fix for Java 24 w/ upcoming new Eclipse Sisu [maven]

2025-05-12 Thread via GitHub
cstamas commented on PR #2311: URL: https://github.com/apache/maven/pull/2311#issuecomment-2872603716 The "full-build" CI job builds Maven Site, that contains PMD report that craps out on Java 24: ``` at net.sourceforge.pmd.lang.java.types.TypeOps.isSubClassOfNoInterface(TypeOps.

Re: [PR] [RSPEC-S1068] Remove `unused` private fields [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on code in PR #2317: URL: https://github.com/apache/maven/pull/2317#discussion_r2084672990 ## its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6401ProxyPortInterpolationTest.java: ## @@ -28,10 +28,6 @@ class MavenITmng6401ProxyPortInterpolatio

Re: [PR] [RSPEC-S1068] Remove `unused` private fields [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on code in PR #2317: URL: https://github.com/apache/maven/pull/2317#discussion_r2084670550 ## its/core-it-suite/src/test/resources/mng-3694/maven-mng3694-plugin/src/main/java/plugin/MyMojo.java: ## @@ -47,24 +47,12 @@ */ public class MyMojo extends Abstrac

Re: [PR] [RSPEC-S1068] Remove `unused` private fields [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on code in PR #2317: URL: https://github.com/apache/maven/pull/2317#discussion_r2084662901 ## its/core-it-suite/src/test/resources/mng-3694/maven-mng3694-plugin/src/main/java/plugin/MyMojo.java: ## @@ -47,24 +47,12 @@ */ public class MyMojo extends Abstrac

Re: [PR] [RSPEC-S1068] Remove `unused` private fields [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on code in PR #2317: URL: https://github.com/apache/maven/pull/2317#discussion_r2084660845 ## its/core-it-suite/src/test/resources/mng-3694/maven-mng3694-plugin/src/main/java/plugin/MyMojo.java: ## @@ -47,24 +47,12 @@ */ public class MyMojo extends Abstrac

Re: [PR] [POC] `rewrite-maven-plugin`: Introduce OpenRewrite by Moderne (RemoveUnusedPrivateMethods) [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on PR #2322: URL: https://github.com/apache/maven/pull/2322#issuecomment-2872538698 > * I don't want to introduce additional plugins into the build. > * no body want but only computer can fix our code. As we out of nature not being consistent. comparing c

Re: [PR] [POC] `rewrite-maven-plugin`: Introduce OpenRewrite by Moderne (RemoveUnusedPrivateMethods) [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on PR #2322: URL: https://github.com/apache/maven/pull/2322#issuecomment-2872525438 > 2\. You're not changing existing public API. yes, > * I don't want to introduce additional plugins into the build. > * spot is limited to format only, while rewrit

Re: [PR] Fix: Use correct `outputStream` destination; `request` instead of `path` in `DefaultPluginXmlFactory#write` [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on PR #2312: URL: https://github.com/apache/maven/pull/2312#issuecomment-2872498097 > The point of this PR is to fix the call with the output stream. Please rename it accordingly. yes, updated. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] [RSPEC-S1068] Remove `unused` private fields [maven]

2025-05-12 Thread via GitHub
elharo commented on code in PR #2317: URL: https://github.com/apache/maven/pull/2317#discussion_r2084566595 ## its/core-it-suite/src/test/resources/mng-3694/maven-mng3694-plugin/src/main/java/plugin/MyMojo.java: ## @@ -47,24 +47,12 @@ */ public class MyMojo extends AbstractMo

[jira] [Commented] (SCM-1029) JGit performing empty commit on CheckIn command if includes or excludes fileset is defined but no files changed in it

2025-05-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SCM-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950941#comment-17950941 ] ASF GitHub Bot commented on SCM-1029: - mhoffrog commented on PR #238: URL: https://gith

Re: [PR] [SCM-1029] Fix empty commits on JGit checkin [maven-scm]

2025-05-12 Thread via GitHub
mhoffrog commented on PR #238: URL: https://github.com/apache/maven-scm/pull/238#issuecomment-2872331326 > > @michael-o Merged PR should have a label and milestone > > By default GitHub action - PR Automation do it but here was not executed ... probably of merge by commit no Git

Re: [PR] [POC] Modernize codebase - Automatically fix `Checkstyle violations` [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on PR #2300: URL: https://github.com/apache/maven/pull/2300#issuecomment-2872322968 > travels enjoy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [POC] Modernize codebase - Automatically fix `Checkstyle violations` [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on PR #2300: URL: https://github.com/apache/maven/pull/2300#issuecomment-2872322282 > suggestions we need strict leadership on our suggestions enforcing them like good cop, bad cop. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] [POC] `rewrite-maven-plugin`: Introduce OpenRewrite by Moderne (RemoveUnusedPrivateMethods) [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on code in PR #2322: URL: https://github.com/apache/maven/pull/2322#discussion_r2084092664 ## pom.xml: ## @@ -796,9 +796,60 @@ under the License. + + org.openrewrite.maven + rewrite-maven-plugin +

Re: [PR] [POC] `rewrite-maven-plugin`: Introduce OpenRewrite by Moderne (RemoveUnusedPrivateMethods) [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on code in PR #2322: URL: https://github.com/apache/maven/pull/2322#discussion_r2084111582 ## pom.xml: ## @@ -796,9 +796,68 @@ under the License. + + org.openrewrite.maven + rewrite-maven-plugin +

Re: [PR] [POC] Modernize codebase - Automatically fix `Checkstyle violations` [maven]

2025-05-12 Thread via GitHub
timtebeek commented on PR #2300: URL: https://github.com/apache/maven/pull/2300#issuecomment-2872290273 At OpenRewrite, and others like Langchain4j, we run recipes that suggest fix comments on PRs as documented here:https://www.moderne.ai/blog/stop-breaking-ci-annotate-prs-with-openrewrite-

Re: [PR] Remove unused `DefaultPluginXmlFactory#fromXml/toXml` [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on code in PR #2327: URL: https://github.com/apache/maven/pull/2327#discussion_r2084519529 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java: ## @@ -100,28 +100,4 @@ public void write(XmlWriterRequest request) throws XmlWrit

[PR] Remove unused `DefaultPluginXmlFactory#fromXml` [maven]

2025-05-12 Thread via GitHub
Pankraz76 opened a new pull request, #2327: URL: https://github.com/apache/maven/pull/2327 Remove unused `DefaultPluginXmlFactory#fromXml` - https://github.com/apache/maven/pull/2312 - https://github.com/apache/maven/pull/2326 -- This is an automated message from the Apache Git S

Re: [PR] Test unused `stream` in `DefaultPluginXmlFactory#write` [maven]

2025-05-12 Thread via GitHub
gnodet commented on code in PR #2312: URL: https://github.com/apache/maven/pull/2312#discussion_r2084506349 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java: ## @@ -35,93 +27,18 @@ import org.apache.maven.api.services.xml.XmlReaderRequest; im

Re: [PR] Test unused `stream` in `DefaultPluginXmlFactory#write` [maven]

2025-05-12 Thread via GitHub
gnodet commented on code in PR #2312: URL: https://github.com/apache/maven/pull/2312#discussion_r2084506349 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java: ## @@ -35,93 +27,18 @@ import org.apache.maven.api.services.xml.XmlReaderRequest; im

Re: [PR] Test unused `stream` in `DefaultPluginXmlFactory#write` [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on code in PR #2312: URL: https://github.com/apache/maven/pull/2312#discussion_r2084504784 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java: ## @@ -45,58 +48,71 @@ @Named @Singleton public class DefaultPluginXmlFactory im

Re: [PR] Escape JIRA reserved words in JqlQueryBuilder [maven-changes-plugin]

2025-05-12 Thread via GitHub
slawekjaranowski commented on PR #127: URL: https://github.com/apache/maven-changes-plugin/pull/127#issuecomment-2872253231 > @slawekjaranowski > > Thank you for the review and merge. > > Would you please set expectations for a release timeframe? This is blocking Commons Exec

Re: [PR] [POC] `rewrite-maven-plugin`: Introduce OpenRewrite by Moderne (RemoveUnusedPrivateMethods) [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on code in PR #2322: URL: https://github.com/apache/maven/pull/2322#discussion_r2084490141 ## pom.xml: ## @@ -796,9 +796,56 @@ under the License. + + org.openrewrite.maven + rewrite-maven-plugin +

Re: [PR] [POC] `editorconfig-maven-plugin`: implement IDE agnostic configuration [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on code in PR #2321: URL: https://github.com/apache/maven/pull/2321#discussion_r2084485977 ## .editorconfig: ## @@ -0,0 +1,33 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# d

Re: [PR] Test unused `stream` in `DefaultPluginXmlFactory#write` [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on code in PR #2312: URL: https://github.com/apache/maven/pull/2312#discussion_r2084474413 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java: ## @@ -35,93 +27,18 @@ import org.apache.maven.api.services.xml.XmlReaderRequest;

Re: [PR] Escape JIRA reserved words in JqlQueryBuilder [maven-changes-plugin]

2025-05-12 Thread via GitHub
garydgregory commented on PR #127: URL: https://github.com/apache/maven-changes-plugin/pull/127#issuecomment-2872168668 @slawekjaranowski Thank you for the review and merge. Would you please set expectations for a release timeframe? This is blocking Commons Exec unless I use

Re: [PR] [POC] `editorconfig-maven-plugin`: implement IDE agnostic configuration [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on code in PR #2321: URL: https://github.com/apache/maven/pull/2321#discussion_r2084464225 ## .editorconfig: ## @@ -0,0 +1,33 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# d

Re: [PR] [POC] `editorconfig-maven-plugin`: implement IDE agnostic configuration [maven]

2025-05-12 Thread via GitHub
Pankraz76 closed pull request #2321: [POC] `editorconfig-maven-plugin`: implement IDE agnostic configuration URL: https://github.com/apache/maven/pull/2321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [POC] `editorconfig-maven-plugin`: implement IDE agnostic configuration [maven]

2025-05-12 Thread via GitHub
Pankraz76 commented on PR #2321: URL: https://github.com/apache/maven/pull/2321#issuecomment-2872151618 https://github.com/apache/maven/pull/2322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Bump io.takari.maven:takari-smart-builder from 1.0.2 to 1.1.0 [maven-mvnd]

2025-05-12 Thread via GitHub
cstamas merged PR #1324: URL: https://github.com/apache/maven-mvnd/pull/1324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

Re: [PR] Bump testcontainers.version from 1.20.6 to 1.21.0 [maven-mvnd]

2025-05-12 Thread via GitHub
cstamas merged PR #1322: URL: https://github.com/apache/maven-mvnd/pull/1322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

Re: [PR] Bump org.codehaus.gmavenplus:gmavenplus-plugin from 4.1.1 to 4.2.0 [maven-mvnd]

2025-05-12 Thread via GitHub
cstamas merged PR #1321: URL: https://github.com/apache/maven-mvnd/pull/1321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[PR] Bump io.takari.maven:takari-smart-builder from 1.0.2 to 1.1.0 [maven-mvnd]

2025-05-12 Thread via GitHub
dependabot[bot] opened a new pull request, #1324: URL: https://github.com/apache/maven-mvnd/pull/1324 Bumps [io.takari.maven:takari-smart-builder](https://github.com/takari/takari-smart-builder) from 1.0.2 to 1.1.0. Release notes Sourced from https://github.com/takari/takari-smart

[PR] Bump jline.version from 3.29.0 to 3.30.0 [maven-mvnd]

2025-05-12 Thread via GitHub
dependabot[bot] opened a new pull request, #1323: URL: https://github.com/apache/maven-mvnd/pull/1323 Bumps `jline.version` from 3.29.0 to 3.30.0. Updates `org.jline:jline` from 3.29.0 to 3.30.0 Release notes Sourced from https://github.com/jline/jline3/releases";>org.jline:jline

  1   2   >