elharo commented on code in PR #2317:
URL: https://github.com/apache/maven/pull/2317#discussion_r2084566595


##########
its/core-it-suite/src/test/resources/mng-3694/maven-mng3694-plugin/src/main/java/plugin/MyMojo.java:
##########
@@ -47,24 +47,12 @@
  */
 public class MyMojo extends AbstractMojo {
 
-    /**

Review Comment:
   I think the comment shows why and how this is used here. Please check this 
sort of thing before sending PRs from automated tools.



##########
its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6401ProxyPortInterpolationTest.java:
##########
@@ -28,10 +28,6 @@
 
 class MavenITmng6401ProxyPortInterpolationTest extends 
AbstractMavenIntegrationTestCase {
 
-    private Proxy proxy;

Review Comment:
   These might be used in a weird way by reflection in the integration tests. 
I'm not sure in this case, but Maven does have a lot of private things that 
look unused but really are used like that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to