Re: [I] Analyzing a project with Java 24 as a compilation target doesn't work [maven-dependency-plugin]

2025-05-05 Thread via GitHub
Bukama commented on issue #524: URL: https://github.com/apache/maven-dependency-plugin/issues/524#issuecomment-2853223154 Can't help on the issue (except knowing that we have already fixed some of Java 24 problems in other parts, but I would like to thank you for the following sentence, sh

[PR] fix: remove duplicate maven-resolver-api and maven-resolver-util dependencies in pom.xml [maven-dependency-plugin]

2025-05-05 Thread via GitHub
Ndacyayisenga-droid opened a new pull request, #526: URL: https://github.com/apache/maven-dependency-plugin/pull/526 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Your pull request should address just one issue, without pulling i

[jira] [Closed] (MNG-8722) Use a single standalone version of asm

2025-05-05 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MNG-8722. Resolution: Fixed > Use a single standalone version of asm >

Re: [PR] [MNG-8722] Use a single standalone version of asm [maven]

2025-05-05 Thread via GitHub
slawekjaranowski merged PR #2297: URL: https://github.com/apache/maven/pull/2297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mave

Re: [PR] [MNG-8722] Enable MavenITmng7587Jsr330 for Maven 3.9.10 and all JDKs [maven-integration-testing]

2025-05-05 Thread via GitHub
slawekjaranowski merged PR #404: URL: https://github.com/apache/maven-integration-testing/pull/404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

Re: [PR] [3.8.x] [MNG-7476] Display a warning when an aggregator mojo locks other mojos executions [maven]

2025-05-05 Thread via GitHub
slawekjaranowski commented on PR #736: URL: https://github.com/apache/maven/pull/736#issuecomment-2852353956 I found commits, jira updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [3.8.x] [MNG-7476] Display a warning when an aggregator mojo locks other mojos executions [maven]

2025-05-05 Thread via GitHub
slawekjaranowski commented on PR #736: URL: https://github.com/apache/maven/pull/736#issuecomment-2852322063 > This needs to be applied to 3.8.x, 3.9.x and master branches Do we did it ? Can you remember issues or PR for it? -- This is an automated message from the Apache Git Ser

[jira] [Closed] (MNG-8169) MINGW support requires --add-opens java.base/java.lang=ALL-UNNAMED

2025-05-05 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MNG-8169. Resolution: Fixed > MINGW support requires --add-opens java.base/java.lang=ALL-UNNAMED >

Re: [PR] [MNG-8169] Add opens java.base/java.lang=ALL-UNNAMED for MinGW [maven]

2025-05-05 Thread via GitHub
slawekjaranowski merged PR #2296: URL: https://github.com/apache/maven/pull/2296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mave

Re: [PR] Bump com.ibm.icu:icu4j from 76.1 to 77.1 [maven-archetype]

2025-05-05 Thread via GitHub
slawekjaranowski merged PR #257: URL: https://github.com/apache/maven-archetype/pull/257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] Skip release drafter only on the next development version [maven-gh-actions-shared]

2025-05-05 Thread via GitHub
slawekjaranowski merged PR #161: URL: https://github.com/apache/maven-gh-actions-shared/pull/161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

Re: [PR] Update parent to 44 [maven-source-plugin]

2025-05-05 Thread via GitHub
slawekjaranowski commented on PR #67: URL: https://github.com/apache/maven-source-plugin/pull/67#issuecomment-2852286049 > @gnodet @desruisseaux Slawek mentioned that the API was changed, can you help me/us on getting this PR ready for merge please. First we need update Maven from 4.

Re: [I] Archetype generation fails with JDK 24 (groovy dependency) [maven-archetype]

2025-05-05 Thread via GitHub
lprimak commented on issue #265: URL: https://github.com/apache/maven-archetype/issues/265#issuecomment-2852260695 Awesome, looking forward to the release, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [I] Archetype generation fails with JDK 24 (groovy dependency) [maven-archetype]

2025-05-05 Thread via GitHub
slawekjaranowski commented on issue #265: URL: https://github.com/apache/maven-archetype/issues/265#issuecomment-2852250378 We have merged: https://github.com/apache/maven-archetype/pull/239 https://github.com/apache/maven-archetype/pull/253 https://github.com/apache/maven-arche

Re: [PR] Bump org.apache.groovy:groovy-bom from 4.0.25 to 4.0.26 [maven-archetype]

2025-05-05 Thread via GitHub
slawekjaranowski merged PR #256: URL: https://github.com/apache/maven-archetype/pull/256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [I] Too many open files on Mac OS with JDK 11 and mvnd 0.8.2 [maven-mvnd]

2025-05-05 Thread via GitHub
telemenar commented on issue #710: URL: https://github.com/apache/maven-mvnd/issues/710#issuecomment-2852216677 Last update for a while. (Hopefully) Based on some reading I was doing as I posted the ticket to Graal, I learned that the change I referenced above in OpenJDK landed in OpenJDK-2

Re: [I] Too many open files on Mac OS with JDK 11 and mvnd 0.8.2 [maven-mvnd]

2025-05-05 Thread via GitHub
telemenar commented on issue #710: URL: https://github.com/apache/maven-mvnd/issues/710#issuecomment-2852189997 @fniephaus I just posted https://github.com/oracle/graal/issues/11136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.7-2 to 1.5.7-3 [maven-assembly-plugin]

2025-05-05 Thread via GitHub
Bukama merged PR #225: URL: https://github.com/apache/maven-assembly-plugin/pull/225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Update parent to 44 [maven-source-plugin]

2025-05-05 Thread via GitHub
Bukama commented on PR #67: URL: https://github.com/apache/maven-source-plugin/pull/67#issuecomment-2852138004 @gnodet @desruisseaux Slawek mentioned that the API was changed, can you help me/us on getting this PR ready for merge please. -- This is an automated message from the Apache Gi

[jira] [Commented] (MNG-8720) Warning about root directory and multiModuleProjectDirectory not being aligned doesn't account for symlinks

2025-05-05 Thread Henning Hoefer (Jira)
[ https://issues.apache.org/jira/browse/MNG-8720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949562#comment-17949562 ] Henning Hoefer commented on MNG-8720: - [~cstamas] Sure, see https://github.com/hho/MNG-

Re: [PR] Githuss Issues for several tool repositories [maven-site]

2025-05-05 Thread via GitHub
Bukama merged PR #775: URL: https://github.com/apache/maven-site/pull/775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach

Re: [PR] Refresh links on the configuration page [maven-resolver]

2025-05-05 Thread via GitHub
cstamas commented on PR #721: URL: https://github.com/apache/maven-resolver/pull/721#issuecomment-2852119082 This file is maintained manually, while the one on master we generate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Enable GitHub issues [maven-gpg-plugin]

2025-05-05 Thread via GitHub
Bukama merged PR #134: URL: https://github.com/apache/maven-gpg-plugin/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven

Re: [PR] Enable Github Stuff [maven-help-plugin]

2025-05-05 Thread via GitHub
Bukama merged PR #131: URL: https://github.com/apache/maven-help-plugin/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mave

Re: [PR] Enable GH Issues [maven-invoker-plugin]

2025-05-05 Thread via GitHub
Bukama merged PR #286: URL: https://github.com/apache/maven-invoker-plugin/pull/286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

Re: [PR] Enable Github Issues [maven-jarsigner-plugin]

2025-05-05 Thread via GitHub
Bukama merged PR #50: URL: https://github.com/apache/maven-jarsigner-plugin/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

Re: [PR] Enable Github Issues and update to verify workflow [maven-jdeprscan-plugin]

2025-05-05 Thread via GitHub
Bukama merged PR #37: URL: https://github.com/apache/maven-jdeprscan-plugin/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

Re: [PR] Github Issues [maven-plugin-tools]

2025-05-05 Thread via GitHub
Bukama merged PR #400: URL: https://github.com/apache/maven-plugin-tools/pull/400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mav

Re: [PR] Github Issues [maven-release]

2025-05-05 Thread via GitHub
Bukama merged PR #241: URL: https://github.com/apache/maven-release/pull/241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

Re: [PR] Enable Github Issues [maven-remote-resources-plugin]

2025-05-05 Thread via GitHub
Bukama merged PR #83: URL: https://github.com/apache/maven-remote-resources-plugin/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

Re: [PR] Enable Github issues [maven-scm]

2025-05-05 Thread via GitHub
Bukama merged PR #242: URL: https://github.com/apache/maven-scm/pull/242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache

Re: [PR] Enable Github Issues [maven-scm-publish-plugin]

2025-05-05 Thread via GitHub
Bukama merged PR #55: URL: https://github.com/apache/maven-scm-publish-plugin/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] Enable Github Issues [maven-scripting-plugin]

2025-05-05 Thread via GitHub
Bukama merged PR #35: URL: https://github.com/apache/maven-scripting-plugin/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

Re: [PR] Enable Github Issues [maven-stage-plugin]

2025-05-05 Thread via GitHub
Bukama merged PR #19: URL: https://github.com/apache/maven-stage-plugin/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven

Re: [PR] Enable Github Issues [maven-toolchains-plugin]

2025-05-05 Thread via GitHub
Bukama merged PR #55: URL: https://github.com/apache/maven-toolchains-plugin/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Refresh links on the configuration page [maven-resolver]

2025-05-05 Thread via GitHub
slawekjaranowski merged PR #721: URL: https://github.com/apache/maven-resolver/pull/721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

Re: [PR] Bump org.junit:junit-bom from 5.12.1 to 5.12.2 [maven-parent]

2025-05-05 Thread via GitHub
Bukama merged PR #466: URL: https://github.com/apache/maven-parent/pull/466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apa

Re: [I] Too many open files on Mac OS with JDK 11 and mvnd 0.8.2 [maven-mvnd]

2025-05-05 Thread via GitHub
telemenar commented on issue #710: URL: https://github.com/apache/maven-mvnd/issues/710#issuecomment-2852086694 Some testing that I did locally, initial setup (I'd previously done work to raise the limits on max files): ``` $ echo "Soft Files Limit"; ulimit -Sn; echo "Hard Files Limit"

Re: [PR] Jira to Github issues [maven-checkstyle-plugin]

2025-05-05 Thread via GitHub
Bukama commented on PR #175: URL: https://github.com/apache/maven-checkstyle-plugin/pull/175#issuecomment-2852085376 > For GitHub issues we use template such: https://github.com/apache/maven-clean-plugin/blob/master/.github/pull_request_template.md > > GitHub issue are not required,

Re: [I] Too many open files on Mac OS with JDK 11 and mvnd 0.8.2 [maven-mvnd]

2025-05-05 Thread via GitHub
fniephaus commented on issue #710: URL: https://github.com/apache/maven-mvnd/issues/710#issuecomment-2852061136 @telemenar could you open an issue for us at https://github.com/oracle/graal/issues? Feel free to tag me in it. We may be able to help. -- This is an automated message from the

[PR] Refresh links on the configuration page [maven-resolver]

2025-05-05 Thread via GitHub
slawekjaranowski opened a new pull request, #721: URL: https://github.com/apache/maven-resolver/pull/721 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Remove Stale label on comments [maven-gh-actions-shared]

2025-05-05 Thread via GitHub
slawekjaranowski merged PR #162: URL: https://github.com/apache/maven-gh-actions-shared/pull/162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

Re: [I] Too many open files on Mac OS with JDK 11 and mvnd 0.8.2 [maven-mvnd]

2025-05-05 Thread via GitHub
telemenar commented on issue #710: URL: https://github.com/apache/maven-mvnd/issues/710#issuecomment-2851964388 Two approaches that could work that would involve advocating for a change to GraalVM would be: * Push for the addition of MaxFDLimit setting to GraalVM * Push for GraalVM to

Re: [I] Too many open files on Mac OS with JDK 11 and mvnd 0.8.2 [maven-mvnd]

2025-05-05 Thread via GitHub
telemenar commented on issue #710: URL: https://github.com/apache/maven-mvnd/issues/710#issuecomment-2851954996 I did a lot more digging recently. This is in fact a limitation to using GraalVM with the client. The reason this happens is that the default behavior for the jvm (both Gr

Re: [PR] [MNG-8720] Fix for symlinked project directory [maven]

2025-05-05 Thread via GitHub
cstamas commented on PR #2289: URL: https://github.com/apache/maven/pull/2289#issuecomment-2851832596 While these changes are kinda okay, I have hard to time reproduce MNG-8720. Moreover, as I see, IF `RootLocator#findRoot` returns `null`, the user reported bug cannot happen (other branch

[jira] [Commented] (MNG-8720) Warning about root directory and multiModuleProjectDirectory not being aligned doesn't account for symlinks

2025-05-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949514#comment-17949514 ] Tamas Cservenak commented on MNG-8720: -- [~hoeferh] Can you create a simple reproducer?

[jira] [Closed] (MNG-8718) Restore Maven 3 compatibility: unable to use ProjectBuilder w/ Maven 4 session

2025-05-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8718. Resolution: Fixed > Restore Maven 3 compatibility: unable to use ProjectBuilder w/ Maven 4 session >

Re: [PR] [MNG-8718] Restore Maven 3 compat: ProjectBuilder is unusable for legacy code [maven]

2025-05-05 Thread via GitHub
cstamas merged PR #2285: URL: https://github.com/apache/maven/pull/2285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

Re: [PR] Introduce parameter failOnMismatchedAllowedViolationsCount [maven-checkstyle-plugin]

2025-05-05 Thread via GitHub
slawekjaranowski commented on PR #165: URL: https://github.com/apache/maven-checkstyle-plugin/pull/165#issuecomment-2851542184 > Github issue then. You are correct not all PRs require issues. However we should have an issue for user visible functionality changes for the release notes.

Re: [PR] Test MavenITmng7587Jsr330 should be executed on every JDK [maven]

2025-05-05 Thread via GitHub
slawekjaranowski merged PR #2298: URL: https://github.com/apache/maven/pull/2298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mave

[PR] Jira to Github issues [maven-checkstyle-plugin]

2025-05-05 Thread via GitHub
elharo opened a new pull request, #175: URL: https://github.com/apache/maven-checkstyle-plugin/pull/175 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Introduce parameter failOnMismatchedAllowedViolationsCount [maven-checkstyle-plugin]

2025-05-05 Thread via GitHub
NathanEckert commented on PR #165: URL: https://github.com/apache/maven-checkstyle-plugin/pull/165#issuecomment-2851335889 > Github issue then. You are correct not all PRs require issues. However we should have an issue for user visible functionality changes for the release notes. I

[I] Introduce parameter failOnMismatchedAllowedViolationsCount [maven-checkstyle-plugin]

2025-05-05 Thread via GitHub
NathanEckert opened a new issue, #174: URL: https://github.com/apache/maven-checkstyle-plugin/issues/174 ### New feature, improvement proposal Associated PR: https://github.com/apache/maven-checkstyle-plugin/pull/165 Introduce a parameter to fail the build when the number of vio

Re: [PR] Introduce parameter failOnMismatchedAllowedViolationsCount [maven-checkstyle-plugin]

2025-05-05 Thread via GitHub
elharo commented on PR #165: URL: https://github.com/apache/maven-checkstyle-plugin/pull/165#issuecomment-2851255141 Github issue then. You are correct not all PRs require issues. However we should have an issue for user visible functionality changes for the release notes. -- This is a

Re: [PR] [MNG-8686] Add `SourceRoot.matcher(boolean)` method [maven]

2025-05-05 Thread via GitHub
desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2073453511 ## api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java: ## @@ -46,23 +47,47 @@ default Path directory() { } /** - * {@return the li

Re: [PR] [MNG-8686] Add `SourceRoot.matcher(boolean)` method [maven]

2025-05-05 Thread via GitHub
desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2073453511 ## api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java: ## @@ -46,23 +47,47 @@ default Path directory() { } /** - * {@return the li

[PR] ignore .DS_Store [maven-plugin-testing]

2025-05-05 Thread via GitHub
elharo opened a new pull request, #100: URL: https://github.com/apache/maven-plugin-testing/pull/100 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] Introduce parameter failOnMismatchedAllowedViolationsCount [maven-checkstyle-plugin]

2025-05-05 Thread via GitHub
slawekjaranowski commented on PR #165: URL: https://github.com/apache/maven-checkstyle-plugin/pull/165#issuecomment-2850745864 > I think a new user visible parameter is significant enough to require a JIRA issue. We have switched to GitHub Issues with this project 😄 According

Re: [PR] Pull #2282: `Add project icon for IntelliJ IDEA` [maven]

2025-05-05 Thread via GitHub
Pankraz76 commented on PR #2283: URL: https://github.com/apache/maven/pull/2283#issuecomment-2850732613 .Editorconfig project has an issue for this feature to be generic, but it’s taking some time to be ready. Yes IDE specific stuff is not nice, that’s why it’s limited to one uncritical fil

[jira] [Closed] (MNG-8719) Restore Maven 3 compatibility: ConfigurationContainer.setInherited

2025-05-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8719. Resolution: Fixed > Restore Maven 3 compatibility: ConfigurationContainer.setInherited >

Re: [PR] [MNG-8719] Restore Maven3 compat: model setInherited(boolean) [maven]

2025-05-05 Thread via GitHub
cstamas merged PR #2288: URL: https://github.com/apache/maven/pull/2288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

Re: [PR] [MNG-8719] Restore Maven3 compat: model setInherited(boolean) [maven]

2025-05-05 Thread via GitHub
cstamas commented on PR #2288: URL: https://github.com/apache/maven/pull/2288#issuecomment-2850725527 I will skip adding test to it, as this is _deprecated_ method anyway, and serves sole purpose of re-adding compatibility for very old codebases (type of inherited with was changed to String

Re: [PR] [MNG-8614] Maven Sisu in Maven 4 same as in Maven 3 [maven]

2025-05-05 Thread via GitHub
cstamas merged PR #2284: URL: https://github.com/apache/maven/pull/2284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

[jira] [Closed] (MNG-8614) Make Sisu used in Maven back to "non strict"

2025-05-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8614. Resolution: Fixed > Make Sisu used in Maven back to "non strict" > --

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-05 Thread via GitHub
Pankraz76 commented on PR #2292: URL: https://github.com/apache/maven/pull/2292#issuecomment-2850713504 Yes it’s a test blind spot I want to cover. Sent from my iPhoneOn 5 May 2025, at 12:24, Elliotte Rusty Harold ***@***.***> wrote: @elharo requested changes on this pull request.

Re: [PR] Modernize codebase with Java improvements [maven]

2025-05-05 Thread via GitHub
Pankraz76 commented on PR #2277: URL: https://github.com/apache/maven/pull/2277#issuecomment-2850710999 Yes we working on a dedicated commit for each concern. Thanks Sent from my iPhoneOn 5 May 2025, at 12:41, Elliotte Rusty Harold ***@***.***> wrote: @elharo requested changes on this pu

Re: [PR] [MDEP-976] Fix artifact overwrites in copy-dependencies [maven-dependency-plugin]

2025-05-05 Thread via GitHub
elharo commented on PR #523: URL: https://github.com/apache/maven-dependency-plugin/pull/523#issuecomment-2850703748 It absolutely is valid in Maven for two different artifacts to have the same artifact ID but different group IDs. Artifact IDs are not unique or intended to be. In fact, thi

[jira] [Commented] (MDEP-976) artifactId is not guaranteed to be globally unique

2025-05-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MDEP-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949412#comment-17949412 ] ASF GitHub Bot commented on MDEP-976: - elharo commented on PR #523: URL: https://githu

Re: [PR] Bump org.apache.maven.shared:maven-dependency-analyzer from 1.15.1 to 1.16.0 [maven-dependency-plugin]

2025-05-05 Thread via GitHub
dependabot[bot] commented on PR #520: URL: https://github.com/apache/maven-dependency-plugin/pull/520#issuecomment-2850699303 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or min

Re: [PR] Bump org.apache.maven.shared:maven-dependency-analyzer from 1.15.1 to 1.16.0 [maven-dependency-plugin]

2025-05-05 Thread via GitHub
elharo commented on PR #520: URL: https://github.com/apache/maven-dependency-plugin/pull/520#issuecomment-2850699231 This update looks too complex for dependabot and needs to be handled manually. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Bump org.apache.maven.shared:maven-dependency-analyzer from 1.15.1 to 1.16.0 [maven-dependency-plugin]

2025-05-05 Thread via GitHub
elharo closed pull request #520: Bump org.apache.maven.shared:maven-dependency-analyzer from 1.15.1 to 1.16.0 URL: https://github.com/apache/maven-dependency-plugin/pull/520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [MNG-8719] Restore Maven3 compat: model setInherited(boolean) [maven]

2025-05-05 Thread via GitHub
cstamas commented on PR #2288: URL: https://github.com/apache/maven/pull/2288#issuecomment-2850697931 > Needs a test. Otherwise it's likely to be deleted again. Maven never had nor currently have tests for generated model. It was dropped last year by this commit: https://github.co

Re: [PR] [MNG-8720] Fix for symlinked project directory [maven]

2025-05-05 Thread via GitHub
cstamas commented on code in PR #2289: URL: https://github.com/apache/maven/pull/2289#discussion_r2073257772 ## impl/maven-impl/src/main/java/org/apache/maven/impl/model/rootlocator/DefaultRootLocator.java: ## @@ -64,8 +66,14 @@ public Path findMandatoryRoot(@Nonnull Path basedi

Re: [PR] Bump jetty9Version from 9.4.55.v20240627 to 12.0.20 [maven]

2025-05-05 Thread via GitHub
dependabot[bot] commented on PR #2299: URL: https://github.com/apache/maven/pull/2299#issuecomment-2850613918 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by a

Re: [PR] Bump jetty9Version from 9.4.55.v20240627 to 12.0.20 [maven]

2025-05-05 Thread via GitHub
elharo closed pull request #2299: Bump jetty9Version from 9.4.55.v20240627 to 12.0.20 URL: https://github.com/apache/maven/pull/2299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [MNG-8686] Add `SourceRoot.matcher(boolean)` method [maven]

2025-05-05 Thread via GitHub
elharo commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2073224351 ## api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java: ## @@ -46,23 +47,47 @@ default Path directory() { } /** - * {@return the list of

Re: [PR] [MNG-8686] Add `SourceRoot.matcher(boolean)` method [maven]

2025-05-05 Thread via GitHub
elharo commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2029890294 ## api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java: ## @@ -46,23 +46,39 @@ default Path directory() { } /** - * {@return the list of

Re: [PR] Pull #2290: `Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNull` [maven]

2025-05-05 Thread via GitHub
elharo commented on code in PR #2290: URL: https://github.com/apache/maven/pull/2290#discussion_r2073206223 ## impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultModelXmlFactoryTest.java: ## @@ -105,7 +105,7 @@ void testNoNamespaceWithModelVersion400() throws Exception {

Re: [PR] [MNG-8720] Fix for symlinked project directory [maven]

2025-05-05 Thread via GitHub
elharo commented on code in PR #2289: URL: https://github.com/apache/maven/pull/2289#discussion_r2073203597 ## impl/maven-impl/src/main/java/org/apache/maven/impl/model/rootlocator/DefaultRootLocator.java: ## @@ -64,8 +66,14 @@ public Path findMandatoryRoot(@Nonnull Path basedir