[jira] [Created] (MSHARED-1408) Refresh IntelliJ formater

2024-06-01 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MSHARED-1408: Summary: Refresh IntelliJ formater Key: MSHARED-1408 URL: https://issues.apache.org/jira/browse/MSHARED-1408 Project: Maven Shared Components

Re: [PR] Add `defaultValue` for all boolean Mojo parameters defaulting to `false` [maven-shade-plugin]

2024-06-01 Thread via GitHub
rmannibucau commented on PR #219: URL: https://github.com/apache/maven-shade-plugin/pull/219#issuecomment-2143720004 The 2 simple options: * Enhance plugin.xml to set defaults for primitives * Enhance doc generation to handle primitives (I prefer 1 since it will work for all

[jira] [Commented] (MSHARED-1407) Track dependency usage by referencing classes

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851353#comment-17851353 ] ASF GitHub Bot commented on MSHARED-1407: - slawekjaranowski commented on code i

Re: [PR] [MSHARED-1407] Track dependency usage by referencing classes [maven-dependency-analyzer]

2024-06-01 Thread via GitHub
slawekjaranowski commented on code in PR #125: URL: https://github.com/apache/maven-dependency-analyzer/pull/125#discussion_r1623336009 ## src/main/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzer.java: ## @@ -25,17 +25,11 @@ import java.io.Fil

[jira] [Created] (MPIR-460) Dependency Information for maven-plugin

2024-06-01 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPIR-460: Summary: Dependency Information for maven-plugin Key: MPIR-460 URL: https://issues.apache.org/jira/browse/MPIR-460 Project: Maven Project Info Reports Plugin

[jira] [Commented] (MPIR-459) Refresh download page

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPIR-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851352#comment-17851352 ] ASF GitHub Bot commented on MPIR-459: - slawekjaranowski opened a new pull request, #68:

[PR] [MPIR-459] Refresh download page [maven-project-info-reports-plugin]

2024-06-01 Thread via GitHub
slawekjaranowski opened a new pull request, #68: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/68 https://issues.apache.org/jira/browse/MPIR-459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Created] (MPIR-459) Refresh download page

2024-06-01 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPIR-459: Summary: Refresh download page Key: MPIR-459 URL: https://issues.apache.org/jira/browse/MPIR-459 Project: Maven Project Info Reports Plugin Issue Typ

Re: [PR] Add `defaultValue` for all boolean Mojo parameters defaulting to `false` [maven-shade-plugin]

2024-06-01 Thread via GitHub
Marcono1234 commented on PR #219: URL: https://github.com/apache/maven-shade-plugin/pull/219#issuecomment-2143611680 > doc should be aware of it somehow, either ensuring we inject the default for primitives in plugin.xml or let the doc handle it IMHO But how do you propose this shoul

Re: [PR] Use Maven Wrapper to build [maven]

2024-06-01 Thread via GitHub
slawekjaranowski commented on PR #1550: URL: https://github.com/apache/maven/pull/1550#issuecomment-2143604023 This one is needed https://github.com/apache/maven-integration-testing/pull/345 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] Add .mvn directory in project root [maven-integration-testing]

2024-06-01 Thread via GitHub
slawekjaranowski opened a new pull request, #345: URL: https://github.com/apache/maven-integration-testing/pull/345 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Add missing dependency [maven-invoker-plugin]

2024-06-01 Thread via GitHub
asfgit merged PR #247: URL: https://github.com/apache/maven-invoker-plugin/pull/247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

[PR] Add missing dependencies [maven-checkstyle-plugin]

2024-06-01 Thread via GitHub
michael-o opened a new pull request, #138: URL: https://github.com/apache/maven-checkstyle-plugin/pull/138 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCHECKSTY

[jira] [Closed] (JXR-191) Upgrade to Parent 42 and Maven 3.6.3

2024-06-01 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/JXR-191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed JXR-191. -- Resolution: Fixed Fixed with [2d507e044e8ae424d760c005d781bcb719a0d37b|https://gitbox.apache.org/repos/as

Re: [PR] Bump org.apache.maven:maven-parent from 41 to 42 [maven-jxr]

2024-06-01 Thread via GitHub
dependabot[bot] closed pull request #111: Bump org.apache.maven:maven-parent from 41 to 42 URL: https://github.com/apache/maven-jxr/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Bump org.apache.maven:maven-parent from 41 to 42 [maven-jxr]

2024-06-01 Thread via GitHub
dependabot[bot] commented on PR #111: URL: https://github.com/apache/maven-jxr/pull/111#issuecomment-2143583323 Looks like org.apache.maven:maven-parent is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (JXR-191) Upgrade to Parent 42 and Maven 3.6.3

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/JXR-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851339#comment-17851339 ] ASF GitHub Bot commented on JXR-191: asfgit closed pull request #114: [JXR-191] Upgrade

Re: [PR] Bump org.apache.maven:maven-parent from 41 to 42 [maven-jxr]

2024-06-01 Thread via GitHub
michael-o commented on PR #111: URL: https://github.com/apache/maven-jxr/pull/111#issuecomment-2143583131 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [JXR-191] Upgrade to Parent 42 and Maven 3.6.3 [maven-jxr]

2024-06-01 Thread via GitHub
asfgit closed pull request #114: [JXR-191] Upgrade to Parent 42 and Maven 3.6.3 URL: https://github.com/apache/maven-jxr/pull/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] Add missing dependency [maven-invoker-plugin]

2024-06-01 Thread via GitHub
michael-o opened a new pull request, #247: URL: https://github.com/apache/maven-invoker-plugin/pull/247 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MINVOKER) fi

[PR] Add missing dependency [maven-dependency-plugin]

2024-06-01 Thread via GitHub
michael-o opened a new pull request, #401: URL: https://github.com/apache/maven-dependency-plugin/pull/401 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MDEP) fil

[jira] [Commented] (MPIR-451) Rename "Dependency Information" to "Maven Coordinates"

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPIR-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851334#comment-17851334 ] ASF GitHub Bot commented on MPIR-451: - michael-o opened a new pull request, #67: URL: h

[PR] [MPIR-451] Rename "Dependency Information" to "Maven Coordinates" [maven-project-info-reports-plugin]

2024-06-01 Thread via GitHub
michael-o opened a new pull request, #67: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/67 This closes #67 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.a

[jira] [Updated] (MPIR-451) Rename "Dependency Information" to "Maven Coordinates"

2024-06-01 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPIR-451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MPIR-451: Summary: Rename "Dependency Information" to "Maven Coordinates" (was: Rename "Dependency Information

[jira] [Updated] (MPIR-451) Rename "Dependency Information" to "Maven Coordinates".

2024-06-01 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPIR-451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MPIR-451: Fix Version/s: 3.6.0 > Rename "Dependency Information" to "Maven Coordinates". > ---

[jira] [Assigned] (MPIR-451) Rename "Dependency Information" to "Maven Coordinates".

2024-06-01 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPIR-451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MPIR-451: --- Assignee: Michael Osipov > Rename "Dependency Information" to "Maven Coordinates". >

[jira] [Commented] (MPIR-455) dependencies goal: add support for multi-release JARs

2024-06-01 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPIR-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851333#comment-17851333 ] Michael Osipov commented on MPIR-455: - Vote for Maven Shared JAR is ongoing, feel free

[jira] [Updated] (MPIR-455) dependencies goal: add support for multi-release JARs

2024-06-01 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPIR-455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MPIR-455: Summary: dependencies goal: add support for multi-release JARs (was: dependencies goal: add support

Re: [PR] Add `defaultValue` for all boolean Mojo parameters defaulting to `false` [maven-shade-plugin]

2024-06-01 Thread via GitHub
rmannibucau commented on PR #219: URL: https://github.com/apache/maven-shade-plugin/pull/219#issuecomment-2143562745 @Marcono1234 it is possible but will not be in the documentation (requires textual description) but guess the good practise stays to write the less so if default is automati

Re: [PR] Bump org.apache.bcel:bcel from 6.8.2 to 6.9.0 [maven-shared-jar]

2024-06-01 Thread via GitHub
dependabot[bot] closed pull request #37: Bump org.apache.bcel:bcel from 6.8.2 to 6.9.0 URL: https://github.com/apache/maven-shared-jar/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Bump commons-codec:commons-codec from 1.16.1 to 1.17.0 [maven-shared-jar]

2024-06-01 Thread via GitHub
dependabot[bot] commented on PR #38: URL: https://github.com/apache/maven-shared-jar/pull/38#issuecomment-2143562431 Looks like commons-codec:commons-codec is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Bump commons-codec:commons-codec from 1.16.1 to 1.17.0 [maven-shared-jar]

2024-06-01 Thread via GitHub
michael-o commented on PR #38: URL: https://github.com/apache/maven-shared-jar/pull/38#issuecomment-2143562349 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Closed] (MSHARED-1256) Add support for Multi-Release JARs

2024-06-01 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSHARED-1256. --- Resolution: Fixed Fixed with [009581918bd86d9bcff1b3db155f7589a9e91c16|https://gitbox.apac

Re: [PR] Bump org.apache.maven.shared:maven-shared-components from 41 to 42 [maven-shared-jar]

2024-06-01 Thread via GitHub
dependabot[bot] closed pull request #36: Bump org.apache.maven.shared:maven-shared-components from 41 to 42 URL: https://github.com/apache/maven-shared-jar/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Bump org.apache.maven.shared:maven-shared-components from 41 to 42 [maven-shared-jar]

2024-06-01 Thread via GitHub
dependabot[bot] commented on PR #36: URL: https://github.com/apache/maven-shared-jar/pull/36#issuecomment-2143562449 Looks like org.apache.maven.shared:maven-shared-components is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To r

Re: [PR] Bump commons-codec:commons-codec from 1.16.1 to 1.17.0 [maven-shared-jar]

2024-06-01 Thread via GitHub
dependabot[bot] closed pull request #38: Bump commons-codec:commons-codec from 1.16.1 to 1.17.0 URL: https://github.com/apache/maven-shared-jar/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Add `defaultValue` for all boolean Mojo parameters defaulting to `false` [maven-shade-plugin]

2024-06-01 Thread via GitHub
Marcono1234 commented on PR #219: URL: https://github.com/apache/maven-shade-plugin/pull/219#issuecomment-2143562110 That might indeed be a better solution. Can there be cases though were a parameter has a different default value, which is not set with `@Parameter(defaultValue = "...")`?

Re: [PR] Bump org.apache.bcel:bcel from 6.8.2 to 6.9.0 [maven-shared-jar]

2024-06-01 Thread via GitHub
dependabot[bot] commented on PR #37: URL: https://github.com/apache/maven-shared-jar/pull/37#issuecomment-2143562435 Looks like org.apache.bcel:bcel is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Bump org.apache.maven.shared:maven-shared-components from 41 to 42 [maven-shared-jar]

2024-06-01 Thread via GitHub
michael-o commented on PR #36: URL: https://github.com/apache/maven-shared-jar/pull/36#issuecomment-2143562367 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Bump org.apache.bcel:bcel from 6.8.2 to 6.9.0 [maven-shared-jar]

2024-06-01 Thread via GitHub
michael-o commented on PR #37: URL: https://github.com/apache/maven-shared-jar/pull/37#issuecomment-2143562358 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [MSHARED-1256] - Add support for Multi-Release jars [maven-shared-jar]

2024-06-01 Thread via GitHub
michael-o commented on PR #21: URL: https://github.com/apache/maven-shared-jar/pull/21#issuecomment-2143562279 Merged, with slight alignments with the rest of the Maven codebase. Thank your for your patience. Will roll the release. -- This is an automated message from the Apache Git Serv

Re: [PR] [MSHARED-1256] - Add support for Multi-Release jars [maven-shared-jar]

2024-06-01 Thread via GitHub
asfgit merged PR #21: URL: https://github.com/apache/maven-shared-jar/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.a

[jira] [Assigned] (MSHARED-1256) Add support for Multi-Release JARs

2024-06-01 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MSHARED-1256: --- Assignee: Michael Osipov > Add support for Multi-Release JARs > --

[jira] [Updated] (MSHARED-1256) Add support for Multi-Release JARs

2024-06-01 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSHARED-1256: Fix Version/s: maven-shared-jar-next-release > Add support for Multi-Release JARs > -

[jira] [Commented] (JXR-191) Upgrade to Parent 42 and Maven 3.6.3

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/JXR-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851330#comment-17851330 ] ASF GitHub Bot commented on JXR-191: michael-o commented on code in PR #114: URL: https:

Re: [PR] [JXR-191] Upgrade to Parent 42 and Maven 3.6.3 [maven-jxr]

2024-06-01 Thread via GitHub
michael-o commented on code in PR #114: URL: https://github.com/apache/maven-jxr/pull/114#discussion_r1623270947 ## pom.xml: ## @@ -126,25 +126,6 @@ under the License. - - - - - - - org.apache.maven.plugins - maven-ja

[jira] [Commented] (JXR-191) Upgrade to Parent 42 and Maven 3.6.3

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/JXR-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851329#comment-17851329 ] ASF GitHub Bot commented on JXR-191: slawekjaranowski commented on code in PR #114: URL:

Re: [PR] [JXR-191] Upgrade to Parent 42 and Maven 3.6.3 [maven-jxr]

2024-06-01 Thread via GitHub
slawekjaranowski commented on code in PR #114: URL: https://github.com/apache/maven-jxr/pull/114#discussion_r1623268640 ## pom.xml: ## @@ -126,25 +126,6 @@ under the License. - - - - - - - org.apache.maven.plugins - m

Re: [PR] [MSHARED-1256] - Add support for Multi-Release jars [maven-shared-jar]

2024-06-01 Thread via GitHub
michael-o commented on code in PR #21: URL: https://github.com/apache/maven-shared-jar/pull/21#discussion_r1623268295 ## src/main/java/org/apache/maven/shared/jar/JarData.java: ## @@ -87,13 +98,19 @@ public JarData(File file, Manifest manifest, List entries) { this.ent

[jira] [Commented] (JXR-191) Upgrade to Parent 42 and Maven 3.6.3

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/JXR-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851328#comment-17851328 ] ASF GitHub Bot commented on JXR-191: michael-o commented on code in PR #114: URL: https:

Re: [PR] [JXR-191] Upgrade to Parent 42 and Maven 3.6.3 [maven-jxr]

2024-06-01 Thread via GitHub
michael-o commented on code in PR #114: URL: https://github.com/apache/maven-jxr/pull/114#discussion_r1623268220 ## pom.xml: ## @@ -126,25 +126,6 @@ under the License. - - - - - - - org.apache.maven.plugins - maven-ja

[jira] [Commented] (JXR-191) Upgrade to Parent 42 and Maven 3.6.3

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/JXR-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851324#comment-17851324 ] ASF GitHub Bot commented on JXR-191: slawekjaranowski commented on code in PR #114: URL:

Re: [PR] [JXR-191] Upgrade to Parent 42 and Maven 3.6.3 [maven-jxr]

2024-06-01 Thread via GitHub
slawekjaranowski commented on code in PR #114: URL: https://github.com/apache/maven-jxr/pull/114#discussion_r1623264506 ## pom.xml: ## @@ -126,25 +126,6 @@ under the License. - - - - - - - org.apache.maven.plugins - m

[jira] [Commented] (JXR-191) Upgrade to Parent 42 and Maven 3.6.3

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/JXR-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851323#comment-17851323 ] ASF GitHub Bot commented on JXR-191: slawekjaranowski commented on code in PR #114: URL:

Re: [PR] [JXR-191] Upgrade to Parent 42 and Maven 3.6.3 [maven-jxr]

2024-06-01 Thread via GitHub
slawekjaranowski commented on code in PR #114: URL: https://github.com/apache/maven-jxr/pull/114#discussion_r1623264458 ## pom.xml: ## @@ -126,25 +126,6 @@ under the License. - - - - - - - org.apache.maven.plugins - m

[jira] [Assigned] (MJAR-310) [REGRESSION] Plugin fails to handle toolchain paths that contain spaces

2024-06-01 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MJAR-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MJAR-310: Assignee: Slawomir Jaranowski > [REGRESSION] Plugin fails to handle toolchain paths

[jira] [Closed] (MJAR-310) [REGRESSION] Plugin fails to handle toolchain paths that contain spaces

2024-06-01 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MJAR-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MJAR-310. Resolution: Fixed > [REGRESSION] Plugin fails to handle toolchain paths that contain spaces >

[jira] [Commented] (MJAR-310) [REGRESSION] Plugin fails to handle toolchain paths that contain spaces

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAR-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851321#comment-17851321 ] ASF GitHub Bot commented on MJAR-310: - slawekjaranowski commented on PR #86: URL: https

[jira] [Commented] (MJAR-310) [REGRESSION] Plugin fails to handle toolchain paths that contain spaces

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAR-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851322#comment-17851322 ] ASF GitHub Bot commented on MJAR-310: - slawekjaranowski closed pull request #87: [MJAR-

[jira] [Commented] (MJAR-310) [REGRESSION] Plugin fails to handle toolchain paths that contain spaces

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAR-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851320#comment-17851320 ] ASF GitHub Bot commented on MJAR-310: - slawekjaranowski merged PR #86: URL: https://git

Re: [PR] [MJAR-310] fixed toolchain version detection when toolchain paths contain white spaces [maven-jar-plugin]

2024-06-01 Thread via GitHub
slawekjaranowski closed pull request #87: [MJAR-310] fixed toolchain version detection when toolchain paths contain white spaces URL: https://github.com/apache/maven-jar-plugin/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] [MJAR-310] - fixed toolchain version detection when toolchain paths contain white spaces [maven-jar-plugin]

2024-06-01 Thread via GitHub
slawekjaranowski commented on PR #86: URL: https://github.com/apache/maven-jar-plugin/pull/86#issuecomment-2143543523 @jansohn thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [MJAR-310] - fixed toolchain version detection when toolchain paths contain white spaces [maven-jar-plugin]

2024-06-01 Thread via GitHub
slawekjaranowski merged PR #86: URL: https://github.com/apache/maven-jar-plugin/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (SUREFIRE-2047) Upgrade maven-common-artifact-filters

2024-06-01 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851319#comment-17851319 ] Slawomir Jaranowski commented on SUREFIRE-2047: --- Ok I will try in next w

[jira] [Assigned] (SUREFIRE-2047) Upgrade maven-common-artifact-filters

2024-06-01 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned SUREFIRE-2047: - Assignee: Slawomir Jaranowski > Upgrade maven-common-artifact-filters

[PR] Use Maven Wrapper to build [maven]

2024-06-01 Thread via GitHub
slawekjaranowski opened a new pull request, #1550: URL: https://github.com/apache/maven/pull/1550 We should control Maven version used for builds -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [MSHARED-1256] - Add support for Multi-Release jars [maven-shared-jar]

2024-06-01 Thread via GitHub
belingueres commented on code in PR #21: URL: https://github.com/apache/maven-shared-jar/pull/21#discussion_r1623259782 ## src/main/java/org/apache/maven/shared/jar/JarData.java: ## @@ -87,13 +98,19 @@ public JarData(File file, Manifest manifest, List entries) { this.e

[PR] Add support for Maven 4 [maven-gh-actions-shared]

2024-06-01 Thread via GitHub
slawekjaranowski opened a new pull request, #103: URL: https://github.com/apache/maven-gh-actions-shared/pull/103 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Bump Maven to 3.9.7 on GH build [maven-integration-testing]

2024-06-01 Thread via GitHub
slawekjaranowski merged PR #343: URL: https://github.com/apache/maven-integration-testing/pull/343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[jira] [Commented] (MBUILDCACHE-87) Checksum should consider plugin dependencies

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851310#comment-17851310 ] ASF GitHub Bot commented on MBUILDCACHE-87: --- AlexanderAshitkin commented on

Re: [PR] [MBUILDCACHE-87] - Checksum should consider plugin dependencies [maven-build-cache-extension]

2024-06-01 Thread via GitHub
AlexanderAshitkin commented on code in PR #146: URL: https://github.com/apache/maven-build-cache-extension/pull/146#discussion_r1623246723 ## src/main/java/org/apache/maven/buildcache/checksum/DigestUtils.java: ## @@ -126,6 +126,10 @@ public static DigestItem dependency(HashChe

[jira] [Commented] (MBUILDCACHE-87) Checksum should consider plugin dependencies

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851309#comment-17851309 ] ASF GitHub Bot commented on MBUILDCACHE-87: --- AlexanderAshitkin commented on

Re: [PR] [MBUILDCACHE-87] - Checksum should consider plugin dependencies [maven-build-cache-extension]

2024-06-01 Thread via GitHub
AlexanderAshitkin commented on code in PR #146: URL: https://github.com/apache/maven-build-cache-extension/pull/146#discussion_r1623246723 ## src/main/java/org/apache/maven/buildcache/checksum/DigestUtils.java: ## @@ -126,6 +126,10 @@ public static DigestItem dependency(HashChe

[jira] [Commented] (MNG-8135) Activate profile by capital OS name fail

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851308#comment-17851308 ] ASF GitHub Bot commented on MNG-8135: - liutang123 opened a new pull request, #1549: URL

[PR] [MNG-8135] Fix caplital OS name can not activate profile [maven]

2024-06-01 Thread via GitHub
liutang123 opened a new pull request, #1549: URL: https://github.com/apache/maven/pull/1549 [MNG-8135] Fix caplital OS name can not activate profile Lowercase the os properties before checking. Following this checklist to help us incorporate your contribution quickly and easily:

[jira] [Commented] (MBUILDCACHE-87) Checksum should consider plugin dependencies

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851307#comment-17851307 ] ASF GitHub Bot commented on MBUILDCACHE-87: --- AlexanderAshitkin commented on

Re: [PR] Use Maven Wrapper to build [maven]

2024-06-01 Thread via GitHub
slawekjaranowski commented on code in PR #1548: URL: https://github.com/apache/maven/pull/1548#discussion_r1623245316 ## .github/workflows/maven.yml: ## @@ -47,7 +47,7 @@ jobs: cache: 'maven' - name: Build with Maven -run: mvn verify -e -B -V -Ddistri

Re: [PR] [MBUILDCACHE-87] - Checksum should consider plugin dependencies [maven-build-cache-extension]

2024-06-01 Thread via GitHub
AlexanderAshitkin commented on code in PR #146: URL: https://github.com/apache/maven-build-cache-extension/pull/146#discussion_r1623244666 ## src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java: ## @@ -620,14 +631,26 @@ private static boolean isReadable(Pa

[jira] [Commented] (MBUILDCACHE-87) Checksum should consider plugin dependencies

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851306#comment-17851306 ] ASF GitHub Bot commented on MBUILDCACHE-87: --- AlexanderAshitkin commented on

Re: [PR] [MBUILDCACHE-87] - Checksum should consider plugin dependencies [maven-build-cache-extension]

2024-06-01 Thread via GitHub
AlexanderAshitkin commented on code in PR #146: URL: https://github.com/apache/maven-build-cache-extension/pull/146#discussion_r1623244666 ## src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java: ## @@ -620,14 +631,26 @@ private static boolean isReadable(Pa

[jira] [Updated] (MNG-8135) Activate profile by capital OS name fail

2024-06-01 Thread Lijia Liu (Jira)
[ https://issues.apache.org/jira/browse/MNG-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijia Liu updated MNG-8135: --- Summary: Activate profile by capital OS name fail (was: Activate profile by capital OS activation name fail)

[jira] [Updated] (MNG-8135) Activate profile by capital OS activation name fail

2024-06-01 Thread Lijia Liu (Jira)
[ https://issues.apache.org/jira/browse/MNG-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijia Liu updated MNG-8135: --- Summary: Activate profile by capital OS activation name fail (was: Activate profile by OS activation name fail

[jira] [Updated] (MNG-8135) Activate profile by OS activation name fail

2024-06-01 Thread Lijia Liu (Jira)
[ https://issues.apache.org/jira/browse/MNG-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijia Liu updated MNG-8135: --- Summary: Activate profile by OS activation name fail (was: Activate profile by OS name fail) > Activate profi

[jira] [Created] (MNG-8135) Activate profile by OS name fail

2024-06-01 Thread Lijia Liu (Jira)
Lijia Liu created MNG-8135: -- Summary: Activate profile by OS name fail Key: MNG-8135 URL: https://issues.apache.org/jira/browse/MNG-8135 Project: Maven Issue Type: Bug Components: Profiles

Re: [PR] Use Maven Wrapper to build [maven]

2024-06-01 Thread via GitHub
gnodet commented on PR #1548: URL: https://github.com/apache/maven/pull/1548#issuecomment-2143461937 Actually, we're not using it... I thought, but the matrix is used with wrapper https://github.com/apache/maven-gh-actions-shared/blob/v4/.github/workflows/maven-verify.yml#L196-L198

Re: [PR] Use Maven Wrapper to build [maven]

2024-06-01 Thread via GitHub
laeubi commented on PR #1548: URL: https://github.com/apache/maven/pull/1548#issuecomment-2143449905 > You are mixing things. Again, we do NOT use setup-maven action, hence the readme you point it is... off topic. I mentioned [you need to use setup-maven action](https://github.com/ap

Re: [PR] Use Maven Wrapper to build [maven]

2024-06-01 Thread via GitHub
cstamas commented on PR #1548: URL: https://github.com/apache/maven/pull/1548#issuecomment-2143449297 IMHO we should not use any action to setup Maven but wrapper that's my 5 cents (we even have examples of "maven matrix" that is simply doable with wrapper). -- This is an automated m

Re: [PR] Use Maven Wrapper to build [maven]

2024-06-01 Thread via GitHub
cstamas commented on PR #1548: URL: https://github.com/apache/maven/pull/1548#issuecomment-2143449034 > Well I would call it **strange** to use an action without specify a version ... I mean even [the readme tells you to specify one](https://github.com/stCarolas/setup-maven), i more suspect

Re: [PR] Use Maven Wrapper to build [maven]

2024-06-01 Thread via GitHub
laeubi commented on PR #1548: URL: https://github.com/apache/maven/pull/1548#issuecomment-2143448479 setup-java has nothing to do with installing / "using" maven it just do the following: - generates `toolchain.xml` from installed jdks - uses `pom.xml` files as cache keys be

Re: [PR] Use Maven Wrapper to build [maven]

2024-06-01 Thread via GitHub
rmannibucau commented on PR #1548: URL: https://github.com/apache/maven/pull/1548#issuecomment-2143424345 setup-java uses OS maven version which is likely not what we want. Guess we should reuse our shared action enabling to support setup-maven to have a build matrix (ideally). -- This

Re: [PR] Use Maven Wrapper to build [maven]

2024-06-01 Thread via GitHub
laeubi commented on PR #1548: URL: https://github.com/apache/maven/pull/1548#issuecomment-2143422824 > I can't see the use of this action for ITs. We do use actions/setup-java, but not actions/setup-maven. I would think reusing this action in the context of GH action makes more sense.

[jira] [Commented] (MCHECKSTYLE-450) Checkstyle rule link format results in 404

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851276#comment-17851276 ] ASF GitHub Bot commented on MCHECKSTYLE-450: asfgit closed pull request

Re: [PR] [MCHECKSTYLE-450] Checkstyle rule link format results in 404 [maven-checkstyle-plugin]

2024-06-01 Thread via GitHub
asfgit closed pull request #134: [MCHECKSTYLE-450] Checkstyle rule link format results in 404 URL: https://github.com/apache/maven-checkstyle-plugin/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Commented] (MCHECKSTYLE-450) Checkstyle rule link format results in 404

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851277#comment-17851277 ] ASF GitHub Bot commented on MCHECKSTYLE-450: asfgit merged PR #134: URL:

Re: [PR] [MCHECKSTYLE-450] Checkstyle rule link format results in 404 [maven-checkstyle-plugin]

2024-06-01 Thread via GitHub
asfgit merged PR #134: URL: https://github.com/apache/maven-checkstyle-plugin/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Closed] (MCHECKSTYLE-450) Checkstyle rule link format results in 404

2024-06-01 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MCHECKSTYLE-450. -- Resolution: Fixed Fixed with [142304a4d93d41a2f95e5f577387ca9de004807a|https://gi

Re: [PR] Use Maven Wrapper to build [maven]

2024-06-01 Thread via GitHub
gnodet commented on PR #1548: URL: https://github.com/apache/maven/pull/1548#issuecomment-2143420229 > > There is a setup-maven action: https://github.com/marketplace/actions/setup-maven > > I use it all the time without any issues and you can perfectly control the maven version. >

[jira] [Created] (MCHECKSTYLE-450) Checkstyle rule link format results in 404

2024-06-01 Thread Michael Osipov (Jira)
Michael Osipov created MCHECKSTYLE-450: -- Summary: Checkstyle rule link format results in 404 Key: MCHECKSTYLE-450 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-450 Project: Maven Checksty

[jira] [Closed] (MCHECKSTYLE-449) Add support for SARIF output format

2024-06-01 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MCHECKSTYLE-449. -- Resolution: Fixed Fixed with [1ad603398fb3e8db919dcd6c15338ecce9ad|https://gi

[jira] [Commented] (MCHECKSTYLE-449) Add support for SARIF output format

2024-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851270#comment-17851270 ] ASF GitHub Bot commented on MCHECKSTYLE-449: asfgit closed pull request

  1   2   >