Marcono1234 commented on PR #219:
URL: 
https://github.com/apache/maven-shade-plugin/pull/219#issuecomment-2143611680

   > doc should be aware of it somehow, either ensuring we inject the default 
for primitives in plugin.xml or let the doc handle it IMHO
   
   But how do you propose this should be done without being error-prone? Or do 
you propose to not only improve how the documentation is generated, but also 
how Maven determines the `@Parameter` default parameter?
   
   Another case which comes to my mind is:
   ```java
   @Parameter
   boolean param = true;
   ```
   
   Will the documentation plugin be aware that the default value is `true`? It 
would either need to parse the source code or analyze the byte code.
   
   Having the documentation plugin just document `false` for all `@Parameter 
boolean` without `defaultValue = "..."` would be incorrect it seems.
   
   ----
   
   So yes, maybe this issue could be solved generally for all plugins by doing 
a change in Maven Plugin Plugin (?). But to me it seems the solution is not 
simple (if possible at all).
   
   So would you mind accepting this pull request here the way it is for now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to