Re: [PR] Maven 4.0.0-alpha-13 release notes [maven-site]

2024-03-07 Thread via GitHub
cstamas commented on PR #499: URL: https://github.com/apache/maven-site/pull/499#issuecomment-1985209000 Checked Maven 3 (3.9.x branch), to me it seems it does not care for version of repository-metadata... -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Maven 4.0.0-alpha-13 release notes [maven-site]

2024-03-07 Thread via GitHub
cstamas commented on PR #499: URL: https://github.com/apache/maven-site/pull/499#issuecomment-1985194320 And now I don't get something: at least looks fishy to me: when I compare repository-metadata 1.1.0 (current metadata) and 1.2.0 (generated by Maven4) I see some changes. Most of them ar

Re: [PR] Maven 4.0.0-alpha-13 release notes [maven-site]

2024-03-07 Thread via GitHub
cstamas commented on PR #499: URL: https://github.com/apache/maven-site/pull/499#issuecomment-1985184173 IIUC, I should do this: * copy all of these into site `content/resources/xsd` * IF there is a change (git shows file as "edited"), restore original and make it alpha-13 suffixed?

Re: [PR] Maven 4.0.0-alpha-13 release notes [maven-site]

2024-03-07 Thread via GitHub
cstamas commented on PR #499: URL: https://github.com/apache/maven-site/pull/499#issuecomment-1985176762 I have following: ``` [cstamas@blondie checkout ((maven-4.0.0-alpha-13))]$ find . -type f | grep generated-site | grep .xsd ./api/maven-api-plugin/target/generated-site/resource

Re: [PR] Maven 4.0.0-alpha-13 release notes [maven-site]

2024-03-07 Thread via GitHub
gnodet commented on PR #499: URL: https://github.com/apache/maven-site/pull/499#issuecomment-1984527253 > Release notes for 4.0.0-alpha-13. > > From where to get XSDs? Were they generated on the release machine (as now am not at it)? Also, the contents are TBD yet. On the relea

Re: [PR] Bump apache/maven-gh-actions-shared from 2 to 4 [maven-jar-plugin]

2024-03-07 Thread via GitHub
slawekjaranowski merged PR #72: URL: https://github.com/apache/maven-jar-plugin/pull/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[PR] Bump junit5Version from 5.9.3 to 5.10.2 [maven-surefire]

2024-03-07 Thread via GitHub
dependabot[bot] opened a new pull request, #726: URL: https://github.com/apache/maven-surefire/pull/726 Bumps `junit5Version` from 5.9.3 to 5.10.2. Updates `org.junit.jupiter:junit-jupiter-engine` from 5.9.3 to 5.10.2 Release notes Sourced from https://github.com/junit-team/junit

[jira] [Commented] (MGPG-105) Stop propagating bad practices; but allow for "compat mode"

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MGPG-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824479#comment-17824479 ] ASF GitHub Bot commented on MGPG-105: - gnodet commented on code in PR #77: URL: https:/

Re: [PR] [MGPG-105] [MGPG-108] Make plugin backward compat and update site and doco [maven-gpg-plugin]

2024-03-07 Thread via GitHub
gnodet commented on code in PR #77: URL: https://github.com/apache/maven-gpg-plugin/pull/77#discussion_r1516523193 ## src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java: ## @@ -138,23 +144,22 @@ public abstract class AbstractGpgMojo extends AbstractMojo { priv

[jira] [Commented] (MGPG-105) Stop propagating bad practices; but allow for "compat mode"

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MGPG-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824457#comment-17824457 ] ASF GitHub Bot commented on MGPG-105: - cstamas commented on code in PR #77: URL: https:

Re: [PR] [MGPG-105] [MGPG-108] Make plugin backward compat and update site and doco [maven-gpg-plugin]

2024-03-07 Thread via GitHub
cstamas commented on code in PR #77: URL: https://github.com/apache/maven-gpg-plugin/pull/77#discussion_r1516406131 ## src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java: ## @@ -138,23 +144,22 @@ public abstract class AbstractGpgMojo extends AbstractMojo { pri

[jira] [Commented] (MGPG-105) Stop propagating bad practices; but allow for "compat mode"

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MGPG-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824446#comment-17824446 ] ASF GitHub Bot commented on MGPG-105: - gnodet commented on code in PR #77: URL: https:/

Re: [PR] [MGPG-105] [MGPG-108] Make plugin backward compat and update site and doco [maven-gpg-plugin]

2024-03-07 Thread via GitHub
gnodet commented on code in PR #77: URL: https://github.com/apache/maven-gpg-plugin/pull/77#discussion_r1516355473 ## src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java: ## @@ -138,23 +144,22 @@ public abstract class AbstractGpgMojo extends AbstractMojo { priv

[jira] [Commented] (MNG-5726) Update OS Activation To Allow Wildcards In OS Version

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1782#comment-1782 ] ASF GitHub Bot commented on MNG-5726: - kwin merged PR #1431: URL: https://github.com/ap

[jira] [Updated] (MNG-5726) Update OS Activation To Allow Wildcards In OS Version

2024-03-07 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MNG-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated MNG-5726: - Fix Version/s: 3.9.7 > Update OS Activation To Allow Wildcards In OS Version >

Re: [PR] MNG-5726 (backport for Maven 3.9) [maven]

2024-03-07 Thread via GitHub
kwin merged PR #1431: URL: https://github.com/apache/maven/pull/1431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

[PR] Maven 4.0.0-alpha-13 release notes [maven-site]

2024-03-07 Thread via GitHub
cstamas opened a new pull request, #499: URL: https://github.com/apache/maven-site/pull/499 Release notes for 4.0.0-alpha-13. From where to get XSDs? Were they generated on the release machine (as now am not at it)? Also, the contents are TBD yet. -- This is an automated message

[jira] [Commented] (SUREFIRE-2240) Using JUnit BOM prevents upgrading the engine version via plugin dependency

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824436#comment-17824436 ] ASF GitHub Bot commented on SUREFIRE-2240: -- marcphilipp commented on PR #725:

Re: [PR] [SUREFIRE-2240] Don't manage JUnit5 artifact versions [maven-surefire]

2024-03-07 Thread via GitHub
marcphilipp commented on PR #725: URL: https://github.com/apache/maven-surefire/pull/725#issuecomment-1983657637 FWIWI Gradle recently went that route to no longer include/resolve junit-platform-launcher but require users to add it themselves: https://docs.gradle.org/current/userguide/upgra

[jira] [Commented] (MNG-2496) dependencyManagement not used for dependencies in plugin section.

2024-03-07 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824424#comment-17824424 ] Tamas Cservenak commented on MNG-2496: -- I am still with jvz that resolution of project

[jira] [Resolved] (SUREFIRE-2240) Using JUnit BOM prevents upgrading the engine version via plugin dependency

2024-03-07 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SUREFIRE-2240. --- Fix Version/s: 3.x-candidate Resolution: Fixed > Using JUnit BOM prevents u

[jira] [Commented] (SUREFIRE-2240) Using JUnit BOM prevents upgrading the engine version via plugin dependency

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824419#comment-17824419 ] ASF GitHub Bot commented on SUREFIRE-2240: -- kwin merged PR #725: URL: https:/

Re: [PR] [SUREFIRE-2240] Don't manage JUnit5 artifact versions [maven-surefire]

2024-03-07 Thread via GitHub
kwin merged PR #725: URL: https://github.com/apache/maven-surefire/pull/725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apa

[jira] [Comment Edited] (MNG-2496) dependencyManagement not used for dependencies in plugin section.

2024-03-07 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824414#comment-17824414 ] Jörg Hohwiller edited comment on MNG-2496 at 3/7/24 1:48 PM: - >

[jira] [Comment Edited] (MNG-2496) dependencyManagement not used for dependencies in plugin section.

2024-03-07 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824414#comment-17824414 ] Jörg Hohwiller edited comment on MNG-2496 at 3/7/24 1:46 PM: - >

[jira] [Commented] (MNG-2496) dependencyManagement not used for dependencies in plugin section.

2024-03-07 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824414#comment-17824414 ] Jörg Hohwiller commented on MNG-2496: - > I am unsure what scenario would require "omit

[jira] [Created] (SUREFIRE-2241) Junitparams based parameterized test may cause test execution to silently pass

2024-03-07 Thread Zoltan Haindrich (Jira)
Zoltan Haindrich created SUREFIRE-2241: -- Summary: Junitparams based parameterized test may cause test execution to silently pass Key: SUREFIRE-2241 URL: https://issues.apache.org/jira/browse/SUREFIRE-2241

[jira] [Updated] (MGPG-105) Stop propagating bad practices; but allow for "compat mode"

2024-03-07 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MGPG-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MGPG-105: - Description: Storing any kind of "password-like" things on disk in files is bad (and no, SecDispat

[jira] [Updated] (MNG-8061) Upgrade Maven runtime requirement to Java 17

2024-03-07 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8061: - Issue Type: New Feature (was: Task) > Upgrade Maven runtime requirement to Java 17 > -

[jira] [Commented] (SUREFIRE-2240) Using JUnit BOM prevents upgrading the engine version via plugin dependency

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824391#comment-17824391 ] ASF GitHub Bot commented on SUREFIRE-2240: -- rmannibucau commented on PR #725:

Re: [PR] [SUREFIRE-2240] Don't manage JUnit5 artifact versions [maven-surefire]

2024-03-07 Thread via GitHub
rmannibucau commented on PR #725: URL: https://github.com/apache/maven-surefire/pull/725#issuecomment-1983399262 @marcphilipp we wouldn't have any provided dependency in surefire itself, everything would be resolved from project dependencies (if provided use else resolve the aligned version

[jira] [Commented] (SUREFIRE-2240) Using JUnit BOM prevents upgrading the engine version via plugin dependency

2024-03-07 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824379#comment-17824379 ] Slawomir Jaranowski commented on SUREFIRE-2240: --- By the way - we shouldn

[jira] [Commented] (SUREFIRE-2240) Using JUnit BOM prevents upgrading the engine version via plugin dependency

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824363#comment-17824363 ] ASF GitHub Bot commented on SUREFIRE-2240: -- kwin commented on PR #725: URL: h

Re: [PR] [SUREFIRE-2240] Don't manage JUnit5 artifact versions [maven-surefire]

2024-03-07 Thread via GitHub
kwin commented on PR #725: URL: https://github.com/apache/maven-surefire/pull/725#issuecomment-1983282674 @marcphilipp @rmannibucau Let us focus in this PR only on the issue that overriding plugin dependencies as outlined in https://maven.apache.org/surefire/maven-surefire-plugin/examples/j

[jira] [Commented] (MNGSITE-533) Add Sentry Maven Skin to the list of available skins for Maven Site plugin

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824361#comment-17824361 ] ASF GitHub Bot commented on MNGSITE-533: bertysentry commented on PR #498: URL:

Re: [PR] [MNGSITE-533] Add Sentry Maven Skin [maven-site]

2024-03-07 Thread via GitHub
bertysentry commented on PR #498: URL: https://github.com/apache/maven-site/pull/498#issuecomment-1983274718 Rebased again to update the commit message and refer to the correct Jira issue (didn't notice it had been moved to MNGSITE-533) -- This is an automated message from the Apache Git

[jira] [Comment Edited] (MCOMPILER-581) Create 2nd default execution "default-generate-sources" for APT

2024-03-07 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824354#comment-17824354 ] Tamas Cservenak edited comment on MCOMPILER-581 at 3/7/24 10:31 AM:

[jira] [Commented] (SUREFIRE-2240) Using JUnit BOM prevents upgrading the engine version via plugin dependency

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824355#comment-17824355 ] ASF GitHub Bot commented on SUREFIRE-2240: -- marcphilipp commented on PR #725:

Re: [PR] [SUREFIRE-2240] Don't manage JUnit5 artifact versions [maven-surefire]

2024-03-07 Thread via GitHub
marcphilipp commented on PR #725: URL: https://github.com/apache/maven-surefire/pull/725#issuecomment-1983213597 The used version needs to match the one in the project's dependencies, i.e. if a build uses JUnit Jupiter 5.10.2, Surefire should use 1.10.2 of its JUnit Platform dependencies. I

[jira] [Commented] (MCOMPILER-581) Create 2nd default execution "default-generate-sources" for APT

2024-03-07 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824354#comment-17824354 ] Tamas Cservenak commented on MCOMPILER-581: --- How about something along these

[jira] [Commented] (SUREFIRE-2240) Using JUnit BOM prevents upgrading the engine version via plugin dependency

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824333#comment-17824333 ] ASF GitHub Bot commented on SUREFIRE-2240: -- rmannibucau commented on PR #725:

Re: [PR] [SUREFIRE-2240] Don't manage JUnit5 artifact versions [maven-surefire]

2024-03-07 Thread via GitHub
rmannibucau commented on PR #725: URL: https://github.com/apache/maven-surefire/pull/725#issuecomment-1983072275 Thinking out loud: any reason to have junit in dependency at all? can't we just use ToolProvider "junit" to launch it and be totally decoupled from junit? Would enable to use the

[jira] [Updated] (MCOMPILER-581) Create 2nd default execution "default-generate-sources" for APT

2024-03-07 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MCOMPILER-581: --- Summary: Create 2nd default execution "default-generate-sources" for APT (was: Cr

[jira] [Commented] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824311#comment-17824311 ] ASF GitHub Bot commented on MTOOLCHAINS-49: --- gnodet commented on PR #14: UR

Re: [PR] [MTOOLCHAINS-49] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-03-07 Thread via GitHub
gnodet commented on PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#issuecomment-1982971274 > With your latest additions, the `display-discovered-jdk-toolchains` mojo reports 9 JDK toolchains, including the two versions of openjdk21 I have installed. Yes, that

[jira] [Commented] (SUREFIRE-2240) Using JUnit BOM prevents upgrading the engine version via plugin dependency

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824309#comment-17824309 ] ASF GitHub Bot commented on SUREFIRE-2240: -- kwin commented on code in PR #725

Re: [PR] [SUREFIRE-2240] Don't manage JUnit5 artifact versions [maven-surefire]

2024-03-07 Thread via GitHub
kwin commented on code in PR #725: URL: https://github.com/apache/maven-surefire/pull/725#discussion_r1515756414 ## surefire-providers/surefire-junit-platform/pom.xml: ## @@ -80,6 +80,13 @@ surefire-3.0.0-M8 + + Review Comment: The BOM will affect transitive

[jira] [Commented] (SUREFIRE-2240) Using JUnit BOM prevents upgrading the engine version via plugin dependency

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824308#comment-17824308 ] ASF GitHub Bot commented on SUREFIRE-2240: -- kwin commented on code in PR #725

Re: [PR] [SUREFIRE-2240] Don't manage JUnit5 artifact versions [maven-surefire]

2024-03-07 Thread via GitHub
kwin commented on code in PR #725: URL: https://github.com/apache/maven-surefire/pull/725#discussion_r1515756414 ## surefire-providers/surefire-junit-platform/pom.xml: ## @@ -80,6 +80,13 @@ surefire-3.0.0-M8 + + Review Comment: The BOM will affect transitive

[jira] [Commented] (SUREFIRE-2240) Using JUnit BOM prevents upgrading the engine version via plugin dependency

2024-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824307#comment-17824307 ] ASF GitHub Bot commented on SUREFIRE-2240: -- marcphilipp commented on code in

Re: [PR] [SUREFIRE-2240] Don't manage JUnit5 artifact versions [maven-surefire]

2024-03-07 Thread via GitHub
marcphilipp commented on code in PR #725: URL: https://github.com/apache/maven-surefire/pull/725#discussion_r1515753439 ## surefire-providers/surefire-junit-platform/pom.xml: ## @@ -80,6 +80,13 @@ surefire-3.0.0-M8 + + Review Comment: Yes, that's correct but

[jira] [Created] (MCOMPILER-581) Create 2nd default goal "default-generate-sources" for APT

2024-03-07 Thread Benjamin Marwell (Jira)
Benjamin Marwell created MCOMPILER-581: -- Summary: Create 2nd default goal "default-generate-sources" for APT Key: MCOMPILER-581 URL: https://issues.apache.org/jira/browse/MCOMPILER-581 Project: Ma