[
https://issues.apache.org/jira/browse/SUREFIRE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824391#comment-17824391
]
ASF GitHub Bot commented on SUREFIRE-2240:
------------------------------------------
rmannibucau commented on PR #725:
URL: https://github.com/apache/maven-surefire/pull/725#issuecomment-1983399262
@marcphilipp we wouldn't have any provided dependency in surefire itself,
everything would be resolved from project dependencies (if provided use else
resolve the aligned version) means there is no more bom topic or things like
that with a hybrid surefire/project source of dependencies.
> Using JUnit BOM prevents upgrading the engine version via plugin dependency
> ---------------------------------------------------------------------------
>
> Key: SUREFIRE-2240
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2240
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support
> Affects Versions: 3.2.1
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> The change being introduced in SUREFIRE-2177 prevents updating the
> {{junit-jupiter-engine}} through explicit plugin dependencies as outlined in
> https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html#select-engine-and-use-multiple-apis:
> {code}
> <plugin>
> <artifactId>maven-surefire-plugin</artifactId>
> <dependencies>
> <dependency>
> <groupId>org.junit.jupiter</groupId>
> <artifactId>junit-jupiter-engine</artifactId>
> <version>5.10.2</version>
> </dependency>
> </dependencies>
> </plugin>
> {code}
> The following classpath is then used in m-surefire-p
> {code}
> [INFO] --- surefire:3.2.2:test (default-test) @ doxia-converter ---
> [DEBUG] Dependency collection stats {ConflictMarker.analyzeTime=62708,
> ConflictMarker.markTime=28792, ConflictMarker.nodeCount=94,
> ConflictIdSorter.graphTime=19292, ConflictIdSorter.topsortTime=17458,
> ConflictIdSorter.conflictIdCount=48, ConflictIdSorter.conflictIdCycleCount=0,
> ConflictResolver.totalTime=382250, ConflictResolver.conflictItemCount=92,
> DfDependencyCollector.collectTime=35588250,
> DfDependencyCollector.transformTime=530209}
> [DEBUG] org.apache.maven.plugins:maven-surefire-plugin:jar:3.2.2
> [DEBUG] org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:runtime
> [DEBUG] org.junit.platform:junit-platform-engine:jar:1.9.3:runtime
> (version managed from default)
> ...
> {code}
> The managed {{junit-platform-engine}} version is incompatible (as being
> downgraded via
> https://github.com/apache/maven-surefire/blob/2fed802397f8c7de4cfc72f49ab4565e72f7aab7/pom.xml#L311-L318)
> For this reason there shouldn't be any depMgmt used in surefire.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
