Re: [I] 1.0 may be less stable than 0.9.0 [maven-mvnd]

2023-11-30 Thread via GitHub
meiMingle commented on issue #902: URL: https://github.com/apache/maven-mvnd/issues/902#issuecomment-1835574337 My project is a project with 200+ modules. The maven plug-in and version used are as follows ```xml org.apache.maven.plugins maven-release-plugin 2.5.3

[I] 1.0 may be less stable than 0.9.0 [maven-mvnd]

2023-11-30 Thread via GitHub
meiMingle opened a new issue, #902: URL: https://github.com/apache/maven-mvnd/issues/902 Recently I upgraded mvnd from 0.9.0 to 1.0-m8. However, the build often fails. Although it does not fail every time, there is at least one fifth chance of failure with errors similar to the following. .

[jira] [Commented] (ARCHETYPE-649) "[WARNING] CP Don't override file" when generating archetype with 3.2.1

2023-11-30 Thread Wolfgang Knauf (Jira)
[ https://issues.apache.org/jira/browse/ARCHETYPE-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791921#comment-17791921 ] Wolfgang Knauf commented on ARCHETYPE-649: -- Sent a pull request, though I don

Re: [PR] refactor IncrementalResourceFilteringTest [maven-filtering]

2023-11-30 Thread via GitHub
laeubi commented on PR #82: URL: https://github.com/apache/maven-filtering/pull/82#issuecomment-1835476734 @hboutemy @gnodet @wborn @elharo or anyone can look into this and review/merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Closed] (MJAVADOC-682) Reactor builds fail when multiple modules with same groupId:artifactId, but different versions

2023-11-30 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MJAVADOC-682. --- Resolution: Fixed Fixed with [b69af90253f769a2669754aa978eded271bf690e|https://gitbox.apac

[jira] [Commented] (MJAVADOC-682) Reactor builds fail when multiple modules with same groupId:artifactId, but different versions

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791798#comment-17791798 ] ASF GitHub Bot commented on MJAVADOC-682: - asfgit closed pull request #253: [MJ

Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]

2023-11-30 Thread via GitHub
asfgit closed pull request #253: [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… URL: https://github.com/apache/maven-javadoc-plugin/pull/253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (MJAVADOC-764) javadoc:aggregate fails after Java 11 upgrade

2023-11-30 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MJAVADOC-764: Fix Version/s: (was: waiting-for-feedback) > javadoc:aggregate fails after Java 11 up

[jira] [Updated] (MJAVADOC-689) When I run "javadoc:fix" , I get an error .

2023-11-30 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MJAVADOC-689: Fix Version/s: (was: waiting-for-feedback) > When I run "javadoc:fix" , I get an erro

[jira] [Commented] (MJAVADOC-682) Reactor builds fail when multiple modules with same groupId:artifactId, but different versions

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791789#comment-17791789 ] ASF GitHub Bot commented on MJAVADOC-682: - ao-apps commented on PR #253: URL:

Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]

2023-11-30 Thread via GitHub
ao-apps commented on PR #253: URL: https://github.com/apache/maven-javadoc-plugin/pull/253#issuecomment-1834560911 I went ahead and confirmed the provided integration tests for MJAVADOC-682 do, in fact, reproduce the originally reported issue: The build succeeds on 3.0.1 and fails on 3.6.2

[jira] [Updated] (SUREFIRE-2211) additionalClasspathElement with UNC path not working with Maven Failsafe Plugin

2023-11-30 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SUREFIRE-2211: - Summary: additionalClasspathElement with UNC path not working with Maven Failsafe Plug

[jira] [Commented] (ARCHETYPE-64) groupId and version redundant when executing archetype with parent

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/ARCHETYPE-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791784#comment-17791784 ] ASF GitHub Bot commented on ARCHETYPE-64: - WolfgangHG opened a new pull request

[PR] [ARCHETYPE-64] work around warning 'Don't override file...' [maven-archetype]

2023-11-30 Thread via GitHub
WolfgangHG opened a new pull request, #160: URL: https://github.com/apache/maven-archetype/pull/160 This pull request tries to work around a warning "Don't override file ..." or "CP Don't override file..." that appeared after switching from maven archetype plugin 3.1.2 to 3.2.1 - more detai

[jira] [Commented] (MJAVADOC-682) Reactor builds fail when multiple modules with same groupId:artifactId, but different versions

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791778#comment-17791778 ] ASF GitHub Bot commented on MJAVADOC-682: - michael-o commented on PR #253: URL:

Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]

2023-11-30 Thread via GitHub
michael-o commented on PR #253: URL: https://github.com/apache/maven-javadoc-plugin/pull/253#issuecomment-1834546577 > > CI is rolling... > > I just noticed a mistake and force-pushed a fix. I left the "package" declaration on top of the module-info.java files. Modified... -

[jira] [Created] (SUREFIRE-2218) Add support for fetching test classes from a jar

2023-11-30 Thread Sebb (Jira)
Sebb created SUREFIRE-2218: -- Summary: Add support for fetching test classes from a jar Key: SUREFIRE-2218 URL: https://issues.apache.org/jira/browse/SUREFIRE-2218 Project: Maven Surefire Issue Type:

[jira] [Commented] (MJAVADOC-682) Reactor builds fail when multiple modules with same groupId:artifactId, but different versions

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791776#comment-17791776 ] ASF GitHub Bot commented on MJAVADOC-682: - ao-apps commented on PR #253: URL:

Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]

2023-11-30 Thread via GitHub
ao-apps commented on PR #253: URL: https://github.com/apache/maven-javadoc-plugin/pull/253#issuecomment-1834544596 > CI is rolling... I just noticed a mistake and force-pushed a fix. I left the "package" declaration on top of the module-info.java files. -- This is an automated me

[jira] [Commented] (MJAVADOC-682) Reactor builds fail when multiple modules with same groupId:artifactId, but different versions

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791775#comment-17791775 ] ASF GitHub Bot commented on MJAVADOC-682: - michael-o commented on PR #253: URL:

Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]

2023-11-30 Thread via GitHub
michael-o commented on PR #253: URL: https://github.com/apache/maven-javadoc-plugin/pull/253#issuecomment-1834541330 CI is rolling... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (MJAVADOC-682) Reactor builds fail when multiple modules with same groupId:artifactId, but different versions

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791773#comment-17791773 ] ASF GitHub Bot commented on MJAVADOC-682: - michael-o commented on PR #253: URL:

Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]

2023-11-30 Thread via GitHub
michael-o commented on PR #253: URL: https://github.com/apache/maven-javadoc-plugin/pull/253#issuecomment-1834535266 > Should I change the commit message to begin with "[[MJAVADOC-682](https://issues.apache.org/jira/browse/MJAVADOC-682)]"? No, I will squash anyway and give you attrib

[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791769#comment-17791769 ] ASF GitHub Bot commented on MRELEASE-1109: -- michael-o commented on code in PR

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

2023-11-30 Thread via GitHub
michael-o commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1411233842 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RewritePomsForReleasePhase.java: ## @@ -214,6 +217,15 @@ private boolean translateScm

[jira] [Commented] (MJAVADOC-682) Reactor builds fail when multiple modules with same groupId:artifactId, but different versions

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791752#comment-17791752 ] ASF GitHub Bot commented on MJAVADOC-682: - ao-apps commented on PR #253: URL:

Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]

2023-11-30 Thread via GitHub
ao-apps commented on PR #253: URL: https://github.com/apache/maven-javadoc-plugin/pull/253#issuecomment-1834421972 Should I change the commit message to begin with "[MJAVADOC-682]"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Commented] (MJAVADOC-682) Reactor builds fail when multiple modules with same groupId:artifactId, but different versions

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791749#comment-17791749 ] ASF GitHub Bot commented on MJAVADOC-682: - michael-o commented on PR #253: URL:

Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]

2023-11-30 Thread via GitHub
michael-o commented on PR #253: URL: https://github.com/apache/maven-javadoc-plugin/pull/253#issuecomment-1834409990 > I have created integration tests for [MJAVADOC-682](https://issues.apache.org/jira/browse/MJAVADOC-682): [2f291d4](https://github.com/apache/maven-javadoc-plugin/commit/2f

Re: [PR] [MRESOLVER-445] Introduce MutableSession to bridge between to two implementation [maven-resolver]

2023-11-30 Thread via GitHub
cstamas commented on PR #383: URL: https://github.com/apache/maven-resolver/pull/383#issuecomment-1834327830 Actually scratch all that above, I changed my mind. Soon will push almost totally opposite change to the commit that introduces MutableSession. -- This is an automated message from

[jira] [Commented] (MRESOLVER-445) Introduce MutableSession, a common ancestor for build and def impl

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791730#comment-17791730 ] ASF GitHub Bot commented on MRESOLVER-445: -- cstamas commented on PR #383: URL

Re: [PR] [MJAVADOC-682] Reactor builds fail when multiple modules with same gr… [maven-javadoc-plugin]

2023-11-30 Thread via GitHub
ao-apps commented on PR #253: URL: https://github.com/apache/maven-javadoc-plugin/pull/253#issuecomment-1834301033 I have created integration tests for MJAVADOC-682: https://github.com/apache/maven-javadoc-plugin/commit/2f291d40e672078e042bfc11241dd90aefc04450 Should I create a separ

[jira] [Commented] (MJAVADOC-682) Reactor builds fail when multiple modules with same groupId:artifactId, but different versions

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791727#comment-17791727 ] ASF GitHub Bot commented on MJAVADOC-682: - ao-apps commented on PR #253: URL:

[jira] [Commented] (MRESOLVER-445) Introduce MutableSession, a common ancestor for build and def impl

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791723#comment-17791723 ] ASF GitHub Bot commented on MRESOLVER-445: -- cstamas commented on PR #383: URL

Re: [PR] [MRESOLVER-445] Introduce MutableSession to bridge between to two implementation [maven-resolver]

2023-11-30 Thread via GitHub
cstamas commented on PR #383: URL: https://github.com/apache/maven-resolver/pull/383#issuecomment-1834282831 @gnodet Yes, taking step back is actually the point here: to ease migration of code that used Resolver 1.x. My plan is following: DefaultRepositorySystemSession (DRSS) should b

[jira] [Commented] (MRESOLVER-445) Introduce MutableSession, a common ancestor for build and def impl

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791626#comment-17791626 ] ASF GitHub Bot commented on MRESOLVER-445: -- gnodet commented on PR #383: URL:

Re: [PR] [MRESOLVER-445] Introduce MutableSession to bridge between to two implementation [maven-resolver]

2023-11-30 Thread via GitHub
gnodet commented on PR #383: URL: https://github.com/apache/maven-resolver/pull/383#issuecomment-1833775253 @cstamas have you looked at the possibility to add mutators that would return a new `RepositorySession` instance instead of modifying the existing one in-place. This would allow pres

[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791624#comment-17791624 ] ASF GitHub Bot commented on MRELEASE-1109: -- kwin commented on code in PR #202

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

2023-11-30 Thread via GitHub
kwin commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1410645662 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RewritePomsForReleasePhase.java: ## @@ -214,6 +217,15 @@ private boolean translateScm(

[jira] [Created] (MSHARED-1338) Update groovy to 4.0.16

2023-11-30 Thread Jira
Jorge Solórzano created MSHARED-1338: Summary: Update groovy to 4.0.16 Key: MSHARED-1338 URL: https://issues.apache.org/jira/browse/MSHARED-1338 Project: Maven Shared Components Issue Typ

[jira] [Commented] (MSHARED-1285) DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791554#comment-17791554 ] ASF GitHub Bot commented on MSHARED-1285: - lalmeras commented on PR #77: URL: h

Re: [PR] [MSHARED-1285] use an up-to-date scanner instead the newscanner [maven-filtering]

2023-11-30 Thread via GitHub
lalmeras commented on PR #77: URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1833477761 Done ! #82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] refactor IncrementalResourceFilteringTest [maven-filtering]

2023-11-30 Thread via GitHub
lalmeras opened a new pull request, #82: URL: https://github.com/apache/maven-filtering/pull/82 Existing test uses a TestIncrementalBuildContext from plexus-build-api:tests that is buggy. isUptodate and hasDelta methods return wrong result, due to path resolution issues (wrong basedir, lead

[jira] [Commented] (SUREFIRE-2211) additionalClasspathElement with UNC path not working with failsafe > 3.0.0-M1

2023-11-30 Thread Robert Seidel (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791526#comment-17791526 ] Robert Seidel commented on SUREFIRE-2211: - Sorry, I didn't had the time in the