Re: [PR] Fix snippet reader tab and indent handling [maven-doxia]

2023-10-09 Thread via GitHub
michael-o commented on PR #161: URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753613903 > I think the indentation is clearly removed in order to prevent horizontal scrollbars for included snippets. I'd prefer to leave formatting as-is, but I am open to a snippet op

Re: [PR] Fix snippet reader tab and indent handling [maven-doxia]

2023-10-09 Thread via GitHub
Jotschi commented on PR #161: URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753609381 I think the indentation is clearly removed in order to prevent horizontal scrollbars for included snippets. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Fix snippet reader tab and indent handling [maven-doxia]

2023-10-09 Thread via GitHub
michael-o commented on PR #161: URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753607241 > The code clearly removes this indentation if it is done by using spaces. Using tabs it is not removed and thus looks broken. I'm okay with it if that is the desired behaviour.

Re: [PR] Fix snippet reader tab and indent handling [maven-doxia]

2023-10-09 Thread via GitHub
Jotschi commented on PR #161: URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753603833 The code clearly removes this indentation if it is done by using spaces. Using tabs it is not removed and thus looks broken. I'm okay with it if that is the desired behaviour. -- T

Re: [PR] Fix snippet reader tab and indent handling [maven-doxia]

2023-10-09 Thread via GitHub
michael-o commented on PR #161: URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753593496 But what if ``` { // your code } ``` is correct indentation? -- This is an automated message from the Apache Git Ser

Re: [PR] Fix snippet reader tab and indent handling [maven-doxia]

2023-10-09 Thread via GitHub
Jotschi commented on PR #161: URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753582952 The snippet renderer removed unnecessary indentation. It thus moved the code block left. A code example which is highly indented will thus not include the bogus indentation. ```j

Re: [PR] Fix snippet reader tab and indent handling [maven-doxia]

2023-10-09 Thread via GitHub
michael-o commented on PR #161: URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753573765 @kwin, do you understand this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Fix snippet reader tab and indent handling [maven-doxia]

2023-10-09 Thread via GitHub
michael-o commented on PR #161: URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753573193 > The tabs from this example `[tab][tab]line` will not be removed. Thus the snippet looks ugly. The tabs should be removed. Why? If the snippet is intended that way? How can we

Re: [PR] Fix snippet reader tab and indent handling [maven-doxia]

2023-10-09 Thread via GitHub
Jotschi commented on PR #161: URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753562919 The tabs from this example ```[tab][tab]line``` will not be removed. Thus the snippet looks ugly. The tabs should be removed. -- This is an automated message from the Apache

[jira] [Closed] (MSHARED-1316) Upgrade to Parent 40

2023-10-09 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSHARED-1316. --- Resolution: Fixed Fixed with [2d773dff789021ba0c4befa3631b2b7201949a5f|https://gitbox.apac

Re: [PR] Fix snippet reader tab and indent handling [maven-doxia]

2023-10-09 Thread via GitHub
michael-o commented on PR #161: URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753550682 First snippet has two tabs, but expected does not have any. What do I miss? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Fix snippet reader tab and indent handling [maven-doxia]

2023-10-09 Thread via GitHub
Jotschi commented on PR #161: URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753545065 As far as I recall - no - tabs are not removed at all. See first example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Fix snippet reader tab and indent handling [maven-doxia]

2023-10-09 Thread via GitHub
michael-o commented on PR #161: URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753541119 > It fixes the indentation behaviour when the source contains tabs. Without the fix the indentation is not correctly handled. Without the fix the source code block has too many tabs a

Re: [PR] Fix snippet reader tab and indent handling [maven-doxia]

2023-10-09 Thread via GitHub
Jotschi commented on PR #161: URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753538027 It fixes the indentation behaviour when the source contains tabs. Without the fix the indentation is not correctly handled. Without the fix the source code block has too many tabs and i

[jira] [Created] (MSHARED-1317) Upgrade to Doxia 2.0.0-M8

2023-10-09 Thread Michael Osipov (Jira)
Michael Osipov created MSHARED-1317: --- Summary: Upgrade to Doxia 2.0.0-M8 Key: MSHARED-1317 URL: https://issues.apache.org/jira/browse/MSHARED-1317 Project: Maven Shared Components Issue Typ

[jira] [Created] (MSHARED-1316) Upgrade to Parent 40

2023-10-09 Thread Michael Osipov (Jira)
Michael Osipov created MSHARED-1316: --- Summary: Upgrade to Parent 40 Key: MSHARED-1316 URL: https://issues.apache.org/jira/browse/MSHARED-1316 Project: Maven Shared Components Issue Type: De

Re: [PR] Fix snippet reader tab and indent handling [maven-doxia]

2023-10-09 Thread via GitHub
michael-o commented on PR #161: URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753520298 I don't understand this change. It does not retain the original format, what does it address? -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Closed] (DOXIA-706) Sink.text(String, SinkEventAttributes) not properly supported by Xhtml5BaseSink

2023-10-09 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIA-706. > Sink.text(String, SinkEventAttributes) not properly supported by > Xhtml5BaseSink > -

[jira] [Closed] (DOXIA-708) Upgrade to Parent 40

2023-10-09 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIA-708. Resolution: Fixed Fixed with [a1e97f9d47b20470c4a5b536406d8c5cb08277bc|https://gitbox.apache.org/re

[jira] [Created] (DOXIA-708) Upgrade to Parent 40

2023-10-09 Thread Michael Osipov (Jira)
Michael Osipov created DOXIA-708: Summary: Upgrade to Parent 40 Key: DOXIA-708 URL: https://issues.apache.org/jira/browse/DOXIA-708 Project: Maven Doxia Issue Type: Dependency upgrade

[jira] [Commented] (MNG-7811) Plugins verification - reports are inconsistent

2023-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773354#comment-17773354 ] ASF GitHub Bot commented on MNG-7811: - hboutemy merged PR #461: URL: https://github.com

Re: [PR] [MNG-7811] improve plugin validation documentation [maven-site]

2023-10-09 Thread via GitHub
hboutemy merged PR #461: URL: https://github.com/apache/maven-site/pull/461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apa

[jira] [Commented] (MNG-7811) Plugins verification - reports are inconsistent

2023-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773351#comment-17773351 ] ASF GitHub Bot commented on MNG-7811: - hboutemy commented on code in PR #461: URL: http

Re: [PR] [MNG-7811] improve plugin validation documentation [maven-site]

2023-10-09 Thread via GitHub
hboutemy commented on code in PR #461: URL: https://github.com/apache/maven-site/pull/461#discussion_r1350409890 ## content/markdown/guides/plugins/validation/index.md: ## @@ -19,56 +19,65 @@ specific language governing permissions and limitations under the License. --> -Mav

[jira] [Closed] (SUREFIRE-2200) JEP 443: Illegal field name "" in class

2023-10-09 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed SUREFIRE-2200. Resolution: Information Provided This is a bug in Java, [~cstamas] has reported it recen

Re: [I] `Could not acquire write lock for…` errors [maven-mvnd]

2023-10-09 Thread via GitHub
eliasbalasis commented on issue #836: URL: https://github.com/apache/maven-mvnd/issues/836#issuecomment-1752973467 @michael-o many thanks for making the effort, it helps a lot. I will try it and see how it goes. -- This is an automated message from the Apache Git Service. To resp

[jira] [Commented] (MNG-7901) Use MetadataStaxReader/Writer in MetadataXpp3Reader/Writer

2023-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773258#comment-17773258 ] ASF GitHub Bot commented on MNG-7901: - slawekjaranowski commented on code in PR #1274:

Re: [PR] [MNG-7901] Use MetadataStaxReader/Writer in MetadataXpp3Reader/Writer [maven]

2023-10-09 Thread via GitHub
slawekjaranowski commented on code in PR #1274: URL: https://github.com/apache/maven/pull/1274#discussion_r1350179172 ## maven-repository-metadata/src/main/java/org/apache/maven/artifact/repository/metadata/io/xpp3/MetadataXpp3Reader.java: ## @@ -26,22 +26,23 @@ import java.io.

[jira] [Commented] (MNG-7901) Use MetadataStaxReader/Writer in MetadataXpp3Reader/Writer

2023-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773245#comment-17773245 ] ASF GitHub Bot commented on MNG-7901: - slawekjaranowski commented on code in PR #1274:

Re: [PR] [MNG-7901] Use MetadataStaxReader/Writer in MetadataXpp3Reader/Writer [maven]

2023-10-09 Thread via GitHub
slawekjaranowski commented on code in PR #1274: URL: https://github.com/apache/maven/pull/1274#discussion_r1350147594 ## maven-repository-metadata/src/main/java/org/apache/maven/artifact/repository/metadata/io/xpp3/MetadataXpp3Reader.java: ## @@ -26,22 +26,23 @@ import java.io.

[jira] [Commented] (MSHARED-1285) DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes

2023-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773241#comment-17773241 ] ASF GitHub Bot commented on MSHARED-1285: - OLibutzki commented on PR #77: URL:

Re: [PR] MSHARED-1285 use an up-to-date scanner instead the newscanner [maven-filtering]

2023-10-09 Thread via GitHub
OLibutzki commented on PR #77: URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1752774319 Any chances to get some progress into this PR? From an Eclipse user perspective this issue is really annoying as some resources are not copied to the target/classes folder. /

[jira] [Created] (SUREFIRE-2200) JEP 443: Illegal field name "" in class

2023-10-09 Thread Sebastian Stenzel (Jira)
Sebastian Stenzel created SUREFIRE-2200: --- Summary: JEP 443: Illegal field name "" in class Key: SUREFIRE-2200 URL: https://issues.apache.org/jira/browse/SUREFIRE-2200 Project: Maven Surefire

[jira] [Commented] (MNG-7898) Missing .mvn directory should not be reported in quiet mode

2023-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773234#comment-17773234 ] ASF GitHub Bot commented on MNG-7898: - slawekjaranowski commented on code in PR #1273:

Re: [PR] [MNG-7898] Missing .mvn directory should not be reported in quiet mode [maven]

2023-10-09 Thread via GitHub
slawekjaranowski commented on code in PR #1273: URL: https://github.com/apache/maven/pull/1273#discussion_r1350122894 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -447,6 +443,10 @@ private void informativeCommands(CliRequest cliRequest) throws ExitE

[jira] [Commented] (MNG-7901) Use MetadataStaxReader/Writer in MetadataXpp3Reader/Writer

2023-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773233#comment-17773233 ] ASF GitHub Bot commented on MNG-7901: - cstamas commented on code in PR #1274: URL: http

Re: [PR] [MNG-7901] Use MetadataStaxReader/Writer in MetadataXpp3Reader/Writer [maven]

2023-10-09 Thread via GitHub
cstamas commented on code in PR #1274: URL: https://github.com/apache/maven/pull/1274#discussion_r1350119788 ## maven-repository-metadata/src/main/java/org/apache/maven/artifact/repository/metadata/io/xpp3/MetadataXpp3Reader.java: ## @@ -26,22 +26,23 @@ import java.io.Reader;

[jira] [Commented] (MNG-7811) Plugins verification - reports are inconsistent

2023-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773224#comment-17773224 ] ASF GitHub Bot commented on MNG-7811: - michael-o commented on code in PR #461: URL: htt

[jira] [Updated] (DOXIA-707) Ability to define lineneding for generated content

2023-10-09 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIA-707: - Fix Version/s: waiting-for-feedback > Ability to define lineneding for generated content > ---

[jira] [Commented] (MNG-7898) Missing .mvn directory should not be reported in quiet mode

2023-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773225#comment-17773225 ] ASF GitHub Bot commented on MNG-7898: - rmannibucau commented on code in PR #1273: URL:

Re: [PR] [MNG-7898] Missing .mvn directory should not be reported in quiet mode [maven]

2023-10-09 Thread via GitHub
rmannibucau commented on code in PR #1273: URL: https://github.com/apache/maven/pull/1273#discussion_r1350107157 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -447,6 +443,10 @@ private void informativeCommands(CliRequest cliRequest) throws ExitExcept

Re: [PR] [MNG-7811] improve plugin validation documentation [maven-site]

2023-10-09 Thread via GitHub
michael-o commented on code in PR #461: URL: https://github.com/apache/maven-site/pull/461#discussion_r1350107023 ## content/markdown/guides/plugins/validation/index.md: ## @@ -19,56 +19,65 @@ specific language governing permissions and limitations under the License. --> -Ma

[jira] [Closed] (MSHARED-1314) mark execute() final to avoid users extending reporting-impl implementation

2023-10-09 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MSHARED-1314. -- Fix Version/s: maven-reporting- Resolution: Fixed > mark execute() final to avoid user

[jira] [Commented] (MSHARED-1314) mark execute() final to avoid users extending reporting-impl implementation

2023-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773214#comment-17773214 ] ASF GitHub Bot commented on MSHARED-1314: - hboutemy merged PR #24: URL: https:/

Re: [PR] [MSHARED-1314] mark execute() final and improve documentation [maven-reporting-impl]

2023-10-09 Thread via GitHub
hboutemy merged PR #24: URL: https://github.com/apache/maven-reporting-impl/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

[jira] [Commented] (MNG-7811) Plugins verification - reports are inconsistent

2023-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773208#comment-17773208 ] ASF GitHub Bot commented on MNG-7811: - cstamas commented on code in PR #461: URL: https

Re: [PR] [MNG-7811] improve plugin validation documentation [maven-site]

2023-10-09 Thread via GitHub
cstamas commented on code in PR #461: URL: https://github.com/apache/maven-site/pull/461#discussion_r1350042054 ## content/markdown/guides/plugins/validation/index.md: ## @@ -19,56 +19,65 @@ specific language governing permissions and limitations under the License. --> -Mave

[jira] [Commented] (MNG-7811) Plugins verification - reports are inconsistent

2023-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773202#comment-17773202 ] ASF GitHub Bot commented on MNG-7811: - michael-o commented on code in PR #461: URL: htt

Re: [PR] [MNG-7811] improve plugin validation documentation [maven-site]

2023-10-09 Thread via GitHub
michael-o commented on code in PR #461: URL: https://github.com/apache/maven-site/pull/461#discussion_r1350059190 ## content/markdown/guides/plugins/validation/index.md: ## @@ -19,56 +19,65 @@ specific language governing permissions and limitations under the License. --> -Ma

[jira] [Commented] (MNG-7811) Plugins verification - reports are inconsistent

2023-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773199#comment-17773199 ] ASF GitHub Bot commented on MNG-7811: - cstamas commented on code in PR #461: URL: https

Re: [PR] [MNG-7811] improve plugin validation documentation [maven-site]

2023-10-09 Thread via GitHub
cstamas commented on code in PR #461: URL: https://github.com/apache/maven-site/pull/461#discussion_r1350044126 ## content/markdown/guides/plugins/validation/index.md: ## @@ -19,56 +19,65 @@ specific language governing permissions and limitations under the License. --> -Mave

[jira] [Commented] (MNG-7811) Plugins verification - reports are inconsistent

2023-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773198#comment-17773198 ] ASF GitHub Bot commented on MNG-7811: - cstamas commented on code in PR #461: URL: https

Re: [PR] [MNG-7811] improve plugin validation documentation [maven-site]

2023-10-09 Thread via GitHub
cstamas commented on code in PR #461: URL: https://github.com/apache/maven-site/pull/461#discussion_r1350042054 ## content/markdown/guides/plugins/validation/index.md: ## @@ -19,56 +19,65 @@ specific language governing permissions and limitations under the License. --> -Mave

[jira] [Commented] (MNG-7811) Plugins verification - reports are inconsistent

2023-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773147#comment-17773147 ] ASF GitHub Bot commented on MNG-7811: - michael-o commented on code in PR #461: URL: htt

Re: [PR] [MNG-7811] improve plugin validation documentation [maven-site]

2023-10-09 Thread via GitHub
michael-o commented on code in PR #461: URL: https://github.com/apache/maven-site/pull/461#discussion_r1349926976 ## content/markdown/guides/plugins/validation/index.md: ## @@ -19,56 +19,65 @@ specific language governing permissions and limitations under the License. --> -Ma