[jira] [Commented] (MASSEMBLY-843) finalName as readonly parameter makes common usecases very complicated

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717466#comment-17717466 ] ASF GitHub Bot commented on MASSEMBLY-843: -- slawekjaranowski opened a new pul

[GitHub] [maven-assembly-plugin] slawekjaranowski opened a new pull request, #139: [MASSEMBLY-843] Make finalName parameter as writable

2023-04-27 Thread via GitHub
slawekjaranowski opened a new pull request, #139: URL: https://github.com/apache/maven-assembly-plugin/pull/139 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MASS

[GitHub] [maven-parent] dependabot[bot] opened a new pull request, #121: Bump maven-checkstyle-plugin from 3.2.1 to 3.2.2

2023-04-27 Thread via GitHub
dependabot[bot] opened a new pull request, #121: URL: https://github.com/apache/maven-parent/pull/121 Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.2.1 to 3.2.2. Commits https://github.com/apache/maven-checkstyle-plugin/commit/d75705

[GitHub] [maven-build-cache-extension] dependabot[bot] commented on pull request #77: Bump junit-jupiter-engine from 5.9.2 to 5.9.3

2023-04-27 Thread via GitHub
dependabot[bot] commented on PR #77: URL: https://github.com/apache/maven-build-cache-extension/pull/77#issuecomment-1526961889 Looks like this PR is closed. If you re-open it I'll rebase it as long as no-one else has edited it (you can use `@dependabot reopen` if the branch has been delet

[GitHub] [maven-build-cache-extension] dependabot[bot] closed pull request #77: Bump junit-jupiter-engine from 5.9.2 to 5.9.3

2023-04-27 Thread via GitHub
dependabot[bot] closed pull request #77: Bump junit-jupiter-engine from 5.9.2 to 5.9.3 URL: https://github.com/apache/maven-build-cache-extension/pull/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-build-cache-extension] olamy commented on pull request #77: Bump junit-jupiter-engine from 5.9.2 to 5.9.3

2023-04-27 Thread via GitHub
olamy commented on PR #77: URL: https://github.com/apache/maven-build-cache-extension/pull/77#issuecomment-1526961858 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [maven-build-cache-extension] dependabot[bot] commented on pull request #77: Bump junit-jupiter-engine from 5.9.2 to 5.9.3

2023-04-27 Thread via GitHub
dependabot[bot] commented on PR #77: URL: https://github.com/apache/maven-build-cache-extension/pull/77#issuecomment-1526961826 Looks like org.junit.jupiter:junit-jupiter-engine is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. T

[GitHub] [maven-build-cache-extension] olamy merged pull request #78: use junit bom

2023-04-27 Thread via GitHub
olamy merged PR #78: URL: https://github.com/apache/maven-build-cache-extension/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [maven-build-cache-extension] olamy opened a new pull request, #78: use junit bom

2023-04-27 Thread via GitHub
olamy opened a new pull request, #78: URL: https://github.com/apache/maven-build-cache-extension/pull/78 Signed-off-by: Olivier Lamy Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [MBUILDCACHE JIRA issue](h

[GitHub] [maven-build-cache-extension] olamy commented on pull request #77: Bump junit-jupiter-engine from 5.9.2 to 5.9.3

2023-04-27 Thread via GitHub
olamy commented on PR #77: URL: https://github.com/apache/maven-build-cache-extension/pull/77#issuecomment-1526940700 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [maven-build-cache-extension] dependabot[bot] merged pull request #76: Bump junit-jupiter-params from 5.9.2 to 5.9.3

2023-04-27 Thread via GitHub
dependabot[bot] merged PR #76: URL: https://github.com/apache/maven-build-cache-extension/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

[jira] [Commented] (MBUILDCACHE-56) NPE with mojo parameters not declared as fields (prevent any saving of cache)

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717452#comment-17717452 ] ASF GitHub Bot commented on MBUILDCACHE-56: --- olamy commented on code in PR

[GitHub] [maven-build-cache-extension] olamy commented on a diff in pull request #73: [MBUILDCACHE-56] fix NPE when mojo does not a have field with same name as parameter

2023-04-27 Thread via GitHub
olamy commented on code in PR #73: URL: https://github.com/apache/maven-build-cache-extension/pull/73#discussion_r1179898215 ## src/test/projects/mbuildcache-56-mojo-parameter-as-method/.mvn/maven-build-cache-config.xml: ## @@ -0,0 +1,69 @@ + + + + +http://maven.apache.org/BUIL

[jira] [Closed] (MDEP-859) Code refactor - UnpackUtil

2023-04-27 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MDEP-859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MDEP-859. Fix Version/s: 3.5.1 Resolution: Fixed > Code refactor - UnpackUtil >

[jira] [Commented] (MDEP-859) Code refactor - UnpackUtil

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MDEP-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717366#comment-17717366 ] ASF GitHub Bot commented on MDEP-859: - slawekjaranowski merged PR #309: URL: https://gi

[GitHub] [maven-dependency-plugin] slawekjaranowski merged pull request #309: [MDEP-859] Code refactor - UnpackUtil

2023-04-27 Thread via GitHub
slawekjaranowski merged PR #309: URL: https://github.com/apache/maven-dependency-plugin/pull/309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [maven-site-plugin] michael-o closed pull request #147: super trivial change to see if the CI is fixed

2023-04-27 Thread via GitHub
michael-o closed pull request #147: super trivial change to see if the CI is fixed URL: https://github.com/apache/maven-site-plugin/pull/147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [maven-site-plugin] michael-o commented on pull request #147: super trivial change to see if the CI is fixed

2023-04-27 Thread via GitHub
michael-o commented on PR #147: URL: https://github.com/apache/maven-site-plugin/pull/147#issuecomment-1526246288 This can be closed now... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Commented] (MSITE-964) Fix failure of 'site-jar' IT on Java 17

2023-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717356#comment-17717356 ] Michael Osipov commented on MSITE-964: -- Problem solved. BeanShell has a JPMS issue, G

[jira] [Commented] (MSITE-873) Mark SiteMojo and SiteJarMojo thread-safe

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717353#comment-17717353 ] ASF GitHub Bot commented on MSITE-873: -- michael-o commented on PR #149: URL: https:/

[GitHub] [maven-site-plugin] michael-o commented on pull request #149: [MSITE-873] Mark SiteMojo and SiteJarMojo thread-safe

2023-04-27 Thread via GitHub
michael-o commented on PR #149: URL: https://github.com/apache/maven-site-plugin/pull/149#issuecomment-1526235447 > Bleah. That's going to be a tough one to fix then. Nope, turned out what I assumed. The code is fine, but BeanShell is the problem. See #150. -- This is an automated

[jira] [Commented] (MSITE-964) Fix failure of 'site-jar' IT on Java 17

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSITE-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717351#comment-17717351 ] ASF GitHub Bot commented on MSITE-964: -- michael-o opened a new pull request, #150: UR

[GitHub] [maven-site-plugin] michael-o opened a new pull request, #150: [MSITE-964] Fix failure of 'site-jar' IT on Java 17

2023-04-27 Thread via GitHub
michael-o opened a new pull request, #150: URL: https://github.com/apache/maven-site-plugin/pull/150 This closes #150 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jir

[jira] [Commented] (MSITE-964) Fix failure of 'site-jar' IT on Java 17

2023-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717345#comment-17717345 ] Michael Osipov commented on MSITE-964: -- [~rfscholte], can you tell from your experien

[jira] [Commented] (MSITE-873) Mark SiteMojo and SiteJarMojo thread-safe

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717323#comment-17717323 ] ASF GitHub Bot commented on MSITE-873: -- michael-o commented on PR #149: URL: https:/

[GitHub] [maven-site-plugin] michael-o commented on pull request #149: [MSITE-873] Mark SiteMojo and SiteJarMojo thread-safe

2023-04-27 Thread via GitHub
michael-o commented on PR #149: URL: https://github.com/apache/maven-site-plugin/pull/149#issuecomment-1526114647 > Is this supposed to fix the JPMS issue? No, unrelated. I think the JPMS issue is related to BeanShell. -- This is an automated message from the Apache Git Service. To

[GitHub] [maven-mvnd] adamretter commented on issue #772: Timeout when connecting maven daemon

2023-04-27 Thread via GitHub
adamretter commented on issue #772: URL: https://github.com/apache/maven-mvnd/issues/772#issuecomment-1526101127 @gnodet Sorry to ask again, but any further insight you could provide on this would be very helpful... -- This is an automated message from the Apache Git Service. To respond t

[jira] [Commented] (MGPG-97) add pgpverify check to the build

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MGPG-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717319#comment-17717319 ] ASF GitHub Bot commented on MGPG-97: slawekjaranowski commented on code in PR #48: URL:

[GitHub] [maven-gpg-plugin] slawekjaranowski commented on a diff in pull request #48: [MGPG-97] use pgpverify plugin to check dependencies signatures

2023-04-27 Thread via GitHub
slawekjaranowski commented on code in PR #48: URL: https://github.com/apache/maven-gpg-plugin/pull/48#discussion_r1179503624 ## pom.xml: ## @@ -194,6 +194,14 @@ under the License. maven-invoker-plugin 3.5.1 + + org.simplify4u.plug

[jira] [Commented] (MSITE-873) Mark SiteMojo and SiteJarMojo thread-safe

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717282#comment-17717282 ] ASF GitHub Bot commented on MSITE-873: -- michael-o opened a new pull request, #149: UR

[GitHub] [maven-site-plugin] michael-o opened a new pull request, #149: [MSITE-873] Mark SiteMojo and SiteJarMojo thread-safe

2023-04-27 Thread via GitHub
michael-o opened a new pull request, #149: URL: https://github.com/apache/maven-site-plugin/pull/149 Both mojos operate on individual modules and do not share any state. This closes #149 Following this checklist to help us incorporate your contribution quickly and easily:

[jira] [Updated] (MSITE-873) Mark SiteMojo and SiteJarMojo thread-safe

2023-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSITE-873: - Summary: Mark SiteMojo and SiteJarMojo thread-safe (was: The following plugins are not marked @th

[jira] [Comment Edited] (MSITE-873) The following plugins are not marked @threadSafe in org.apache.maven.plugins:maven-site-plugin:3.9.1

2023-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716924#comment-17716924 ] Michael Osipov edited comment on MSITE-873 at 4/27/23 3:55 PM: -

[jira] [Created] (MSITE-964) Fix failure of 'site-jar' IT on Java 17

2023-04-27 Thread Michael Osipov (Jira)
Michael Osipov created MSITE-964: Summary: Fix failure of 'site-jar' IT on Java 17 Key: MSITE-964 URL: https://issues.apache.org/jira/browse/MSITE-964 Project: Maven Site Plugin Issue Type: S

[jira] [Commented] (MSITE-960) CI is broken

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSITE-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717279#comment-17717279 ] ASF GitHub Bot commented on MSITE-960: -- asfgit merged PR #148: URL: https://github.co

[jira] [Updated] (MSITE-960) CI is broken

2023-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSITE-960: - Fix Version/s: (was: 4.0.0-M8) > CI is broken > > > Key: MSITE-96

[jira] [Closed] (MSITE-963) Delete broken site descriptor files from local repository

2023-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSITE-963. Resolution: Fixed Fixed with [d452e4befc21c79b12c1277beab975418bca6bc8|https://gitbox.apache.org/re

[GitHub] [maven-site-plugin] asfgit merged pull request #148: [MSITE-960] +[MSITE-961]

2023-04-27 Thread via GitHub
asfgit merged PR #148: URL: https://github.com/apache/maven-site-plugin/pull/148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mave

[jira] [Closed] (MSITE-961) Separate Fluido Skin version between site generation and testing/development

2023-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSITE-961. Resolution: Done Fixed with [ab07cd2ce6f22a40350f7b964c2fc0466591|https://gitbox.apache.org/rep

[jira] [Created] (MSITE-963) Delete broken site descriptor files from local repository

2023-04-27 Thread Michael Osipov (Jira)
Michael Osipov created MSITE-963: Summary: Delete broken site descriptor files from local repository Key: MSITE-963 URL: https://issues.apache.org/jira/browse/MSITE-963 Project: Maven Site Plugin

[jira] [Updated] (MSITE-961) Separate Fluido Skin version between site generation and testing/development

2023-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSITE-961: - Parent: MSITE-960 Issue Type: Sub-task (was: Task) > Separate Fluido Skin version between

[jira] [Updated] (MSITE-961) Separate Fluido Skin version between site generation and testing/development

2023-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSITE-961: - Fix Version/s: (was: 4.0.0-M8) > Separate Fluido Skin version between site generation and test

[jira] [Commented] (MNG-7706) Deprecate ${localRepository} mojo parameter expression

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717275#comment-17717275 ] ASF GitHub Bot commented on MNG-7706: - basil commented on PR #1012: URL: https://github

[GitHub] [maven] basil commented on pull request #1012: [MNG-7706] Deprecate 'localRepository' parameter expression (#1009)

2023-04-27 Thread via GitHub
basil commented on PR #1012: URL: https://github.com/apache/maven/pull/1012#issuecomment-1525919109 This migration was poorly documented. What you asked me to do had nothing to do with the instructions in the deprecation warning. I think it was appropriate to complain about that in this PR.

[jira] [Commented] (MNG-7706) Deprecate ${localRepository} mojo parameter expression

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717274#comment-17717274 ] ASF GitHub Bot commented on MNG-7706: - cstamas commented on PR #1012: URL: https://gith

[GitHub] [maven] cstamas commented on pull request #1012: [MNG-7706] Deprecate 'localRepository' parameter expression (#1009)

2023-04-27 Thread via GitHub
cstamas commented on PR #1012: URL: https://github.com/apache/maven/pull/1012#issuecomment-1525916444 Just for future: please use ML for asks like this one :) https://maven.apache.org/mailing-lists.html -- This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Commented] (MNG-7706) Deprecate ${localRepository} mojo parameter expression

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717273#comment-17717273 ] ASF GitHub Bot commented on MNG-7706: - cstamas commented on PR #1012: URL: https://gith

[GitHub] [maven] cstamas commented on pull request #1012: [MNG-7706] Deprecate 'localRepository' parameter expression (#1009)

2023-04-27 Thread via GitHub
cstamas commented on PR #1012: URL: https://github.com/apache/maven/pull/1012#issuecomment-1525915360 Yup, setRepositorySession... if you are sure it is there, then not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Commented] (MNG-7706) Deprecate ${localRepository} mojo parameter expression

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717271#comment-17717271 ] ASF GitHub Bot commented on MNG-7706: - basil commented on PR #1012: URL: https://github

[GitHub] [maven] basil commented on pull request #1012: [MNG-7706] Deprecate 'localRepository' parameter expression (#1009)

2023-04-27 Thread via GitHub
basil commented on PR #1012: URL: https://github.com/apache/maven/pull/1012#issuecomment-1525911551 > on `ProjectBuildingRequest` `setSession` from 2 The `setSession` method does not exist, but a `setRepositorySession` exists. But why should I call that when `session.getProjectBuildin

[jira] [Commented] (MSITE-960) CI is broken

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSITE-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717270#comment-17717270 ] ASF GitHub Bot commented on MSITE-960: -- michael-o commented on PR #148: URL: https:/

[jira] [Assigned] (MGPG-97) add pgpverify check to the build

2023-04-27 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MGPG-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy reassigned MGPG-97: - Assignee: Herve Boutemy > add pgpverify check to the build > > >

[GitHub] [maven-site-plugin] michael-o commented on pull request #148: [MSITE-960] +[MSITE-961]

2023-04-27 Thread via GitHub
michael-o commented on PR #148: URL: https://github.com/apache/maven-site-plugin/pull/148#issuecomment-1525905338 @elharo Is this acceptable for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (MBUILDCACHE-56) NPE with mojo parameters not declared as fields (prevent any saving of cache)

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717269#comment-17717269 ] ASF GitHub Bot commented on MBUILDCACHE-56: --- maximilian-novikov-db commente

[GitHub] [maven-build-cache-extension] maximilian-novikov-db commented on a diff in pull request #73: [MBUILDCACHE-56] fix NPE when mojo does not a have field with same name as parameter

2023-04-27 Thread via GitHub
maximilian-novikov-db commented on code in PR #73: URL: https://github.com/apache/maven-build-cache-extension/pull/73#discussion_r1179331432 ## src/test/projects/mbuildcache-56-mojo-parameter-as-method/.mvn/maven-build-cache-config.xml: ## @@ -0,0 +1,69 @@ + + + + +http://maven

[jira] [Commented] (MNG-7706) Deprecate ${localRepository} mojo parameter expression

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717266#comment-17717266 ] ASF GitHub Bot commented on MNG-7706: - cstamas commented on PR #1012: URL: https://gith

[GitHub] [maven] cstamas commented on pull request #1012: [MNG-7706] Deprecate 'localRepository' parameter expression (#1009)

2023-04-27 Thread via GitHub
cstamas commented on PR #1012: URL: https://github.com/apache/maven/pull/1012#issuecomment-1525882346 1. drop `localRepository`, remove `buildingRequest.setLocalRepository(localRepository);` 2. instead grab RepositorySystemSession "${repositorySystemSession}" 3. on ProjectBuildingReq

[jira] [Closed] (MNGSITE-517) "Maven before 3.8.8" table under /docs/history.html not rendering correctly

2023-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNGSITE-517. -- Assignee: Olivier Lamy Resolution: Fixed > "Maven before 3.8.8" table under /docs/histor

[jira] [Commented] (MNG-7706) Deprecate ${localRepository} mojo parameter expression

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717253#comment-17717253 ] ASF GitHub Bot commented on MNG-7706: - basil commented on PR #1012: URL: https://github

[GitHub] [maven] basil commented on pull request #1012: [MNG-7706] Deprecate 'localRepository' parameter expression (#1009)

2023-04-27 Thread via GitHub
basil commented on PR #1012: URL: https://github.com/apache/maven/pull/1012#issuecomment-1525828731 How should https://github.com/cloudbees/maven-license-plugin/blob/b58872cc1f4062ec01ca903d9a5546cc3b85a748/src/main/java/com/cloudbees/maven/license/ProcessMojo.java#L179 be adapted? The depr

[jira] [Commented] (MNG-5659) Project specific settings.xml

2023-04-27 Thread Nils Breunese (Jira)
[ https://issues.apache.org/jira/browse/MNG-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717234#comment-17717234 ] Nils Breunese commented on MNG-5659: [~delany] I would prefer for all projects, both in

[jira] [Commented] (MPOM-263) Enforce building with Java 8+

2023-04-27 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MPOM-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717177#comment-17717177 ] Tamas Cservenak commented on MPOM-263: -- Obviously this is not enough. Someone can stil

[jira] [Closed] (MENFORCER-478) Investigate if is it possible to exclude obviously obsolete versions

2023-04-27 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MENFORCER-478. - Resolution: Not A Problem Plugin is already able to perform such a check, no action ne

[jira] [Commented] (MENFORCER-478) Investigate if is it possible to exclude obviously obsolete versions

2023-04-27 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717175#comment-17717175 ] Tamas Cservenak commented on MENFORCER-478: --- Then next is to set these in Ma

[jira] [Commented] (MENFORCER-478) Investigate if is it possible to exclude obviously obsolete versions

2023-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717174#comment-17717174 ] Michael Osipov commented on MENFORCER-478: -- [~sjaranowski], very nice. > Inv

[jira] [Commented] (MENFORCER-478) Investigate if is it possible to exclude obviously obsolete versions

2023-04-27 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717139#comment-17717139 ] Slawomir Jaranowski commented on MENFORCER-478: --- There are from logs: {n

[jira] [Commented] (MSITE-960) CI is broken

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSITE-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717138#comment-17717138 ] ASF GitHub Bot commented on MSITE-960: -- michael-o commented on PR #148: URL: https:/

[GitHub] [maven-site-plugin] michael-o commented on pull request #148: [MSITE-960] +[MSITE-961]

2023-04-27 Thread via GitHub
michael-o commented on PR #148: URL: https://github.com/apache/maven-site-plugin/pull/148#issuecomment-1525543988 > There's a test failure on JDK 17 that might or might not be related: > > Sourced file: inline evaluation of: `/* * Licensed to the Apache Software Foundation (ASF) unde

[jira] [Updated] (MENFORCER-478) Investigate if is it possible to exclude obviously obsolete versions

2023-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MENFORCER-478: - Summary: Investigate if is it possible to exclude obviously obsolete versions (was: I

[jira] [Commented] (MNGSITE-517) "Maven before 3.8.8" table under /docs/history.html not rendering correctly

2023-04-27 Thread Shaddy Baddah (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717122#comment-17717122 ] Shaddy Baddah commented on MNGSITE-517: --- Looks great. Thank you very much all :)

[jira] [Commented] (MSITE-960) CI is broken

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSITE-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717115#comment-17717115 ] ASF GitHub Bot commented on MSITE-960: -- elharo commented on PR #148: URL: https://gi

[GitHub] [maven-site-plugin] elharo commented on pull request #148: [MSITE-960] +[MSITE-961]

2023-04-27 Thread via GitHub
elharo commented on PR #148: URL: https://github.com/apache/maven-site-plugin/pull/148#issuecomment-1525468715 There's a test failure on JDK 17 that might or might not be related: Sourced file: inline evaluation of: `` /* * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Created] (MENFORCER-478) Investigate is it possible to exclude obviously obsolete versions

2023-04-27 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MENFORCER-478: - Summary: Investigate is it possible to exclude obviously obsolete versions Key: MENFORCER-478 URL: https://issues.apache.org/jira/browse/MENFORCER-478 Proje

[jira] [Commented] (MSITE-960) CI is broken

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSITE-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717089#comment-17717089 ] ASF GitHub Bot commented on MSITE-960: -- michael-o commented on PR #148: URL: https:/

[GitHub] [maven-site-plugin] michael-o commented on pull request #148: [MSITE-960] +[MSITE-961]

2023-04-27 Thread via GitHub
michael-o commented on PR #148: URL: https://github.com/apache/maven-site-plugin/pull/148#issuecomment-1525298871 @elharo Please have a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (MGPG-97) add pgpverify check to the build

2023-04-27 Thread Herve Boutemy (Jira)
Herve Boutemy created MGPG-97: - Summary: add pgpverify check to the build Key: MGPG-97 URL: https://issues.apache.org/jira/browse/MGPG-97 Project: Maven GPG Plugin Issue Type: Improvement Aff

[jira] [Commented] (MGPG-96) add INFO message when signing

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MGPG-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717027#comment-17717027 ] ASF GitHub Bot commented on MGPG-96: hboutemy opened a new pull request, #47: URL: https

[GitHub] [maven-gpg-plugin] hboutemy opened a new pull request, #47: [MGPG-96] add INFO message

2023-04-27 Thread via GitHub
hboutemy opened a new pull request, #47: URL: https://github.com/apache/maven-gpg-plugin/pull/47 adding message: ``` [INFO] --- gpg:3.1.0-SNAPSHOT:sign (default-cli) @ maven-gpg-plugin --- [INFO] Signing 5 files with default secret key. ``` -- This is an automated message from

[jira] [Commented] (MGPG-96) add INFO message when signing

2023-04-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MGPG-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717026#comment-17717026 ] Michael Osipov commented on MGPG-96: Sounds reasonable... > add INFO message when signi

[jira] [Commented] (MNG-7639) Prepare a unit test for DefaultRepositorySystemSessionFactory#newRepositorySession

2023-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717023#comment-17717023 ] ASF GitHub Bot commented on MNG-7639: - CrazyHZM opened a new pull request, #1096: URL:

[GitHub] [maven] CrazyHZM opened a new pull request, #1096: [MNG-7639] Add unit test for DefaultRepositorySystemSessionFactory#newRepositorySession

2023-04-27 Thread via GitHub
CrazyHZM opened a new pull request, #1096: URL: https://github.com/apache/maven/pull/1096 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for th