[jira] [Commented] (MNG-7628) help:all-profiles doesn't work if there are any profiles in setting.xml

2022-12-13 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646983#comment-17646983 ] Michael Osipov commented on MNG-7628: - [~gnodet], [~cstamas], please have a look. > he

[jira] [Commented] (MNG-7627) Maven release plugin doesn't upload artifacts to maven central

2022-12-13 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646982#comment-17646982 ] Michael Osipov commented on MNG-7627: - There are two problems here: * You cannot direct

[jira] [Commented] (MNG-7627) Maven release plugin doesn't upload artifacts to maven central

2022-12-13 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646974#comment-17646974 ] Slawomir Jaranowski commented on MNG-7627: -- For nexus-staging-plugin you should re

[jira] [Updated] (MPOM-386) update documentation for previous changes

2022-12-13 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MPOM-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MPOM-386: --- Description: a few updates done in past releases were not updated in the documentation https://maven.a

[GitHub] [maven-apache-parent] hboutemy opened a new pull request, #121: [MPOM-386] update documentation to match previous changes in pom.xml

2022-12-13 Thread GitBox
hboutemy opened a new pull request, #121: URL: https://github.com/apache/maven-apache-parent/pull/121 https://issues.apache.org/jira/browse/MPOM-386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Created] (MPOM-386) update documentation for previous changes

2022-12-13 Thread Herve Boutemy (Jira)
Herve Boutemy created MPOM-386: -- Summary: update documentation for previous changes Key: MPOM-386 URL: https://issues.apache.org/jira/browse/MPOM-386 Project: Maven POMs Issue Type: Bug

[jira] [Updated] (MNG-7627) Maven release plugin doesn't upload artifacts to maven central

2022-12-13 Thread Lenny Primak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lenny Primak updated MNG-7627: -- Priority: Minor (was: Blocker) > Maven release plugin doesn't upload artifacts to maven central > --

[jira] [Commented] (MNG-7627) Maven release plugin doesn't upload artifacts to maven central

2022-12-13 Thread Lenny Primak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646892#comment-17646892 ] Lenny Primak commented on MNG-7627: --- It looks like that nexus-staging-maven-plugin has so

[jira] [Commented] (MNG-7627) Maven release plugin doesn't upload artifacts to maven central

2022-12-13 Thread Lenny Primak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646893#comment-17646893 ] Lenny Primak commented on MNG-7627: --- I have bumped down the priority to minor since there

[jira] [Created] (MNG-7628) help:all-profiles doesn't work if there are any profiles in setting.xml

2022-12-13 Thread Lenny Primak (Jira)
Lenny Primak created MNG-7628: - Summary: help:all-profiles doesn't work if there are any profiles in setting.xml Key: MNG-7628 URL: https://issues.apache.org/jira/browse/MNG-7628 Project: Maven

[jira] [Commented] (MNG-7627) Maven release plugin doesn't upload artifacts to maven central

2022-12-13 Thread Lenny Primak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646884#comment-17646884 ] Lenny Primak commented on MNG-7627: --- Yes, snapshots deploy fine with Maven 4. There are

[jira] [Commented] (MNG-7627) Maven release plugin doesn't upload artifacts to maven central

2022-12-13 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646878#comment-17646878 ] Slawomir Jaranowski commented on MNG-7627: -- Can you deploy your project in snapsho

[jira] [Created] (MNG-7627) Maven release plugin doesn't upload artifacts to maven central

2022-12-13 Thread Lenny Primak (Jira)
Lenny Primak created MNG-7627: - Summary: Maven release plugin doesn't upload artifacts to maven central Key: MNG-7627 URL: https://issues.apache.org/jira/browse/MNG-7627 Project: Maven Issue Typ

[jira] [Closed] (MINSTALL-186) install-file fails when the file belongs to the local repository and using a localRepositoryPath

2022-12-13 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MINSTALL-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MINSTALL-186. Fix Version/s: next-release Resolution: Fixed > install-file fails when th

[jira] [Assigned] (MINSTALL-186) install-file fails when the file belongs to the local repository and using a localRepositoryPath

2022-12-13 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MINSTALL-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MINSTALL-186: Assignee: Slawomir Jaranowski > install-file fails when the file belongs

[GitHub] [maven-install-plugin] slawekjaranowski merged pull request #49: [MINSTALL-186] Use proper repositorySystemSession

2022-12-13 Thread GitBox
slawekjaranowski merged PR #49: URL: https://github.com/apache/maven-install-plugin/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [maven-mvnd] gnodet merged pull request #721: Fixup #716 Calculate java home from java command

2022-12-13 Thread GitBox
gnodet merged PR #721: URL: https://github.com/apache/maven-mvnd/pull/721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach

[jira] [Closed] (MENFORCER-441) Bump maven-common-artifact-filters from 3.2.0 to 3.3.2

2022-12-13 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-441. - Resolution: Fixed > Bump maven-common-artifact-filters from 3.2.0 to 3.3.2 > -

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #185: [MENFORCER-441] Bump maven-common-artifact-filters from 3.2.0 to 3.3.2

2022-12-13 Thread GitBox
slawekjaranowski merged PR #185: URL: https://github.com/apache/maven-enforcer/pull/185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Created] (MENFORCER-441) Bump maven-common-artifact-filters from 3.2.0 to 3.3.2

2022-12-13 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MENFORCER-441: - Summary: Bump maven-common-artifact-filters from 3.2.0 to 3.3.2 Key: MENFORCER-441 URL: https://issues.apache.org/jira/browse/MENFORCER-441 Project:

[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #195: [MENFORCER-440] Allow 8 as JDK version for requireJavaVersion

2022-12-13 Thread GitBox
slawekjaranowski opened a new pull request, #195: URL: https://github.com/apache/maven-enforcer/pull/195 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER)

[jira] [Commented] (MNG-7563) User properties now override model properties in dependencies

2022-12-13 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646857#comment-17646857 ] Hervé Guillemet commented on MNG-7563: -- I'm not familiar enough with maven internals t

[jira] [Comment Edited] (MNG-7563) User properties now override model properties in dependencies

2022-12-13 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646830#comment-17646830 ] Michael Osipov edited comment on MNG-7563 at 12/13/22 10:59 PM: -

[GitHub] [maven-mvnd] gnodet merged pull request #581: Support redirecting input from client to daemon, #541

2022-12-13 Thread GitBox
gnodet merged PR #581: URL: https://github.com/apache/maven-mvnd/pull/581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach

[GitHub] [maven-mvnd] gnodet merged pull request #748: Display plugin's goal prefix and version instead of artifactId

2022-12-13 Thread GitBox
gnodet merged PR #748: URL: https://github.com/apache/maven-mvnd/pull/748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach

[GitHub] [maven-mvnd] gnodet merged pull request #730: Build mostly static native image, loose linux glibc requirement to 2.12

2022-12-13 Thread GitBox
gnodet merged PR #730: URL: https://github.com/apache/maven-mvnd/pull/730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach

[GitHub] [maven-site] slawekjaranowski merged pull request #351: Using an SPDX identifier as the license name in example

2022-12-13 Thread GitBox
slawekjaranowski merged PR #351: URL: https://github.com/apache/maven-site/pull/351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

[GitHub] [maven-mvnd] gnodet merged pull request #750: Clean up some warnings during the build

2022-12-13 Thread GitBox
gnodet merged PR #750: URL: https://github.com/apache/maven-mvnd/pull/750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach

[jira] [Assigned] (MENFORCER-440) Allow 8 as JDK version for requireJavaVersion

2022-12-13 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MENFORCER-440: - Assignee: Slawomir Jaranowski > Allow 8 as JDK version for requireJav

[jira] [Commented] (MNG-7563) User properties now override model properties in dependencies

2022-12-13 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646830#comment-17646830 ] Michael Osipov commented on MNG-7563: - I need to revert my previous statement: {{MAVEN_

[GitHub] [maven-site] michael-o commented on pull request #351: Using an SPDX identifier as the license name in example

2022-12-13 Thread GitBox
michael-o commented on PR #351: URL: https://github.com/apache/maven-site/pull/351#issuecomment-1349775831 > For me id is more useful than an arbitrary label. Therefore I think we should stick to using an id in the name element (although the naming of the element is unfortunate) Real

[GitHub] [maven-site] kwin commented on pull request #351: Using an SPDX identifier as the license name in example

2022-12-13 Thread GitBox
kwin commented on PR #351: URL: https://github.com/apache/maven-site/pull/351#issuecomment-1349743139 For me id is more useful than an arbitrary label. Therefore I think we should stick to using an id in the name element (although the naming of the element is unfortunate) -- This is an a

[jira] [Comment Edited] (MNG-7563) User properties now override model properties in dependencies

2022-12-13 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645645#comment-17645645 ] Michael Osipov edited comment on MNG-7563 at 12/13/22 9:22 PM: --

[jira] [Commented] (MNG-7621) Parameter '-f' causes ignoring any 'maven.config' (only on Windows)

2022-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646821#comment-17646821 ] ASF GitHub Bot commented on MNG-7621: - michael-o commented on PR #905: URL: https://git

[GitHub] [maven] michael-o commented on pull request #905: [MNG-7621] Parameter '-f' causes ignoring any 'maven.config' (only on…

2022-12-13 Thread GitBox
michael-o commented on PR #905: URL: https://github.com/apache/maven/pull/905#issuecomment-1349699974 Anyone else wants to review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Closed] (MNG-7597) Infinite loop in PropertiesAsMap

2022-12-13 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-7597. --- > Infinite loop in PropertiesAsMap > > > Key: MNG-7597 >

[jira] [Closed] (MNG-7609) Clarify documentation of extension descriptor

2022-12-13 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-7609. --- > Clarify documentation of extension descriptor > - > >

[jira] [Closed] (MNG-7611) java.lang.IllegalStateException: Required Java version 1.8 is not met by current version: 17.0.5

2022-12-13 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-7611. --- > java.lang.IllegalStateException: Required Java version 1.8 is not met by > current version: 17.0.5 > ---

[jira] [Closed] (MNG-7566) Allow a Maven plugin to require a Java version through its plugin descriptor

2022-12-13 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-7566. --- > Allow a Maven plugin to require a Java version through its plugin descriptor > --

[GitHub] [maven-compiler-plugin] olamy commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
olamy commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1349673838 > > If we ignore the figures right - highly depends your build, tomee container/openejb-core module for ex, it is 14s -> 4s (1 module so if you do the math you almost save 1h f

[jira] [Closed] (MINVOKER-316) Refresh plugins versions in IT tests

2022-12-13 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MINVOKER-316. Fix Version/s: 3.4.0 Resolution: Fixed > Refresh plugins versions in IT te

[GitHub] [maven-invoker-plugin] slawekjaranowski merged pull request #156: [MINVOKER-316] Refresh plugins versions in IT tests

2022-12-13 Thread GitBox
slawekjaranowski merged PR #156: URL: https://github.com/apache/maven-invoker-plugin/pull/156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[GitHub] [maven-shared-utils] dependabot[bot] closed pull request #126: Bump slf4j-api from 1.7.36 to 2.0.5

2022-12-13 Thread GitBox
dependabot[bot] closed pull request #126: Bump slf4j-api from 1.7.36 to 2.0.5 URL: https://github.com/apache/maven-shared-utils/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [maven-shared-utils] dependabot[bot] commented on pull request #126: Bump slf4j-api from 1.7.36 to 2.0.5

2022-12-13 Thread GitBox
dependabot[bot] commented on PR #126: URL: https://github.com/apache/maven-shared-utils/pull/126#issuecomment-1349539063 Superseded by #128. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven-shared-utils] dependabot[bot] opened a new pull request, #128: Bump slf4j-api from 1.7.36 to 2.0.6

2022-12-13 Thread GitBox
dependabot[bot] opened a new pull request, #128: URL: https://github.com/apache/maven-shared-utils/pull/128 Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 1.7.36 to 2.0.6. Commits https://github.com/qos-ch/slf4j/commit/5ff6f2c385c36ea4f8b85cacd69f7ca891c37818";>5ff6f2c

[GitHub] [maven-filtering] dependabot[bot] commented on pull request #58: Bump slf4jVersion from 1.7.36 to 2.0.5

2022-12-13 Thread GitBox
dependabot[bot] commented on PR #58: URL: https://github.com/apache/maven-filtering/pull/58#issuecomment-1349076652 Superseded by #59. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-filtering] dependabot[bot] closed pull request #58: Bump slf4jVersion from 1.7.36 to 2.0.5

2022-12-13 Thread GitBox
dependabot[bot] closed pull request #58: Bump slf4jVersion from 1.7.36 to 2.0.5 URL: https://github.com/apache/maven-filtering/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [maven-filtering] dependabot[bot] opened a new pull request, #59: Bump slf4jVersion from 1.7.36 to 2.0.6

2022-12-13 Thread GitBox
dependabot[bot] opened a new pull request, #59: URL: https://github.com/apache/maven-filtering/pull/59 Bumps `slf4jVersion` from 1.7.36 to 2.0.6. Updates `slf4j-api` from 1.7.36 to 2.0.6 Commits https://github.com/qos-ch/slf4j/commit/5ff6f2c385c36ea4f8b85cacd69f7ca891c37818";

[jira] [Commented] (MNG-7626) maven-bom should have the same parent version as project

2022-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646742#comment-17646742 ] ASF GitHub Bot commented on MNG-7626: - slawekjaranowski opened a new pull request, #910

[GitHub] [maven] slawekjaranowski opened a new pull request, #910: [MNG-7626] maven-bom should have the same parent version as project

2022-12-13 Thread GitBox
slawekjaranowski opened a new pull request, #910: URL: https://github.com/apache/maven/pull/910 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed

[GitHub] [maven-compiler-plugin] bmarwell commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
bmarwell commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1349073554 I agree with @rmannibucau here. It is very dependent of the examples and really changes your output. Let's keep the default behaviour, but maybe rename it. If I am not

[jira] [Created] (MBUILDCACHE-35) Incorrect pom is put to local repo for module with maven-shade-plugin

2022-12-13 Thread Maximilian Novikov (Jira)
Maximilian Novikov created MBUILDCACHE-35: - Summary: Incorrect pom is put to local repo for module with maven-shade-plugin Key: MBUILDCACHE-35 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-35

[jira] [Created] (MNG-7626) maven-bom should have the same parent version as project

2022-12-13 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MNG-7626: Summary: maven-bom should have the same parent version as project Key: MNG-7626 URL: https://issues.apache.org/jira/browse/MNG-7626 Project: Maven Is

[GitHub] [maven-compiler-plugin] rmannibucau commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
rmannibucau commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348932531 > that do not depend on each other, but I guess this cannot be called "majority", unless am mistaken. Depends how you build the multi-modules projects. Often you ha

[jira] [Commented] (MNG-7625) Restore compatibility with Maven 3 - SettingsUtils#merge

2022-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646713#comment-17646713 ] ASF GitHub Bot commented on MNG-7625: - slawekjaranowski commented on code in PR #909: U

[GitHub] [maven] slawekjaranowski commented on a diff in pull request #909: [MNG-7625] Restore compatibility with Maven 3 - SettingsUtils#merge

2022-12-13 Thread GitBox
slawekjaranowski commented on code in PR #909: URL: https://github.com/apache/maven/pull/909#discussion_r1047360970 ## maven-core/src/main/java/org/apache/maven/settings/SettingsUtils.java: ## @@ -51,6 +52,25 @@ public static Settings merge(Settings dominant, Settings recessive

[GitHub] [maven-invoker-plugin] dependabot[bot] commented on pull request #153: Bump maven-plugins from 37 to 38

2022-12-13 Thread GitBox
dependabot[bot] commented on PR #153: URL: https://github.com/apache/maven-invoker-plugin/pull/153#issuecomment-1348880323 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [maven-invoker-plugin] slachiewicz closed pull request #153: Bump maven-plugins from 37 to 38

2022-12-13 Thread GitBox
slachiewicz closed pull request #153: Bump maven-plugins from 37 to 38 URL: https://github.com/apache/maven-invoker-plugin/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Commented] (MNG-7625) Restore compatibility with Maven 3 - SettingsUtils#merge

2022-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646709#comment-17646709 ] ASF GitHub Bot commented on MNG-7625: - gnodet commented on code in PR #909: URL: https:

[GitHub] [maven] gnodet commented on a diff in pull request #909: [MNG-7625] Restore compatibility with Maven 3 - SettingsUtils#merge

2022-12-13 Thread GitBox
gnodet commented on code in PR #909: URL: https://github.com/apache/maven/pull/909#discussion_r1047350107 ## maven-core/src/main/java/org/apache/maven/settings/SettingsUtils.java: ## @@ -51,6 +52,25 @@ public static Settings merge(Settings dominant, Settings recessive, String r

[jira] [Commented] (MNG-7625) Restore compatibility with Maven 3 - SettingsUtils#merge

2022-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646706#comment-17646706 ] ASF GitHub Bot commented on MNG-7625: - gnodet commented on PR #909: URL: https://github

[GitHub] [maven] gnodet commented on pull request #909: [MNG-7625] Restore compatibility with Maven 3 - SettingsUtils#merge

2022-12-13 Thread GitBox
gnodet commented on PR #909: URL: https://github.com/apache/maven/pull/909#issuecomment-1348858555 Also related to https://github.com/apache/maven/pull/874, which contains a similar fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (MNG-7625) Restore compatibility with Maven 3 - SettingsUtils#merge

2022-12-13 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646703#comment-17646703 ] Slawomir Jaranowski commented on MNG-7625: -- [~gnodet]  I used {{org.apache.maven.

[jira] [Commented] (MNG-7625) Restore compatibility with Maven 3 - SettingsUtils#merge

2022-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646697#comment-17646697 ] ASF GitHub Bot commented on MNG-7625: - slawekjaranowski opened a new pull request, #909

[GitHub] [maven] slawekjaranowski opened a new pull request, #909: [MNG-7625] Restore compatibility with Maven 3 - SettingsUtils#merge

2022-12-13 Thread GitBox
slawekjaranowski opened a new pull request, #909: URL: https://github.com/apache/maven/pull/909 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed

[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature

2022-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646642#comment-17646642 ] ASF GitHub Bot commented on MNG-7622: - cstamas commented on code in PR #907: URL: https

[GitHub] [maven] cstamas commented on a diff in pull request #907: [MNG-7622] Maven Transformation and Consumer POM

2022-12-13 Thread GitBox
cstamas commented on code in PR #907: URL: https://github.com/apache/maven/pull/907#discussion_r1047185218 ## maven-core/src/main/java/org/apache/maven/internal/transformation/ArtifactTransformer.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [maven-compiler-plugin] slawekjaranowski commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
slawekjaranowski commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348588366 # Master commit 5be316391ea7c575ee65c3fe83b4c7b30e1174d0 ## Result 1 - next execution - rebuild is skipped ``` [INFO] Total time: 01:12 mi

[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348585346 > If we ignore the figures right - highly depends your build, tomee container/openejb-core module for ex, it is 14s -> 4s (1 module so if you do the math you almost save 1h f

[GitHub] [maven-compiler-plugin] rmannibucau commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
rmannibucau commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348539648 > "incremental" feature may bring 4 minute gain on 300 module build, unless If we ignore the figures right - highly depends your build, tomee container/openejb-core

[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature

2022-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646627#comment-17646627 ] ASF GitHub Bot commented on MNG-7622: - rfscholte commented on code in PR #907: URL: htt

[GitHub] [maven] rfscholte commented on a diff in pull request #907: [MNG-7622] Maven Transformation and Consumer POM

2022-12-13 Thread GitBox
rfscholte commented on code in PR #907: URL: https://github.com/apache/maven/pull/907#discussion_r1047135097 ## maven-core/src/main/java/org/apache/maven/internal/transformation/ArtifactTransformer.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348510150 Recap what we have so fat: * "incremental" feature may bring 4 minute gain on 300 module build, unless * there are inter-module dependencies, as in that case this feature

[GitHub] [maven-compiler-plugin] rmannibucau commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
rmannibucau commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348508155 > The I don't understand this: "17s for the first build, 10s for the second", isn't first the "full"? @cstamas the first is the run after a `clean` which means this

[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348501492 > @cstamas you mean slower and produces the same output? master does by default a full rebuild in 10s whereas your PR does a full rebuild in 14s The I don't understand

[GitHub] [maven-javadoc-plugin] elharo commented on a diff in pull request #176: Assorted minor updates

2022-12-13 Thread GitBox
elharo commented on code in PR #176: URL: https://github.com/apache/maven-javadoc-plugin/pull/176#discussion_r1047124908 ## src/site/fml/faq.fml: ## @@ -301,11 +301,11 @@ mvn deploy:deploy-file \ - - On Windows with Sun JDK, why javadoc:javadoc

[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348488063 Ok, tried with another project, Maven this time: maven master: 984f73dc7ca2515ee520fbded3382820f62116e9 # Invocations 1st: `mvn clean install -DskipTests`

[GitHub] [maven-compiler-plugin] rmannibucau commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
rmannibucau commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348483187 > As I thought: PR is clearly better at "full recompile" case of m-c-p master @cstamas you mean slower and produces the same output? master does by default a full r

[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348457823 @rmannibucau ok, thanks for doing this. As I thought: PR is _clearly better_ at "full recompile" case of m-c-p master -- This is an automated message from the Apache Git Se

[GitHub] [maven-compiler-plugin] rmannibucau commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
rmannibucau commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348441207 @cstamas 16s first time then always ~14s so overall the diff logic is worth it even if it costs some time - guess we can make it faster there too tracking files more effi

[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348422749 @rmannibucau could you please build locally this PR and try with that same steps? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [maven-compiler-plugin] rmannibucau commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
rmannibucau commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348410859 @cstamas as Olivier mentionned, your build does not use this feature so you compare twice the same things. Also my example shows the real gain. I tested on a work project

[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348406757 @slawekjaranowski please compare m-c-p master (or any released) vs this PRl :smile: As your test really compares m-c-p against m-c-p, not m-c-p master/released against PR.

[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348400764 @rmannibucau a bit of simple math: your "full" compile: 1391ms your "incremental" compile: 572ms difference is: 819ms On "big" build (a 300 module build was mention

[GitHub] [maven-compiler-plugin] slawekjaranowski commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
slawekjaranowski commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348400184 My test - Classes in target prod and unit: 4883 - Maven modules: 326 - JDK 1.8 - Os: MacOs 12.6.1 - 2,6 GHz 6-Core Intel Core i7, 32 GB 2667 MHz DDR4

[GitHub] [maven-invoker-plugin] olamy commented on a diff in pull request #156: [MINVOKER-316] Refresh plugins versions in IT tests

2022-12-13 Thread GitBox
olamy commented on code in PR #156: URL: https://github.com/apache/maven-invoker-plugin/pull/156#discussion_r1047075394 ## pom.xml: ## @@ -357,7 +357,19 @@ under the License. run-its + +3.1.0 +3.2.0 +3.10.1 +3.1.0 +

[GitHub] [maven-jxr] dependabot[bot] opened a new pull request, #89: Bump slf4jVersion from 1.7.36 to 2.0.6

2022-12-13 Thread GitBox
dependabot[bot] opened a new pull request, #89: URL: https://github.com/apache/maven-jxr/pull/89 Bumps `slf4jVersion` from 1.7.36 to 2.0.6. Updates `slf4j-api` from 1.7.36 to 2.0.6 Commits https://github.com/qos-ch/slf4j/commit/5ff6f2c385c36ea4f8b85cacd69f7ca891c37818";>5ff6f

[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348361295 Full logs of `mvn verify -DskipTests` are here (they are huge) https://drive.google.com/file/d/1S8GUWW7C2SC2Wv4_LjxCji_VaJZORGMj/view?usp=share_link -- This is an automated

[GitHub] [maven-compiler-plugin] olamy commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
olamy commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348339146 > Nope, I removed bits needing install, 3rd invocation is `mvn verify`, please reread. read my comment especially on the reactor and rebuild of artifacts. what do

[GitHub] [maven-invoker-plugin] slawekjaranowski commented on a diff in pull request #156: [MINVOKER-316] Refresh plugins versions in IT tests

2022-12-13 Thread GitBox
slawekjaranowski commented on code in PR #156: URL: https://github.com/apache/maven-invoker-plugin/pull/156#discussion_r1047049860 ## pom.xml: ## @@ -357,7 +357,19 @@ under the License. run-its + +3.1.0 +3.2.0 +3.10.1 +

[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348309636 @rmannibucau i hope you understand your example does not make sense? Can you show me a real life example, a full build? -- This is an automated message from the Apache Git

[GitHub] [maven-compiler-plugin] rmannibucau commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
rmannibucau commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348260251 Here is a simple project showing the usage: ``` rmannibucau@rmannibucau-yupiik:/opt/rmannibucau/dev/demo-sunny $ mvn clean [INFO] Scanning for projects... [

[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348251135 Nope, I removed bits needing install, 3rd invocation is `mvn verify`, please reread. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-compiler-plugin] olamy commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
olamy commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348235817 as you are using a project which need install this doesn't work because some artifacts are part of the reactor and rebuild (e.g re package) so they are detected as new de

[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348211764 As everyone talks how this is "must to have" but nobody provided any number to support this claim, I tried to convince myself this is "must to have". So... Subject buil

[GitHub] [maven-invoker-plugin] michael-o commented on a diff in pull request #156: [MINVOKER-316] Refresh plugins versions in IT tests

2022-12-13 Thread GitBox
michael-o commented on code in PR #156: URL: https://github.com/apache/maven-invoker-plugin/pull/156#discussion_r1047007075 ## src/it/local-repo-path/pom.xml: ## @@ -54,7 +54,9 @@ under the License. src/it/settings.xml -org.apache.

[GitHub] [maven-pmd-plugin] dependabot[bot] closed pull request #105: Bump slf4jVersion from 1.7.36 to 2.0.5

2022-12-13 Thread GitBox
dependabot[bot] closed pull request #105: Bump slf4jVersion from 1.7.36 to 2.0.5 URL: https://github.com/apache/maven-pmd-plugin/pull/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-pmd-plugin] dependabot[bot] opened a new pull request, #106: Bump slf4jVersion from 1.7.36 to 2.0.6

2022-12-13 Thread GitBox
dependabot[bot] opened a new pull request, #106: URL: https://github.com/apache/maven-pmd-plugin/pull/106 Bumps `slf4jVersion` from 1.7.36 to 2.0.6. Updates `slf4j-api` from 1.7.36 to 2.0.6 Commits https://github.com/qos-ch/slf4j/commit/5ff6f2c385c36ea4f8b85cacd69f7ca891c3781

[GitHub] [maven-pmd-plugin] dependabot[bot] commented on pull request #105: Bump slf4jVersion from 1.7.36 to 2.0.5

2022-12-13 Thread GitBox
dependabot[bot] commented on PR #105: URL: https://github.com/apache/maven-pmd-plugin/pull/105#issuecomment-1348200460 Superseded by #106. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [maven-invoker-plugin] slawekjaranowski opened a new pull request, #156: [MINVOKER-316] Refresh plugins versions in IT tests

2022-12-13 Thread GitBox
slawekjaranowski opened a new pull request, #156: URL: https://github.com/apache/maven-invoker-plugin/pull/156 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/M

  1   2   >