olamy commented on PR #160:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1349673838

   > > If we ignore the figures right - highly depends your build, tomee 
container/openejb-core module for ex, it is 14s -> 4s (1 module so if you do 
the math you almost save 1h for your example ;)).
   > 
   > Sure, we can come up with numbers as we like, but I will shut up in a 
moment this very feature saves 1h on a _real life project_ out there.
   > 
   > > Kind of, "magic" happens there 
https://github.com/apache/maven-compiler-plugin/blob/master/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java#L897
 and agree the rule can be enhanced to better manage multi-reactor builds, can 
be a great enhancement/PR to do.
   > 
   > Sure, but this also means that almost no multi module build benefits from 
this feature, as the sole idea of multi module build is usually to "depend on 
each other". I can imagine some "lab" project where you have 300 modules that 
do not depend on each other, but I guess this cannot be called "majority", 
unless am mistaken.
   
   no it depends if you reach install phase or not... I tried to explain 
previously in this issue and this has already been discussed here 
https://lists.apache.org/thread/1l87rfqk7k26lgh07vt8w6367qgp3sct 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to