[GitHub] [maven] timboudreau closed pull request #750: Allow Maven to resolve a parent it is about to build

2022-06-06 Thread GitBox
timboudreau closed pull request #750: Allow Maven to resolve a parent it is about to build URL: https://github.com/apache/maven/pull/750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven] timboudreau commented on pull request #750: Allow Maven to resolve a parent it is about to build

2022-06-06 Thread GitBox
timboudreau commented on PR #750: URL: https://github.com/apache/maven/pull/750#issuecomment-1148177204 This may have been addressed in another way in the 4.x branch. Going to close this and open a patch for 3.9.x. -- This is an automated message from the Apache Git Service. To respond t

[jira] [Commented] (SUREFIRE-1426) Fork crash doesn't fail build with -Dmaven.test.failure.ignore=true

2022-06-06 Thread Olivier Lamy (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550783#comment-17550783 ] Olivier Lamy commented on SUREFIRE-1426: [~br0nstein]please open another issue

[jira] [Commented] (SUREFIRE-1426) Fork crash doesn't fail build with -Dmaven.test.failure.ignore=true

2022-06-06 Thread Aaron Braunstein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550762#comment-17550762 ] Aaron Braunstein commented on SUREFIRE-1426: [~tibordigana] I have a fix f

[GitHub] [maven-fluido-skin] olamy commented on pull request #34: Mskins 191 dynamic library retrieval

2022-06-06 Thread GitBox
olamy commented on PR #34: URL: https://github.com/apache/maven-fluido-skin/pull/34#issuecomment-1148033740 @stevecrox I agree this skin has very dated.. but you might face some conservative reactions here. If you are interested there is this "new one" as well https://olamy.github.io/re

[GitHub] [maven-fluido-skin] olamy commented on a diff in pull request #34: Mskins 191 dynamic library retrieval

2022-06-06 Thread GitBox
olamy commented on code in PR #34: URL: https://github.com/apache/maven-fluido-skin/pull/34#discussion_r890642306 ## pom.xml: ## @@ -184,6 +186,93 @@ under the License. false + + +copy-anchor-js-into-build-output +

[GitHub] [maven-fluido-skin] slawekjaranowski commented on a diff in pull request #33: rework ITs to better integrate into skin documentation

2022-06-06 Thread GitBox
slawekjaranowski commented on code in PR #33: URL: https://github.com/apache/maven-fluido-skin/pull/33#discussion_r890615352 ## src/site/site.xml: ## @@ -27,9 +27,7 @@ under the License. org.apache.maven.skins maven-fluido-skin - - -1.10.0 +${projec

[GitHub] [maven-fluido-skin] stevecrox commented on a diff in pull request #34: Mskins 191 dynamic library retrieval

2022-06-06 Thread GitBox
stevecrox commented on code in PR #34: URL: https://github.com/apache/maven-fluido-skin/pull/34#discussion_r890611319 ## pom.xml: ## @@ -98,12 +98,14 @@ under the License. -2.3.2 +3.1.1 Review Comment: Yes I've deciphered from one of the comments that to te

[GitHub] [maven-fluido-skin] stevecrox commented on pull request #34: Mskins 191 dynamic library retrieval

2022-06-06 Thread GitBox
stevecrox commented on PR #34: URL: https://github.com/apache/maven-fluido-skin/pull/34#issuecomment-1147985599 Micheal-o the PR was simply closed I assume this was done in error since it appeared some discussion started and then before I could even raise questions or make adjustments it wa

[jira] [Commented] (MNGSITE-485) Expired signature in provided KEYS file on the download page

2022-06-06 Thread Baiyang Li (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550679#comment-17550679 ] Baiyang Li commented on MNGSITE-485: I tried again. I get another error even before

[jira] [Updated] (MWRAPPER-68) MVNW_REPOURL improperly formed distributionUrl

2022-06-06 Thread HumanFund (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HumanFund updated MWRAPPER-68: -- Description: In Maven Wrapper v3.1.1, Installer::createDist(), file maven-wrapper/src/main/java/org/a

[GitHub] [maven-fluido-skin] michael-o commented on a diff in pull request #34: Mskins 191 dynamic library retrieval

2022-06-06 Thread GitBox
michael-o commented on code in PR #34: URL: https://github.com/apache/maven-fluido-skin/pull/34#discussion_r890578218 ## pom.xml: ## @@ -98,12 +98,14 @@ under the License. -2.3.2 +3.1.1 Review Comment: Correct and this is wrong... -- This is an automate

[jira] [Commented] (MASSEMBLY-955) dependencySet includes filter with classifier breaks include of artifacts without classifier

2022-06-06 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550662#comment-17550662 ] Michael Osipov commented on MASSEMBLY-955: -- I have tried your IT against curr

[jira] [Commented] (MNGSITE-485) Expired signature in provided KEYS file on the download page

2022-06-06 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550661#comment-17550661 ] Michael Osipov commented on MNGSITE-485: Please try again. > Expired signature

[jira] [Created] (MWRAPPER-68) MVNW_REPOURL improperly formed distributionUrl

2022-06-06 Thread HumanFund (Jira)
HumanFund created MWRAPPER-68: - Summary: MVNW_REPOURL improperly formed distributionUrl Key: MWRAPPER-68 URL: https://issues.apache.org/jira/browse/MWRAPPER-68 Project: Maven Wrapper Issue Type:

[GitHub] [maven-fluido-skin] slachiewicz commented on a diff in pull request #34: Mskins 191 dynamic library retrieval

2022-06-06 Thread GitBox
slachiewicz commented on code in PR #34: URL: https://github.com/apache/maven-fluido-skin/pull/34#discussion_r890568061 ## pom.xml: ## @@ -98,12 +98,14 @@ under the License. -2.3.2 +3.1.1 Review Comment: so only version change and no need to adjust any macr

[GitHub] [maven-fluido-skin] michael-o commented on pull request #35: Mskins 97 redefine macro layout

2022-06-06 Thread GitBox
michael-o commented on PR #35: URL: https://github.com/apache/maven-fluido-skin/pull/35#issuecomment-1147925038 Logical change. Will take a look next couple of days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [maven-fluido-skin] slachiewicz commented on a diff in pull request #34: Mskins 191 dynamic library retrieval

2022-06-06 Thread GitBox
slachiewicz commented on code in PR #34: URL: https://github.com/apache/maven-fluido-skin/pull/34#discussion_r890566562 ## pom.xml: ## @@ -98,12 +98,14 @@ under the License. -2.3.2 +3.1.1 1.11.2 3.12.0 3.3.0 2022-05-14T18:16:12Z 4.2.2

[GitHub] [maven-fluido-skin] stevecrox opened a new pull request, #35: Mskins 97 redefine macro layout

2022-06-06 Thread GitBox
stevecrox opened a new pull request, #35: URL: https://github.com/apache/maven-fluido-skin/pull/35 This change is about breaking out the velocity macros, so when I modify sections (to work with Bootstrap 5) it is clearer what I am changing and why -- This is an automated message from the

[GitHub] [maven-fluido-skin] michael-o commented on pull request #34: Mskins 191 dynamic library retrieval

2022-06-06 Thread GitBox
michael-o commented on PR #34: URL: https://github.com/apache/maven-fluido-skin/pull/34#issuecomment-1147917259 What is the difference between this and the other PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [maven-shared-utils] wilx commented on pull request #54: rework directory scanner to ensure it can enforce exclusions and it uses path

2022-06-06 Thread GitBox
wilx commented on PR #54: URL: https://github.com/apache/maven-shared-utils/pull/54#issuecomment-1147914189 Any progress? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Commented] (MNGSITE-485) Expired signature in provided KEYS file on the download page

2022-06-06 Thread Baiyang Li (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550658#comment-17550658 ] Baiyang Li commented on MNGSITE-485: Hey [~michael-o] , Thanks for your update. I t

[jira] [Comment Edited] (MNGSITE-485) Expired signature in provided KEYS file on the download page

2022-06-06 Thread Baiyang Li (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550658#comment-17550658 ] Baiyang Li edited comment on MNGSITE-485 at 6/6/22 8:51 PM:

[jira] [Comment Edited] (MNGSITE-485) Expired signature in provided KEYS file on the download page

2022-06-06 Thread Baiyang Li (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550658#comment-17550658 ] Baiyang Li edited comment on MNGSITE-485 at 6/6/22 8:51 PM:

[GitHub] [maven-fluido-skin] stevecrox opened a new pull request, #34: Mskins 191 dynamic library retrieval

2022-06-06 Thread GitBox
stevecrox opened a new pull request, #34: URL: https://github.com/apache/maven-fluido-skin/pull/34 I assume there was some kind of glitch, there appeared to be the start of a discussion on the PR and then it was simply closed before I could explain some of the issues or receive actionable f

[GitHub] [maven-common-artifact-filters] michael-o closed pull request #24: [MASSEMBLY-955] Keep iterating over patterns.

2022-06-06 Thread GitBox
michael-o closed pull request #24: [MASSEMBLY-955] Keep iterating over patterns. URL: https://github.com/apache/maven-common-artifact-filters/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [maven-common-artifact-filters] michael-o commented on pull request #24: [MASSEMBLY-955] Keep iterating over patterns.

2022-06-06 Thread GitBox
michael-o commented on PR #24: URL: https://github.com/apache/maven-common-artifact-filters/pull/24#issuecomment-1147876623 I am closing this PR because it cannot be applied. The entire class has changed. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [maven] jglick commented on pull request #750: Allow Maven to resolve a parent it is about to build

2022-06-06 Thread GitBox
jglick commented on PR #750: URL: https://github.com/apache/maven/pull/750#issuecomment-1147841396 > I have no idea _why_ it was never implemented For M2Eclipse perhaps? https://github.com/apache/maven-integration-testing would be the place to write a test AFAIK. -- This is

[jira] [Created] (MSHARED-1076) [REGRESSION] 1b5d50b390c4548d16d0c7d507c38240c6f49b07 prematurely breaks loop

2022-06-06 Thread Michael Osipov (Jira)
Michael Osipov created MSHARED-1076: --- Summary: [REGRESSION] 1b5d50b390c4548d16d0c7d507c38240c6f49b07 prematurely breaks loop Key: MSHARED-1076 URL: https://issues.apache.org/jira/browse/MSHARED-1076

[jira] [Created] (SUREFIRE-2094) Leaked file descriptors

2022-06-06 Thread Michael Keppler (Jira)
Michael Keppler created SUREFIRE-2094: - Summary: Leaked file descriptors Key: SUREFIRE-2094 URL: https://issues.apache.org/jira/browse/SUREFIRE-2094 Project: Maven Surefire Issue Type: Bu

[jira] [Updated] (MASSEMBLY-957) Deprecate the repository element in assembly decriptor

2022-06-06 Thread Jira
[ https://issues.apache.org/jira/browse/MASSEMBLY-957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MASSEMBLY-957: -- Fix Version/s: 3.3.1 > Deprecate the repository element in assembly decriptor >

[GitHub] [maven-filtering] dependabot[bot] closed pull request #36: Bump mockito-core from 2.28.2 to 4.6.0

2022-06-06 Thread GitBox
dependabot[bot] closed pull request #36: Bump mockito-core from 2.28.2 to 4.6.0 URL: https://github.com/apache/maven-filtering/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [maven-filtering] dependabot[bot] commented on pull request #36: Bump mockito-core from 2.28.2 to 4.6.0

2022-06-06 Thread GitBox
dependabot[bot] commented on PR #36: URL: https://github.com/apache/maven-filtering/pull/36#issuecomment-1147698676 Superseded by #37. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-filtering] dependabot[bot] opened a new pull request, #37: Bump mockito-core from 2.28.2 to 4.6.1

2022-06-06 Thread GitBox
dependabot[bot] opened a new pull request, #37: URL: https://github.com/apache/maven-filtering/pull/37 Bumps [mockito-core](https://github.com/mockito/mockito) from 2.28.2 to 4.6.1. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases.

[jira] [Commented] (MRESOLVER-7) Download dependency POMs in parallel

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550590#comment-17550590 ] ASF GitHub Bot commented on MRESOLVER-7: cstamas commented on PR #178: URL: http

[GitHub] [maven-resolver] cstamas commented on pull request #178: [MRESOLVER-7] download poms in parallel

2022-06-06 Thread GitBox
cstamas commented on PR #178: URL: https://github.com/apache/maven-resolver/pull/178#issuecomment-1147694146 Something is wrong here, unsure what. But, I tried to build maven master using maven-3.9.x + this PR + empty local repo and it fails: ``` [ERROR] Failed to execute goal org.apa

[jira] [Commented] (MNG-7468) Unsupported plugins parameters in configuration should be verified

2022-06-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550589#comment-17550589 ] Hudson commented on MNG-7468: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.

[jira] [Commented] (MNG-7468) Unsupported plugins parameters in configuration should be verified

2022-06-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550587#comment-17550587 ] Hudson commented on MNG-7468: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.

[jira] [Commented] (MRESOLVER-262) Provide contextual data in trace data for collector invoked requests

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550585#comment-17550585 ] ASF GitHub Bot commented on MRESOLVER-262: -- grgrzybek commented on PR #182: U

[GitHub] [maven-resolver] grgrzybek commented on pull request #182: [MRESOLVER-262] Provide contextual data in trace during collect

2022-06-06 Thread GitBox
grgrzybek commented on PR #182: URL: https://github.com/apache/maven-resolver/pull/182#issuecomment-1147681955 I'll check tomorrow - thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Commented] (MRESOLVER-262) Provide contextual data in trace data for collector invoked requests

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550582#comment-17550582 ] ASF GitHub Bot commented on MRESOLVER-262: -- cstamas commented on PR #182: URL

[GitHub] [maven-resolver] cstamas commented on pull request #182: [MRESOLVER-262] Provide contextual data in trace during collect

2022-06-06 Thread GitBox
cstamas commented on PR #182: URL: https://github.com/apache/maven-resolver/pull/182#issuecomment-1147667658 @grgrzybek Please take a peek a compare the "demo snippet" output with what you need -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on pull request #46: Add more FF flags

2022-06-06 Thread GitBox
slawekjaranowski commented on PR #46: URL: https://github.com/apache/maven-gh-actions-shared/pull/46#issuecomment-1147659197 I see one more issue, when ff is disabled and we create PR from branch in repo we have build matrix for both events push and pull-request, like in https://github.com

[jira] [Updated] (SUREFIRE-2090) Xref link to source code with specified line number doesn't work. Missing "L" in anchor

2022-06-06 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated SUREFIRE-2090: -- Labels: up-for-grabs (was: ) > Xref link to source code with specified line

[jira] [Closed] (MNG-7468) Unsupported plugins parameters in configuration should be verified

2022-06-06 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MNG-7468. Resolution: Fixed > Unsupported plugins parameters in configuration should be verified >

[jira] [Commented] (MNG-7468) Unsupported plugins parameters in configuration should be verified

2022-06-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550543#comment-17550543 ] Hudson commented on MNG-7468: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.

[GitHub] [maven] timboudreau commented on pull request #750: Allow Maven to resolve a parent it is about to build

2022-06-06 Thread GitBox
timboudreau commented on PR #750: URL: https://github.com/apache/maven/pull/750#issuecomment-1147596279 Example repositories I know of with the problem this solves: * [Mastfrog Parent](https://github.com/timboudreau/mastfrog-parent) * [Telenav Build](https://github.com/telenav/t

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #161: Bump mockito.version from 4.6.0 to 4.6.1

2022-06-06 Thread GitBox
slawekjaranowski merged PR #161: URL: https://github.com/apache/maven-enforcer/pull/161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [maven] timboudreau commented on pull request #750: Allow Maven to resolve a parent it is about to build

2022-06-06 Thread GitBox
timboudreau commented on PR #750: URL: https://github.com/apache/maven/pull/750#issuecomment-1147589016 Working on a backport to the 3.9.x branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven] timboudreau opened a new pull request, #750: Allow Maven to resolve a parent it is about to build

2022-06-06 Thread GitBox
timboudreau opened a new pull request, #750: URL: https://github.com/apache/maven/pull/750 Fixes a long-standing issue when using Maven with git submodules: * You have a library project in a git repository * That library is part of a larger set of projects, but should be buildabl

[jira] [Commented] (MNG-7468) Unsupported plugins parameters in configuration should be verified

2022-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550533#comment-17550533 ] ASF GitHub Bot commented on MNG-7468: - slawekjaranowski merged PR #749: URL: https://gi

[GitHub] [maven] slawekjaranowski merged pull request #749: [MNG-7468] Check unsupported plugins parameters in configuration - 3.9

2022-06-06 Thread GitBox
slawekjaranowski merged PR #749: URL: https://github.com/apache/maven/pull/749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #171: [MNG-7468] Check unsupported plugins parameters in configuration - 3.9

2022-06-06 Thread GitBox
slawekjaranowski merged PR #171: URL: https://github.com/apache/maven-integration-testing/pull/171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[GitHub] [maven-surefire] chalmagr commented on pull request #476: [SUREFIRE-2010] Parameterized Selection Does not Work

2022-06-06 Thread GitBox
chalmagr commented on PR #476: URL: https://github.com/apache/maven-surefire/pull/476#issuecomment-1147570883 > Thanks for the hints. I adapted the code, but is there any part of the maven launcher which allows to pass something like `-Dtest=MySelector`, or do I have to call it myself? Just

[jira] [Commented] (MENFORCER-401) DependencyConvergence ignores exclusions

2022-06-06 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550530#comment-17550530 ] Slawomir Jaranowski commented on MENFORCER-401: --- Without possibility to

[GitHub] [maven-fluido-skin] hboutemy commented on pull request #33: rework ITs to better integrate into skin documentation

2022-06-06 Thread GitBox
hboutemy commented on PR #33: URL: https://github.com/apache/maven-fluido-skin/pull/33#issuecomment-1147563059 @slawekjaranowski IIRC, you're a GH expert, if you can please configure this branch to run "mvn package site" instead of "mvn site", that would fix the build... -- This is an au

[jira] [Commented] (SUREFIRE-2065) Test Reports Inconsistencies with Parameterized and junit4

2022-06-06 Thread Christian Marquez Grabia (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550524#comment-17550524 ] Christian Marquez Grabia commented on SUREFIRE-2065: When creating

[jira] [Closed] (MNG-7485) Failed To Load JANSI Native Library

2022-06-06 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-7485. --- Fix Version/s: (was: waiting-for-feedback) (was: wontfix-candidate) Re

[jira] [Commented] (MNG-7485) Failed To Load JANSI Native Library

2022-06-06 Thread Mark (Jira)
[ https://issues.apache.org/jira/browse/MNG-7485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550470#comment-17550470 ] Mark commented on MNG-7485: --- I can confirm that this has solved our issue. > Failed To Load JANS

[GitHub] [maven-surefire] chalmagr commented on a diff in pull request #516: [SUREFIRE-2065] Test Reports Inconsistencies with Parameterized and junit4

2022-06-06 Thread GitBox
chalmagr commented on code in PR #516: URL: https://github.com/apache/maven-surefire/pull/516#discussion_r890146141 ## maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java: ## @@ -312,7 +312,7 @@ private void addTestMethodStats()

[GitHub] [maven-jxr] dependabot[bot] opened a new pull request, #58: Bump maven-pmd-plugin from 3.16.0 to 3.17.0

2022-06-06 Thread GitBox
dependabot[bot] opened a new pull request, #58: URL: https://github.com/apache/maven-jxr/pull/58 Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.16.0 to 3.17.0. Release notes Sourced from https://github.com/apache/maven-pmd-plugin/releases";>maven-pmd-pl

[GitHub] [maven-jar-plugin] jorsol opened a new pull request, #43: [MJAR-275] - Update maven-archiver to 3.6.0

2022-06-06 Thread GitBox
jorsol opened a new pull request, #43: URL: https://github.com/apache/maven-jar-plugin/pull/43 This requires the release of plexus-archiver 4.3.0 and maven-archiver 3.6.0. Fixing the "MJAR-275 - outputTimestamp not applied to module-info; breaks reproducible builds" Followi

[GitHub] [maven-fluido-skin] stevecrox closed pull request #32: Mskins 191 dynamic library retrieval

2022-06-06 Thread GitBox
stevecrox closed pull request #32: Mskins 191 dynamic library retrieval URL: https://github.com/apache/maven-fluido-skin/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [maven-fluido-skin] stevecrox commented on pull request #32: Mskins 191 dynamic library retrieval

2022-06-06 Thread GitBox
stevecrox commented on PR #32: URL: https://github.com/apache/maven-fluido-skin/pull/32#issuecomment-1147355223 I am interested in this skin, because maven allows me to incorporate documentation and analysis into a site. The problem is the current site style has dated. Historically f

[GitHub] [maven-fluido-skin] rmannibucau commented on pull request #32: Mskins 191 dynamic library retrieval

2022-06-06 Thread GitBox
rmannibucau commented on PR #32: URL: https://github.com/apache/maven-fluido-skin/pull/32#issuecomment-1147350603 Not sure, using node today is not rocket science (at least no more than using velocity to create a template) but overall it would benefit end users (either using CDN or node to

[GitHub] [maven-fluido-skin] michael-o commented on pull request #32: Mskins 191 dynamic library retrieval

2022-06-06 Thread GitBox
michael-o commented on PR #32: URL: https://github.com/apache/maven-fluido-skin/pull/32#issuecomment-1147325263 I don't want this skin to be rocket science, but this makes it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [maven-fluido-skin] slachiewicz commented on pull request #32: Mskins 191 dynamic library retrieval

2022-06-06 Thread GitBox
slachiewicz commented on PR #32: URL: https://github.com/apache/maven-fluido-skin/pull/32#issuecomment-1147321586 Main challenge is how to cut template, adjust macros. including 2 css and .js files doesn't have to be problem here. -- This is an automated message from the Apache Git Se

[GitHub] [maven-fluido-skin] rmannibucau commented on pull request #32: Mskins 191 dynamic library retrieval

2022-06-06 Thread GitBox
rmannibucau commented on PR #32: URL: https://github.com/apache/maven-fluido-skin/pull/32#issuecomment-1147312549 @hboutemy exploding webjars and copying resources would work but would still rely on outdated plugins for the resources build, this is where using nodejs ecosystem would be a bi

[GitHub] [maven-fluido-skin] hboutemy commented on pull request #32: Mskins 191 dynamic library retrieval

2022-06-06 Thread GitBox
hboutemy commented on PR #32: URL: https://github.com/apache/maven-fluido-skin/pull/32#issuecomment-1147290751 notice: given updates to the skin requires to check the rendering, I had a look at how easy currently and I found: 1. it's easy to see the result of many edge cases: https://

[GitHub] [maven-fluido-skin] hboutemy commented on pull request #32: Mskins 191 dynamic library retrieval

2022-06-06 Thread GitBox
hboutemy commented on PR #32: URL: https://github.com/apache/maven-fluido-skin/pull/32#issuecomment-1147281228 I love the idea of making updates of the 3 used js libraries easier, even if the hard work when upgrading is to check that the template still works as expected: at least, it eases

[jira] [Commented] (MNG-7485) Failed To Load JANSI Native Library

2022-06-06 Thread Mark (Jira)
[ https://issues.apache.org/jira/browse/MNG-7485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550358#comment-17550358 ] Mark commented on MNG-7485: --- Hi Michael - apologies for the late response, been on leave for the

[GitHub] [maven-fluido-skin] michael-o commented on pull request #32: Mskins 191 dynamic library retrieval

2022-06-06 Thread GitBox
michael-o commented on PR #32: URL: https://github.com/apache/maven-fluido-skin/pull/32#issuecomment-1147172114 The need for an upgrade does not relate to using npm or packaging. Maven sites are supposed to be self-contained because they can be archived, see site:jar. Using CDNs would compl