hboutemy commented on PR #32: URL: https://github.com/apache/maven-fluido-skin/pull/32#issuecomment-1147290751
notice: given updates to the skin requires to check the rendering, I had a look at how easy currently and I found: 1. it's easy to see the result of many edge cases: https://maven.apache.org/skins/maven-fluido-skin/ITs.html 2. but it's not so easy to see result for the sample page, given it uses previous skin version: https://maven.apache.org/skins/maven-fluido-skin/sample.html perhaps we should inject the sample page content into the 3 main layouts tests https://maven.apache.org/skins/maven-fluido-skin/sidebar/index.html we never had much contribution to skins, this is time to learn together how to improve that aspect -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
