[GitHub] [maven] rmannibucau commented on pull request #578: [MNG-7285] [3.8.x] Replace ThreadLocal in MavenProject with locking in MojoExecutor to fix MNG-6843

2021-10-10 Thread GitBox
rmannibucau commented on pull request #578: URL: https://github.com/apache/maven/pull/578#issuecomment-939739225 @michael-o yes, the fact it handles concurrency=1 to fall back on the well known and used behavior is a clear important step and the lock solves the original issue I think - I d

[GitHub] [maven] michael-o commented on pull request #578: [MNG-7285] [3.8.x] Replace ThreadLocal in MavenProject with locking in MojoExecutor to fix MNG-6843

2021-10-10 Thread GitBox
michael-o commented on pull request #578: URL: https://github.com/apache/maven/pull/578#issuecomment-939735645 @rmannibucau Do you consider this as a better approach than thread local? What about Olivier's PR? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-archetype] dependabot[bot] opened a new pull request #82: Bump maven-aether-provider from 3.0 to 3.3.9

2021-10-10 Thread GitBox
dependabot[bot] opened a new pull request #82: URL: https://github.com/apache/maven-archetype/pull/82 Bumps maven-aether-provider from 3.0 to 3.3.9. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.ma

[GitHub] [maven-indexer] dependabot[bot] opened a new pull request #138: Bump checkstyle from 8.41.1 to 9.0.1

2021-10-10 Thread GitBox
dependabot[bot] opened a new pull request #138: URL: https://github.com/apache/maven-indexer/pull/138 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.41.1 to 9.0.1. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases";>checkstyle's rel

[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request #77: Bump mockito-core from 3.12.4 to 4.0.0

2021-10-10 Thread GitBox
dependabot[bot] opened a new pull request #77: URL: https://github.com/apache/maven-jlink-plugin/pull/77 Bumps [mockito-core](https://github.com/mockito/mockito) from 3.12.4 to 4.0.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases

[GitHub] [maven-filtering] olamy closed pull request #17: Bump mavenVersion from 3.1.0 to 3.8.3

2021-10-10 Thread GitBox
olamy closed pull request #17: URL: https://github.com/apache/maven-filtering/pull/17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [maven-filtering] dependabot[bot] commented on pull request #17: Bump mavenVersion from 3.1.0 to 3.8.3

2021-10-10 Thread GitBox
dependabot[bot] commented on pull request #17: URL: https://github.com/apache/maven-filtering/pull/17#issuecomment-939653708 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a

[GitHub] [maven-filtering] olamy merged pull request #16: Bump junit from 4.13 to 4.13.2

2021-10-10 Thread GitBox
olamy merged pull request #16: URL: https://github.com/apache/maven-filtering/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [maven-filtering] dependabot[bot] opened a new pull request #17: Bump mavenVersion from 3.1.0 to 3.8.3

2021-10-10 Thread GitBox
dependabot[bot] opened a new pull request #17: URL: https://github.com/apache/maven-filtering/pull/17 Bumps `mavenVersion` from 3.1.0 to 3.8.3. Updates `maven-core` from 3.1.0 to 3.8.3 Commits https://github.com/apache/maven/commit/ff8e977a158738155dc465c6a97ffaf31982d739";>

[GitHub] [maven-filtering] dependabot[bot] opened a new pull request #16: Bump junit from 4.13 to 4.13.2

2021-10-10 Thread GitBox
dependabot[bot] opened a new pull request #16: URL: https://github.com/apache/maven-filtering/pull/16 Bumps [junit](https://github.com/junit-team/junit4) from 4.13 to 4.13.2. Release notes Sourced from https://github.com/junit-team/junit4/releases";>junit's releases. JUnit

[GitHub] [maven] hboutemy opened a new pull request #580: simplify, reorganise and document apache-maven-wrapper distribution

2021-10-10 Thread GitBox
hboutemy opened a new pull request #580: URL: https://github.com/apache/maven/pull/580 now that I understand the different pieces behind wrapper :) I still have a few additional questions: - are sha512 checksums really useful? - are these files intended to be distributed in Apac

[GitHub] [maven] slachiewicz commented on pull request #394: [MNG-7020] Remove Maven 2 WagonExcluder backward compat code

2021-10-10 Thread GitBox
slachiewicz commented on pull request #394: URL: https://github.com/apache/maven/pull/394#issuecomment-939556010 That was MNG-7122 https://github.com/apache/maven/commit/184db56e4f149fd0b6931a72af22fa184b15a2bd -- This is an automated message from the Apache Git Service. To respond to t

[jira] [Updated] (MNG-7122) Require specific Maven compatibility version for plugins

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-7122: -- Fix Version/s: 4.0.x-candidate > Require specific Maven compatibility version for plugins

[GitHub] [maven-clean-plugin] cstamas opened a new pull request #2: Update plugin dependencies

2021-10-10 Thread GitBox
cstamas opened a new pull request #2: URL: https://github.com/apache/maven-clean-plugin/pull/2 And make plugin-api provided -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Assigned] (MNG-7287) Simplify assertion with simpler and equivalent calls.

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MNG-7287: - Assignee: Sylwester Lachiewicz (was: Karl Heinz Marbaise) > Simplify assertion wi

[jira] [Commented] (MNG-7287) Simplify assertion with simpler and equivalent calls.

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426895#comment-17426895 ] Sylwester Lachiewicz commented on MNG-7287: --- Done for  4.x with [4daa48e0f6041f5

[jira] [Closed] (MNG-7287) Simplify assertion with simpler and equivalent calls.

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MNG-7287. - Resolution: Fixed > Simplify assertion with simpler and equivalent calls. > ---

[jira] [Issue Comment Deleted] (MNG-7287) Simplify assertion with simpler and equivalent calls.

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-7287: -- Comment: was deleted (was: Done for  4.x with [4daa48e0f6041f52647919adfadd2d783e6debdc|

[jira] [Commented] (MNG-7287) Simplify assertion with simpler and equivalent calls.

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426894#comment-17426894 ] Sylwester Lachiewicz commented on MNG-7287: --- Done for  4.x with [4daa48e0f6041f5

[GitHub] [maven] slachiewicz commented on pull request #576: MNG-7287 - Simplify assertion with simpler and equivalent calls.

2021-10-10 Thread GitBox
slachiewicz commented on pull request #576: URL: https://github.com/apache/maven/pull/576#issuecomment-939548616 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [maven] slachiewicz closed pull request #576: MNG-7287 - Simplify assertion with simpler and equivalent calls.

2021-10-10 Thread GitBox
slachiewicz closed pull request #576: URL: https://github.com/apache/maven/pull/576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Closed] (MRRESOURCES-92) Upgrade to Maven 3.0 compatiblity

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MRRESOURCES-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MRRESOURCES-92. --- Resolution: Duplicate > Upgrade to Maven 3.0 compatiblity > -

[jira] [Updated] (MRRESOURCES-118) Require Maven 3.2.0

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MRRESOURCES-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MRRESOURCES-118: - Fix Version/s: 3.0.0 > Require Maven 3.2.0 > --- > >

[jira] [Commented] (MRRESOURCES-118) Require Maven 3.2.0

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MRRESOURCES-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426891#comment-17426891 ] Sylwester Lachiewicz commented on MRRESOURCES-118: -- Fixed with [ad

[jira] [Closed] (MNG-7291) Avoid String concatenation in loops.

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MNG-7291. - Resolution: Fixed > Avoid String concatenation in loops. >

[jira] [Commented] (MNG-7291) Avoid String concatenation in loops.

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426887#comment-17426887 ] Sylwester Lachiewicz commented on MNG-7291: --- Fixed for 4.x with [b31f3aeef3a7b9e

[jira] [Assigned] (MNG-7291) Avoid String concatenation in loops.

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MNG-7291: - Assignee: Sylwester Lachiewicz > Avoid String concatenation in loops. > --

[GitHub] [maven] slachiewicz merged pull request #572: MNG-7291 -Avoid String concatenation in loops.

2021-10-10 Thread GitBox
slachiewicz merged pull request #572: URL: https://github.com/apache/maven/pull/572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Commented] (MNG-7230) Replace assert by simpler but equivalent calls

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426876#comment-17426876 ] Hudson commented on MNG-7230: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-7189) Remove undocumented environment variable MAVEN_BASEDIR in startup scripts

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426875#comment-17426875 ] Hudson commented on MNG-7189: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-7231) Fix Javadoc errors

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426877#comment-17426877 ] Hudson commented on MNG-7231: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-6759) [REGRESSION] Maven fails to use section from dependency when resolving transitive dependencies in some cases

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426874#comment-17426874 ] Hudson commented on MNG-6759: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-7047) Validate that repo configuration does not contain any expression

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426873#comment-17426873 ] Hudson commented on MNG-7047: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-7115) MavenITmng5771CoreExtensionsTest fails on maven-3.8.x branch

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426870#comment-17426870 ] Hudson commented on MNG-7115: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-7056) Replace tabs in IT files

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426871#comment-17426871 ] Hudson commented on MNG-7056: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-6511) Option -pl ! foo should not fail if foo does not exist

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426863#comment-17426863 ] Hudson commented on MNG-6511: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-5868) Adding serval times the same artifact via MavenProjectHelper (attachArtifact) keep adding to the List duplicate artifacts

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426868#comment-17426868 ] Hudson commented on MNG-5868: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-6071) GetResource ('/) returns 'null' if build is started with -f

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426869#comment-17426869 ] Hudson commented on MNG-6071: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-7112) --projects flag should honor --non-recursive flag

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426866#comment-17426866 ] Hudson commented on MNG-7112: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-6075) Increase the model validation level to the next minor level version

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426862#comment-17426862 ] Hudson commented on MNG-6075: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-6772) Super POM overwrites remapped central repository in nested dependencyManagement import POMs

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426867#comment-17426867 ] Hudson commented on MNG-6772: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-6114) Elements from the global settings should be ordered before elements from the user settings

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426857#comment-17426857 ] Hudson commented on MNG-6114: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-7128) Improve error message when blocked repository defined in build POM

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426864#comment-17426864 ] Hudson commented on MNG-7128: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-7045) Drop CDI API from Maven

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426865#comment-17426865 ] Hudson commented on MNG-7045: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-5639) Support resolution of Import Scope POMs from Repo that contains a ${parameter}

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-5639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426861#comment-17426861 ] Hudson commented on MNG-5639: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-6754) Set the same timestamp in multi module builds

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426872#comment-17426872 ] Hudson commented on MNG-6754: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-7051) Optionally skip non-existing profiles

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426858#comment-17426858 ] Hudson commented on MNG-7051: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-7095) Support for parallel builds when resuming

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426856#comment-17426856 ] Hudson commented on MNG-7095: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-7046) Revert MNG-5639 and make repo config static only

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426860#comment-17426860 ] Hudson commented on MNG-7046: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[jira] [Commented] (MNG-7110) Different behavior of extensions

2021-10-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426859#comment-17426859 ] Hudson commented on MNG-7110: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7020

[GitHub] [maven] arturobernalg commented on a change in pull request #572: MNG-7291 -Avoid String concatenation in loops.

2021-10-10 Thread GitBox
arturobernalg commented on a change in pull request #572: URL: https://github.com/apache/maven/pull/572#discussion_r725665332 ## File path: maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java ## @@ -213,10 +213,10 @@ else if ( numTokens == 3

[GitHub] [maven-enforcer] timtebeek commented on pull request #113: MENFORCER-372 JUnit 5

2021-10-10 Thread GitBox
timtebeek commented on pull request #113: URL: https://github.com/apache/maven-enforcer/pull/113#issuecomment-939496268 OK the test failure is quite puzzling to me. Not sure I fully grasp what `maven-enforcer-extension` and the `run-its` profile within that are doing, and why it's not work

[GitHub] [maven] slachiewicz commented on a change in pull request #306: [MNG-5982] Pass user properties to ModelBuildingRequest

2021-10-10 Thread GitBox
slachiewicz commented on a change in pull request #306: URL: https://github.com/apache/maven/pull/306#discussion_r725650983 ## File path: maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java ## @@ -275,6 +275,7 @@ priv

[jira] [Commented] (MWRAPPER-15) Support SNAPSHOT versions

2021-10-10 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426815#comment-17426815 ] Michael Osipov commented on MWRAPPER-15: This can only be served by repository.a

[GitHub] [maven-enforcer] timtebeek commented on pull request #113: MENFORCER-372 JUnit 5

2021-10-10 Thread GitBox
timtebeek commented on pull request #113: URL: https://github.com/apache/maven-enforcer/pull/113#issuecomment-939493730 I'm looking at the failing tests here; it's the final module Apache maven Enforcer Extension that apparently fails to resolve the enforcer-api that's created as part of t

[GitHub] [maven-enforcer] slachiewicz commented on pull request #113: MENFORCER-372 JUnit 5

2021-10-10 Thread GitBox
slachiewicz commented on pull request #113: URL: https://github.com/apache/maven-enforcer/pull/113#issuecomment-939489395 Thx for amazing job. I'll review it soon. Can you check few failing tests? -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [maven] slachiewicz closed pull request #421: Artifact.getPath() and .setPath()

2021-10-10 Thread GitBox
slachiewicz closed pull request #421: URL: https://github.com/apache/maven/pull/421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [maven-enforcer] timtebeek commented on a change in pull request #113: MENFORCER-372 JUnit 5

2021-10-10 Thread GitBox
timtebeek commented on a change in pull request #113: URL: https://github.com/apache/maven-enforcer/pull/113#discussion_r725622342 ## File path: enforcer-rules/src/test/java/org/apache/maven/plugins/enforcer/utils/TestArtifactMatcher.java ## @@ -19,109 +19,128 @@ * under the

[GitHub] [maven-enforcer] timtebeek commented on a change in pull request #113: MENFORCER-372 JUnit 5

2021-10-10 Thread GitBox
timtebeek commented on a change in pull request #113: URL: https://github.com/apache/maven-enforcer/pull/113#discussion_r725621520 ## File path: enforcer-rules/src/test/java/org/apache/maven/plugins/enforcer/BanDistributionManagementTest.java ## @@ -220,7 +229,7 @@ public void

[GitHub] [maven] slachiewicz closed pull request #350: [MNG-6907] fix endless loop in StringSearchModelInterpolator

2021-10-10 Thread GitBox
slachiewicz closed pull request #350: URL: https://github.com/apache/maven/pull/350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Updated] (MNG-6907) endless loop in StringSearchModelInterpolator

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-6907: -- Affects Version/s: (was: 3.6.3) 3.6.2 > endless loop in String

[jira] [Commented] (MENFORCER-372) Switch to JUnit5

2021-10-10 Thread Tim te Beek (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426798#comment-17426798 ] Tim te Beek commented on MENFORCER-372: --- Figured I'd give this one a try; see  h

[GitHub] [maven-enforcer] timtebeek opened a new pull request #113: MENFORCER-372 JUnit 5

2021-10-10 Thread GitBox
timtebeek opened a new pull request #113: URL: https://github.com/apache/maven-enforcer/pull/113 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed

[jira] [Closed] (MNG-7290) java8 improvements

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MNG-7290. - Resolution: Fixed > java8 improvements > -- > > Key: MNG-72

[jira] [Commented] (MNG-7290) java8 improvements

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426797#comment-17426797 ] Sylwester Lachiewicz commented on MNG-7290: --- Done for 4.x with [16afe061c992c01b

[jira] [Assigned] (MNG-7290) java8 improvements

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MNG-7290: - Assignee: Sylwester Lachiewicz > java8 improvements > -- > >

[GitHub] [maven] slachiewicz closed pull request #571: MNG-7290 - java8 improvements.

2021-10-10 Thread GitBox
slachiewicz closed pull request #571: URL: https://github.com/apache/maven/pull/571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Closed] (MNG-7288) Remove redundant local variables

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MNG-7288. - Resolution: Fixed > Remove redundant local variables > > >

[jira] [Commented] (MNG-7288) Remove redundant local variables

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426796#comment-17426796 ] Sylwester Lachiewicz commented on MNG-7288: --- Done for 4.x with [d61fcf7da1a1d7b0

[jira] [Assigned] (MNG-7288) Remove redundant local variables

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MNG-7288: - Assignee: Sylwester Lachiewicz > Remove redundant local variables > --

[GitHub] [maven] slachiewicz closed pull request #569: MNG-7288 - Remove redundant local variables.

2021-10-10 Thread GitBox
slachiewicz closed pull request #569: URL: https://github.com/apache/maven/pull/569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [maven] slachiewicz commented on a change in pull request #572: MNG-7291 -Avoid String concatenation in loops.

2021-10-10 Thread GitBox
slachiewicz commented on a change in pull request #572: URL: https://github.com/apache/maven/pull/572#discussion_r725615753 ## File path: maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java ## @@ -213,10 +213,10 @@ else if ( numTokens == 3 )

[jira] [Closed] (MNG-7292) Unnecessarily escaped character

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MNG-7292. - Resolution: Fixed > Unnecessarily escaped character > --- > >

[jira] [Commented] (MNG-7292) Unnecessarily escaped character

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426792#comment-17426792 ] Sylwester Lachiewicz commented on MNG-7292: --- Fixed for 4.x with [b9fb76221525b45

[GitHub] [maven] slachiewicz closed pull request #573: MNG-7292 - Unnecessarily escaped character

2021-10-10 Thread GitBox
slachiewicz closed pull request #573: URL: https://github.com/apache/maven/pull/573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Assigned] (MNG-7292) Unnecessarily escaped character

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MNG-7292: - Assignee: Sylwester Lachiewicz > Unnecessarily escaped character > ---

[jira] [Commented] (MNG-7293) Resource Leak due to Files.walk

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426783#comment-17426783 ] Sylwester Lachiewicz commented on MNG-7293: --- Fixed for 4.x with [fbb9d95d5048da8

[jira] [Closed] (MNG-7293) Resource Leak due to Files.walk

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MNG-7293. - Resolution: Fixed > Resource Leak due to Files.walk > --- > >

[jira] [Assigned] (MNG-7293) Resource Leak due to Files.walk

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MNG-7293: - Assignee: Sylwester Lachiewicz > Resource Leak due to Files.walk > ---

[jira] [Updated] (MNG-7293) Resource Leak due to Files.walk

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-7293: -- Fix Version/s: 4.0.0-alpha-1 4.0.0 > Resource Leak due to Files.walk >

[GitHub] [maven] slachiewicz merged pull request #574: [MNG-7293] - fix resource leak due to Files.walk

2021-10-10 Thread GitBox
slachiewicz merged pull request #574: URL: https://github.com/apache/maven/pull/574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [maven] slachiewicz closed pull request #461: changed version to 2.3

2021-10-10 Thread GitBox
slachiewicz closed pull request #461: URL: https://github.com/apache/maven/pull/461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Commented] (MNG-7037) Add JPMS support -> solve split packages problem

2021-10-10 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426780#comment-17426780 ] Robert Scholte commented on MNG-7037: - [~md_5] are we talking about Artifact Resolver o

[GitHub] [maven] slachiewicz merged pull request #567: (doc) Update dead link for Github PR docs

2021-10-10 Thread GitBox
slachiewicz merged pull request #567: URL: https://github.com/apache/maven/pull/567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Commented] (MNG-7037) Add JPMS support -> solve split packages problem

2021-10-10 Thread md_5 (Jira)
[ https://issues.apache.org/jira/browse/MNG-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426772#comment-17426772 ] md_5 commented on MNG-7037: --- Why would you stop publishing it to central? The resolver especiall

[GitHub] [maven] famod edited a comment on pull request #578: [MNG-7285] [3.8.x] Replace ThreadLocal in MavenProject with locking in MojoExecutor to fix MNG-6843

2021-10-10 Thread GitBox
famod edited a comment on pull request #578: URL: https://github.com/apache/maven/pull/578#issuecomment-939364462 > Let's do the revert in one commit, the new change in a separate one. Oh well, I first had it this that way but that will be two reverts. But ok, I can do that... --

[GitHub] [maven] famod commented on pull request #570: [MNG-7285] - Test showcasing regression

2021-10-10 Thread GitBox
famod commented on pull request #570: URL: https://github.com/apache/maven/pull/570#issuecomment-939436539 I don't mind in the end. But we should really avoid "un-fixing" MNG-6843 in 3.8.4. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (MNG-7037) Add JPMS support -> solve split packages problem

2021-10-10 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/MNG-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426771#comment-17426771 ] Pavel_K commented on MNG-7037: -- [~rfscholte] Could you explain, what you suggest to solve this

[jira] [Commented] (MNG-7037) Add JPMS support -> solve split packages problem

2021-10-10 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426770#comment-17426770 ] Robert Scholte commented on MNG-7037: - Renaming will likely break things. I think I wil

[jira] [Closed] (MNG-7296) Remove redundant 'if' statement

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MNG-7296. - Resolution: Fixed > Remove redundant 'if' statement > --- > >

[jira] [Commented] (MNG-7296) Remove redundant 'if' statement

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426769#comment-17426769 ] Sylwester Lachiewicz commented on MNG-7296: --- Done for 4.x with [4fafe44112e7c8e8

[GitHub] [maven] slachiewicz merged pull request #579: MNG-7296 - Remove redundant 'if' statement

2021-10-10 Thread GitBox
slachiewicz merged pull request #579: URL: https://github.com/apache/maven/pull/579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Assigned] (MNG-7296) Remove redundant 'if' statement

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MNG-7296: - Assignee: Sylwester Lachiewicz > Remove redundant 'if' statement > ---

[jira] [Updated] (MNG-7286) Maven code style improvements

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-7286: -- Fix Version/s: 4.0.0-alpha-1 4.0.0 > Maven code style improvements > -

[jira] [Updated] (MNG-7286) Maven code style improvements

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-7286: -- Summary: Maven code style improvements (was: Maven Improvements:) > Maven code style imp

[jira] [Commented] (MNG-7295) Remove redundant/unused import statements.

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426768#comment-17426768 ] Sylwester Lachiewicz commented on MNG-7295: --- Done for 4.x in [e50d65d228fb2bda72

[jira] [Closed] (MNG-7295) Remove redundant/unused import statements.

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MNG-7295. - Resolution: Fixed > Remove redundant/unused import statements. > --

[jira] [Assigned] (MNG-7295) Remove redundant/unused import statements.

2021-10-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MNG-7295: - Assignee: Sylwester Lachiewicz > Remove redundant/unused import statements. >

[jira] [Commented] (MNG-7037) Add JPMS support -> solve split packages problem

2021-10-10 Thread md_5 (Jira)
[ https://issues.apache.org/jira/browse/MNG-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426766#comment-17426766 ] md_5 commented on MNG-7037: --- Well the easiest solution would just be to rename the package…. > A

[GitHub] [maven] michael-o edited a comment on pull request #570: [MNG-7285] - Test showcasing regression

2021-10-10 Thread GitBox
michael-o edited a comment on pull request #570: URL: https://github.com/apache/maven/pull/570#issuecomment-939427466 Can we agree that, unfortunately, @famod's solution did not work out as expected an can revert both commits in separate ticket to make it clear in the release notes first?

  1   2   >