[GitHub] [maven] mickaelistria commented on pull request #570: [MNG-7285] - Test showcasing regression

2021-10-07 Thread GitBox
mickaelistria commented on pull request #570: URL: https://github.com/apache/maven/pull/570#issuecomment-938393511 > this stopped working in 3.8.2, not 3.8.3, right? Yes. We just noticed it in 3.8.3 because some other issues prevented m2e from adopting 3.8.2. But the test does fail s

[jira] [Created] (SUREFIRE-1950) maven-surefire-plugin goes wrong with Junit-5.6.2

2021-10-07 Thread liang (Jira)
liang created SUREFIRE-1950: --- Summary: maven-surefire-plugin goes wrong with Junit-5.6.2 Key: SUREFIRE-1950 URL: https://issues.apache.org/jira/browse/SUREFIRE-1950 Project: Maven Surefire Issue Ty

[GitHub] [maven-install-plugin] cstamas closed pull request #14: Install At End, Variant 2

2021-10-07 Thread GitBox
cstamas closed pull request #14: URL: https://github.com/apache/maven-install-plugin/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[GitHub] [maven] famod commented on pull request #570: [MNG-7285] - Test showcasing regression

2021-10-07 Thread GitBox
famod commented on pull request #570: URL: https://github.com/apache/maven/pull/570#issuecomment-938180266 A few things: - this stopped working in 3.8.2, not 3.8.3, right? - this specific case would be fixed by #521 - but I don't think is exactly what happens in m2e because there ar

[GitHub] [maven-archetype] olamy merged pull request #79: Bump junit from 4.13.1 to 4.13.2

2021-10-07 Thread GitBox
olamy merged pull request #79: URL: https://github.com/apache/maven-archetype/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [maven-deploy-plugin] cstamas closed pull request #14: [MDEPLOY-280] Ability so skip specified classifiers from deploy

2021-10-07 Thread GitBox
cstamas closed pull request #14: URL: https://github.com/apache/maven-deploy-plugin/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

[GitHub] [maven-deploy-plugin] cstamas closed pull request #18: Update plugin

2021-10-07 Thread GitBox
cstamas closed pull request #18: URL: https://github.com/apache/maven-deploy-plugin/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

[GitHub] [maven-install-plugin] bmarwell commented on pull request #9: [MINSTALL-164] - Create GitHub Actions

2021-10-07 Thread GitBox
bmarwell commented on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937792838 @cstamas done. Do we want to update the JDKs? Do you need additional JDKs (like OpenJ9)? -- This is an automated message from the Apache Git Service. To resp

[GitHub] [maven-resolver] michael-o commented on a change in pull request #130: Updated Redisson and HZ doco

2021-10-07 Thread GitBox
michael-o commented on a change in pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#discussion_r724030140 ## File path: maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm ## @@ -31,12 +31,19 @@ Out of the box "redisson" (distributed) name

[GitHub] [maven-install-plugin] cstamas commented on pull request #14: Install At End, Variant 2

2021-10-07 Thread GitBox
cstamas commented on pull request #14: URL: https://github.com/apache/maven-install-plugin/pull/14#issuecomment-937529860 Superseded by https://github.com/apache/maven-install-plugin/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [maven] MartinKanters commented on pull request #566: [MNG-6762] Resolve .mvn/settings.xml relatively in multi module projects

2021-10-07 Thread GitBox
MartinKanters commented on pull request #566: URL: https://github.com/apache/maven/pull/566#issuecomment-937498369 I'm wondering whether that's worth the effort and potential overhead, rather than supporting both or either of the environment variable syntaxes in `maven.config` and then adj

[GitHub] [maven-resolver] michael-o commented on pull request #130: Updated Redisson and HZ doco

2021-10-07 Thread GitBox
michael-o commented on pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#issuecomment-937677949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [maven] slawekjaranowski commented on a change in pull request #568: MNG-7287 - Simplify assertion with simpler and equivalent calls.

2021-10-07 Thread GitBox
slawekjaranowski commented on a change in pull request #568: URL: https://github.com/apache/maven/pull/568#discussion_r724460160 ## File path: maven-artifact/src/test/java/org/apache/maven/artifact/versioning/VersionRangeTest.java ## @@ -753,6 +754,7 @@ public void testCache()

[GitHub] [maven-resolver] cstamas merged pull request #130: Updated Redisson and HZ doco

2021-10-07 Thread GitBox
cstamas merged pull request #130: URL: https://github.com/apache/maven-resolver/pull/130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [maven] slawekjaranowski commented on a change in pull request #570: [MNG-7285] - Test showcasing regression

2021-10-07 Thread GitBox
slawekjaranowski commented on a change in pull request #570: URL: https://github.com/apache/maven/pull/570#discussion_r724537513 ## File path: maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java ## @@ -43,6 +43,8 @@ import org.apache.maven.shared.utils.i

[GitHub] [maven-resolver] gnodet merged pull request #125: [MRESOLVER-204] Add a SessionData#computeIfAbsent method

2021-10-07 Thread GitBox
gnodet merged pull request #125: URL: https://github.com/apache/maven-resolver/pull/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[GitHub] [maven-resolver] cstamas commented on pull request #130: Updated Redisson and HZ doco

2021-10-07 Thread GitBox
cstamas commented on pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#issuecomment-937647249 @michael-o did you like the video? :wink: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-integration-testing] MartinKanters closed pull request #120: [MNG-6762] Test whether a settings.xml file can be referenced relatively to the .mvn directory instead of working directory

2021-10-07 Thread GitBox
MartinKanters closed pull request #120: URL: https://github.com/apache/maven-integration-testing/pull/120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [maven-install-plugin] cstamas commented on pull request #12: Update plugin

2021-10-07 Thread GitBox
cstamas commented on pull request #12: URL: https://github.com/apache/maven-install-plugin/pull/12#issuecomment-937581976 Superseded by https://github.com/apache/maven-install-plugin/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [maven-resolver] gnodet commented on pull request #125: [MRESOLVER-204] Add a SessionData#computeIfAbsent method

2021-10-07 Thread GitBox
gnodet commented on pull request #125: URL: https://github.com/apache/maven-resolver/pull/125#issuecomment-937554545 @michael-o @cstamas @rmannibucau can one of you create a version in JIRA for the next version, I can't create one as the fixVersion for the jira issue : https://issues.apach

[GitHub] [maven-resolver] michael-o commented on a change in pull request #131: File advisory locking based NamedLocks

2021-10-07 Thread GitBox
michael-o commented on a change in pull request #131: URL: https://github.com/apache/maven-resolver/pull/131#discussion_r724214698 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/FileLockNamedLockFactory.java ## @@ -0,0 +1,91

[GitHub] [maven-resolver] cstamas commented on a change in pull request #130: Updated Redisson and HZ doco

2021-10-07 Thread GitBox
cstamas commented on a change in pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#discussion_r724033873 ## File path: maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm ## @@ -31,12 +31,19 @@ Out of the box "redisson" (distributed) named

[GitHub] [maven] michael-o commented on pull request #570: [MNG-7285] - Test showcasing regression

2021-10-07 Thread GitBox
michael-o commented on pull request #570: URL: https://github.com/apache/maven/pull/570#issuecomment-938128652 @famod -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [maven-install-plugin] cstamas commented on pull request #13: Install At End, Variant 1

2021-10-07 Thread GitBox
cstamas commented on pull request #13: URL: https://github.com/apache/maven-install-plugin/pull/13#issuecomment-937529968 Superseded by https://github.com/apache/maven-install-plugin/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [maven-archetype] olamy merged pull request #76: Bump maven-invoker from 3.0.1 to 3.1.0

2021-10-07 Thread GitBox
olamy merged pull request #76: URL: https://github.com/apache/maven-archetype/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [maven-resolver] michael-o commented on pull request #125: [MRESOLVER-204] Add a SessionData#computeIfAbsent method

2021-10-07 Thread GitBox
michael-o commented on pull request #125: URL: https://github.com/apache/maven-resolver/pull/125#issuecomment-937560709 @gnodet Created. Go ahead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-resolver] cstamas commented on a change in pull request #131: File advisory locking based NamedLocks

2021-10-07 Thread GitBox
cstamas commented on a change in pull request #131: URL: https://github.com/apache/maven-resolver/pull/131#discussion_r724224501 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/FileLockNamedLockFactory.java ## @@ -0,0 +1,91 @@

[GitHub] [maven-deploy-plugin] cstamas commented on pull request #18: Update plugin

2021-10-07 Thread GitBox
cstamas commented on pull request #18: URL: https://github.com/apache/maven-deploy-plugin/pull/18#issuecomment-937583034 Superseded by https://github.com/apache/maven-deploy-plugin/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [maven-install-plugin] cstamas commented on pull request #9: [MINSTALL-164] - Create GitHub Actions

2021-10-07 Thread GitBox
cstamas commented on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937584306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [maven-install-plugin] cstamas commented on pull request #1: [MINSTALL-115] installAtEnd fails with multiple class realms

2021-10-07 Thread GitBox
cstamas commented on pull request #1: URL: https://github.com/apache/maven-install-plugin/pull/1#issuecomment-937530270 Check out https://github.com/apache/maven-install-plugin/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [maven-install-plugin] cstamas closed pull request #12: Update plugin

2021-10-07 Thread GitBox
cstamas closed pull request #12: URL: https://github.com/apache/maven-install-plugin/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[GitHub] [maven] mthmulders commented on a change in pull request #565: Mojo API update proposal

2021-10-07 Thread GitBox
mthmulders commented on a change in pull request #565: URL: https://github.com/apache/maven/pull/565#discussion_r724474642 ## File path: maven-core/src/main/java/org/apache/maven/plugin/internal/MojoLog.java ## @@ -22,24 +22,35 @@ import org.apache.maven.plugin.logging.Log;

[GitHub] [maven] famod edited a comment on pull request #570: [MNG-7285] - Test showcasing regression

2021-10-07 Thread GitBox
famod edited a comment on pull request #570: URL: https://github.com/apache/maven/pull/570#issuecomment-938180266 A few things: - this stopped working in 3.8.2, not 3.8.3, right? - this specific case would be fixed by #521 - but I don't think this is exactly what happens in m2e beca

[GitHub] [maven] gnodet commented on pull request #476: [MNG-7156] Parallel build can cause issues between clean and forked g…

2021-10-07 Thread GitBox
gnodet commented on pull request #476: URL: https://github.com/apache/maven/pull/476#issuecomment-937813747 > Cool, I think I saw some of issues while using mvnd that should be solved... Fwiw, it's not really urgent, as it has already been integrated into `mvnd` ... https://gi

[GitHub] [maven] cstamas commented on a change in pull request #476: [MNG-7156] Parallel build can cause issues between clean and forked g…

2021-10-07 Thread GitBox
cstamas commented on a change in pull request #476: URL: https://github.com/apache/maven/pull/476#discussion_r724151436 ## File path: maven-core/src/main/java/org/apache/maven/execution/LockingEventSpy.java ## @@ -0,0 +1,96 @@ +package org.apache.maven.execution; + +/* + * Lic

[GitHub] [maven-install-plugin] cstamas closed pull request #13: Install At End, Variant 1

2021-10-07 Thread GitBox
cstamas closed pull request #13: URL: https://github.com/apache/maven-install-plugin/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[GitHub] [maven-resolver] cstamas commented on a change in pull request #129: Update build plugins

2021-10-07 Thread GitBox
cstamas commented on a change in pull request #129: URL: https://github.com/apache/maven-resolver/pull/129#discussion_r724028309 ## File path: pom.xml ## @@ -366,16 +367,23 @@ + + org.apache.maven.plugins + maven-jxr

[GitHub] [maven-resolver] cstamas commented on a change in pull request #125: [MRESOLVER-204] Add a SessionData#computeIfAbsent method

2021-10-07 Thread GitBox
cstamas commented on a change in pull request #125: URL: https://github.com/apache/maven-resolver/pull/125#discussion_r723889022 ## File path: maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java ## @@ -81,4 +82,8 @@ public Object get( Object key )

[GitHub] [maven-resolver] rmannibucau commented on a change in pull request #125: [MRESOLVER-204] Add a SessionData#computeIfAbsent method

2021-10-07 Thread GitBox
rmannibucau commented on a change in pull request #125: URL: https://github.com/apache/maven-resolver/pull/125#discussion_r723880468 ## File path: maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java ## @@ -81,4 +82,8 @@ public Object get( Object key )

[GitHub] [maven-resolver] michael-o removed a comment on pull request #130: Updated Redisson and HZ doco

2021-10-07 Thread GitBox
michael-o removed a comment on pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#issuecomment-937677949 > > > @michael-o did you like the video? 😉 Which? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [maven-install-plugin] cstamas edited a comment on pull request #9: [MINSTALL-164] - Create GitHub Actions

2021-10-07 Thread GitBox
cstamas edited a comment on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937758742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [maven-resolver] gnodet commented on a change in pull request #125: [MRESOLVER-204] Add a SessionData#computeIfAbsent method

2021-10-07 Thread GitBox
gnodet commented on a change in pull request #125: URL: https://github.com/apache/maven-resolver/pull/125#discussion_r723887906 ## File path: maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java ## @@ -81,4 +82,8 @@ public Object get( Object key )

[GitHub] [maven-install-plugin] bmarwell merged pull request #9: [MINSTALL-164] - Create GitHub Actions

2021-10-07 Thread GitBox
bmarwell merged pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

[GitHub] [maven-install-plugin] slawekjaranowski commented on pull request #9: [MINSTALL-164] - Create GitHub Actions

2021-10-07 Thread GitBox
slawekjaranowski commented on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937889620 And I see it is another way for GA ... here be using build in containers ... -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [maven] famod edited a comment on pull request #570: [MNG-7285] - Test showcasing regression

2021-10-07 Thread GitBox
famod edited a comment on pull request #570: URL: https://github.com/apache/maven/pull/570#issuecomment-938180266 A few things: - this stopped working in 3.8.2, not 3.8.3, right? - this specific case would be fixed by #521 - but I don't think this is exactly what happens in m2e beca

[GitHub] [maven] famod commented on pull request #570: [MNG-7285] - Test showcasing regression

2021-10-07 Thread GitBox
famod commented on pull request #570: URL: https://github.com/apache/maven/pull/570#issuecomment-938180266 A few things: - this stopped working in 3.8.2, not 3.8.3, right? - this specific case would be fixed by #521 - but I don't think is exactly what happens in m2e because there ar

[GitHub] [maven] slawekjaranowski commented on a change in pull request #570: [MNG-7285] - Test showcasing regression

2021-10-07 Thread GitBox
slawekjaranowski commented on a change in pull request #570: URL: https://github.com/apache/maven/pull/570#discussion_r724537513 ## File path: maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java ## @@ -43,6 +43,8 @@ import org.apache.maven.shared.utils.i

[GitHub] [maven] michael-o commented on pull request #570: [MNG-7285] - Test showcasing regression

2021-10-07 Thread GitBox
michael-o commented on pull request #570: URL: https://github.com/apache/maven/pull/570#issuecomment-938128652 @famod -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[jira] [Commented] (MNG-7285) [Regression] MavenProject.getArtifacts() not returning correct value across multiple threads

2021-10-07 Thread Mickael Istria (Jira)
[ https://issues.apache.org/jira/browse/MNG-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425779#comment-17425779 ] Mickael Istria commented on MNG-7285: - PR at [https://github.com/apache/maven/pull/570]

[jira] [Updated] (MNG-7285) [Regression] MavenProject.getArtifacts() not returning correct value across multiple threads

2021-10-07 Thread Mickael Istria (Jira)
[ https://issues.apache.org/jira/browse/MNG-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Istria updated MNG-7285: Affects Version/s: 3.8.2 > [Regression] MavenProject.getArtifacts() not returning correct value acros

[GitHub] [maven] mickaelistria opened a new pull request #570: [MNG-7285 - Test showcasing regression

2021-10-07 Thread GitBox
mickaelistria opened a new pull request #570: URL: https://github.com/apache/maven/pull/570 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed f

[GitHub] [maven] mthmulders commented on a change in pull request #565: Mojo API update proposal

2021-10-07 Thread GitBox
mthmulders commented on a change in pull request #565: URL: https://github.com/apache/maven/pull/565#discussion_r724474642 ## File path: maven-core/src/main/java/org/apache/maven/plugin/internal/MojoLog.java ## @@ -22,24 +22,35 @@ import org.apache.maven.plugin.logging.Log;

[GitHub] [maven] slawekjaranowski commented on a change in pull request #568: MNG-7287 - Simplify assertion with simpler and equivalent calls.

2021-10-07 Thread GitBox
slawekjaranowski commented on a change in pull request #568: URL: https://github.com/apache/maven/pull/568#discussion_r724460160 ## File path: maven-artifact/src/test/java/org/apache/maven/artifact/versioning/VersionRangeTest.java ## @@ -753,6 +754,7 @@ public void testCache()

[jira] [Created] (MWRAPPER-14) Make maven wrapper functional

2021-10-07 Thread Jira
Tamás Cservenák created MWRAPPER-14: --- Summary: Make maven wrapper functional Key: MWRAPPER-14 URL: https://issues.apache.org/jira/browse/MWRAPPER-14 Project: Maven Wrapper Issue Type: Task

[GitHub] [maven] arturobernalg opened a new pull request #569: MNG-7288 - Remove redundant local variables.

2021-10-07 Thread GitBox
arturobernalg opened a new pull request #569: URL: https://github.com/apache/maven/pull/569 Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed f

[jira] [Assigned] (MNG-7287) Simplify assertion with simpler and equivalent calls.

2021-10-07 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise reassigned MNG-7287: Assignee: Karl Heinz Marbaise > Simplify assertion with simpler and equivalent calls

[jira] [Created] (MNG-7288) Remove redundant local variables

2021-10-07 Thread Arturo Bernal (Jira)
Arturo Bernal created MNG-7288: -- Summary: Remove redundant local variables Key: MNG-7288 URL: https://issues.apache.org/jira/browse/MNG-7288 Project: Maven Issue Type: Sub-task Repor

[GitHub] [maven] arturobernalg opened a new pull request #568: MNG-7287 - Simplify assertion with simpler and equivalent calls.

2021-10-07 Thread GitBox
arturobernalg opened a new pull request #568: URL: https://github.com/apache/maven/pull/568 Following this checklist to help us incorporate your contribution quickly and easily: - [X ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed

[jira] [Created] (MNG-7287) Simplify assertion with simpler and equivalent calls.

2021-10-07 Thread Arturo Bernal (Jira)
Arturo Bernal created MNG-7287: -- Summary: Simplify assertion with simpler and equivalent calls. Key: MNG-7287 URL: https://issues.apache.org/jira/browse/MNG-7287 Project: Maven Issue Type: Sub-t

[jira] [Created] (MNG-7286) Improvements:

2021-10-07 Thread Arturo Bernal (Jira)
Arturo Bernal created MNG-7286: -- Summary: Improvements: Key: MNG-7286 URL: https://issues.apache.org/jira/browse/MNG-7286 Project: Maven Issue Type: Improvement Reporter: Arturo Bern

[GitHub] [maven-install-plugin] cstamas commented on pull request #9: [MINSTALL-164] - Create GitHub Actions

2021-10-07 Thread GitBox
cstamas commented on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937895491 Cool, thanks! @slawekjaranowski @bmarwell am fine, I really just wanted to have ITs run here as well. But we started a discussion on ML to do this for all repos

[GitHub] [maven-install-plugin] slawekjaranowski commented on pull request #9: [MINSTALL-164] - Create GitHub Actions

2021-10-07 Thread GitBox
slawekjaranowski commented on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937889620 And I see it is another way for GA ... here be using build in containers ... -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [maven-resolver] cstamas commented on a change in pull request #131: File advisory locking based NamedLocks

2021-10-07 Thread GitBox
cstamas commented on a change in pull request #131: URL: https://github.com/apache/maven-resolver/pull/131#discussion_r724233857 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/FileLockNamedLockFactory.java ## @@ -0,0 +1,91 @@

[GitHub] [maven-resolver] cstamas commented on a change in pull request #131: File advisory locking based NamedLocks

2021-10-07 Thread GitBox
cstamas commented on a change in pull request #131: URL: https://github.com/apache/maven-resolver/pull/131#discussion_r724226914 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/FileLockNamedLockFactory.java ## @@ -0,0 +1,91 @@

[GitHub] [maven-resolver] cstamas commented on a change in pull request #131: File advisory locking based NamedLocks

2021-10-07 Thread GitBox
cstamas commented on a change in pull request #131: URL: https://github.com/apache/maven-resolver/pull/131#discussion_r724225265 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/FileLockNamedLockFactory.java ## @@ -0,0 +1,91 @@

[GitHub] [maven-resolver] cstamas commented on a change in pull request #131: File advisory locking based NamedLocks

2021-10-07 Thread GitBox
cstamas commented on a change in pull request #131: URL: https://github.com/apache/maven-resolver/pull/131#discussion_r724224501 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/FileLockNamedLockFactory.java ## @@ -0,0 +1,91 @@

[GitHub] [maven-resolver] michael-o commented on a change in pull request #131: File advisory locking based NamedLocks

2021-10-07 Thread GitBox
michael-o commented on a change in pull request #131: URL: https://github.com/apache/maven-resolver/pull/131#discussion_r724214698 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/FileLockNamedLockFactory.java ## @@ -0,0 +1,91

[GitHub] [maven] gnodet commented on pull request #476: [MNG-7156] Parallel build can cause issues between clean and forked g…

2021-10-07 Thread GitBox
gnodet commented on pull request #476: URL: https://github.com/apache/maven/pull/476#issuecomment-937813747 > Cool, I think I saw some of issues while using mvnd that should be solved... Fwiw, it's not really urgent, as it has already been integrated into `mvnd` ... https://gi

[GitHub] [maven-resolver] cstamas opened a new pull request #131: File advisory locking based NamedLocks

2021-10-07 Thread GitBox
cstamas opened a new pull request #131: URL: https://github.com/apache/maven-resolver/pull/131 This PR returns the removed FileNamedLocks from original PR and will try to make them work as expected. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-install-plugin] bmarwell commented on pull request #9: [MINSTALL-164] - Create GitHub Actions

2021-10-07 Thread GitBox
bmarwell commented on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937792838 @cstamas done. Do we want to update the JDKs? Do you need additional JDKs (like OpenJ9)? -- This is an automated message from the Apache Git Service. To resp

[GitHub] [maven-install-plugin] bmarwell merged pull request #9: [MINSTALL-164] - Create GitHub Actions

2021-10-07 Thread GitBox
bmarwell merged pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

[jira] [Comment Edited] (MCHECKSTYLE-406) Make plugin compatible with Checkstyle 8.44

2021-10-07 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425536#comment-17425536 ] Alexander Kriegisch edited comment on MCHECKSTYLE-406 at 10/7/21, 12:55 PM: --

[jira] [Comment Edited] (MCHECKSTYLE-406) Make plugin compatible with Checkstyle 8.44

2021-10-07 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425536#comment-17425536 ] Alexander Kriegisch edited comment on MCHECKSTYLE-406 at 10/7/21, 12:54 PM: --

[GitHub] [maven] cstamas commented on a change in pull request #476: [MNG-7156] Parallel build can cause issues between clean and forked g…

2021-10-07 Thread GitBox
cstamas commented on a change in pull request #476: URL: https://github.com/apache/maven/pull/476#discussion_r724151436 ## File path: maven-core/src/main/java/org/apache/maven/execution/LockingEventSpy.java ## @@ -0,0 +1,96 @@ +package org.apache.maven.execution; + +/* + * Lic

[jira] [Commented] (MCHECKSTYLE-406) Make plugin compatible with Checkstyle 8.44

2021-10-07 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425536#comment-17425536 ] Alexander Kriegisch commented on MCHECKSTYLE-406: - When Shared Resou

[GitHub] [maven-pdf-plugin] dependabot[bot] opened a new pull request #12: Bump mavenVersion from 3.1.1 to 3.8.3

2021-10-07 Thread GitBox
dependabot[bot] opened a new pull request #12: URL: https://github.com/apache/maven-pdf-plugin/pull/12 Bumps `mavenVersion` from 3.1.1 to 3.8.3. Updates `maven-core` from 3.1.1 to 3.8.3 Commits https://github.com/apache/maven/commit/ff8e977a158738155dc465c6a97ffaf31982d739";

[jira] [Commented] (MSHARED-990) Checkstyle config: Swap scope and exclude scope to access modifier in the check JavadocMethodCheck.

2021-10-07 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425535#comment-17425535 ] Alexander Kriegisch commented on MSHARED-990: - I hope the current release vo

[GitHub] [maven-install-plugin] cstamas edited a comment on pull request #9: [MINSTALL-164] - Create GitHub Actions

2021-10-07 Thread GitBox
cstamas edited a comment on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937758742 @aheritier ASF Jenkins is still the "source of truth", OTOH GH Actions: * gives amazingly fast builds (well, off US office hours at least) * gives feedback ab

[GitHub] [maven-install-plugin] cstamas edited a comment on pull request #9: [MINSTALL-164] - Create GitHub Actions

2021-10-07 Thread GitBox
cstamas edited a comment on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937758742 @aheritier ASF Jenkins is still the "source of truth", OTOH GH Actions: * gives amazingly fast builds (well, off US office hours at least) * gives feedback ab

[GitHub] [maven-install-plugin] cstamas edited a comment on pull request #9: [MINSTALL-164] - Create GitHub Actions

2021-10-07 Thread GitBox
cstamas edited a comment on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937758742 @aheritier ASF Jenkins is still the "source of truth", OTOH GH Actions: * gives amazingly fast builds (well, off US office hours at least) * gives feedback ab

[GitHub] [maven-install-plugin] cstamas commented on pull request #9: [MINSTALL-164] - Create GitHub Actions

2021-10-07 Thread GitBox
cstamas commented on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937758742 @aheritier ASF Jenkins is still the "source of truth", OTOH GH Actions: * gives amazingly fast builds (well, off US office hours at least) * gives feedback about "fu

[GitHub] [maven-plugin-testing] cstamas opened a new pull request #19: Get rid of warnings, cleanup

2021-10-07 Thread GitBox
cstamas opened a new pull request #19: URL: https://github.com/apache/maven-plugin-testing/pull/19 Changes: * get rid of unused Plexus XML and properties * sligh updates * use jar-no-fork * remove prerequisite, this is not a maven-plugin -- This is an automated message from th

[GitHub] [maven-deploy-plugin] cstamas closed pull request #14: [MDEPLOY-280] Ability so skip specified classifiers from deploy

2021-10-07 Thread GitBox
cstamas closed pull request #14: URL: https://github.com/apache/maven-deploy-plugin/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

[GitHub] [maven-resolver] cstamas merged pull request #130: Updated Redisson and HZ doco

2021-10-07 Thread GitBox
cstamas merged pull request #130: URL: https://github.com/apache/maven-resolver/pull/130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [maven-resolver] michael-o commented on pull request #130: Updated Redisson and HZ doco

2021-10-07 Thread GitBox
michael-o commented on pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#issuecomment-937678715 > > > @michael-o did you like the video? 😉 I never understood Monty Python -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-resolver] michael-o removed a comment on pull request #130: Updated Redisson and HZ doco

2021-10-07 Thread GitBox
michael-o removed a comment on pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#issuecomment-937677949 > > > @michael-o did you like the video? 😉 Which? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [maven-resolver] michael-o commented on pull request #130: Updated Redisson and HZ doco

2021-10-07 Thread GitBox
michael-o commented on pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#issuecomment-937677949 > > > @michael-o did you like the video? 😉 Which? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [maven-archetype] olamy merged pull request #79: Bump junit from 4.13.1 to 4.13.2

2021-10-07 Thread GitBox
olamy merged pull request #79: URL: https://github.com/apache/maven-archetype/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [maven-archetype] olamy merged pull request #76: Bump maven-invoker from 3.0.1 to 3.1.0

2021-10-07 Thread GitBox
olamy merged pull request #76: URL: https://github.com/apache/maven-archetype/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[jira] [Commented] (MENFORCER-393) Upgrading to 3.0.0 causes `Could not build dependency tree` with repositories some unknown protocol

2021-10-07 Thread Quentin Caillard (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425464#comment-17425464 ] Quentin Caillard commented on MENFORCER-393: I have this message when upgr

[GitHub] [maven-resolver] cstamas commented on pull request #130: Updated Redisson and HZ doco

2021-10-07 Thread GitBox
cstamas commented on pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#issuecomment-937647249 @michael-o did you like the video? :wink: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-resolver] cstamas commented on a change in pull request #130: Updated Redisson and HZ doco

2021-10-07 Thread GitBox
cstamas commented on a change in pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#discussion_r724033997 ## File path: maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm ## @@ -31,12 +31,19 @@ Out of the box "redisson" (distributed) named

[GitHub] [maven-resolver] cstamas commented on a change in pull request #130: Updated Redisson and HZ doco

2021-10-07 Thread GitBox
cstamas commented on a change in pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#discussion_r724033873 ## File path: maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm ## @@ -31,12 +31,19 @@ Out of the box "redisson" (distributed) named

[GitHub] [maven-resolver] michael-o commented on a change in pull request #130: Updated Redisson and HZ doco

2021-10-07 Thread GitBox
michael-o commented on a change in pull request #130: URL: https://github.com/apache/maven-resolver/pull/130#discussion_r724030140 ## File path: maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm ## @@ -31,12 +31,19 @@ Out of the box "redisson" (distributed) name

[GitHub] [maven-resolver] cstamas commented on a change in pull request #129: Update build plugins

2021-10-07 Thread GitBox
cstamas commented on a change in pull request #129: URL: https://github.com/apache/maven-resolver/pull/129#discussion_r724028309 ## File path: pom.xml ## @@ -366,16 +367,23 @@ + + org.apache.maven.plugins + maven-jxr

[jira] [Commented] (MJAVADOC-693) NPE if URL is not defined in a dependency

2021-10-07 Thread Roberto Benedetti (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425448#comment-17425448 ] Roberto Benedetti commented on MJAVADOC-693: I tried the latest snapshot an

[GitHub] [maven-resolver] cstamas opened a new pull request #130: Updated Redisson and HZ doco

2021-10-07 Thread GitBox
cstamas opened a new pull request #130: URL: https://github.com/apache/maven-resolver/pull/130 Make it clear that "it only works with Sisu" is meant for integrators, not "end users" wishing to use them with Maven. -- This is an automated message from the Apache Git Service. To respond

[jira] [Closed] (MRESOLVER-204) Add a SessionData#computeIfAbsent method

2021-10-07 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MRESOLVER-204. - Resolution: Fixed > Add a SessionData#computeIfAbsent method > ---

[GitHub] [maven-install-plugin] cstamas commented on pull request #9: [MINSTALL-164] - Create GitHub Actions

2021-10-07 Thread GitBox
cstamas commented on pull request #9: URL: https://github.com/apache/maven-install-plugin/pull/9#issuecomment-937584306 Pls pls merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-deploy-plugin] cstamas commented on pull request #18: Update plugin

2021-10-07 Thread GitBox
cstamas commented on pull request #18: URL: https://github.com/apache/maven-deploy-plugin/pull/18#issuecomment-937583034 Superseded by https://github.com/apache/maven-deploy-plugin/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log

  1   2   >