slawekjaranowski commented on a change in pull request #568:
URL: https://github.com/apache/maven/pull/568#discussion_r724460160
##########
File path:
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/VersionRangeTest.java
##########
@@ -753,6 +754,7 @@ public void testCache()
restrictions = version.getRestrictions();
assertEquals( 0, restrictions.size(), CHECK_NUM_RESTRICTIONS );
- assertFalse( spec.equals( version ), "check
!VersionRange.createFromVersionSpec(x).equals(VersionRange.createFromVersion(x))"
);
+ assertNotEquals( spec, version,
+ "check
!VersionRange.createFromVersionSpec(x).equals(VersionRange.createFromVersion(x))"
);
Review comment:
`equals` test
##########
File path:
maven-compat/src/test/java/org/apache/maven/project/inheritance/t06/ProjectInheritanceTest.java
##########
@@ -71,15 +71,14 @@ public void testDependencyManagement()
assertNotNull( set, "No artifacts" );
assertTrue( set.size() > 0, "No Artifacts" );
Iterator iter = set.iterator();
- assertTrue( set.size() == 4, "Set size should be 4, is " + set.size()
);
+ assertEquals( 4, set.size(), "Set size should be 4, is " + set.size()
);
while ( iter.hasNext() )
{
Artifact artifact = (Artifact) iter.next();
System.out.println( "Artifact: " +
artifact.getDependencyConflictId() + " " + artifact.getVersion()
+ " Optional=" + ( artifact.isOptional() ? "true" : "false" ) );
- assertTrue( artifact.getVersion().equals( "1.0" ),
- "Incorrect version for " +
artifact.getDependencyConflictId() );
+ assertEquals( "1.0", artifact.getVersion(), "Incorrect version for
" + artifact.getDependencyConflictId() );
Review comment:
equals test
##########
File path:
maven-compat/src/test/java/org/apache/maven/project/inheritance/t07/ProjectInheritanceTest.java
##########
@@ -70,19 +71,18 @@ public void testDependencyManagement()
Set set = project1.getArtifacts();
assertNotNull( set, "No artifacts" );
assertTrue( set.size() > 0, "No Artifacts" );
- assertTrue( set.size() == 3, "Set size should be 3, is " + set.size()
);
+ assertEquals( 3, set.size(), "Set size should be 3, is " + set.size()
);
for ( Object aSet : set )
{
Artifact artifact = (Artifact) aSet;
- assertFalse( artifact.getArtifactId().equals( "t07-d" ) );
+ assertNotEquals( "t07-d", artifact.getArtifactId() );
Review comment:
equals test
##########
File path:
maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/OrArtifactFilterTest.java
##########
@@ -47,12 +48,12 @@ public void testEquals()
OrArtifactFilter filter2 = new OrArtifactFilter( Arrays.asList(
newSubFilter() ) );
- assertFalse( filter1.equals( null ) );
- assertTrue( filter1.equals( filter1 ) );
+ assertNotEquals( null, filter1 );
+ assertEquals( filter1, filter1 );
assertEquals( filter1.hashCode(), filter1.hashCode() );
- assertFalse( filter1.equals( filter2 ) );
- assertFalse( filter2.equals( filter1 ) );
+ assertNotEquals( filter1, filter2 );
+ assertNotEquals( filter2, filter1 );
Review comment:
equals test
##########
File path:
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/DefaultArtifactVersionTest.java
##########
@@ -189,20 +190,20 @@ public void testHashCode()
{
ArtifactVersion v1 = newArtifactVersion( "1" );
ArtifactVersion v2 = newArtifactVersion( "1.0" );
- assertEquals( true, v1.equals( v2 ) );
+ assertTrue( v1.equals( v2 ) );
assertEquals( v1.hashCode(), v2.hashCode() );
}
@Test
public void testEqualsNullSafe()
{
- assertFalse( newArtifactVersion( "1" ).equals( null ) );
+ assertNotEquals( null, newArtifactVersion( "1" ) );
}
@Test
public void testEqualsTypeSafe()
{
- assertFalse( newArtifactVersion( "1" ).equals(
"non-an-artifact-version-instance" ) );
+ assertNotEquals( "non-an-artifact-version-instance",
newArtifactVersion( "1" ) );
Review comment:
the same show what we want to test
##########
File path:
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/DefaultArtifactVersionTest.java
##########
@@ -189,20 +190,20 @@ public void testHashCode()
{
ArtifactVersion v1 = newArtifactVersion( "1" );
ArtifactVersion v2 = newArtifactVersion( "1.0" );
- assertEquals( true, v1.equals( v2 ) );
+ assertTrue( v1.equals( v2 ) );
assertEquals( v1.hashCode(), v2.hashCode() );
}
@Test
public void testEqualsNullSafe()
{
- assertFalse( newArtifactVersion( "1" ).equals( null ) );
+ assertNotEquals( null, newArtifactVersion( "1" ) );
Review comment:
in this case `assertFalse` is more readable, we want to test `equals`
original assertions show what we want to do in new `equals` method is called
somewhere in `assertNotEquals`
##########
File path:
maven-compat/src/test/java/org/apache/maven/project/inheritance/t05/ProjectInheritanceTest.java
##########
@@ -76,8 +76,7 @@ public void testDependencyManagement()
System.out.println(
"Artifact: " + artifact.getDependencyConflictId() + " " +
artifact.getVersion() + " Scope: "
+ artifact.getScope() );
- assertTrue( artifact.getVersion().equals( "1.0" ),
- "Incorrect version for " +
artifact.getDependencyConflictId() );
+ assertEquals( "1.0", artifact.getVersion(), "Incorrect version for
" + artifact.getDependencyConflictId() );
Review comment:
equals test
##########
File path:
maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/OrArtifactFilterTest.java
##########
@@ -47,12 +48,12 @@ public void testEquals()
OrArtifactFilter filter2 = new OrArtifactFilter( Arrays.asList(
newSubFilter() ) );
- assertFalse( filter1.equals( null ) );
- assertTrue( filter1.equals( filter1 ) );
+ assertNotEquals( null, filter1 );
+ assertEquals( filter1, filter1 );
Review comment:
equals test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
