[jira] [Resolved] (MNG-7278) Drop use of Plexus Logger in Maven Core

2021-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák resolved MNG-7278. -- Resolution: Fixed > Drop use of Plexus Logger in Maven Core > ---

[jira] [Closed] (MNG-7278) Drop use of Plexus Logger in Maven Core

2021-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák closed MNG-7278. > Drop use of Plexus Logger in Maven Core > --- > > K

[GitHub] [maven] cstamas merged pull request #562: [MNG-7278] Clean up core logging

2021-10-02 Thread GitBox
cstamas merged pull request #562: URL: https://github.com/apache/maven/pull/562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (MNG-6762) Multimodule project with .mvn/settings.xml not working properly

2021-10-02 Thread Martin Kanters (Jira)
[ https://issues.apache.org/jira/browse/MNG-6762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423578#comment-17423578 ] Martin Kanters commented on MNG-6762: - [~anatoly.zaretsky] I like your idea. It's also

[GitHub] [maven-integration-testing] khmarbaise commented on pull request #113: MNG-7232 - Make final variable when is possible.

2021-10-02 Thread GitBox
khmarbaise commented on pull request #113: URL: https://github.com/apache/maven-integration-testing/pull/113#issuecomment-932769955 Ok lets us take a deeper look... adding `final` for all the cases where class ends with `Mojo` because that are parameters of plugins which are annotated wit

[jira] [Commented] (MNG-6898) Convert DefaultLifecyclePluginAnalyzer to JSR 330

2021-10-02 Thread Joseph Walton (Jira)
[ https://issues.apache.org/jira/browse/MNG-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423545#comment-17423545 ] Joseph Walton commented on MNG-6898: Thanks for fixing this, [~cstamas]; having one fil

[GitHub] [maven-integration-testing] arturobernalg commented on pull request #113: MNG-7232 - Make final variable when is possible.

2021-10-02 Thread GitBox
arturobernalg commented on pull request #113: URL: https://github.com/apache/maven-integration-testing/pull/113#issuecomment-932764180 > Hm... The `DefaultStatefulSingleton` it makes no sense to define the property `final` because the attribute itself is not given outside...it will not pr

[jira] [Closed] (MNG-6898) Convert DefaultLifecyclePluginAnalyzer to JSR 330

2021-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák closed MNG-6898. > Convert DefaultLifecyclePluginAnalyzer to JSR 330 > - >

[jira] [Resolved] (MNG-6898) Convert DefaultLifecyclePluginAnalyzer to JSR 330

2021-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák resolved MNG-6898. -- Fix Version/s: 4.0.0-alpha-1 Assignee: Tamás Cservenák Resolution: Fixed > Conver

[jira] [Updated] (MNG-7055) Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into maven-metadata.xml

2021-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MNG-7055: - Fix Version/s: 4.0.0-alpha-1 > Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information in

[jira] [Updated] (MNG-7279) Drop PluginParameterExpressionEvaluator deprecated ctor

2021-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MNG-7279: - Fix Version/s: 4.0.x-candidate > Drop PluginParameterExpressionEvaluator deprecated ctor >

[jira] [Updated] (MNG-7280) Refactor DefaultToolchainManager and DefaultToolchainManagerPrivate

2021-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MNG-7280: - Fix Version/s: 4.0.x-candidate > Refactor DefaultToolchainManager and DefaultToolchainManagerPrivat

[jira] [Updated] (MNG-7280) Refactor DefaultToolchainManager and DefaultToolchainManagerPrivate

2021-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MNG-7280: - Description: Component extending Component is bad practice. Obviously they need common ancestor.

[jira] [Created] (MNG-7280) Refactor DefaultToolchainManager and DefaultToolchainManagerPrivate

2021-10-02 Thread Jira
Tamás Cservenák created MNG-7280: Summary: Refactor DefaultToolchainManager and DefaultToolchainManagerPrivate Key: MNG-7280 URL: https://issues.apache.org/jira/browse/MNG-7280 Project: Maven

[GitHub] [maven] cstamas commented on a change in pull request #562: [MNG-7278] Clean up core logging

2021-10-02 Thread GitBox
cstamas commented on a change in pull request #562: URL: https://github.com/apache/maven/pull/562#discussion_r720685731 ## File path: maven-core/src/main/java/org/apache/maven/toolchain/DefaultToolchainManager.java ## @@ -43,14 +46,24 @@ public class DefaultToolchainManager

[GitHub] [maven-enforcer] slachiewicz merged pull request #112: Bump extra-enforcer-rules from 1.3 to 1.4

2021-10-02 Thread GitBox
slachiewicz merged pull request #112: URL: https://github.com/apache/maven-enforcer/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[jira] [Updated] (MNG-7279) Drop PluginParameterExpressionEvaluator deprecated ctor

2021-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MNG-7279: - Description: The ctor {{org.apache.maven.plugin.PluginParameterExpressionEvaluator#PluginParameter

[GitHub] [maven] cstamas commented on a change in pull request #562: [MNG-7278] Clean up core logging

2021-10-02 Thread GitBox
cstamas commented on a change in pull request #562: URL: https://github.com/apache/maven/pull/562#discussion_r720685267 ## File path: maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java ## @@ -85,9 +84,9 @@ private Properties propert

[jira] [Created] (MNG-7279) Drop PluginParameterExpressionEvaluator deprecated ctor

2021-10-02 Thread Jira
Tamás Cservenák created MNG-7279: Summary: Drop PluginParameterExpressionEvaluator deprecated ctor Key: MNG-7279 URL: https://issues.apache.org/jira/browse/MNG-7279 Project: Maven Issue Type:

[GitHub] [maven-integration-testing] khmarbaise commented on pull request #113: MNG-7232 - Make final variable when is possible.

2021-10-02 Thread GitBox
khmarbaise commented on pull request #113: URL: https://github.com/apache/maven-integration-testing/pull/113#issuecomment-932759976 Hm... The `DefaultStatefulSingleton` it makes no sense to define the property `final` because the attribute itself is not given outside...it will not prevent

[jira] [Closed] (MENFORCER-392) Upgrading to Maven Enforcer 3.0.0 results in java.lang.NoSuchMethodError

2021-10-02 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MENFORCER-392. -- Resolution: Resolved > Upgrading to Maven Enforcer 3.0.0 results in java.lan

[GitHub] [maven] cstamas commented on a change in pull request #562: [MNG-7278] Clean up core logging

2021-10-02 Thread GitBox
cstamas commented on a change in pull request #562: URL: https://github.com/apache/maven/pull/562#discussion_r720684321 ## File path: maven-core/src/main/java/org/apache/maven/toolchain/DefaultToolchainManager.java ## @@ -43,14 +46,24 @@ public class DefaultToolchainManager

[GitHub] [maven] cstamas commented on a change in pull request #562: [MNG-7278] Clean up core logging

2021-10-02 Thread GitBox
cstamas commented on a change in pull request #562: URL: https://github.com/apache/maven/pull/562#discussion_r720683762 ## File path: maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuildingHelper.java ## @@ -67,24 +68,21 @@ public class DefaultProjectBuilding

[GitHub] [maven] cstamas commented on a change in pull request #562: [MNG-7278] Clean up core logging

2021-10-02 Thread GitBox
cstamas commented on a change in pull request #562: URL: https://github.com/apache/maven/pull/562#discussion_r720683592 ## File path: maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java ## @@ -85,9 +84,9 @@ private Properties propert

[GitHub] [maven] cstamas merged pull request #554: [MNG-6898] Drop plexus-component-metadata plugin from maven-core

2021-10-02 Thread GitBox
cstamas merged pull request #554: URL: https://github.com/apache/maven/pull/554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Closed] (MNG-7055) Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into maven-metadata.xml

2021-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák closed MNG-7055. > Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into > maven-metadata.xml >

[jira] [Assigned] (MNG-7055) Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into maven-metadata.xml

2021-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák reassigned MNG-7055: Assignee: Tamás Cservenák > Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin informatio

[jira] [Resolved] (MNG-7055) Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into maven-metadata.xml

2021-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák resolved MNG-7055. -- Resolution: Fixed > Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into > mav

[GitHub] [maven] cstamas merged pull request #555: [MNG-7055] Fix G level metadata handling

2021-10-02 Thread GitBox
cstamas merged pull request #555: URL: https://github.com/apache/maven/pull/555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [maven-archetype] slachiewicz merged pull request #70: Bump maven-jetty-plugin from 6.1.6 to 6.1.26

2021-10-02 Thread GitBox
slachiewicz merged pull request #70: URL: https://github.com/apache/maven-archetype/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

[GitHub] [maven-jlink-plugin] dependabot[bot] commented on pull request #66: Bump maven-enforcer-plugin from 3.0.0-M3 to 3.0.0

2021-10-02 Thread GitBox
dependabot[bot] commented on pull request #66: URL: https://github.com/apache/maven-jlink-plugin/pull/66#issuecomment-932747155 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or m

[GitHub] [maven-jlink-plugin] slachiewicz closed pull request #66: Bump maven-enforcer-plugin from 3.0.0-M3 to 3.0.0

2021-10-02 Thread GitBox
slachiewicz closed pull request #66: URL: https://github.com/apache/maven-jlink-plugin/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: iss

[GitHub] [maven-jlink-plugin] slachiewicz merged pull request #64: Bump commons-io from 2.10.0 to 2.11.0

2021-10-02 Thread GitBox
slachiewicz merged pull request #64: URL: https://github.com/apache/maven-jlink-plugin/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: iss

[GitHub] [maven-jlink-plugin] slachiewicz merged pull request #74: Bump assertj-core from 3.20.2 to 3.21.0

2021-10-02 Thread GitBox
slachiewicz merged pull request #74: URL: https://github.com/apache/maven-jlink-plugin/pull/74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: iss

[GitHub] [maven-jlink-plugin] slachiewicz merged pull request #68: Bump plexus-java from 1.0.6 to 1.1.0

2021-10-02 Thread GitBox
slachiewicz merged pull request #68: URL: https://github.com/apache/maven-jlink-plugin/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: iss

[GitHub] [maven-jlink-plugin] slachiewicz merged pull request #70: Bump mockito-core from 3.10.0 to 3.12.4

2021-10-02 Thread GitBox
slachiewicz merged pull request #70: URL: https://github.com/apache/maven-jlink-plugin/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: iss

[GitHub] [maven-jlink-plugin] slachiewicz merged pull request #75: Bump junit-bom from 5.7.2 to 5.8.1

2021-10-02 Thread GitBox
slachiewicz merged pull request #75: URL: https://github.com/apache/maven-jlink-plugin/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: iss

[jira] [Comment Edited] (MNG-7277) Remove useless Test - testNonNumericVersionRepresentationReturnsANumberFormatException

2021-10-02 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423262#comment-17423262 ] Karl Heinz Marbaise edited comment on MNG-7277 at 10/2/21, 12:41 PM:

[jira] [Closed] (MNG-7272) Code Improvement - II

2021-10-02 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MNG-7272. Resolution: Done > Code Improvement - II > - > > Key: MNG

[jira] [Commented] (MNG-7272) Code Improvement - II

2021-10-02 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423517#comment-17423517 ] Karl Heinz Marbaise commented on MNG-7272: -- Done in [71a0a49904dcfa2427b72e0b3d0e9

[GitHub] [maven] asfgit merged pull request #558: [MNG-7272] - Code Improvement - II

2021-10-02 Thread GitBox
asfgit merged pull request #558: URL: https://github.com/apache/maven/pull/558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [maven-remote-resources-plugin] slachiewicz commented on pull request #4: Upgrade to maven 3.x and avoid using deprecated API

2021-10-02 Thread GitBox
slachiewicz commented on pull request #4: URL: https://github.com/apache/maven-remote-resources-plugin/pull/4#issuecomment-932737457 it will also (at some time) effectively bump minimum maven for apache-maven parent pom: https://github.com/apache/maven-apache-parent/blob/01d2517a3d8e30227

[jira] [Commented] (MJAVADOC-669) Generated javadoc JARs contain jQuery and other MIT-licenced works without reproducing a copy of the MIT licence, same for GPL-licenced works

2021-10-02 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423505#comment-17423505 ] Sylwester Lachiewicz commented on MJAVADOC-669: --- 8259530: Generated docs

[jira] [Updated] (MJAVADOC-689) When I run "javadoc:fix" , I get an error .

2021-10-02 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MJAVADOC-689: -- Fix Version/s: 3.3.2 > When I run "javadoc:fix" , I get an error . >

[jira] [Closed] (MJAVADOC-693) NPE if URL is not defined in a dependency

2021-10-02 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MJAVADOC-693. - Resolution: Fixed > NPE if URL is not defined in a dependency > ---

[jira] [Commented] (MJAVADOC-693) NPE if URL is not defined in a dependency

2021-10-02 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423502#comment-17423502 ] Sylwester Lachiewicz commented on MJAVADOC-693: --- Fixed with [24d2533e848

[jira] [Assigned] (MJAVADOC-693) NPE if URL is not defined in a dependency

2021-10-02 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MJAVADOC-693: - Assignee: Sylwester Lachiewicz > NPE if URL is not defined in a depend

[jira] [Commented] (MJAVADOC-693) NPE if URL is not defined in a dependency

2021-10-02 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423501#comment-17423501 ] Sylwester Lachiewicz commented on MJAVADOC-693: --- I think I found the same

[jira] [Updated] (MJAVADOC-693) NPE if URL is not defined in a dependency

2021-10-02 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MJAVADOC-693: -- Fix Version/s: 3.3.2 > NPE if URL is not defined in a dependency > --

[GitHub] [maven-release] dependabot[bot] commented on pull request #72: Bump aether-connector-wagon from 1.7 to 1.13.1

2021-10-02 Thread GitBox
dependabot[bot] commented on pull request #72: URL: https://github.com/apache/maven-release/pull/72#issuecomment-932731058 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [maven-release] slachiewicz closed pull request #72: Bump aether-connector-wagon from 1.7 to 1.13.1

2021-10-02 Thread GitBox
slachiewicz closed pull request #72: URL: https://github.com/apache/maven-release/pull/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

[GitHub] [maven-release] slachiewicz merged pull request #73: Bump maven-plugin-plugin from 3.6.0 to 3.6.1

2021-10-02 Thread GitBox
slachiewicz merged pull request #73: URL: https://github.com/apache/maven-release/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

[GitHub] [maven-release] slachiewicz merged pull request #71: Bump xmlunit-core from 2.6.4 to 2.8.2

2021-10-02 Thread GitBox
slachiewicz merged pull request #71: URL: https://github.com/apache/maven-release/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

[GitHub] [maven-remote-resources-plugin] gnodet merged pull request #4: Upgrade to maven 3.x and avoid using deprecated API

2021-10-02 Thread GitBox
gnodet merged pull request #4: URL: https://github.com/apache/maven-remote-resources-plugin/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-remote-resources-plugin] gnodet commented on pull request #4: Upgrade to maven 3.x and avoid using deprecated API

2021-10-02 Thread GitBox
gnodet commented on pull request #4: URL: https://github.com/apache/maven-remote-resources-plugin/pull/4#issuecomment-932729027 > Personally I see this as a proof that our baseline of 3.1.1 is simply wrong/broken idea. > > I am +1 on this change, but we should reconcile what is the

[GitHub] [maven] gnodet commented on pull request #440: Remove ServiceLocator and Service

2021-10-02 Thread GitBox
gnodet commented on pull request #440: URL: https://github.com/apache/maven/pull/440#issuecomment-932728642 Closing as #547 has been merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven] gnodet closed pull request #440: Remove ServiceLocator and Service

2021-10-02 Thread GitBox
gnodet closed pull request #440: URL: https://github.com/apache/maven/pull/440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [maven] gnodet merged pull request #547: [MNG-5577] Use constructor injection and remove the use of @Component

2021-10-02 Thread GitBox
gnodet merged pull request #547: URL: https://github.com/apache/maven/pull/547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [maven-release] slachiewicz commented on pull request #71: Bump xmlunit-core from 2.6.4 to 2.8.2

2021-10-02 Thread GitBox
slachiewicz commented on pull request #71: URL: https://github.com/apache/maven-release/pull/71#issuecomment-932726303 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [maven] gnodet commented on pull request #547: [MNG-5577] Use constructor injection and remove the use of @Component

2021-10-02 Thread GitBox
gnodet commented on pull request #547: URL: https://github.com/apache/maven/pull/547#issuecomment-932725928 > @gnodet please make sure you ingest all changes of this #440 as then we have two 🪰 (issues) killed with one 👏 (change) (as they are related: ServiceLocator prevents ctor injection,

[GitHub] [maven] cstamas edited a comment on pull request #547: [MNG-5577] Use constructor injection and remove the use of @Component

2021-10-02 Thread GitBox
cstamas edited a comment on pull request #547: URL: https://github.com/apache/maven/pull/547#issuecomment-932718082 @gnodet please make sure you ingest all changes of this https://github.com/apache/maven/pull/440 as then we have two 🪰 (issues) killed with one 👏 (change) (as they are relat

[jira] [Created] (MDEP-773) Getting Warning : Non-test scoped test only dependencies found

2021-10-02 Thread Venkata Ramana Gujja (Jira)
Venkata Ramana Gujja created MDEP-773: - Summary: Getting Warning : Non-test scoped test only dependencies found Key: MDEP-773 URL: https://issues.apache.org/jira/browse/MDEP-773 Project: Maven Dep

[GitHub] [maven] rfscholte commented on pull request #517: Collapse mvnDebug into mvn

2021-10-02 Thread GitBox
rfscholte commented on pull request #517: URL: https://github.com/apache/maven/pull/517#issuecomment-932719108 We're still in doubt if this is the right thing to do. However, renaming `--debug` to `--verbose` is clearly a good thing. -- This is an automated message from the Apache Git Se

[GitHub] [maven] cstamas edited a comment on pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-10-02 Thread GitBox
cstamas edited a comment on pull request #438: URL: https://github.com/apache/maven/pull/438#issuecomment-932717398 I really don't think we want to invent new logging API. Let me explain: * I do agree with @rmannibucau et al that "slf4j-api should not leak into plugins", but IMHO none of

[GitHub] [maven] cstamas closed pull request #428: [EXPERIMENT] Update resolver and use newly introduced method

2021-10-02 Thread GitBox
cstamas closed pull request #428: URL: https://github.com/apache/maven/pull/428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [maven] cstamas commented on pull request #547: [MNG-5577] Use constructor injection and remove the use of @Component

2021-10-02 Thread GitBox
cstamas commented on pull request #547: URL: https://github.com/apache/maven/pull/547#issuecomment-932718082 @gnodet please make sure you ingest all changes of this https://github.com/apache/maven/pull/440 as then we have two flies with one change (as they are related: ServiceLocator preve

[GitHub] [maven] cstamas commented on pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-10-02 Thread GitBox
cstamas commented on pull request #438: URL: https://github.com/apache/maven/pull/438#issuecomment-932717398 I really don't think we want to invent new logging API. Let me explain: * I do agree with @rmannibucau et al that "slf4j-api should not leak into plugins", but IMHO none of the re

[GitHub] [maven] cstamas commented on pull request #517: Collapse mvnDebug into mvn

2021-10-02 Thread GitBox
cstamas commented on pull request #517: URL: https://github.com/apache/maven/pull/517#issuecomment-932710983 Why is this still draft? Is there some open question about it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [maven] khmarbaise commented on pull request #558: [MNG-7272] - Code Improvement - II

2021-10-02 Thread GitBox
khmarbaise commented on pull request #558: URL: https://github.com/apache/maven/pull/558#issuecomment-932710006 Squashed... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [maven] cstamas commented on a change in pull request #562: [MNG-7278] Clean up core logging

2021-10-02 Thread GitBox
cstamas commented on a change in pull request #562: URL: https://github.com/apache/maven/pull/562#discussion_r720646147 ## File path: maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java ## @@ -80,15 +83,14 @@ @Inject private Execut

[GitHub] [maven] cstamas commented on a change in pull request #562: [MNG-7278] Clean up core logging

2021-10-02 Thread GitBox
cstamas commented on a change in pull request #562: URL: https://github.com/apache/maven/pull/562#discussion_r720645955 ## File path: maven-core/src/main/java/org/apache/maven/toolchain/DefaultToolchainManagerPrivate.java ## @@ -39,6 +43,19 @@ extends DefaultToolchainMana

[GitHub] [maven] cstamas commented on a change in pull request #562: [MNG-7278] Clean up core logging

2021-10-02 Thread GitBox
cstamas commented on a change in pull request #562: URL: https://github.com/apache/maven/pull/562#discussion_r720645947 ## File path: maven-core/src/main/java/org/apache/maven/toolchain/DefaultToolchainManager.java ## @@ -43,12 +46,25 @@ public class DefaultToolchainManager

Can not use a snapshot version in parent

2021-10-02 Thread martin
Hi, My problem is that I want to test uplift our parent on 400 project to test the combability with Java 17 without releasing the new parent. It works perfect for regular releases, but not if I using a snapshot with time prefix. Do any one have a idea if this can be solved in any way or if I'm d