cstamas commented on a change in pull request #562:
URL: https://github.com/apache/maven/pull/562#discussion_r720683592
##########
File path:
maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java
##########
@@ -85,9 +84,9 @@
private Properties properties;
- @Deprecated //TODO used by the Enforcer plugin
+ @Deprecated //TODO used by the Enforcer plugin (cstamas: not anymore,
since 3.0.0)
public PluginParameterExpressionEvaluator( MavenSession session,
MojoExecution mojoExecution,
- PathTranslator pathTranslator,
Logger logger, MavenProject project,
+ PathTranslator pathTranslator,
MavenProject project,
Review comment:
This is a breaking change for maven-enforcer-plugin pre 3.0.0... IMO, we
should just drop this (long time deprecated) constructor, as 3.x plugins are
requirement for a long time, and this is Maven4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
