[jira] [Comment Edited] (MSHADE-197) Shade fails to relocate packages for all classes

[ https://issues.apache.org/jira/browse/MSHADE-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350804#comment-17350804 ] Alexander Kriegisch edited comment on MSHADE-197 at 5/25/21, 6:03 AM: -

[jira] [Comment Edited] (MSHADE-197) Shade fails to relocate packages for all classes

[ https://issues.apache.org/jira/browse/MSHADE-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350804#comment-17350804 ] Alexander Kriegisch edited comment on MSHADE-197 at 5/25/21, 6:00 AM: -

[jira] [Commented] (MSHADE-197) Shade fails to relocate packages for all classes

[ https://issues.apache.org/jira/browse/MSHADE-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350804#comment-17350804 ] Alexander Kriegisch commented on MSHADE-197: OK, I checked out your branch an

[jira] [Closed] (MNGSITE-452) broken link to settings-1.2.0.xsd

[ https://issues.apache.org/jira/browse/MNGSITE-452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MNGSITE-452. - Assignee: Herve Boutemy Resolution: Fixed nice catch, thank you for the report: fixed in

[jira] [Commented] (MNGSITE-452) broken link to settings-1.2.0.xsd

[ https://issues.apache.org/jira/browse/MNGSITE-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350800#comment-17350800 ] Hudson commented on MNGSITE-452: Build succeeded in Jenkins: Maven » Maven TLP » maven-s

[jira] [Commented] (MSHADE-197) Shade fails to relocate packages for all classes

[ https://issues.apache.org/jira/browse/MSHADE-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350793#comment-17350793 ] Alexander Kriegisch commented on MSHADE-197: I also do source shading sometim

[jira] [Updated] (MSHADE-393) Upgrade project from Java 7 to 8

[ https://issues.apache.org/jira/browse/MSHADE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Kriegisch updated MSHADE-393: --- Description: If there is no specific reason forcing us to stay on Java source and tar

[jira] [Created] (MSHADE-393) Upgrade project from Java 7 to 8

Alexander Kriegisch created MSHADE-393: -- Summary: Upgrade project from Java 7 to 8 Key: MSHADE-393 URL: https://issues.apache.org/jira/browse/MSHADE-393 Project: Maven Shade Plugin Issue

[jira] [Commented] (MSHADE-124) Need better plan for getting dependency-reduced-pom.xml out of basedir

[ https://issues.apache.org/jira/browse/MSHADE-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350721#comment-17350721 ] Alexander Kriegisch commented on MSHADE-124: Hello, is anybody still maintain

[jira] [Comment Edited] (MSHADE-366) "Access denied" during 'minimizeJar'

[ https://issues.apache.org/jira/browse/MSHADE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350709#comment-17350709 ] Alexander Kriegisch edited comment on MSHADE-366 at 5/25/21, 1:05 AM: -

[jira] [Commented] (MSHADE-366) "Access denied" during 'minimizeJar'

[ https://issues.apache.org/jira/browse/MSHADE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350709#comment-17350709 ] Alexander Kriegisch commented on MSHADE-366: Sorry for cross-posting the same

[GitHub] [maven-shade-plugin] kriegaex edited a comment on pull request #83: [MSHADE-366] - "Access denied" during 'minimizeJar'

kriegaex edited a comment on pull request #83: URL: https://github.com/apache/maven-shade-plugin/pull/83#issuecomment-847452890 As MSHADE-366 was originally created and is still bugging me and because lately @rmannibucau collaborated with me in another PR, I want to restart this one here i

[jira] [Comment Edited] (MSHADE-366) "Access denied" during 'minimizeJar'

[ https://issues.apache.org/jira/browse/MSHADE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273260#comment-17273260 ] Alexander Kriegisch edited comment on MSHADE-366 at 5/25/21, 1:01 AM: -

[GitHub] [maven-shade-plugin] kriegaex commented on pull request #83: [MSHADE-366] - "Access denied" during 'minimizeJar'

kriegaex commented on pull request #83: URL: https://github.com/apache/maven-shade-plugin/pull/83#issuecomment-847452890 As MSHADE-366 was originally created and is still bugging me and because lately @rmannibucau collaborated with me in another PR, I want to restart this one here in order

[GitHub] [maven-surefire] Tibor17 commented on pull request #351: [SUREFIRE-1914] Draft: Document expected XML report format for @ParameterizedTest with ITs

Tibor17 commented on pull request #351: URL: https://github.com/apache/maven-surefire/pull/351#issuecomment-847334812 @andpab Do you want to continue with the RunListenerAdapter? I may guide you and then the tests will pass successfully. -- This is an automated message from the Apach

[GitHub] [maven] michael-o commented on pull request #347: [MNG-6802] Fix bug in FileProfileActivator

michael-o commented on pull request #347: URL: https://github.com/apache/maven/pull/347#issuecomment-847330320 @elharo Why didn't you modify the commit message before merging? It is unreable and therefore pointless. Intermediate work should not land when merged. -- This is an automated m

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #351: [SUREFIRE-1914] Draft: Document expected XML report format for @ParameterizedTest with ITs

Tibor17 commented on a change in pull request #351: URL: https://github.com/apache/maven-surefire/pull/351#discussion_r638232837 ## File path: surefire-its/src/test/resources/surefire-1914-xml-reporting-parameterizedtest/pom.xml ## @@ -0,0 +1,110 @@ + + + +http://maven.apache.

[GitHub] [maven] MartinKanters commented on pull request #347: [MNG-6802] Fix bug in FileProfileActivator

MartinKanters commented on pull request #347: URL: https://github.com/apache/maven/pull/347#issuecomment-847290163 @basvandenbrink The next release will be Maven 4.0.0-alpha-1, which is coming "soon" (can't give any real ETA since we are all doing this in spare time). -- This is an aut

[jira] [Created] (MNGSITE-452) broken link to settings-1.2.0.xsd

Florian created MNGSITE-452: --- Summary: broken link to settings-1.2.0.xsd Key: MNGSITE-452 URL: https://issues.apache.org/jira/browse/MNGSITE-452 Project: Maven Project Web Site Issue Type: Bug

[jira] [Commented] (MSHARED-519) Maven31DependencyGraphBuilder (and others?) should not download dependencies other than the pom

[ https://issues.apache.org/jira/browse/MSHARED-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350429#comment-17350429 ] Hudson commented on MSHARED-519: Build succeeded in Jenkins: Maven » Maven TLP » maven-d

[jira] [Reopened] (MSHARED-491) DependencyGraphBuilders should use reactorProjects first when resolving dependencies

[ https://issues.apache.org/jira/browse/MSHARED-491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte reopened MSHARED-491: > DependencyGraphBuilders should use reactorProjects first when resolving > dependencies > --

[jira] [Closed] (MSHARED-519) Maven31DependencyGraphBuilder (and others?) should not download dependencies other than the pom

[ https://issues.apache.org/jira/browse/MSHARED-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MSHARED-519. -- Fix Version/s: maven-dependency-tree-3.1.0 Assignee: Robert Scholte Resolution:

[jira] [Closed] (MSHARED-491) DependencyGraphBuilders should use reactorProjects first when resolving dependencies

[ https://issues.apache.org/jira/browse/MSHARED-491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MSHARED-491. -- Fix Version/s: maven-dependency-tree-3.1.0 Assignee: Robert Scholte Resolution:

[jira] [Issue Comment Deleted] (MSHARED-491) DependencyGraphBuilders should use reactorProjects first when resolving dependencies

[ https://issues.apache.org/jira/browse/MSHARED-491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MSHARED-491: --- Comment: was deleted (was: Fixed in [b330fa93b70e35c70a8afa75f0404cf47d5935d6|https://gitbo

[GitHub] [maven-shade-plugin] kriegaex commented on pull request #95: [MSHADE-391] Do not write modified class files for no-op relocations

kriegaex commented on pull request #95: URL: https://github.com/apache/maven-shade-plugin/pull/95#issuecomment-847010353 @rmannibucau, I pushed both your commit and my refactoring of it to this PR, please review again. I hope you are OK with what I changed. The commit comment is quite exte

[GitHub] [maven] basvandenbrink commented on pull request #347: [MNG-6802] Fix bug in FileProfileActivator

basvandenbrink commented on pull request #347: URL: https://github.com/apache/maven/pull/347#issuecomment-846932824 Great to see it has been merged! Question: will this fix be included in the next 3.x.x release? -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [maven-shade-plugin] kriegaex edited a comment on pull request #95: [MSHADE-391] Do not write modified class files for no-op relocations

kriegaex edited a comment on pull request #95: URL: https://github.com/apache/maven-shade-plugin/pull/95#issuecomment-846887726 @rmannibucau: I showed you mine. If you show me yours, I can say more about it. Is it a PR on top of my PR or a reimplementation of it? I would not be sad to thro

[GitHub] [maven-shade-plugin] kriegaex commented on pull request #95: [MSHADE-391] Do not write modified class files for no-op relocations

kriegaex commented on pull request #95: URL: https://github.com/apache/maven-shade-plugin/pull/95#issuecomment-846887726 @rmannibucau: I showed you mine. If you show me yours, I can say more about it. Is it a PR on top of my PR or a reimplementation of it? I would not be sad to throw away

[GitHub] [maven-shade-plugin] rmannibucau commented on pull request #95: [MSHADE-391] Do not write modified class files for no-op relocations

rmannibucau commented on pull request #95: URL: https://github.com/apache/maven-shade-plugin/pull/95#issuecomment-846870345 Hi @kriegaex , as said last week I had a look to this and have multiple comments to do: 1. I tested the 1 remapper instance per visitor (ClassRemapper) and perf