[
https://issues.apache.org/jira/browse/MSHADE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350709#comment-17350709
]
Alexander Kriegisch commented on MSHADE-366:
--------------------------------------------
Sorry for cross-posting the same question from Jan's PR, before I maybe start
working on my own PR, but I a assume that not everybody reads comments in the
PR:
Is it necessary to do the same analysis and exclusion for used services during
minification for files in a {{target}} directory on the classpath, which
currently happens for JAR files, or is it the right thing to just ignore it? Is
a classpath directory a valid use case here? It could very well be the case,
because the current module's class files are usually part of the uber JAR if
not explicitly excluded by a filter. So we would have to mimic the same logic
here. I can try doing that, starting a fresh PR. But I want a maintainer's
qualified answer before I start potentially wasting time with a superfluous
feature.
> "Access denied" during 'minimizeJar'
> ------------------------------------
>
> Key: MSHADE-366
> URL: https://issues.apache.org/jira/browse/MSHADE-366
> Project: Maven Shade Plugin
> Issue Type: Bug
> Affects Versions: 3.2.3
> Environment: Windows 10 Professional, Java 8, Maven 3.6.3 (bundled in
> IntelliJ IDEA Ultimate 2020.1)
> Reporter: Alexander Kriegisch
> Priority: Major
> Attachments: full-build.log, module-build.log
>
>
> Whenever I use Maven Shade with {{minimizeJar}} on my Windows 10 box, I see
> this warning during the build:
> {code:none}
> [INFO] Including net.bytebuddy:byte-buddy:jar:1.10.10 in the shaded jar.
> [INFO] Minimizing jar de.scrum-master:remove-final-agent:jar:1.0-SNAPSHOT
> [WARNING]
> C:\Users\alexa\Documents\java-src\ByteBuddyAspect\remove-final-parent\remove-final-agent\target\classes
> (Zugriff verweigert)
> {code}
> "Zugriff verweigert" is German for "access denied".
> One sample plugin configuration is:
> {code:xml}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-shade-plugin</artifactId>
> <version>3.2.3</version>
> <executions>
> <execution>
> <phase>package</phase>
> <goals>
> <goal>shade</goal>
> </goals>
> <configuration>
> <minimizeJar>true</minimizeJar>
> <createDependencyReducedPom>false</createDependencyReducedPom>
> <shadedArtifactAttached>false</shadedArtifactAttached>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
> I removed my filters because even without them the same warning occurs. As
> soon as I deactivate {{minimizeJar}}, the warning is gone.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
