kriegaex commented on pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#issuecomment-846486020
FYI, I rebased on master after #88 was merged. Otherwise no changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/MSHADE-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349852#comment-17349852
]
Hudson commented on MSHADE-252:
---
Build succeeded in Jenkins: Maven » Maven TLP » maven-shad
hboutemy merged pull request #88:
URL: https://github.com/apache/maven-shade-plugin/pull/88
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service
[
https://issues.apache.org/jira/browse/MJAVADOC-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349847#comment-17349847
]
Hudson commented on MJAVADOC-678:
-
Build failed in Jenkins: Maven » Maven TLP » maven-j
[
https://issues.apache.org/jira/browse/MJAVADOC-678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy closed MJAVADOC-678.
--
Resolution: Fixed
done in
https://github.com/apache/maven-javadoc-plugin/commit/2c524ede6319
Herve Boutemy created MJAVADOC-678:
--
Summary: avoid unit test creating
javadoc-options-javadoc-resources.xml in root directory
Key: MJAVADOC-678
URL: https://issues.apache.org/jira/browse/MJAVADOC-678
kwin edited a comment on pull request #40:
URL:
https://github.com/apache/maven-apache-parent/pull/40#issuecomment-846447592
I can do that but for clarity reason I would still reorder in the pom
Update: Done in
https://github.com/apache/maven-apache-parent/pull/40/commits/5b2579ddc8
kwin edited a comment on pull request #40:
URL:
https://github.com/apache/maven-apache-parent/pull/40#issuecomment-846447592
I can do that but for clarity reason I would still reorder in the pom
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
kwin commented on pull request #40:
URL:
https://github.com/apache/maven-apache-parent/pull/40#issuecomment-846447592
I can do that but for clarity reason I would still reorder in the pin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
hboutemy commented on pull request #40:
URL:
https://github.com/apache/maven-apache-parent/pull/40#issuecomment-846436636
ok, then it's safer to bind the `checksum-maven-plugin:artifacts` goal to
`post-integration-test` phase
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/MNG-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Cross updated MNG-7160:
Description:
I have a project that we use for all of our internal Red Hat builds (although
primarily through
[
https://issues.apache.org/jira/browse/MNG-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Cross updated MNG-7160:
Description:
I have a project that we use for all of our internal Red Hat builds (although
primarily through
[
https://issues.apache.org/jira/browse/MNG-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Cross updated MNG-7160:
Description:
I have a project that we use for all of our internal Red Hat builds (although
primarily through
[
https://issues.apache.org/jira/browse/MNG-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Cross updated MNG-7160:
Description:
I have a project that we use for all of our internal RedHat builds (although
primarily through
[
https://issues.apache.org/jira/browse/MNG-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Cross updated MNG-7160:
Description:
I have a project that we use for all of our internal Red Hat builds (although
primarily through
Nick Cross created MNG-7160:
---
Summary: Extension And Classloaders
Key: MNG-7160
URL: https://issues.apache.org/jira/browse/MNG-7160
Project: Maven
Issue Type: Bug
Reporter: Nick Cross
kwin commented on pull request #40:
URL:
https://github.com/apache/maven-apache-parent/pull/40#issuecomment-846429451
files goal does never attach with a classifier, therefore we can't use it
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
hboutemy commented on pull request #40:
URL:
https://github.com/apache/maven-apache-parent/pull/40#issuecomment-846427543
@kwin wouldn't `files` goal
https://checksum-maven-plugin.nicoulaj.net/files-mojo.html be an option? It
supports attach, and would not suffer from the ordering prerequ
kwin edited a comment on pull request #40:
URL:
https://github.com/apache/maven-apache-parent/pull/40#issuecomment-845799597
Let me summarize the status quo (without PR):
1. `gpg-maven-plugin:sign` executed in phase `verify`, calculates ASC files
for almost all attached files (excep
hboutemy commented on pull request #40:
URL:
https://github.com/apache/maven-apache-parent/pull/40#issuecomment-846426759
ah, ok, I didn't get that attaching checksums required to switch from
`files` goal to `artifacts`, and no exclusion based on extension exists yet...
thanks for the e
[
https://issues.apache.org/jira/browse/MSHARED-339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MSHARED-339.
--
Fix Version/s: maven-dependency-tree-3.1.0
Assignee: Robert Scholte
Resolution:
[
https://issues.apache.org/jira/browse/MSHARED-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MSHARED-801.
--
Assignee: Robert Scholte
Resolution: Won't Fix
It has become too hard to solve this in m
[
https://issues.apache.org/jira/browse/MSHARED-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349761#comment-17349761
]
Robert Scholte commented on MSHARED-890:
Root cause is the change of method sign
[
https://issues.apache.org/jira/browse/MSHARED-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349757#comment-17349757
]
Hudson commented on MSHARED-816:
Build succeeded in Jenkins: Maven » Maven TLP » maven-d
[
https://issues.apache.org/jira/browse/MSHARED-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MSHARED-816.
--
Fix Version/s: maven-dependency-tree-3.1.0
Assignee: Robert Scholte
Resolution:
eolivelli commented on pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#issuecomment-846417356
I am sorry I cannot help with the single run issue.
For some plugjns I modify the pom.xml file in order to select only one
single IT.
I have never really w
rfscholte commented on pull request #1:
URL:
https://github.com/apache/maven-dependency-tree/pull/1#issuecomment-846410958
I'll leave the clean up to somebody else on a separate ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Tibor17 commented on a change in pull request #351:
URL: https://github.com/apache/maven-surefire/pull/351#discussion_r637404894
##
File path:
surefire-its/src/test/resources/surefire-1914-xml-reporting-parameterizedtest/pom.xml
##
@@ -0,0 +1,110 @@
+
+
+
+http://maven.apache.
Tibor17 commented on a change in pull request #351:
URL: https://github.com/apache/maven-surefire/pull/351#discussion_r637404894
##
File path:
surefire-its/src/test/resources/surefire-1914-xml-reporting-parameterizedtest/pom.xml
##
@@ -0,0 +1,110 @@
+
+
+
+http://maven.apache.
cstamas commented on pull request #1:
URL:
https://github.com/apache/maven-dependency-tree/pull/1#issuecomment-846408313
I don't quite understand why this was merged as is...
* Uses plexus
* Uses AbstractLogEnabled
* Uses nasty reflection pattern from m-artifact-transfer we want to
Tibor17 edited a comment on pull request #343:
URL: https://github.com/apache/maven-surefire/pull/343#issuecomment-846400534
@kriegaex
I am having a look. Only 1497 messages went through. 400 thousand messages
were written. So it must be only some stupid bug in this PR. I will find it.
Tibor17 commented on pull request #343:
URL: https://github.com/apache/maven-surefire/pull/343#issuecomment-846400534
@kriegaex
I am having a look. Only 1497 went through. 400 thousand messages were
written. So it must be only some stupid bug in this PR. I will find it.
--
This is an
rfscholte closed pull request #1:
URL: https://github.com/apache/maven-dependency-tree/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servi
rfscholte commented on pull request #1:
URL:
https://github.com/apache/maven-dependency-tree/pull/1#issuecomment-846399151
merged with
https://github.com/apache/maven-dependency-tree/commit/7e225abf11faf1a0114d735b9aa2ca9f0669c694
--
This is an automated message from the Apache Git Serv
[
https://issues.apache.org/jira/browse/MSHARED-788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MSHARED-788.
--
Fix Version/s: maven-dependency-tree-3.1.0
Assignee: Robert Scholte
Resolution:
[
https://issues.apache.org/jira/browse/MSHARED-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349720#comment-17349720
]
Hudson commented on MSHARED-788:
Build succeeded in Jenkins: Maven » Maven TLP » maven-d
kriegaex commented on a change in pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#discussion_r637392426
##
File path: src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
##
@@ -694,6 +702,11 @@ private void addResource( Set resources,
Ja
kriegaex commented on a change in pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#discussion_r637392426
##
File path: src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
##
@@ -694,6 +702,11 @@ private void addResource( Set resources,
Ja
kriegaex commented on a change in pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#discussion_r637392426
##
File path: src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
##
@@ -694,6 +702,11 @@ private void addResource( Set resources,
Ja
rmannibucau commented on a change in pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#discussion_r637391903
##
File path: src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
##
@@ -694,6 +702,11 @@ private void addResource( Set resources,
kriegaex commented on a change in pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#discussion_r637390118
##
File path: src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
##
@@ -694,6 +702,11 @@ private void addResource( Set resources,
Ja
kriegaex commented on a change in pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#discussion_r637390118
##
File path: src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
##
@@ -694,6 +702,11 @@ private void addResource( Set resources,
Ja
kriegaex commented on a change in pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#discussion_r637390118
##
File path: src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
##
@@ -694,6 +702,11 @@ private void addResource( Set resources,
Ja
rmannibucau commented on a change in pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#discussion_r637384689
##
File path: src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
##
@@ -694,6 +702,11 @@ private void addResource( Set resources,
[
https://issues.apache.org/jira/browse/MNG-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349645#comment-17349645
]
Hudson commented on MNG-6915:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » master #
kriegaex commented on a change in pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#discussion_r637379490
##
File path: src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
##
@@ -694,6 +702,11 @@ private void addResource( Set resources,
Ja
kriegaex commented on a change in pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#discussion_r637379490
##
File path: src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
##
@@ -694,6 +702,11 @@ private void addResource( Set resources,
Ja
kriegaex commented on pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#issuecomment-846380070
BTW, can anyone tell me why running a single IT by
```text
mvn -DskipTests=true
-Dinvoker.test=MSHADE-391_noRelocationKeepOriginalClasses verify -P run-its
`
mthmulders closed pull request #472:
URL: https://github.com/apache/maven/pull/472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
mthmulders commented on pull request #472:
URL: https://github.com/apache/maven/pull/472#issuecomment-846377504
Superseded by #473.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
[
https://issues.apache.org/jira/browse/MSHADE-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349639#comment-17349639
]
Alexander Kriegisch commented on MSHADE-391:
[~hboutemy], thanks for the flow
[
https://issues.apache.org/jira/browse/MNG-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349638#comment-17349638
]
Martin Kanters edited comment on MNG-6915 at 5/22/21, 8:53 AM:
--
[
https://issues.apache.org/jira/browse/MNG-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kanters closed MNG-6915.
---
Fix Version/s: 4.0.0-alpha-1
4.0.0
Resolution: Fixed
With [!473|https://githu
kriegaex commented on pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#issuecomment-846377157
> I wonder if you could try to add a test case in order to prevent
regressions in the future
I just added an integration test. Please review and execute.
--
Thi
[
https://issues.apache.org/jira/browse/MNG-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kanters reassigned MNG-6915:
---
Assignee: Martin Kanters
> Maven console output could be wider
> -
MartinKanters merged pull request #473:
URL: https://github.com/apache/maven/pull/473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
[
https://issues.apache.org/jira/browse/MSHADE-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349622#comment-17349622
]
Herve Boutemy commented on MSHADE-391:
--
nice analysis, well done, thanks Alexander
hboutemy edited a comment on pull request #93:
URL: https://github.com/apache/maven-shade-plugin/pull/93#issuecomment-846365632
platform dependent newline is not an issue, it's normal, even if sometimes
it adds some complexity: it does not block Reproducible Builds, see
https://github.com/
hboutemy edited a comment on pull request #93:
URL: https://github.com/apache/maven-shade-plugin/pull/93#issuecomment-846365632
platform dependent newline is not an issue, it's normal, even if sometimes
it adds some complexity: it does not block Reproducible Builds, see
https://github.com/
hboutemy commented on pull request #93:
URL: https://github.com/apache/maven-shade-plugin/pull/93#issuecomment-846365632
platform dependent newline is not an issue, it's normal, even if sometimes
it adds some complexity: it does not block Reproducible Builds, see
https://github.com/jvm-rep
60 matches
Mail list logo
