kriegaex commented on a change in pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#discussion_r637392426
##########
File path: src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
##########
@@ -694,6 +702,11 @@ private void addResource( Set<String> resources,
JarOutputStream jos, String nam
List<Relocator> relocators;
+ // Use thread-local, just in case 'map*' calls are ever done
concurrently. Make sure that the using class
+ // initialises this value according to its needs, usually setting the
value to false per file before starting
+ // relocation.
+ ThreadLocal<Boolean> wasRelocated = new ThreadLocal<>();
Review comment:
Actually, after my experience with questions asked on the mailing list,
issues opened on Jira and PRs on GitHub, I am kind of afraid that this issue is
going to lose momentum and trickle out instead of being merged and closed.
Let's not bloat this. We got the code and integration test in place, I would
love to see this one merged.
The I want to move on to my MSHADE-252 feature PR next. Still no feedback
there, and this is one I really have used for months from my private repository
with a temporary version number, because without it Maven Shade is basically
useless for me and the AspectJ project, as we also produce shaded and relocated
source JARs which should respect excludes, too.
##########
File path: src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
##########
@@ -694,6 +702,11 @@ private void addResource( Set<String> resources,
JarOutputStream jos, String nam
List<Relocator> relocators;
+ // Use thread-local, just in case 'map*' calls are ever done
concurrently. Make sure that the using class
+ // initialises this value according to its needs, usually setting the
value to false per file before starting
+ // relocation.
+ ThreadLocal<Boolean> wasRelocated = new ThreadLocal<>();
Review comment:
Actually, after my experience with questions asked on the mailing list,
issues opened on Jira and PRs on GitHub, I am kind of afraid that this issue is
going to lose momentum and trickle out instead of being merged and closed.
Let's not bloat this. We got the code and integration test in place, I would
love to see this one merged.
Then I want to move on to my MSHADE-252 feature PR next. Still no feedback
there, and this is one I really have used for months from my private repository
with a temporary version number, because without it Maven Shade is basically
useless for me and the AspectJ project, as we also produce shaded and relocated
source JARs which should respect excludes, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
