[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312854#comment-17312854 ] Alexander Kriegisch edited comment on SUREFIRE-1881 at 4/1/21, 6:36 AM:

[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312905#comment-17312905 ] Alexander Kriegisch commented on SUREFIRE-1881: --- {quote}A good idea. You

[GitHub] [maven] marcelstoer commented on pull request #92: MNG-5909 : Add combined expression evaluator to file activation property

2021-03-31 Thread GitBox
marcelstoer commented on pull request #92: URL: https://github.com/apache/maven/pull/92#issuecomment-811678794 Any chance this will ever be accepted? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (MNG-7110) Different behavior of extensions

2021-03-31 Thread Mirko Friedenhagen (Jira)
[ https://issues.apache.org/jira/browse/MNG-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312873#comment-17312873 ] Mirko Friedenhagen commented on MNG-7110: - Thanks, works for our in-house project a

[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312857#comment-17312857 ] Alexander Kriegisch edited comment on SUREFIRE-1881 at 4/1/21, 4:51 AM:

[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312854#comment-17312854 ] Alexander Kriegisch edited comment on SUREFIRE-1881 at 4/1/21, 4:47 AM:

[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312857#comment-17312857 ] Alexander Kriegisch edited comment on SUREFIRE-1881 at 4/1/21, 4:46 AM:

[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312857#comment-17312857 ] Alexander Kriegisch edited comment on SUREFIRE-1881 at 4/1/21, 4:42 AM:

[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312854#comment-17312854 ] Alexander Kriegisch edited comment on SUREFIRE-1881 at 4/1/21, 4:39 AM:

[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312857#comment-17312857 ] Alexander Kriegisch commented on SUREFIRE-1881: --- {quote}To be more speci

[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312854#comment-17312854 ] Alexander Kriegisch edited comment on SUREFIRE-1881 at 4/1/21, 4:17 AM:

[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312854#comment-17312854 ] Alexander Kriegisch commented on SUREFIRE-1881: --- {quote} I am guessing t

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #344: SUREFIRE-1854 Support include/exclude junit test engine

2021-03-31 Thread GitBox
Tibor17 commented on a change in pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605305509 ## File path: surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java ## @@

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #344: SUREFIRE-1854 Support include/exclude junit test engine

2021-03-31 Thread GitBox
Tibor17 commented on a change in pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605305237 ## File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java ## @@ -60,

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #344: SUREFIRE-1854 Support include/exclude junit test engine

2021-03-31 Thread GitBox
Tibor17 edited a comment on pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-811555475 yes, you have modified the biggest class AbstractSurefireMojo. The problem is that I am not able to recognize real changes within the code formatyou changed. I g

[GitHub] [maven-surefire] Tibor17 commented on pull request #344: SUREFIRE-1854 Support include/exclude junit test engine

2021-03-31 Thread GitBox
Tibor17 commented on pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-811555475 yes, you have modified the biggest class AbstractSurefireMojo. The problem is that I am not able to recognize real changes and the code format. I guess you pressed CRTL+L i

[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312788#comment-17312788 ] Tibor Digana commented on SUREFIRE-1881: New findings with {{$ mvnDebug test -

[jira] [Issue Comment Deleted] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1881: --- Comment: was deleted (was: New findings with {{$ mvnDebug test -X -o}}. Thsi is the CLI {

[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312761#comment-17312761 ] Tibor Digana commented on SUREFIRE-1881: New findings with {{$ mvnDebug test -

[jira] [Created] (MNG-7133) Allow to inline collection/array items within plugin root configuration

2021-03-31 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MNG-7133: Summary: Allow to inline collection/array items within plugin root configuration Key: MNG-7133 URL: https://issues.apache.org/jira/browse/MNG-7133 Project: Ma

[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2021-03-31 Thread Guy Brand (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312705#comment-17312705 ] Guy Brand commented on MRESOLVER-153: - [~michael-o] What is the status of this iss

[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Patrick Reinhart (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312685#comment-17312685 ] Patrick Reinhart commented on SUREFIRE-1881: [~tibordigana] I did some pok

[GitHub] [maven-surefire] adam11grafik commented on pull request #344: SUREFIRE-1854 Support include/exclude junit test engine

2021-03-31 Thread GitBox
adam11grafik commented on pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-811354712 Hi @Tibor17, can you help me with build issue? maven-checkstyle-plugin throw a lot of error s but any formatter was not triggered for my branch when I was building

[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312622#comment-17312622 ] Tibor Digana commented on SUREFIRE-1881: [~kriegaex] [~reinhapa] Hey guys, A g

[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312589#comment-17312589 ] Alexander Kriegisch edited comment on SUREFIRE-1881 at 3/31/21, 6:04 PM: ---

[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312589#comment-17312589 ] Alexander Kriegisch commented on SUREFIRE-1881: --- Why not? It sounds good

[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Patrick Reinhart (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312574#comment-17312574 ] Patrick Reinhart commented on SUREFIRE-1881: [~tibordigana] [~kriegaex] I

[GitHub] [maven-jar-plugin] elharo opened a new pull request #18: docs: grammar

2021-03-31 Thread GitBox
elharo opened a new pull request #18: URL: https://github.com/apache/maven-jar-plugin/pull/18 @khmarbaise -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries a

[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312566#comment-17312566 ] Alexander Kriegisch edited comment on SUREFIRE-1881 at 3/31/21, 5:32 PM: ---

[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312566#comment-17312566 ] Alexander Kriegisch commented on SUREFIRE-1881: --- I experimentally made t

[GitHub] [maven-integration-testing] mthmulders opened a new pull request #105: [MNG-7045] Upgrade to IT to use Groovy 4.0.0-alpha-2

2021-03-31 Thread GitBox
mthmulders opened a new pull request #105: URL: https://github.com/apache/maven-integration-testing/pull/105 The IT for MNG-7045 [fails on Java 17 early access builds](https://github.com/apache/maven/pull/456) due to Groovy 3 using an older version of ASM. This MR upgrades to the latest Gr

[jira] [Created] (MDEP-741) Omitting incorrect occurrence in tree

2021-03-31 Thread nabeel saabna (Jira)
nabeel saabna created MDEP-741: -- Summary: Omitting incorrect occurrence in tree Key: MDEP-741 URL: https://issues.apache.org/jira/browse/MDEP-741 Project: Maven Dependency Plugin Issue Type: Bug

[GitHub] [maven-surefire] adam11grafik opened a new pull request #344: SUREFIRE-1854 Support include/exclude junit test engine

2021-03-31 Thread GitBox
adam11grafik opened a new pull request #344: URL: https://github.com/apache/maven-surefire/pull/344 Support include/exclude junit test engine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312242#comment-17312242 ] Alexander Kriegisch edited comment on SUREFIRE-1881 at 3/31/21, 10:37 AM: --

[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312242#comment-17312242 ] Alexander Kriegisch edited comment on SUREFIRE-1881 at 3/31/21, 10:36 AM: --

[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312260#comment-17312260 ] Tibor Digana commented on SUREFIRE-1881: [~kriegaex] My answer to your pre-pre

[GitHub] [maven-surefire] kriegaex edited a comment on pull request #343: SUREFIRE-1881 Adds additional debug log and fork connection timeout

2021-03-31 Thread GitBox
kriegaex edited a comment on pull request #343: URL: https://github.com/apache/maven-surefire/pull/343#issuecomment-810956819 Oh, and one more thing. Just in case someone wants to bring up the issue of me not being friendly anymore: I admit to it. But I was so patient over in the Surefire

[GitHub] [maven-surefire] kriegaex edited a comment on pull request #343: SUREFIRE-1881 Adds additional debug log and fork connection timeout

2021-03-31 Thread GitBox
kriegaex edited a comment on pull request #343: URL: https://github.com/apache/maven-surefire/pull/343#issuecomment-810956819 Oh, and one more thing. Just in case someone wants to bring up the issue of me not being friendly anymore: I admit to it. But I was so patient over in the Surefire

[GitHub] [maven-surefire] kriegaex commented on pull request #343: SUREFIRE-1881 Adds additional debug log and fork connection timeout

2021-03-31 Thread GitBox
kriegaex commented on pull request #343: URL: https://github.com/apache/maven-surefire/pull/343#issuecomment-810956819 Oh, and one more thing. Just in case someone wants to bring up the issue of me not being friendly anymore: I was so patient over in the Surefire issue, explaining so much,

[GitHub] [maven-surefire] kriegaex edited a comment on pull request #343: SUREFIRE-1881 Adds additional debug log and fork connection timeout

2021-03-31 Thread GitBox
kriegaex edited a comment on pull request #343: URL: https://github.com/apache/maven-surefire/pull/343#issuecomment-810952849 > @kriegaex > This code is right! What the heck, @Tibor17? Again, you did not read my comment carefully or misinterpret it. I was not commenting the code i

[GitHub] [maven-surefire] kriegaex commented on pull request #343: SUREFIRE-1881 Adds additional debug log and fork connection timeout

2021-03-31 Thread GitBox
kriegaex commented on pull request #343: URL: https://github.com/apache/maven-surefire/pull/343#issuecomment-810952849 > @kriegaex > This code is right! What the heck, @Tibor17? Again, you did not read my comment carefully or misinterpret it. I was not commenting the code in this

[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312244#comment-17312244 ] Alexander Kriegisch commented on SUREFIRE-1881: --- [~tibordigana], would y

[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312242#comment-17312242 ] Alexander Kriegisch edited comment on SUREFIRE-1881 at 3/31/21, 9:52 AM: ---

[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312242#comment-17312242 ] Alexander Kriegisch edited comment on SUREFIRE-1881 at 3/31/21, 9:51 AM: ---

[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312242#comment-17312242 ] Alexander Kriegisch edited comment on SUREFIRE-1881 at 3/31/21, 9:50 AM: ---

[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312242#comment-17312242 ] Alexander Kriegisch edited comment on SUREFIRE-1881 at 3/31/21, 9:50 AM: ---

[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312242#comment-17312242 ] Alexander Kriegisch commented on SUREFIRE-1881: --- {quote}Pls don't make a

[jira] [Commented] (SUREFIRE-1659) Log4j logger in TestExecutionListener corrupts Surefire's STDOUT.

2021-03-31 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312239#comment-17312239 ] Tibor Digana commented on SUREFIRE-1659: [~kalgon] Thx for contributing! I am

[GitHub] [maven-surefire] Tibor17 commented on pull request #342: [SUREFIRE-1659] Log4j logger in TestExecutionListener corrupts Surefire's STDOUT

2021-03-31 Thread GitBox
Tibor17 commented on pull request #342: URL: https://github.com/apache/maven-surefire/pull/342#issuecomment-810932158 @kalgon Thx for contributing! I am going to publish pull requests where I need to have clever participants. Feel free to track the pull requests in the project. -- Th

[jira] [Closed] (SUREFIRE-1659) Log4j logger in TestExecutionListener corrupts Surefire's STDOUT.

2021-03-31 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1659. -- Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=0ec128

[GitHub] [maven-surefire] Tibor17 merged pull request #342: [SUREFIRE-1659] Log4j logger in TestExecutionListener corrupts Surefire's STDOUT

2021-03-31 Thread GitBox
Tibor17 merged pull request #342: URL: https://github.com/apache/maven-surefire/pull/342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312178#comment-17312178 ] Tibor Digana commented on SUREFIRE-1881: [~kriegaex] [~reinhapa] Pls see that

[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312176#comment-17312176 ] Tibor Digana commented on SUREFIRE-1881: [~kriegaex] Pls don't make any thinki

[GitHub] [maven-surefire] Tibor17 commented on pull request #343: SUREFIRE-1881 Adds additional debug log and fork connection timeout

2021-03-31 Thread GitBox
Tibor17 commented on pull request #343: URL: https://github.com/apache/maven-surefire/pull/343#issuecomment-810851691 It;s clear to me that the servers use `CompletionHandler` and we don't. Maybe the JDK is tested much more in the scenario with `CompletionHandler` as the third method param

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #343: SUREFIRE-1881 Adds additional debug log and fork connection timeout

2021-03-31 Thread GitBox
Tibor17 edited a comment on pull request #343: URL: https://github.com/apache/maven-surefire/pull/343#issuecomment-810847701 @rehevkor5 You can see that the last change timed out the build because you reordered `accept` and the reads. Look, first you should understand the principal of t

[GitHub] [maven-surefire] Tibor17 commented on pull request #343: SUREFIRE-1881 Adds additional debug log and fork connection timeout

2021-03-31 Thread GitBox
Tibor17 commented on pull request #343: URL: https://github.com/apache/maven-surefire/pull/343#issuecomment-810847701 @rehevkor5 You can see that the last change timed out the build because you reordered `accept` and the reads. Look, first you should understand the principal of the err

[GitHub] [maven-surefire] reinhapa commented on pull request #343: SUREFIRE-1881 Adds additional debug log and fork connection timeout

2021-03-31 Thread GitBox
reinhapa commented on pull request #343: URL: https://github.com/apache/maven-surefire/pull/343#issuecomment-810843571 > @kriegaex > This code is right! > Why you think that we have so many working builds in GitHub and Jenkins on Mac, Linux and Ubuntu? > I don;t know if you are onl

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #343: SUREFIRE-1881 Adds additional debug log and fork connection timeout

2021-03-31 Thread GitBox
Tibor17 edited a comment on pull request #343: URL: https://github.com/apache/maven-surefire/pull/343#issuecomment-810834109 @kriegaex This code is right! Why you think that we have so many working builds in GitHub and Jenkins on Mac, Linux and Ubuntu? I don;t know if you are only

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #343: SUREFIRE-1881 Adds additional debug log and fork connection timeout

2021-03-31 Thread GitBox
Tibor17 edited a comment on pull request #343: URL: https://github.com/apache/maven-surefire/pull/343#issuecomment-810834109 @kriegaex This code is right! Why you think that we have so many working builds in GitHub and Jenkins on Mac, Linux and Ubuntu? I don;t know if you are only

[GitHub] [maven-surefire] reinhapa commented on a change in pull request #343: SUREFIRE-1881 Adds additional debug log and fork connection timeout

2021-03-31 Thread GitBox
reinhapa commented on a change in pull request #343: URL: https://github.com/apache/maven-surefire/pull/343#discussion_r604654736 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java ## @@ -656,6 +652,10 @@ private Ru

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #343: SUREFIRE-1881 Adds additional debug log and fork connection timeout

2021-03-31 Thread GitBox
Tibor17 edited a comment on pull request #343: URL: https://github.com/apache/maven-surefire/pull/343#issuecomment-810834109 @kriegaex This code is right! Why you think that we have so many working builds in GitHub and Jenkins on Mac, Linux and Ubuntu in the Apache on Mac, Linux and

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #343: SUREFIRE-1881 Adds additional debug log and fork connection timeout

2021-03-31 Thread GitBox
Tibor17 edited a comment on pull request #343: URL: https://github.com/apache/maven-surefire/pull/343#issuecomment-810834109 @kriegaex This code is right! Why you think that we have so many working builds in GitHub and Jenkins in the Apache? I don;t know if you are only a scrum ma

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #343: SUREFIRE-1881 Adds additional debug log and fork connection timeout

2021-03-31 Thread GitBox
Tibor17 commented on a change in pull request #343: URL: https://github.com/apache/maven-surefire/pull/343#discussion_r604652429 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java ## @@ -656,6 +652,10 @@ private Run

[GitHub] [maven-surefire] Tibor17 commented on pull request #343: SUREFIRE-1881 Adds additional debug log and fork connection timeout

2021-03-31 Thread GitBox
Tibor17 commented on pull request #343: URL: https://github.com/apache/maven-surefire/pull/343#issuecomment-810834109 @kriegaex This code is right! Why you think that we have so many working builds in GitHub and Jenkins in the Apache? I don;t know if you are only a scrum manager o

[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-03-31 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312125#comment-17312125 ] Alexander Kriegisch commented on SUREFIRE-1881: --- Agreed, [~reinhapa]. By