[GitHub] [maven-enforcer] KroArtem commented on a change in pull request #86: [MENFORCER-376] Add excludes/includes functionality to RequireJavaVendor rule

2021-01-26 Thread GitBox
KroArtem commented on a change in pull request #86: URL: https://github.com/apache/maven-enforcer/pull/86#discussion_r565083783 ## File path: enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVendor.java ## @@ -31,40 +33,112 @@ */ public class Requir

[GitHub] [maven] McFoggy commented on pull request #437: [MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log

2021-01-26 Thread GitBox
McFoggy commented on pull request #437: URL: https://github.com/apache/maven/pull/437#issuecomment-768091466 @rmannibucau finally I only removed depreciation on `org.apache.maven.plugin.logging.Log`, there was a consensus for this point let's stick to it.

[GitHub] [maven-enforcer] bmarwell commented on a change in pull request #86: [MENFORCER-376] Add excludes/includes functionality to RequireJavaVendor rule

2021-01-26 Thread GitBox
bmarwell commented on a change in pull request #86: URL: https://github.com/apache/maven-enforcer/pull/86#discussion_r565072990 ## File path: enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVendor.java ## @@ -31,40 +33,112 @@ */ public class Requir

[GitHub] [maven-enforcer] bmarwell commented on a change in pull request #86: [MENFORCER-376] Add excludes/includes functionality to RequireJavaVendor rule

2021-01-26 Thread GitBox
bmarwell commented on a change in pull request #86: URL: https://github.com/apache/maven-enforcer/pull/86#discussion_r565072791 ## File path: enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVendor.java ## @@ -31,40 +33,112 @@ */ public class Requir

[GitHub] [maven-surefire] kriegaex edited a comment on pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex edited a comment on pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#issuecomment-767947574 > Maybe you want to contribute instead of micro-managing my edits? 😉 After having checked all your code review suggestions plus all the other places I changed

[GitHub] [maven-surefire] kriegaex edited a comment on pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex edited a comment on pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#issuecomment-767947574 > Maybe you want to contribute instead of micro-managing my edits? 😉 After having checked all your code review suggestions plus all the other places I changed

[GitHub] [maven-surefire] kriegaex edited a comment on pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex edited a comment on pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#issuecomment-767947574 > Maybe you want to contribute instead of micro-managing my edits? 😉 After having checked all your code review suggestions plus all the other places I changed

[jira] [Comment Edited] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-26 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272513#comment-17272513 ] Alexander Kriegisch edited comment on SUREFIRE-1882 at 1/27/21, 2:42 AM: ---

[jira] [Comment Edited] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-26 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272513#comment-17272513 ] Alexander Kriegisch edited comment on SUREFIRE-1882 at 1/27/21, 2:41 AM: ---

[jira] [Comment Edited] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-26 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272513#comment-17272513 ] Alexander Kriegisch edited comment on SUREFIRE-1882 at 1/27/21, 1:56 AM: ---

[jira] [Comment Edited] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-26 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272513#comment-17272513 ] Alexander Kriegisch edited comment on SUREFIRE-1882 at 1/27/21, 1:55 AM: ---

[jira] [Commented] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-26 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272513#comment-17272513 ] Alexander Kriegisch commented on SUREFIRE-1882: --- I think that enforcing

[GitHub] [maven-surefire] kriegaex commented on a change in pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex commented on a change in pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#discussion_r564965487 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporterTest.java ## @@ -380,7 +381,7 @@ publ

[GitHub] [maven-surefire] kriegaex edited a comment on pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex edited a comment on pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#issuecomment-767947574 > Maybe you want to contribute instead of micro-managing my edits? 😉 After having checked all your code review suggestions plus all the other places I changed

[GitHub] [maven-surefire] kriegaex edited a comment on pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex edited a comment on pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#issuecomment-767947574 > Maybe you want to contribute instead of micro-managing my edits? 😉 After having checked all your code review suggestions plus all the other places I changed

[GitHub] [maven-surefire] kriegaex edited a comment on pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex edited a comment on pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#issuecomment-767947574 > Maybe you want to contribute instead of micro-managing my edits? 😉 After having checked all your code review suggestions plus all the other places I changed

[GitHub] [maven-surefire] kriegaex edited a comment on pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex edited a comment on pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#issuecomment-767947574 > Maybe you want to contribute instead of micro-managing my edits? 😉 After having checked all your code review suggestions plus all the other places I changed

[GitHub] [maven-surefire] kriegaex commented on pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex commented on pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#issuecomment-767947574 > Maybe you want to contribute instead of micro-managing my edits? 😉 After having checked all your code review suggestions plus all the other places I changed which

[GitHub] [maven-surefire] Tibor17 commented on pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
Tibor17 commented on pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#issuecomment-767947085 We can move on if the fix is complete. This is an automated message from the Apache Git Service. To respond

[GitHub] [maven-surefire] Tibor17 commented on pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
Tibor17 commented on pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#issuecomment-767945402 I talked about the Travis CI with our Infra team. They have migrated `travis-ci.org` to `travis-ci.com`. Let's leave the Travis alone for a while but it will come back in s

[GitHub] [maven-surefire] kriegaex commented on a change in pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex commented on a change in pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#discussion_r564957111 ## File path: surefire-api/src/main/java/org/apache/maven/surefire/api/stream/AbstractStreamEncoder.java ## @@ -112,17 +113,17 @@ public void encod

[GitHub] [maven-surefire] kriegaex commented on a change in pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex commented on a change in pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#discussion_r564956338 ## File path: surefire-api/src/main/java/org/apache/maven/surefire/api/stream/AbstractStreamDecoder.java ## @@ -28,6 +28,7 @@ import java.io.EOFEx

[GitHub] [maven-surefire] kriegaex commented on a change in pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex commented on a change in pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#discussion_r564955600 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporterTest.java ## @@ -380,7 +381,7 @@ publ

[GitHub] [maven-surefire] kriegaex commented on a change in pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex commented on a change in pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#discussion_r564942022 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/Utf8RecodingDeferredFileOutputStream.java ## @@ -93,14 +9

[GitHub] [maven-surefire] kriegaex commented on a change in pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex commented on a change in pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#discussion_r564941015 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/extensions/StreamFeederTest.java ## @@ -90,9 +91,9 @@ public voi

[GitHub] [maven-surefire] kriegaex commented on pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex commented on pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#issuecomment-767927878 Is the Travis CI build really still necessary? This is an automated message from the Apache Git Service. T

[jira] [Closed] (MARTIFACT-2) First version release

2021-01-26 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MARTIFACT-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MARTIFACT-2. - Resolution: Fixed vote started > First version release > - > >

[jira] [Assigned] (MNG-7078) The integration tests use the default maven settings

2021-01-26 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MNG-7078: --- Assignee: (was: Michael Osipov) > The integration tests use the default maven settings > -

[jira] [Commented] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-26 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272332#comment-17272332 ] Tibor Digana commented on SUREFIRE-1882: [~KroArtem] Pls check it in our POM

[GitHub] [maven] McFoggy commented on pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on pull request #438: URL: https://github.com/apache/maven/pull/438#issuecomment-767746580 If asked for, I will squash the commits. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven] McFoggy commented on pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on pull request #438: URL: https://github.com/apache/maven/pull/438#issuecomment-767740201 FYI ICLA received & handled by Apache secretary, signed CLAs list updated (https://people.apache.org/unlistedclas.html) ---

[jira] [Comment Edited] (MJAVADOC-329) Allow generation of empty javadoc JARs

2021-01-26 Thread John Robert Fallows (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272302#comment-17272302 ] John Robert Fallows edited comment on MJAVADOC-329 at 1/26/21, 6:18 PM: -

[jira] [Comment Edited] (MJAVADOC-329) Allow generation of empty javadoc JARs

2021-01-26 Thread John Robert Fallows (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272302#comment-17272302 ] John Robert Fallows edited comment on MJAVADOC-329 at 1/26/21, 6:16 PM: -

[jira] [Commented] (MJAVADOC-329) Allow generation of empty javadoc JARs

2021-01-26 Thread John Robert Fallows (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272302#comment-17272302 ] John Robert Fallows commented on MJAVADOC-329: -- Pull request implementing

[GitHub] [maven-javadoc-plugin] jfallows opened a new pull request #65: [MJAVADOC-329] - Allow generation of empty javadoc JARs

2021-01-26 Thread GitBox
jfallows opened a new pull request #65: URL: https://github.com/apache/maven-javadoc-plugin/pull/65 Add `generateIfEmpty` property to `javadoc:jar` goal, defaulting to `false` for backwards compatibility. Add `testGenerateIfEmpty` property to `javadoc:test-jar` goal for consistency, def

[GitHub] [maven] McFoggy commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564616279 ## File path: maven-plugin-api/pom.xml ## @@ -54,6 +54,11 @@ under the License. org.codehaus.plexus plexus-classworlds + Review comme

[GitHub] [maven] McFoggy commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564616540 ## File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/logging/Log.java ## @@ -63,6 +65,20 @@ */ void debug( Throwable error ); +

[jira] [Commented] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-26 Thread Krosheninnikov Artem (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272157#comment-17272157 ] Krosheninnikov Artem commented on SUREFIRE-1882: Isn't it possible to

[jira] [Comment Edited] (MPIR-402) Modules Report: provide links to Maven Central

2021-01-26 Thread Florian Brunner (Jira)
[ https://issues.apache.org/jira/browse/MPIR-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272145#comment-17272145 ] Florian Brunner edited comment on MPIR-402 at 1/26/21, 3:02 PM: -

[jira] [Commented] (MPIR-402) Modules Report: provide links to Maven Central

2021-01-26 Thread Florian Brunner (Jira)
[ https://issues.apache.org/jira/browse/MPIR-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272145#comment-17272145 ] Florian Brunner commented on MPIR-402: -- Feel free to already have a look at, but I hav

[GitHub] [maven] McFoggy commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564572336 ## File path: maven-plugin-api/pom.xml ## @@ -54,6 +54,11 @@ under the License. org.codehaus.plexus plexus-classworlds + Review comme

[GitHub] [maven] McFoggy commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564571911 ## File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/logging/Log.java ## @@ -63,6 +65,20 @@ */ void debug( Throwable error ); +

[jira] [Commented] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-26 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272127#comment-17272127 ] Tibor Digana commented on SUREFIRE-1882: [~kriegaex] This issue was found out

[GitHub] [maven] rmannibucau commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
rmannibucau commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564558395 ## File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/logging/Log.java ## @@ -63,6 +65,20 @@ */ void debug( Throwable error );

[GitHub] [maven] rmannibucau commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
rmannibucau commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564557392 ## File path: maven-plugin-api/pom.xml ## @@ -54,6 +54,11 @@ under the License. org.codehaus.plexus plexus-classworlds + Review c

[jira] [Updated] (MNG-7055) Using MINSTALL/DEPLOY 3.0.0-M1+ does not write plugin information into maven-metadata.xml

2021-01-26 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7055: Description: Copying [~michaelo]'s comment from mailing list on HEAD with Maven core ITs: https://ma

[GitHub] [maven] McFoggy commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564547259 ## File path: maven-plugin-api/pom.xml ## @@ -54,6 +54,11 @@ under the License. org.codehaus.plexus plexus-classworlds + Review comme

[GitHub] [maven] slachiewicz commented on pull request #437: [MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log

2021-01-26 Thread GitBox
slachiewicz commented on pull request #437: URL: https://github.com/apache/maven/pull/437#issuecomment-767568731 Sorry, that should be comment to other PR This is an automated message from the Apache Git Service. To respond t

[GitHub] [maven] McFoggy commented on pull request #437: [MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log

2021-01-26 Thread GitBox
McFoggy commented on pull request #437: URL: https://github.com/apache/maven/pull/437#issuecomment-767563490 > > > One short notice - Plexus logger Log here, api and implementation is from Eclipse Plexus Sisu Sorry @slachiewicz I do not get your point. -

[GitHub] [maven] michael-o commented on pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
michael-o commented on pull request #438: URL: https://github.com/apache/maven/pull/438#issuecomment-767563022 > > > @McFoggy it is the outcome of the discussions because slf4j is 1. unstable, 2. has no correct binding impl (it is a singleton leading to a bunch of issues in mojo wh

[GitHub] [maven] McFoggy commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564527199 ## File path: maven-plugin-api/src/test/java/org/apache/maven/plugin/logging/SystemStreamLogTest.java ## @@ -0,0 +1,94 @@ +package org.apache.maven.plugin.lo

[GitHub] [maven] McFoggy commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564527024 ## File path: maven-plugin-api/src/test/java/org/apache/maven/plugin/logging/SystemStreamLogTest.java ## @@ -0,0 +1,94 @@ +package org.apache.maven.plugin.lo

[GitHub] [maven] McFoggy commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564526250 ## File path: maven-plugin-api/src/test/java/org/apache/maven/plugin/logging/SystemStreamLogTest.java ## @@ -0,0 +1,94 @@ +package org.apache.maven.plugin.lo

[GitHub] [maven-artifact-plugin] hboutemy merged pull request #8: tidy up dependencies

2021-01-26 Thread GitBox
hboutemy merged pull request #8: URL: https://github.com/apache/maven-artifact-plugin/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven] McFoggy commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564525577 ## File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/logging/Log.java ## @@ -63,6 +65,20 @@ */ void debug( Throwable error ); +

[GitHub] [maven] rmannibucau commented on pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
rmannibucau commented on pull request #438: URL: https://github.com/apache/maven/pull/438#issuecomment-767550173 @McFoggy it is the outcome of the discussions because slf4j is 1. unstable, 2. has no correct binding impl (it is a singleton leading to a bunch of issues in mojo when transpare

[GitHub] [maven] McFoggy commented on pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on pull request #438: URL: https://github.com/apache/maven/pull/438#issuecomment-767546195 > I really can't believe we are reinventing the wheel by implementing SLF4J Light. that's not what I understood from the different discussions. I really thought that it was

[GitHub] [maven] McFoggy commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564504423 ## File path: maven-plugin-api/pom.xml ## @@ -54,6 +54,11 @@ under the License. org.codehaus.plexus plexus-classworlds + Review comme

[GitHub] [maven] McFoggy commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564502239 ## File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/logging/Log.java ## @@ -63,6 +65,20 @@ */ void debug( Throwable error ); +

[GitHub] [maven] McFoggy commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564500288 ## File path: maven-plugin-api/src/test/java/org/apache/maven/plugin/logging/SystemStreamLogTest.java ## @@ -0,0 +1,94 @@ +package org.apache.maven.plugin.lo

[GitHub] [maven] McFoggy commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564498644 ## File path: maven-plugin-api/src/test/java/org/apache/maven/plugin/logging/SystemStreamLogTest.java ## @@ -0,0 +1,94 @@ +package org.apache.maven.plugin.lo

[GitHub] [maven] McFoggy commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564497192 ## File path: maven-plugin-api/src/test/java/org/apache/maven/plugin/logging/SystemStreamLogTest.java ## @@ -0,0 +1,94 @@ +package org.apache.maven.plugin.lo

[GitHub] [maven] McFoggy commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564496153 ## File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/logging/Log.java ## @@ -63,6 +65,20 @@ */ void debug( Throwable error ); +

[jira] [Commented] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-26 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272087#comment-17272087 ] Michael Osipov commented on SUREFIRE-1882: -- They are likely more, my commits

[GitHub] [maven] michael-o commented on pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
michael-o commented on pull request #438: URL: https://github.com/apache/maven/pull/438#issuecomment-767524135 I really can't believe we are reinventing the wheel by implementing SLF4J Light. This is an automated message fro

[GitHub] [maven] michael-o commented on pull request #413: [MNG-6843] Thread-safe artifacts in MavenProject

2021-01-26 Thread GitBox
michael-o commented on pull request #413: URL: https://github.com/apache/maven/pull/413#issuecomment-767523804 Please ping me next week, I am current incapable to do anything fruitful. Alternatively, go through Core ITs commits from me and check Plugin changes. ---

[GitHub] [maven-shared-utils] rfscholte commented on a change in pull request #70: [MNG-6915] Add a helper method to get the terminal width

2021-01-26 Thread GitBox
rfscholte commented on a change in pull request #70: URL: https://github.com/apache/maven-shared-utils/pull/70#discussion_r564454311 ## File path: pom.xml ## @@ -70,7 +70,7 @@ org.fusesource.jansi jansi - 2.0.1 + 2.2.0 true Review comment:

[GitHub] [maven] slachiewicz commented on pull request #437: [MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log

2021-01-26 Thread GitBox
slachiewicz commented on pull request #437: URL: https://github.com/apache/maven/pull/437#issuecomment-767493277 One short notice - Plexus logger Log here, api and implementation is from Eclipse Plexus Sisu This is an automa

[GitHub] [maven] rmannibucau commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
rmannibucau commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564449085 ## File path: maven-plugin-api/pom.xml ## @@ -54,6 +54,11 @@ under the License. org.codehaus.plexus plexus-classworlds + Review c

[GitHub] [maven] slawekjaranowski commented on a change in pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
slawekjaranowski commented on a change in pull request #438: URL: https://github.com/apache/maven/pull/438#discussion_r564440925 ## File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/logging/Log.java ## @@ -63,6 +65,20 @@ */ void debug( Throwable erro

[GitHub] [maven] rmannibucau commented on pull request #437: [MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log

2021-01-26 Thread GitBox
rmannibucau commented on pull request #437: URL: https://github.com/apache/maven/pull/437#issuecomment-767488286 @McFoggy not a big blocker for me since removing the deprecation on Log is the "big thing" there IMHO but think it is worth to have an implementation not deprecated (maybe defau

[GitHub] [maven] McFoggy commented on pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy commented on pull request #438: URL: https://github.com/apache/maven/pull/438#issuecomment-767480098 Initially I did not wanted to pollute `stdout` & `stderr` that's why I mocked them in SystemStreamLogTest. Thinking more about it, it can be a bad idea to have mocked them. If

[GitHub] [maven-surefire] kriegaex edited a comment on pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex edited a comment on pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#issuecomment-767476849 Maybe you want to contribute instead of micro-managing my edits? 😉 ![image](https://user-images.githubusercontent.com/1537384/105838558-d1250f00-6002-11eb-968

[GitHub] [maven-surefire] kriegaex edited a comment on pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex edited a comment on pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#issuecomment-767476849 Maybe you want to contribute instead of micro-managing my edits? 😉 ![image](https://user-images.githubusercontent.com/1537384/105838558-d1250f00-6002-11eb-968

[GitHub] [maven-surefire] kriegaex commented on pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex commented on pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#issuecomment-767476849 Maybe you want to contribute instead of micro-managing my edits? 😉 ![image](https://user-images.githubusercontent.com/1537384/105838558-d1250f00-6002-11eb-9689-55ee8

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
Tibor17 commented on a change in pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#discussion_r564434105 ## File path: surefire-api/src/main/java/org/apache/maven/surefire/api/stream/AbstractStreamEncoder.java ## @@ -112,17 +113,17 @@ public void encode

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
Tibor17 commented on a change in pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#discussion_r564432905 ## File path: surefire-api/src/main/java/org/apache/maven/surefire/api/stream/AbstractStreamDecoder.java ## @@ -28,6 +28,7 @@ import java.io.EOFExc

[GitHub] [maven] McFoggy opened a new pull request #438: [MNG-7083] - introduce lazy Log message evaluation

2021-01-26 Thread GitBox
McFoggy opened a new pull request #438: URL: https://github.com/apache/maven/pull/438 as discussed in the dev mailing list [[1](https://mail-archives.apache.org/mod_mbox/maven-dev/202101.mbox/%3CCAGjJkv0%2BAa1ffGYnxWVYkz8_QWt7KsAYcJ0CsEe%2BMGy6h6FQ6w%40mail.gmail.com%3E)][[2](https://mail-a

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
Tibor17 commented on a change in pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#discussion_r564431601 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporterTest.java ## @@ -380,7 +381,7 @@ publi

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
Tibor17 commented on a change in pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#discussion_r564430829 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/Utf8RecodingDeferredFileOutputStream.java ## @@ -93,14 +94

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
Tibor17 commented on a change in pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#discussion_r564430136 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/extensions/StreamFeederTest.java ## @@ -90,9 +91,9 @@ public void

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
Tibor17 commented on a change in pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#discussion_r564429679 ## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/extensions/StreamFeederTest.java ## @@ -90,9 +91,9 @@ public void

[jira] [Commented] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-26 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272037#comment-17272037 ] Alexander Kriegisch commented on SUREFIRE-1882: --- BTW, are there or could

[jira] [Commented] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-26 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272034#comment-17272034 ] Alexander Kriegisch commented on SUREFIRE-1882: --- Like I said before when

[GitHub] [maven] McFoggy commented on pull request #437: [MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log

2021-01-26 Thread GitBox
McFoggy commented on pull request #437: URL: https://github.com/apache/maven/pull/437#issuecomment-767467591 Hi Romain, >isn't only Log which shouldn't be deprecated I hesitated on this. I can switch it back for the 2 implementations if it is more aligned with the long term g

[jira] [Commented] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-26 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272033#comment-17272033 ] Tibor Digana commented on SUREFIRE-1882: [~kriegaex] Thx for the fix. This iss

[GitHub] [maven-surefire] Tibor17 commented on pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
Tibor17 commented on pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#issuecomment-767465083 @kriegaex I did rerun of the build. The networ is bad sometimes. This is an automated message from the Apac

[GitHub] [maven-shared-utils] elharo commented on a change in pull request #70: [MNG-6915] Add a helper method to get the terminal width

2021-01-26 Thread GitBox
elharo commented on a change in pull request #70: URL: https://github.com/apache/maven-shared-utils/pull/70#discussion_r564418571 ## File path: pom.xml ## @@ -70,7 +70,7 @@ org.fusesource.jansi jansi - 2.0.1 + 2.2.0 true Review comment:

[jira] [Comment Edited] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-26 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272021#comment-17272021 ] Alexander Kriegisch edited comment on SUREFIRE-1882 at 1/26/21, 10:45 AM: --

[GitHub] [maven-surefire] kriegaex edited a comment on pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex edited a comment on pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#issuecomment-767453228 Looks like the "CI for Windows 1" failure was caused by a network problem: ```text Caused by: java.net.UnknownHostException: repo.maven.apache.org at

[GitHub] [maven] rmannibucau commented on pull request #437: [MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log

2021-01-26 Thread GitBox
rmannibucau commented on pull request #437: URL: https://github.com/apache/maven/pull/437#issuecomment-767455778 Hi @McFoggy , isnt only Log which shouldn't be deprecated and the implementation can stay deprecated if we want to forward them to slf4j internally - I suspect we will want to d

[GitHub] [maven-surefire] kriegaex commented on pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex commented on pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#issuecomment-767453228 Looks like CI failure was caused by a network problem: ```text Caused by: java.net.UnknownHostException: repo.maven.apache.org at java.net.Inet6AddressImpl.

[GitHub] [maven] McFoggy opened a new pull request #437: [MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log

2021-01-26 Thread GitBox
McFoggy opened a new pull request #437: URL: https://github.com/apache/maven/pull/437 as discussed in the dev mailing list [[1](https://mail-archives.apache.org/mod_mbox/maven-dev/202101.mbox/%3CCAGjJkv0%2BAa1ffGYnxWVYkz8_QWt7KsAYcJ0CsEe%2BMGy6h6FQ6w%40mail.gmail.com%3E)][[2](https://mail-a

[GitHub] [maven] famod commented on pull request #413: [MNG-6843] Thread-safe artifacts in MavenProject

2021-01-26 Thread GitBox
famod commented on pull request #413: URL: https://github.com/apache/maven/pull/413#issuecomment-767452439 @michael-o friendly reminder: > Can you point me to such a test with a custom mojo? I would then try to take a (timeboxed) stab at it. > Thanks! ---

[jira] [Commented] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-26 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272021#comment-17272021 ] Alexander Kriegisch commented on SUREFIRE-1882: --- I did a naive but hopef

[GitHub] [maven-surefire] kriegaex opened a new pull request #332: [SUREFIRE-1882] Fix failures when compiled on Java 9+ and run on Java 8

2021-01-26 Thread GitBox
kriegaex opened a new pull request #332: URL: https://github.com/apache/maven-surefire/pull/332 Cast to Buffer to avoid java.lang.NoSuchMethodError due to JDK API breakage. This was fixed in a similar way in apache/maven-wagon@92c0d2a. See mongodb/mongo-java-driver@21c91bd f

[jira] [Commented] (MPIR-402) Modules Report: provide links to Maven Central

2021-01-26 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPIR-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272007#comment-17272007 ] Michael Osipov commented on MPIR-402: - I will go through soon... > Modules Report: pro

[jira] [Commented] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-26 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272005#comment-17272005 ] Michael Osipov commented on SUREFIRE-1882: -- You edit is correct. The supplied

[jira] [Comment Edited] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-26 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271979#comment-17271979 ] Alexander Kriegisch edited comment on SUREFIRE-1882 at 1/26/21, 9:11 AM: ---

[jira] [Commented] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-26 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271979#comment-17271979 ] Alexander Kriegisch commented on SUREFIRE-1882: --- [~michael-o], what is t

  1   2   >