McFoggy commented on a change in pull request #438:
URL: https://github.com/apache/maven/pull/438#discussion_r564547259
##########
File path: maven-plugin-api/pom.xml
##########
@@ -54,6 +54,11 @@ under the License.
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-classworlds</artifactId>
</dependency>
+ <dependency>
Review comment:
> with a custom Log impl
you probably meant with a org.codehaus.plexus.logging.Logger implementation
; applying to tests in DefaultLogTest.
@rmannibucau If I provide a stub/custom impl what is the difference with the
mock ; I mean in regard of the remark _"... what it brings but I see how the
test can pass with a broken impl"_
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
