[
https://issues.apache.org/jira/browse/MNG-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262113#comment-17262113
]
Pavel_K commented on MNG-7037:
--
[~rfscholte] Important note - I don't know maven internal work
[
https://issues.apache.org/jira/browse/MNG-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262110#comment-17262110
]
Pavel_K commented on MNG-7037:
--
[~rfscholte] Yes, I understand that to modularize the project
mkarg commented on pull request #421:
URL: https://github.com/apache/maven/pull/421#issuecomment-756912897
So if there is nobody voting -1 I would kindly ask someone to merge this, as
I am not a committer. :-)
This is an aut
MartinKanters commented on a change in pull request #429:
URL: https://github.com/apache/maven/pull/429#discussion_r554435075
##
File path:
maven-core/src/main/java/org/apache/maven/execution/ProfileActivationRequest.java
##
@@ -0,0 +1,180 @@
+package org.apache.maven.executio
hboutemy merged pull request #34:
URL: https://github.com/apache/maven-apache-parent/pull/34
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
kwin edited a comment on pull request #31:
URL:
https://github.com/apache/maven-apache-parent/pull/31#issuecomment-757183847
It would be good to explain the relation to
https://maven.apache.org/ref/3.6.3/maven-model-builder/, especially the role of
https://maven.apache.org/ref/3.6.3/maven
rmannibucau commented on pull request #421:
URL: https://github.com/apache/maven/pull/421#issuecomment-756929903
Ok for me when all *our* impl will have implemented it and do not rely on
the default method.
This is an automa
rfscholte commented on a change in pull request #429:
URL: https://github.com/apache/maven/pull/429#discussion_r554032511
##
File path:
maven-core/src/main/java/org/apache/maven/execution/ProfileActivationRequest.java
##
@@ -0,0 +1,180 @@
+package org.apache.maven.execution;
+
rfscholte commented on pull request #402:
URL: https://github.com/apache/maven/pull/402#issuecomment-756893732
Probably related is MNG-7063: if trying to read the same file multiple times
(in this case {{dependency-reduced-pom.xml}}, it'll be picked up from cache. In
this case the model sh
K-J-Henken commented on a change in pull request #62:
URL: https://github.com/apache/maven-release/pull/62#discussion_r553916385
##
File path:
maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
##
@@ -387,4 +403,27 @@ protected void pre
michael-o commented on pull request #429:
URL: https://github.com/apache/maven/pull/429#issuecomment-756748127
I will happily review this next week.
This is an automated message from the Apache Git Service.
To respond to the
rmannibucau commented on pull request #400:
URL: https://github.com/apache/maven/pull/400#issuecomment-756641275
Guess the question is do we switch to junit4 ot junit5 directly today. I
think in both cases we need to write the BaseTest as an extension (junit5) or
rule (junit4) so the effor
kwin commented on pull request #31:
URL:
https://github.com/apache/maven-apache-parent/pull/31#issuecomment-756635706
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
[
https://issues.apache.org/jira/browse/DOXIA-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262015#comment-17262015
]
ASF GitHub Bot commented on DOXIA-618:
--
elharo commented on pull request #52:
URL: ht
elharo commented on pull request #52:
URL: https://github.com/apache/maven-doxia/pull/52#issuecomment-756729841
The branches are a bit confusing but I'm running it through now
This is an automated message from the Apache Git
Tibor17 commented on pull request #329:
URL: https://github.com/apache/maven-surefire/pull/329#issuecomment-756703691
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Tibor17 merged pull request #329:
URL: https://github.com/apache/maven-surefire/pull/329
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
MartinKanters commented on pull request #429:
URL: https://github.com/apache/maven/pull/429#issuecomment-756779444
> I will happily review this next week.
Great! Thanks in advance
This is an automated message from the
cstamas commented on a change in pull request #87:
URL: https://github.com/apache/maven-resolver/pull/87#discussion_r553925217
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRemoteRepositoryManager.java
##
@@ -201,7 +210,14 @@ public De
hboutemy commented on pull request #31:
URL:
https://github.com/apache/maven-apache-parent/pull/31#issuecomment-756610411
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
adangel merged pull request #41:
URL: https://github.com/apache/maven-pmd-plugin/pull/41
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
gnodet commented on pull request #400:
URL: https://github.com/apache/maven/pull/400#issuecomment-756611580
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
michael-o commented on a change in pull request #87:
URL: https://github.com/apache/maven-resolver/pull/87#discussion_r553906483
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRemoteRepositoryManager.java
##
@@ -201,7 +210,14 @@ public
adangel commented on a change in pull request #41:
URL: https://github.com/apache/maven-pmd-plugin/pull/41#discussion_r553814436
##
File path: src/main/java/org/apache/maven/plugins/pmd/exec/PmdExecutor.java
##
@@ -429,7 +430,7 @@ private void writeFormattedReport( Report repor
cstamas commented on pull request #400:
URL: https://github.com/apache/maven/pull/400#issuecomment-756658412
I'd prefer "baby steps", so this PR as is is okay for me, and let have later
go with other changes...
This is an au
slachiewicz commented on pull request #427:
URL: https://github.com/apache/maven/pull/427#issuecomment-756642164
FYI - I fixed ITS (by default compiler.target was set to Java 6.
CI run in progress:
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6727/
---
slachiewicz commented on a change in pull request #400:
URL: https://github.com/apache/maven/pull/400#discussion_r553820298
##
File path: maven-compat/src/test/java/org/apache/maven/PlexusTestCase.java
##
@@ -0,0 +1,317 @@
+package org.apache.maven;
+
+/*
+ * Licensed to the Ap
Tibor17 commented on a change in pull request #330:
URL: https://github.com/apache/maven-surefire/pull/330#discussion_r553887117
##
File path:
maven-surefire-plugin/src/site/apt/examples/inclusion-exclusion.apt.vm
##
@@ -61,7 +61,9 @@ Inclusions and Exclusions of Tests
[]
slachiewicz commented on pull request #400:
URL: https://github.com/apache/maven/pull/400#issuecomment-756631816
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
cstamas commented on pull request #428:
URL: https://github.com/apache/maven/pull/428#issuecomment-756645983
Was m-a-t initial goal to "hide" org.sonatype vs org.eclipse resolver diffs?
So to say maven 3.0 vs maven 3.1. Also, it is sitting between maven (core) and
resolver (core), but m-a-
slachiewicz commented on pull request #428:
URL: https://github.com/apache/maven/pull/428#issuecomment-756633507
I'm really interested in how this will work (ie use the newer resolver
method) in plugins - that run in older maven 3.6.3 (as a replacement to
m-artifact-transfer.
---
gnodet commented on a change in pull request #400:
URL: https://github.com/apache/maven/pull/400#discussion_r553839266
##
File path: maven-compat/src/test/java/org/apache/maven/PlexusTestCase.java
##
@@ -0,0 +1,317 @@
+package org.apache.maven;
+
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/MNG-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261960#comment-17261960
]
Robert Scholte commented on MNG-7037:
-
One idea I had is to start with a complete new s
[
https://issues.apache.org/jira/browse/MNG-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261950#comment-17261950
]
Pavel_K edited comment on MNG-7037 at 1/9/21, 9:11 PM:
---
[~rfscholte]
[
https://issues.apache.org/jira/browse/MNG-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261950#comment-17261950
]
Pavel_K commented on MNG-7037:
--
[~rfscholte] From here https://stackoverflow.com/a/46504438/50
[
https://issues.apache.org/jira/browse/MNG-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261949#comment-17261949
]
Pavel_K commented on MNG-7037:
--
[~rfscholte] Ok. Can you say, if this issue will be resolved a
[
https://issues.apache.org/jira/browse/MNG-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261937#comment-17261937
]
Robert Scholte commented on MNG-7037:
-
One way to solve this is to bring back all class
[
https://issues.apache.org/jira/browse/MNG-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261934#comment-17261934
]
Robert Scholte commented on MNG-7037:
-
[~Pavel_K] several fellow member of the [JSR 376
rfscholte commented on a change in pull request #429:
URL: https://github.com/apache/maven/pull/429#discussion_r554451003
##
File path:
maven-core/src/main/java/org/apache/maven/execution/ProfileActivationRequest.java
##
@@ -0,0 +1,180 @@
+package org.apache.maven.execution;
+
[
https://issues.apache.org/jira/browse/MNG-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261883#comment-17261883
]
Pavel_K commented on MNG-7037:
--
[~rfscholte] By the way, could you say, what experts agree tha
[
https://issues.apache.org/jira/browse/MNG-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261879#comment-17261879
]
Pavel_K commented on MNG-7037:
--
[~rfscholte] There are different module types
(https://github
MartinKanters commented on a change in pull request #429:
URL: https://github.com/apache/maven/pull/429#discussion_r554435075
##
File path:
maven-core/src/main/java/org/apache/maven/execution/ProfileActivationRequest.java
##
@@ -0,0 +1,180 @@
+package org.apache.maven.executio
[
https://issues.apache.org/jira/browse/MNG-6980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MNG-6980.
---
Assignee: Robert Scholte
Resolution: Won't Fix
To me this doesn't make sense. You want to build a
[
https://issues.apache.org/jira/browse/MNG-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte updated MNG-7037:
Priority: Minor (was: Major)
> Add JPMS support -> solve split packages problem
> --
[
https://issues.apache.org/jira/browse/MNG-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261873#comment-17261873
]
Robert Scholte commented on MNG-7037:
-
bq. No, as I need to use
org.apache.maven.repos
kwin edited a comment on pull request #31:
URL:
https://github.com/apache/maven-apache-parent/pull/31#issuecomment-757183847
It would be good to explain the relation to
https://maven.apache.org/ref/3.6.3/maven-model-builder/, especially the role of
https://maven.apache.org/ref/3.6.3/maven
kwin commented on pull request #31:
URL:
https://github.com/apache/maven-apache-parent/pull/31#issuecomment-757183847
It would be good to explain the relation to
https://maven.apache.org/ref/3.6.3/maven-model-builder/.
This
[
https://issues.apache.org/jira/browse/MNG-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261855#comment-17261855
]
Robert Scholte commented on MNG-7051:
-
[~slawekjaranowski] we need to draw a line somew
48 matches
Mail list logo
