[GitHub] [maven] gnodet commented on a change in pull request #399: [MNG-7034] StackOverflowError thrown if a cycle exists in BOM imports

2020-11-25 Thread GitBox
gnodet commented on a change in pull request #399: URL: https://github.com/apache/maven/pull/399#discussion_r530821777 ## File path: maven-model-builder/src/test/java/org/apache/maven/model/building/CyclicParentTest.java ## @@ -0,0 +1,143 @@ +package org.apache.maven.model.bui

[GitHub] [maven] gnodet commented on a change in pull request #399: [MNG-7034] StackOverflowError thrown if a cycle exists in BOM imports

2020-11-25 Thread GitBox
gnodet commented on a change in pull request #399: URL: https://github.com/apache/maven/pull/399#discussion_r530816578 ## File path: maven-model-builder/src/test/java/org/apache/maven/model/building/CyclicParentTest.java ## @@ -0,0 +1,143 @@ +package org.apache.maven.model.bui

[GitHub] [maven] gnodet commented on a change in pull request #399: [MNG-7034] StackOverflowError thrown if a cycle exists in BOM imports

2020-11-25 Thread GitBox
gnodet commented on a change in pull request #399: URL: https://github.com/apache/maven/pull/399#discussion_r530698046 ## File path: maven-model-builder/src/test/java/org/apache/maven/model/building/CyclicParentTest.java ## @@ -0,0 +1,143 @@ +package org.apache.maven.model.bui

[jira] [Commented] (MNG-3485) unable to override wagons that are bundled with a different version via extensions

2020-11-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238967#comment-17238967 ] Hudson commented on MNG-3485: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #

[GitHub] [maven-checkstyle-plugin] elharo merged pull request #40: remove unused imports

2020-11-25 Thread GitBox
elharo merged pull request #40: URL: https://github.com/apache/maven-checkstyle-plugin/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [maven-checkstyle-plugin] elharo merged pull request #39: use try with resources instead of deprecated method

2020-11-25 Thread GitBox
elharo merged pull request #39: URL: https://github.com/apache/maven-checkstyle-plugin/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Closed] (MSHARED-962) Upgrade Jansi to 2.0.1

2020-11-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MSHARED-962. Resolution: Fixed > Upgrade Jansi to 2.0.1 > -- > >

[jira] [Commented] (MSHARED-962) Upgrade Jansi to 2.0.1

2020-11-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238953#comment-17238953 ] Hudson commented on MSHARED-962: Build succeeded in Jenkins: Maven » Maven TLP » maven-s

[jira] [Updated] (MSHARED-962) Upgrade Jansi to 2.0.1

2020-11-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MSHARED-962: - Fix Version/s: maven-shared-utils-3.4.0 > Upgrade Jansi to 2.0.1 > -

[jira] [Assigned] (MSHARED-962) Upgrade Jansi to 2.0.1

2020-11-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MSHARED-962: Assignee: Sylwester Lachiewicz > Upgrade Jansi to 2.0.1 > ---

[jira] [Commented] (SUREFIRE-1863) Tests run in surefire can clear the thread interrupted flag silently when any message is logged to the console.

2020-11-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238936#comment-17238936 ] Tibor Digana commented on SUREFIRE-1863: Well, clearing the flag was always in

[GitHub] [maven-checkstyle-plugin] elharo opened a new pull request #40: remove unused imports

2020-11-25 Thread GitBox
elharo opened a new pull request #40: URL: https://github.com/apache/maven-checkstyle-plugin/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [maven-checkstyle-plugin] elharo opened a new pull request #39: use try with resources instead of deprecated method

2020-11-25 Thread GitBox
elharo opened a new pull request #39: URL: https://github.com/apache/maven-checkstyle-plugin/pull/39 @michael-o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [maven] pzygielo commented on a change in pull request #399: [MNG-7034] StackOverflowError thrown if a cycle exists in BOM imports

2020-11-25 Thread GitBox
pzygielo commented on a change in pull request #399: URL: https://github.com/apache/maven/pull/399#discussion_r530606021 ## File path: maven-model-builder/src/test/java/org/apache/maven/model/building/CyclicParentTest.java ## @@ -0,0 +1,143 @@ +package org.apache.maven.model.b

[GitHub] [maven] pzygielo commented on a change in pull request #399: [MNG-7034] StackOverflowError thrown if a cycle exists in BOM imports

2020-11-25 Thread GitBox
pzygielo commented on a change in pull request #399: URL: https://github.com/apache/maven/pull/399#discussion_r530603237 ## File path: maven-model-builder/src/test/java/org/apache/maven/model/building/CyclicParentTest.java ## @@ -0,0 +1,143 @@ +package org.apache.maven.model.b

[GitHub] [maven-ear-plugin] mabrarov commented on pull request #24: [MEAR-153] skinnyModules option

2020-11-25 Thread GitBox
mabrarov commented on pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-733909141 Hey guy, is it possible to release EAR plugin 3.2.0 with #24 and #22 this year? It would be a nice New Year's gift :) Thank you for your patience and work. -

[GitHub] [maven] gnodet opened a new pull request #399: [MNG-7034] StackOverflowError thrown if a cycle exists in BOM imports

2020-11-25 Thread GitBox
gnodet opened a new pull request #399: URL: https://github.com/apache/maven/pull/399 This is a very old regression, but while working on the `DefaultModelBuilder`, I found a few weird code paths, so investigating a bit lead me to create MNG-7034 and this PR. -

[jira] [Commented] (MNG-7034) StackOverflowError thrown if a cycle exists in BOM imports

2020-11-25 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238877#comment-17238877 ] Guillaume Nodet commented on MNG-7034: -- I can either provide a PR which will bring bac

[jira] [Comment Edited] (MNG-7034) StackOverflowError thrown if a cycle exists in BOM imports

2020-11-25 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238877#comment-17238877 ] Guillaume Nodet edited comment on MNG-7034 at 11/25/20, 7:08 PM:

[jira] [Created] (MNG-7034) StackOverflowError thrown if a cycle exists in BOM imports

2020-11-25 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-7034: Summary: StackOverflowError thrown if a cycle exists in BOM imports Key: MNG-7034 URL: https://issues.apache.org/jira/browse/MNG-7034 Project: Maven Issue Ty

[GitHub] [maven-checkstyle-plugin] elharo merged pull request #38: remove unused dependency

2020-11-25 Thread GitBox
elharo merged pull request #38: URL: https://github.com/apache/maven-checkstyle-plugin/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [maven-checkstyle-plugin] elharo opened a new pull request #38: remove unused dependency

2020-11-25 Thread GitBox
elharo opened a new pull request #38: URL: https://github.com/apache/maven-checkstyle-plugin/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [maven-pmd-plugin] elharo commented on pull request #37: replace deprecated method

2020-11-25 Thread GitBox
elharo commented on pull request #37: URL: https://github.com/apache/maven-pmd-plugin/pull/37#issuecomment-733887758 The cast is guarded by an instanceof check. This is an automated message from the Apache Git Service. To re

[jira] [Updated] (MSHARED-962) Upgrade Jansi to 2.0.1

2020-11-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MSHARED-962: - Description: Changelog: [https://github.com/fusesource/jansi/blob/master/changel

[jira] [Created] (MSHARED-962) Upgrade Jansi to 2.0.1

2020-11-25 Thread Sylwester Lachiewicz (Jira)
Sylwester Lachiewicz created MSHARED-962: Summary: Upgrade Jansi to 2.0.1 Key: MSHARED-962 URL: https://issues.apache.org/jira/browse/MSHARED-962 Project: Maven Shared Components Issu

[jira] [Updated] (MNG-5001) @readonly Mojo parameter annotation doesn't work any more

2020-11-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-5001: -- Fix Version/s: (was: 3.7.0-candidate) 3.7.x-candidate > @readonly

[jira] [Updated] (MNG-5982) The POM for ... is invalid, transitive dependencies ... while property was overriden

2020-11-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-5982: -- Fix Version/s: (was: 3.7.0-candidate) 3.7.x-candidate > The POM fo

[jira] [Updated] (MNG-6907) endless loop in StringSearchModelInterpolator

2020-11-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-6907: -- Fix Version/s: (was: 3.7.0-candidate) > endless loop in StringSearchModelInterpolator

[jira] [Commented] (MNG-6511) Option -pl ! foo should not fail if foo does not exist

2020-11-25 Thread Adam Gent (Jira)
[ https://issues.apache.org/jira/browse/MNG-6511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238848#comment-17238848 ] Adam Gent commented on MNG-6511: We desperately need this improvement as well. We are in a

[jira] [Updated] (MNG-7033) Excluded projects through -pl should not need to be in the reactor

2020-11-25 Thread Adam Gent (Jira)
[ https://issues.apache.org/jira/browse/MNG-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Gent updated MNG-7033: --- Description: TLDR if you exclude a module using {{!module}} or {{-module}} with {{-pl}} that module needs to s

[jira] [Created] (MNG-7033) Excluded projects through -pl should not need to be in the reactor

2020-11-25 Thread Adam Gent (Jira)
Adam Gent created MNG-7033: -- Summary: Excluded projects through -pl should not need to be in the reactor Key: MNG-7033 URL: https://issues.apache.org/jira/browse/MNG-7033 Project: Maven Issue Type:

[jira] [Commented] (MNG-7024) Directory instead of file in an artifact

2020-11-25 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238840#comment-17238840 ] Robert Scholte commented on MNG-7024: - Here's the magic: https://github.com/apache/came

[GitHub] [maven-checkstyle-plugin] elharo opened a new pull request #37: update JUnit

2020-11-25 Thread GitBox
elharo opened a new pull request #37: URL: https://github.com/apache/maven-checkstyle-plugin/pull/37 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [maven-checkstyle-plugin] elharo merged pull request #37: update JUnit

2020-11-25 Thread GitBox
elharo merged pull request #37: URL: https://github.com/apache/maven-checkstyle-plugin/pull/37 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Commented] (SUREFIRE-1863) Tests run in surefire can clear the thread interrupted flag silently when any message is logged to the console.

2020-11-25 Thread Peter Lawrey (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238784#comment-17238784 ] Peter Lawrey commented on SUREFIRE-1863: Clearing the interrupt doesn't ensure

[GitHub] [maven-pmd-plugin] elharo opened a new pull request #37: replace deprecated method

2020-11-25 Thread GitBox
elharo opened a new pull request #37: URL: https://github.com/apache/maven-pmd-plugin/pull/37 @michael-o a rare case where try with resources doesn't work due to a cast to Closeable This is an automated message from the Apac

[jira] [Commented] (SUREFIRE-1863) Tests run in surefire can clear the thread interrupted flag silently when any message is logged to the console.

2020-11-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238723#comment-17238723 ] Tibor Digana commented on SUREFIRE-1863: Pls check the fix in SUREFIRE-1815. T

[jira] [Commented] (MINVOKER-267) Update maven-script-interpreter to 1.3

2020-11-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238693#comment-17238693 ] Hudson commented on MINVOKER-267: - Build succeeded in Jenkins: Maven » Maven TLP » mave

[jira] [Commented] (SUREFIRE-1863) Tests run in surefire can clear the thread interrupted flag silently when any message is logged to the console.

2020-11-25 Thread Peter Lawrey (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238677#comment-17238677 ] Peter Lawrey commented on SUREFIRE-1863: It is related however "1815" suggests

[jira] [Commented] (MNG-6268) When a reactor build fails Maven should include -f (if used) in command line suggestion

2020-11-25 Thread Piotr Zygielo (Jira)
[ https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238674#comment-17238674 ] Piotr Zygielo commented on MNG-6268: Not directly related to {{-f}}, but I find it *cru

[jira] [Commented] (SUREFIRE-1861) failsafe shall use jar

2020-11-25 Thread Ernst Reissner (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238665#comment-17238665 ] Ernst Reissner commented on SUREFIRE-1861: -- I give you my config: ``` org

[jira] [Commented] (MNG-6268) When a reactor build fails Maven should include -f (if used) in command line suggestion

2020-11-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238623#comment-17238623 ] Michael Osipov commented on MNG-6268: - That's a very interesting idea. I agree that the

[jira] [Comment Edited] (MNG-7008) skip reactor logging

2020-11-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224495#comment-17224495 ] Michael Osipov edited comment on MNG-7008 at 11/25/20, 8:46 AM: -

[jira] [Updated] (MINVOKER-267) Update maven-script-interpreter to 1.3

2020-11-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MINVOKER-267: -- Summary: Update maven-script-interpreter to 1.3 (was: Update maven-script-in

[jira] [Comment Edited] (MRESOURCES-270) mandatory resources

2020-11-25 Thread Delany (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238599#comment-17238599 ] Delany edited comment on MRESOURCES-270 at 11/25/20, 8:33 AM: -

[jira] [Commented] (MRESOURCES-270) mandatory resources

2020-11-25 Thread Delany (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238599#comment-17238599 ] Delany commented on MRESOURCES-270: --- Using enforcer or verifier before the resource