[GitHub] [maven-surefire] akomakom commented on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
akomakom commented on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619465755 However, to your point about `excludedEnvironmentVariables` always containing JAVA_HOME, perhaps this array should always contain anything configured in `environmentVariab

[GitHub] [maven-surefire] akomakom commented on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
akomakom commented on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619465465 In other words, I can't think of a simpler way than the code example above. Of course we could come up with some templating system that allows a customized environ

[GitHub] [maven-surefire] akomakom commented on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
akomakom commented on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619465122 I'd say that `excludedEnvironmentVariables` can only contain `JAVA_HOME` in Toolchain mode (either maven's or surefire's). If there is no toolchain of any sort, or if `jv

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
Tibor17 edited a comment on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619463893 You want to say that the inherited JAVA_HOME is a problem, right? This might be an issue but i don't think that we should touch the class `DefaultJavaToolChain` in

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
Tibor17 edited a comment on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619463893 You want to say that the inherited JAVA_HOME is a problem, right? This might be an issue but i don't think that we should touch the class `DefaultJavaToolChain` in

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
Tibor17 edited a comment on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619463893 You want to say that the inherited JAVA_HOME is a problem, right? This might be an issue but i don't think that we should touch the class `DefaultJavaToolChain` in

[GitHub] [maven-surefire] Tibor17 commented on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
Tibor17 commented on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619463893 You want to say that the inherited JAVA_HOME is a problem, right? This might be and issue but i don't think that we should touch the class DefaultJavaToolChain due to we

[GitHub] [maven-surefire] akomakom edited a comment on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
akomakom edited a comment on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619460223 So the implementation might look like this: ```diff diff --git a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java

[GitHub] [maven-surefire] akomakom edited a comment on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
akomakom edited a comment on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619460223 So the implementation might look like this: ```diff diff --git a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java

[GitHub] [maven-surefire] akomakom commented on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
akomakom commented on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619460223 So the implementation might look like this: ```diff diff --git a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java b/ma

[GitHub] [maven-surefire] akomakom edited a comment on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
akomakom edited a comment on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619458497 I'm fairly convinced that **JAVA_HOME** is not being changed for the test process and is inherited from the parent process. I'd definitely like it to be, and, assu

[GitHub] [maven-surefire] akomakom edited a comment on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
akomakom edited a comment on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619458497 I'm fairly convinced that **JAVA_HOME** is not being changed for the test process and is inherited from the parent process. I'd definitely like it to be, and, assu

[GitHub] [maven-surefire] akomakom edited a comment on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
akomakom edited a comment on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619458497 I'm fairly convinced that **JAVA_HOME** is not being changed for the test process and is inherited from the parent process. I'd definitely like it to be, and, assu

[GitHub] [maven-surefire] akomakom edited a comment on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
akomakom edited a comment on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619458497 I'm fairly convinced that **JAVA_HOME** is not being changed for the test process and is inherited from the parent process. I'd definitely like it to be, and, assu

[GitHub] [maven-surefire] akomakom edited a comment on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
akomakom edited a comment on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619458497 I'm fairly convinced that **JAVA_HOME** is not being changed for the test process and is inherited from the parent process. I'd definitely like it to be, and, assu

[GitHub] [maven-surefire] akomakom commented on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
akomakom commented on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619458497 I'm fairly convinced that **JAVA_HOME** is not being changed for the test process and is inherited from the parent process. I'd definitely like it to be, and, assuming th

[GitHub] [maven-surefire] akomakom commented on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
akomakom commented on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619457404 @Tibor17 I just realized something that I forgot to check until now: `JAVA_HOME` is not set for the test JVM. This was one of the requirements on our end, since our integ

[GitHub] [maven-surefire] Tibor17 commented on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
Tibor17 commented on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619452640 We are currently working on JPMS (Java Modularity) and JUnit5 problems related to the Surefire. Maybe you have seen our activity in Jira. These are very important things fo

[GitHub] [maven-surefire] akomakom commented on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
akomakom commented on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619452288 I'm also impressed with how quickly this made it into master, and I'll be very impressed indeed with a release in a week. ---

[GitHub] [maven-surefire] Tibor17 commented on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
Tibor17 commented on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619452155 Thx to be fast. I didn't expect it so fast ;-) We will complete bug fixes in a week. Building the surefire project is well to go with `mvn clean install -DskipTests` i

[GitHub] [maven-surefire] akomakom commented on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
akomakom commented on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619450982 Never mind, needed a `clean` for some reason. Confirmed, `` is working as expected. Good to go. This is

[GitHub] [maven-surefire] akomakom commented on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
akomakom commented on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619450026 > @akomakom > Pls try to use the snapsot version of Surefire on your local project with this feature. I want to make sure, we can release the version. I have been

[GitHub] [maven-surefire] Tibor17 commented on pull request #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry

2020-04-25 Thread GitBox
Tibor17 commented on pull request #285: URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619448492 @akomakom Pls try to use the snapsot version of Surefire on your local project with this feature. I want to make sure, we can release the version.

[jira] [Commented] (MNG-2741) [regression] Meaningless error message: "Error transferring file"

2020-04-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092388#comment-17092388 ] Hudson commented on MNG-2741: - Build failed in Jenkins: Maven TLP » maven » MNG-6845 #14 See h

[jira] [Commented] (MNG-2741) [regression] Meaningless error message: "Error transferring file"

2020-04-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092386#comment-17092386 ] Hudson commented on MNG-2741: - Build succeeded in Jenkins: Maven TLP » maven » runITsWithJavaEA

[jira] [Commented] (MNG-4660) Use of --resume-from in multi-module project fails with missing inter-module dependencies

2020-04-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092385#comment-17092385 ] Hudson commented on MNG-4660: - Build succeeded in Jenkins: Maven TLP » maven » runITsWithJavaEA

[jira] [Commented] (MNG-5640) AbstractMavenLifecycleParticipant#afterSessionEnd is not invoked in some cases

2020-04-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-5640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092384#comment-17092384 ] Hudson commented on MNG-5640: - Build succeeded in Jenkins: Maven TLP » maven » runITsWithJavaEA

[jira] [Commented] (MNG-4660) Use of --resume-from in multi-module project fails with missing inter-module dependencies

2020-04-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092364#comment-17092364 ] Hudson commented on MNG-4660: - Build failed in Jenkins: Maven TLP » maven » MNG-6819 #10 See h

[jira] [Commented] (MNG-5640) AbstractMavenLifecycleParticipant#afterSessionEnd is not invoked in some cases

2020-04-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-5640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092362#comment-17092362 ] Hudson commented on MNG-5640: - Build failed in Jenkins: Maven TLP » maven » MNG-6819 #10 See h

[jira] [Commented] (MNG-2741) [regression] Meaningless error message: "Error transferring file"

2020-04-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092365#comment-17092365 ] Hudson commented on MNG-2741: - Build failed in Jenkins: Maven TLP » maven » MNG-6819 #10 See h

[jira] [Commented] (MNG-6819) NullPointerException for DefaultArtifactDescriptorReader.loadPom

2020-04-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092359#comment-17092359 ] Hudson commented on MNG-6819: - Build failed in Jenkins: Maven TLP » maven » MNG-6819 #11 See h

[GitHub] [maven] slachiewicz commented on pull request #301: [MNG-6819] Fix NullPointerException in StringVisitorModelInterpolator$ModelVisitor

2020-04-25 Thread GitBox
slachiewicz commented on pull request #301: URL: https://github.com/apache/maven/pull/301#issuecomment-619439295 sure - https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=9c46b06bfc080ad51d2d5626114f47293693d05c ---

[GitHub] [maven] famod commented on pull request #310: [MNG-6843] - Parallel build fails due to missing JAR artifacts in compilePath

2020-04-25 Thread GitBox
famod commented on pull request #310: URL: https://github.com/apache/maven/pull/310#issuecomment-619433732 Unfortunately, https://github.com/fkalinski/maven/commit/b38e3c2bfb6183c0f45214012112a1c1ca4048bd does not fix my problem. It seems there is yet another concurrency issue...

[GitHub] [maven] rfscholte commented on pull request #301: [MNG-6819] Fix NullPointerException in StringVisitorModelInterpolator$ModelVisitor

2020-04-25 Thread GitBox
rfscholte commented on pull request #301: URL: https://github.com/apache/maven/pull/301#issuecomment-619432576 Can you make a unittest for it? This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [maven] slachiewicz commented on pull request #301: [MNG-6819] Fix NullPointerException in StringVisitorModelInterpolator$ModelVisitor

2020-04-25 Thread GitBox
slachiewicz commented on pull request #301: URL: https://github.com/apache/maven/pull/301#issuecomment-619432298 yes, it's bug - simple pom.xml to reproduce the problem locally ``` http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:s

[jira] [Commented] (MSKINS-165) Inconsistent parent pom in IT tests.

2020-04-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MSKINS-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092337#comment-17092337 ] Hudson commented on MSKINS-165: --- Build failed in Jenkins: Maven TLP » maven-fluido-skin » m

[GitHub] [maven] rfscholte commented on pull request #301: [MNG-6819] Fix NullPointerException in StringVisitorModelInterpolator$ModelVisitor

2020-04-25 Thread GitBox
rfscholte commented on pull request #301: URL: https://github.com/apache/maven/pull/301#issuecomment-619429112 I have my doubt that this is the bug. I would love to see a failing test first. This is an automated message from

[jira] [Closed] (SUREFIRE-1781) Log a warning if forkCount = 0

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1781. -- Assignee: Romain Manni-Bucau Resolution: Fixed https://gitbox.apache.org/repos/asf?p=m

[jira] [Updated] (SUREFIRE-1781) Log a warning if forkCount = 0

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1781: --- Fix Version/s: 3.0.0-M5 > Log a warning if forkCount = 0 > --

[GitHub] [maven-surefire] Tibor17 commented on pull request #286: logging a warning if forkcount=0

2020-04-25 Thread GitBox
Tibor17 commented on pull request #286: URL: https://github.com/apache/maven-surefire/pull/286#issuecomment-619424693 @rmannibucau Thx, very good job! This is an automated message from the Apache Git Service. To respond t

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092315#comment-17092315 ] Tibor Digana commented on SUREFIRE-1570: [~Pavel_K] and 5 - i am not alone. I

[GitHub] [maven-invoker-plugin] khmarbaise commented on a change in pull request #20: [MINVOKER-250] streamLogsOnFailures

2020-04-25 Thread GitBox
khmarbaise commented on a change in pull request #20: URL: https://github.com/apache/maven-invoker-plugin/pull/20#discussion_r415091524 ## File path: src/main/java/org/apache/maven/plugins/invoker/InvokerSession.java ## @@ -190,54 +196,69 @@ else if ( buildJob.getResult() != n

[jira] [Commented] (SUREFIRE-1262) Add modulepath support

2020-04-25 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092282#comment-17092282 ] Pavel_K commented on SUREFIRE-1262: --- [~tibordigana] Of course. But that project I de

[GitHub] [maven-invoker-plugin] slawekjaranowski commented on a change in pull request #20: [MINVOKER-250] streamLogsOnFailures

2020-04-25 Thread GitBox
slawekjaranowski commented on a change in pull request #20: URL: https://github.com/apache/maven-invoker-plugin/pull/20#discussion_r415090492 ## File path: src/main/java/org/apache/maven/plugins/invoker/InvokerSession.java ## @@ -190,54 +196,69 @@ else if ( buildJob.getResult(

[GitHub] [maven-invoker-plugin] slawekjaranowski commented on a change in pull request #20: [MINVOKER-250] streamLogsOnFailures

2020-04-25 Thread GitBox
slawekjaranowski commented on a change in pull request #20: URL: https://github.com/apache/maven-invoker-plugin/pull/20#discussion_r415089181 ## File path: src/main/java/org/apache/maven/plugins/invoker/VerifyMojo.java ## @@ -82,8 +82,16 @@ * * @since 1.9 */

[jira] [Closed] (MSKINS-165) Inconsistent parent pom in IT tests.

2020-04-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSKINS-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MSKINS-165. --- Resolution: Fixed > Inconsistent parent pom in IT tests. > -

[jira] [Closed] (MNG-6845) Upgrade to apache-rat-plugin 0.13

2020-04-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MNG-6845. - Resolution: Fixed > Upgrade to apache-rat-plugin 0.13 > - >

[jira] [Commented] (MNG-6887) Provide a Github Action to check the validity of the Maven Wrapper

2020-04-25 Thread Fred Bricon (Jira)
[ https://issues.apache.org/jira/browse/MNG-6887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092280#comment-17092280 ] Fred Bricon commented on MNG-6887: -- [~rfscholte] indeed, it would be useless to perform th

[GitHub] [maven-invoker-plugin] khmarbaise commented on a change in pull request #20: [MINVOKER-250] streamLogsOnFailures

2020-04-25 Thread GitBox
khmarbaise commented on a change in pull request #20: URL: https://github.com/apache/maven-invoker-plugin/pull/20#discussion_r415085836 ## File path: src/main/java/org/apache/maven/plugins/invoker/InvokerSession.java ## @@ -190,54 +196,69 @@ else if ( buildJob.getResult() != n

[GitHub] [maven-invoker-plugin] khmarbaise commented on a change in pull request #20: [MINVOKER-250] streamLogsOnFailures

2020-04-25 Thread GitBox
khmarbaise commented on a change in pull request #20: URL: https://github.com/apache/maven-invoker-plugin/pull/20#discussion_r415085370 ## File path: src/main/java/org/apache/maven/plugins/invoker/VerifyMojo.java ## @@ -82,8 +82,16 @@ * * @since 1.9 */ -@

[GitHub] [maven-surefire] rmannibucau opened a new pull request #286: logging a warning if forkcount=0

2020-04-25 Thread GitBox
rmannibucau opened a new pull request #286: URL: https://github.com/apache/maven-surefire/pull/286 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-invoker-plugin] khmarbaise commented on a change in pull request #20: [MINVOKER-250] streamLogsOnFailures

2020-04-25 Thread GitBox
khmarbaise commented on a change in pull request #20: URL: https://github.com/apache/maven-invoker-plugin/pull/20#discussion_r415084211 ## File path: pom.xml ## @@ -323,7 +323,7 @@ under the License. org.apache.maven.plugins maven-in

[GitHub] [maven-invoker-plugin] slawekjaranowski commented on a change in pull request #20: [MINVOKER-250] streamLogsOnFailures

2020-04-25 Thread GitBox
slawekjaranowski commented on a change in pull request #20: URL: https://github.com/apache/maven-invoker-plugin/pull/20#discussion_r415083701 ## File path: src/main/java/org/apache/maven/plugins/invoker/VerifyMojo.java ## @@ -82,8 +82,16 @@ * * @since 1.9 */

[jira] [Created] (SUREFIRE-1781) Log a warning if forkCount = 0

2020-04-25 Thread Romain Manni-Bucau (Jira)
Romain Manni-Bucau created SUREFIRE-1781: Summary: Log a warning if forkCount = 0 Key: SUREFIRE-1781 URL: https://issues.apache.org/jira/browse/SUREFIRE-1781 Project: Maven Surefire I

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-25 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092277#comment-17092277 ] Pavel_K commented on SUREFIRE-1570: --- [~tibordigana] Thank you very much for your exp

[GitHub] [maven-invoker-plugin] slawekjaranowski commented on a change in pull request #20: [MINVOKER-250] streamLogsOnFailures

2020-04-25 Thread GitBox
slawekjaranowski commented on a change in pull request #20: URL: https://github.com/apache/maven-invoker-plugin/pull/20#discussion_r415082667 ## File path: src/main/java/org/apache/maven/plugins/invoker/VerifyMojo.java ## @@ -82,8 +82,16 @@ * * @since 1.9 */

[GitHub] [maven-invoker-plugin] slawekjaranowski commented on a change in pull request #20: [MINVOKER-250] streamLogsOnFailures

2020-04-25 Thread GitBox
slawekjaranowski commented on a change in pull request #20: URL: https://github.com/apache/maven-invoker-plugin/pull/20#discussion_r415080796 ## File path: pom.xml ## @@ -323,7 +323,7 @@ under the License. org.apache.maven.plugins ma

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092263#comment-17092263 ] Tibor Digana commented on SUREFIRE-1570: Of course, it is null {{Lets see JDK

[jira] [Commented] (MNG-5577) Convert the core to use JSR 330 and remove the use of Plexus

2020-04-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-5577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092258#comment-17092258 ] Michael Osipov commented on MNG-5577: - Can you create a separate ticket for that? > Co

[jira] [Comment Edited] (MNG-6687) Convert Maven Compat to JSR 330

2020-04-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092256#comment-17092256 ] Michael Osipov edited comment on MNG-6687 at 4/25/20, 2:39 PM: --

[jira] [Comment Edited] (MNG-6687) Convert Maven Compat to JSR 330

2020-04-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092256#comment-17092256 ] Michael Osipov edited comment on MNG-6687 at 4/25/20, 2:39 PM: --

[jira] [Closed] (MNG-6687) Convert Maven Compat to JSR 330

2020-04-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6687. --- Fix Version/s: (was: wontfix-candidate) Resolution: Won't Fix compat will remain as-is and s

[jira] [Commented] (MNG-6687) Convert Maven Compat to JSR 330

2020-04-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092256#comment-17092256 ] Michael Osipov commented on MNG-6687: - Yes, there should be, inho. > Convert Maven Com

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-25 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092251#comment-17092251 ] Pavel_K commented on SUREFIRE-1570: --- [~tibordigana] Ok. I see. If you have 1-2 free

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092250#comment-17092250 ] Tibor Digana commented on SUREFIRE-1570: Just for your information, [~Pavel_K]

[jira] [Issue Comment Deleted] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1570: --- Comment: was deleted (was: [~Pavel_K] I don't undestand your troubles with project either

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092247#comment-17092247 ] Tibor Digana commented on SUREFIRE-1570: So what i want to say is that it is u

[jira] [Comment Edited] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092246#comment-17092246 ] Tibor Digana edited comment on SUREFIRE-1570 at 4/25/20, 2:06 PM: --

[jira] [Comment Edited] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092246#comment-17092246 ] Tibor Digana edited comment on SUREFIRE-1570 at 4/25/20, 2:05 PM: --

[jira] [Comment Edited] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092246#comment-17092246 ] Tibor Digana edited comment on SUREFIRE-1570 at 4/25/20, 2:05 PM: --

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092246#comment-17092246 ] Tibor Digana commented on SUREFIRE-1570: [~Pavel_K] You have to see all the co

[GitHub] [maven-invoker-plugin] khmarbaise commented on a change in pull request #20: [MINVOKER-250] streamLogsOnFailures

2020-04-25 Thread GitBox
khmarbaise commented on a change in pull request #20: URL: https://github.com/apache/maven-invoker-plugin/pull/20#discussion_r415069358 ## File path: src/main/java/org/apache/maven/plugins/invoker/VerifyMojo.java ## @@ -82,8 +82,16 @@ * * @since 1.9 */ -@

[GitHub] [maven-invoker-plugin] khmarbaise commented on a change in pull request #20: [MINVOKER-250] streamLogsOnFailures

2020-04-25 Thread GitBox
khmarbaise commented on a change in pull request #20: URL: https://github.com/apache/maven-invoker-plugin/pull/20#discussion_r415069040 ## File path: pom.xml ## @@ -323,7 +323,7 @@ under the License. org.apache.maven.plugins maven-in

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092244#comment-17092244 ] Tibor Digana commented on SUREFIRE-1570: [~Pavel_K] I don't undestand your tro

[jira] [Commented] (MNG-5577) Convert the core to use JSR 330 and remove the use of Plexus

2020-04-25 Thread Joseph Walton (Jira)
[ https://issues.apache.org/jira/browse/MNG-5577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092233#comment-17092233 ] Joseph Walton commented on MNG-5577: There's a single class still to do here; see earli

[jira] [Commented] (MNG-6687) Convert Maven Compat to JSR 330

2020-04-25 Thread Joseph Walton (Jira)
[ https://issues.apache.org/jira/browse/MNG-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092231#comment-17092231 ] Joseph Walton commented on MNG-6687: As the reporter, I'm totally fine with wontfix her

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-25 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092227#comment-17092227 ] Pavel_K commented on SUREFIRE-1570: --- [~tibordigana] To tell the truth I understood n

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092226#comment-17092226 ] Tibor Digana commented on SUREFIRE-1570: JPMS works for both but this issue is

[jira] [Comment Edited] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-25 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092221#comment-17092221 ] Pavel_K edited comment on SUREFIRE-1570 at 4/25/20, 12:55 PM: --

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-25 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092221#comment-17092221 ] Pavel_K commented on SUREFIRE-1570: --- [~tibordigana] Why when do I run my IT tests th

[jira] [Commented] (SUREFIRE-1780) Print JPMS errors from native stream of the fork JVM

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092213#comment-17092213 ] Tibor Digana commented on SUREFIRE-1780: [~Pavel_K] There's no difference agai

[jira] [Commented] (SUREFIRE-1780) Print JPMS errors from native stream of the fork JVM

2020-04-25 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092204#comment-17092204 ] Pavel_K commented on SUREFIRE-1780: --- [~tibordigana] Thank you very much! Finally I c

[jira] [Comment Edited] (SUREFIRE-1780) Print JPMS errors from native stream of the fork JVM

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092192#comment-17092192 ] Tibor Digana edited comment on SUREFIRE-1780 at 4/25/20, 11:57 AM: -

[jira] [Comment Edited] (SUREFIRE-1780) Print JPMS errors from native stream of the fork JVM

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092192#comment-17092192 ] Tibor Digana edited comment on SUREFIRE-1780 at 4/25/20, 11:55 AM: -

[jira] [Commented] (SUREFIRE-1780) Print JPMS errors from native stream of the fork JVM

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092192#comment-17092192 ] Tibor Digana commented on SUREFIRE-1780: [~Pavel_K] Pull new changes again. I

[jira] [Commented] (SUREFIRE-1780) Print JPMS errors from native stream of the fork JVM

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092191#comment-17092191 ] Tibor Digana commented on SUREFIRE-1780: https://gitbox.apache.org/repos/asf?p

[jira] [Comment Edited] (SUREFIRE-1780) Print JPMS errors from native stream of the fork JVM

2020-04-25 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092185#comment-17092185 ] Pavel_K edited comment on SUREFIRE-1780 at 4/25/20, 11:27 AM: --

[jira] [Commented] (SUREFIRE-1780) Print JPMS errors from native stream of the fork JVM

2020-04-25 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092185#comment-17092185 ] Pavel_K commented on SUREFIRE-1780: --- [~tibordigana] I have seen that you fixed this

[jira] [Commented] (SUREFIRE-1262) Add modulepath support

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092179#comment-17092179 ] Tibor Digana commented on SUREFIRE-1262: [~Pavel_K] Can we reuse [your projec

[jira] [Commented] (DOXIA-540) Update/remove ancient information on Doxia site

2020-04-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092174#comment-17092174 ] Michael Osipov commented on DOXIA-540: -- [~hboutemy], this is a pun on the Latin state

[jira] [Commented] (SUREFIRE-1262) Add modulepath support

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092161#comment-17092161 ] Tibor Digana commented on SUREFIRE-1262: [~Pavel_K] The fix is in master and n

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092160#comment-17092160 ] Tibor Digana commented on SUREFIRE-1570: [~Pavel_K] Stay tuned. Pls try to fin

[jira] [Comment Edited] (SUREFIRE-1780) Print JPMS errors from native stream of the fork JVM

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092155#comment-17092155 ] Tibor Digana edited comment on SUREFIRE-1780 at 4/25/20, 9:30 AM: --

[jira] [Closed] (SUREFIRE-1780) Print JPMS errors from native stream of the fork JVM

2020-04-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1780. -- Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=e0304d

[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path

2020-04-25 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092146#comment-17092146 ] Pavel_K commented on SUREFIRE-1570: --- [~tibordigana] I will be glad to help, but as I

[jira] [Closed] (MNG-6893) Update other plugins in superpom

2020-04-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-6893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MNG-6893. - Resolution: Won't Fix > Update other plugins in superpom >

[jira] [Updated] (MNG-6893) Update other plugins in superpom

2020-04-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-6893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-6893: -- Fix Version/s: (was: 3.7.0-candidate) > Update other plugins in superpom > --

[jira] [Commented] (MNG-6893) Update other plugins in superpom

2020-04-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-6893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092139#comment-17092139 ] Sylwester Lachiewicz commented on MNG-6893: --- Looks more complicated, see MNG-6054

[GitHub] [maven] michael-o commented on pull request #339: [MNG-6893] upgrade maven-antrun-plugin to 3.0.0

2020-04-25 Thread GitBox
michael-o commented on pull request #339: URL: https://github.com/apache/maven/pull/339#issuecomment-619345408 The purpose of the JIRA issue is to remove this plugin from the section. See also my thread on dev@. This is an a

[GitHub] [maven] slachiewicz commented on pull request #339: [MNG-6893] upgrade maven-antrun-plugin to 3.0.0

2020-04-25 Thread GitBox
slachiewicz commented on pull request #339: URL: https://github.com/apache/maven/pull/339#issuecomment-619345157 https://issues.apache.org/jira/browse/MNG-6054 This is an automated message from the Apache Git Service. To resp

  1   2   >