Tibor17 edited a comment on pull request #285:
URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-619463893


   You want to say that the inherited JAVA_HOME is a problem, right?
   This might be an issue but i don't think that we should touch the class 
`DefaultJavaToolChain` in `getEffectiveJvm()` so heavily due to we use the 
toolchain only in order to observe the path to the Java executable. There is an 
external library `maven-shared-utils` which contains the CLI API and it 
performs all the way how the JVM is launched. This library inherits all 
environments to the fork JVM from the default JVM. Therefore i added the config 
parameter `excludedEnvironmentVariables` due to this inheritance might be 
unwanted for some environments and users.
   
   Personally, i would say that `excludedEnvironmentVariables` should always 
contain `JAVA_HOME`.
   WDYT?
   
   Pls check it out only with this change and try to test and investigate the 
processes environmets again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to