gnodet commented on issue #261: [MNG-6697] New fast model interpolator not
using reflection
URL: https://github.com/apache/maven/pull/261#issuecomment-507964374
@Tibor17 The whole point of this PR is to actually provide a completely new
implementation of the `ModelInterpolator`, so that th
Tibor17 commented on issue #261: [MNG-6697] New fast model interpolator not
using reflection
URL: https://github.com/apache/maven/pull/261#issuecomment-507862291
`private static void evaluateArray( Object target, InterpolateObjectAction
ctx )` has unpleasant Java Reflection. Removing the r
Tibor17 edited a comment on issue #261: [MNG-6697] New fast model interpolator
not using reflection
URL: https://github.com/apache/maven/pull/261#issuecomment-507858570
If you want to improve the performance this `this.fields = fields.toArray(
new CacheField[0] );` should used real size an
Tibor17 commented on issue #261: [MNG-6697] New fast model interpolator not
using reflection
URL: https://github.com/apache/maven/pull/261#issuecomment-507858570
If you want to improve the performance this `this.fields = fields.toArray(
new CacheField[0] );` should used real size and not 0
Tibor17 commented on a change in pull request #261: [MNG-6697] New fast model
interpolator not using reflection
URL: https://github.com/apache/maven/pull/261#discussion_r299691453
##
File path:
maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringSearchModel
gnodet commented on issue #261: [MNG-6697] New fast model interpolator not
using reflection
URL: https://github.com/apache/maven/pull/261#issuecomment-507846100
> @gnodet
> The `HashMap` cannot perform better since it is not threadsafe.
There is no concurrent access at all for the
Tibor17 commented on issue #261: [MNG-6697] New fast model interpolator not
using reflection
URL: https://github.com/apache/maven/pull/261#issuecomment-507776816
@gnodet
Are you sure that the method `interpolate( String value )` is not used in
concurrent access?
I am mostly missing
Tibor17 commented on issue #261: [MNG-6697] New fast model interpolator not
using reflection
URL: https://github.com/apache/maven/pull/261#issuecomment-507775001
@gnodet
The `HashMap` cannot perform better since it is not threadsafe.
rfscholte commented on a change in pull request #264: [MNG-6535] Improve test
coverage of UrlNormalizer.
URL: https://github.com/apache/maven/pull/264#discussion_r299588903
##
File path:
maven-model-builder/src/test/java/org/apache/maven/model/path/DefaultUrlNormalizerTest.java
##
[
https://issues.apache.org/jira/browse/MJAVADOC-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877146#comment-16877146
]
Robert Scholte commented on MJAVADOC-583:
-
In all cases it is a matter of runni
[
https://issues.apache.org/jira/browse/MNG-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877128#comment-16877128
]
Robert Scholte commented on MNG-6691:
-
This all happened before I joined the team. [~cs
repolevedavaj edited a comment on issue #69: MNG-5899 Reactor should use
reduced dependency pom
URL: https://github.com/apache/maven/pull/69#issuecomment-507746758
Is there any update on this topic?
This is an automated messa
repolevedavaj commented on issue #69: MNG-5899 Reactor should use reduced
dependency pom
URL: https://github.com/apache/maven/pull/69#issuecomment-507746758
Is there any update on this topic? We are currently facing the issue that we
cannot deploy our project with the flatten plugin becaus
gnodet commented on issue #261: [MNG-6697] New fast model interpolator not
using reflection
URL: https://github.com/apache/maven/pull/261#issuecomment-507669256
I haven't been able to gain anything using a fork/join pool...
T
[
https://issues.apache.org/jira/browse/MNG-6604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876930#comment-16876930
]
Adam Gent edited comment on MNG-6604 at 7/2/19 12:48 PM:
-
Since thi
[
https://issues.apache.org/jira/browse/MNG-6604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876930#comment-16876930
]
Adam Gent commented on MNG-6604:
Since this is happening on our build machine and our build
[
https://issues.apache.org/jira/browse/MNG-6604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876928#comment-16876928
]
Adam Gent commented on MNG-6604:
[~michael-o] see my edits on previous comment.
We are usi
[
https://issues.apache.org/jira/browse/MNG-6604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876866#comment-16876866
]
Adam Gent edited comment on MNG-6604 at 7/2/19 12:39 PM:
-
We are ge
[
https://issues.apache.org/jira/browse/MNG-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876903#comment-16876903
]
Michael Osipov edited comment on MNG-6691 at 7/2/19 12:01 PM:
--
[
https://issues.apache.org/jira/browse/MNG-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876903#comment-16876903
]
Michael Osipov commented on MNG-6691:
-
[~rfscholte], I guess we don't have a formal spe
[
https://issues.apache.org/jira/browse/MNG-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876890#comment-16876890
]
dzikoysk commented on MNG-6691:
---
[~michael-o] that's right. The first implementation (PoC tha
[
https://issues.apache.org/jira/browse/MNG-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876890#comment-16876890
]
dzikoysk edited comment on MNG-6691 at 7/2/19 11:44 AM:
[~michael-o
[
https://issues.apache.org/jira/browse/MNG-6604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876896#comment-16876896
]
Michael Osipov commented on MNG-6604:
-
[~agentgt], I am quite certain that this is the
[
https://issues.apache.org/jira/browse/MNG-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876890#comment-16876890
]
dzikoysk edited comment on MNG-6691 at 7/2/19 11:47 AM:
[~michael-o
[
https://issues.apache.org/jira/browse/MNG-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876890#comment-16876890
]
dzikoysk edited comment on MNG-6691 at 7/2/19 11:44 AM:
[~michael-o
[
https://issues.apache.org/jira/browse/MNG-6604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816273#comment-16816273
]
Michael Osipov edited comment on MNG-6604 at 7/2/19 11:50 AM:
--
[
https://issues.apache.org/jira/browse/MNG-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876890#comment-16876890
]
dzikoysk edited comment on MNG-6691 at 7/2/19 11:46 AM:
[~michael-o
[
https://issues.apache.org/jira/browse/MNG-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876872#comment-16876872
]
Michael Osipov commented on MNG-6691:
-
Why do you need this? Do you plan to implement a
[
https://issues.apache.org/jira/browse/MNG-6604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876866#comment-16876866
]
Adam Gent commented on MNG-6604:
We are getting this issue as well however we are not using
gnodet commented on issue #261: [MNG-6697] New fast model interpolator not
using reflection
URL: https://github.com/apache/maven/pull/261#issuecomment-507626372
Fwiw, the changes to `StringSearchModelInterpolator` are not required, those
are left-overs from a previous optimization attempt,
[
https://issues.apache.org/jira/browse/MCOMPILER-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876863#comment-16876863
]
Paul Scholz commented on MCOMPILER-310:
---
Behavior did not change while using cla
Tibor17 commented on issue #261: [MNG-6697] New fast model interpolator not
using reflection
URL: https://github.com/apache/maven/pull/261#issuecomment-507617583
We can put a TODO comment for `computeIfAbsent` because this call is J8
related or wait for Mvn 3.7.0 where I guess it would be
Tibor17 commented on issue #261: [MNG-6697] New fast model interpolator not
using reflection
URL: https://github.com/apache/maven/pull/261#issuecomment-507616968
`FIELDS_CACHE` does not seem to have any usages, so it can be deleted.
It's better to use `ConcurrentHashMap` instead of `Hash
33 matches
Mail list logo
