gnodet commented on issue #261: [MNG-6697] New fast model interpolator not 
using reflection
URL: https://github.com/apache/maven/pull/261#issuecomment-507626372
 
 
   Fwiw, the changes to `StringSearchModelInterpolator` are not required, those 
are left-overs from a previous optimization attempt, before I actually write 
the new `StringVisitorModelInterpolator`.  Maybe I should just revert it back 
to the way it was.
   
   I believe in non-concurrent access, `HashMap` performs better than 
`ConcurrentHashMap`. For the new `StringVisitorModelInterpolator`, one 
additional performance improvement could be the usage of a fork/join pool.  
I'll give it a try to see if the visitor can gain anything running  in a 
fork/join pool.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to