rnveach commented on issue #16: Remove window line endings from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495955593
> a fix for Mcheckstyle54
Done and added the issue number to the commit message.
Just as a note, this patches the issue t
rnveach edited a comment on issue #16: Remove window line endings from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495954551
> what about adding in this commit a fix for Mcheckstyle54.java ?
That test is using the default sun_checks.xml, which has th
rnveach commented on issue #16: Remove window line endings from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495954551
> what about adding in this commit a fix for Mcheckstyle54.java ?
That test is using the default sun_checks.xml, which has the offen
rnveach commented on issue #16: Remove window line endings from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495954051
> Modern IDEs and text editors work fine with unix line endings on Windows.
Yes, it isn't a problem with working an existing fil
eolivelli commented on issue #16: Remove window line endings from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495951458
@Tibor17 I see.
Thanks.
Let's wait for the fix on checkstyle.
Them we will commit this patch and the upgrade of checkstyle t
[
https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848287#comment-16848287
]
Hudson commented on MNG-6573:
-
Build unstable in Jenkins: Maven TLP » maven » MNG-6071 #16
See
[
https://issues.apache.org/jira/browse/MNG-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848288#comment-16848288
]
Hudson commented on MNG-6071:
-
Build unstable in Jenkins: Maven TLP » maven » MNG-6071 #16
See
Tibor17 commented on issue #16: Remove window line endings from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495950799
@eolivelli
I mean https://github.com/checkstyle/checkstyle/pull/6559
One commit has been already pushed
https://github.com/chec
eolivelli commented on issue #16: Remove window line endings from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495949713
@Tibor17 which fix in checkstyle?
This is an automated message from
[
https://issues.apache.org/jira/browse/MNG-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz reassigned MNG-6638:
-
Assignee: (was: Sylwester Lachiewicz)
> MavenMetadataSource parses POMs unnece
[
https://issues.apache.org/jira/browse/MNG-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated MNG-5001:
--
Fix Version/s: (was: 3.6.2)
3.7.0-candidate
> @readonly Mojo param
Tibor17 commented on issue #16: Remove window line endings from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495948335
@eolivelli
Then let's wait for the fix in checkstyle dependency and we don't have to do
anything after this PR.
This PR is good
pzygielo opened a new pull request #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234
Encountered the problem of not firing `setUp`/`tearDown` instance methods of
POJO test - in
[2.22.2](https://github.com/apache/maven-surefire/releases/tag
eolivelli commented on issue #16: Remove window line endings from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495947225
I don't like very much the groovy script that rewrites a source file.
This is not safe, because those .java files are the sources
michael-o closed pull request #127: [MNG-6255] Fix concat_lines in mvn to deal
with CRLF
URL: https://github.com/apache/maven/pull/127
This is an automated message from the Apache Git Service.
To respond to the message, plea
[
https://issues.apache.org/jira/browse/MNG-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848278#comment-16848278
]
Michael Osipov commented on MNG-5001:
-
This might introduce side effects and should be
[
https://issues.apache.org/jira/browse/MNG-6637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6637:
Fix Version/s: (was: 3.6.2)
> NPE while trying to build Maven Site
>
michael-o commented on issue #244: [MNG-6638] - Prevent reparsing POMs in
MavenMetadataSource
URL: https://github.com/apache/maven/pull/244#issuecomment-495946458
@oehme Can you please rebase?
This is an automated message fro
Tibor17 commented on issue #16: Remove window line endings from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495945760
Not all ITs use the same rules.
Only some ITs use the problematic default rules, and there you have to write
the Groovy script like
jjlharrison commented on issue #16: Remove window line endings from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495943671
> I just recommend documenting this somewhere so it is clear that it is
required for windows users.
I wouldn’t say it was r
rnveach edited a comment on issue #16: Remove window line endings from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495939990
@eolivelli
Sorry for the confusion and not giving enough details in my first post. I
thought this would have been clearer.
rnveach commented on issue #16: Remove window line endings from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495939990
@eolivelli
Sorry for the confusion and not giving enough details in my first post. I
thought this would have been clearer.
This
eolivelli commented on issue #16: Remove window line endings from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495935712
I have amended the commit message and *force* pushed to
https://github.com/apache/maven-checkstyle-plugin/tree/MCHECKSTYLE-376
eolivelli commented on issue #22: [MSHADE-321] - Always respect
'createDependencyReducedPom' flag
URL: https://github.com/apache/maven-shade-plugin/pull/22#issuecomment-495935460
Let's wait for CI
https://builds.apache.org/job/maven-box/job/maven-shade-plugin/job/MSHADE-321/
--
jjlharrison commented on issue #16: Remove window line endings from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495928714
Windows users should be fine thanks to Git autocrlf.
This is an a
eolivelli commented on issue #16: Remove window line endings from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495927659
Will Windows users (developers of the plugin I mean) be happy with this
change? Or is it better to have CRLF every where?
-
eolivelli commented on issue #16: Remove window line endings from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495926067
So your are changing all to LF ?
In my fix I only changed Mcheckstyle54.java to CFLF.
Honestly I don't know if we have a ru
eolivelli commented on issue #16: Remove window line endings from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495925824
So this is your fix for MCHECKSTYLE-376.
Can you please change the commit message and the itle of the PR, this way we
will automa
[
https://issues.apache.org/jira/browse/MNG-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz closed MNG-6633.
-
Resolution: Fixed
> ExcludesArtifactFilter is a memory hog
> --
[
https://issues.apache.org/jira/browse/MNG-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848219#comment-16848219
]
Sylwester Lachiewicz commented on MNG-6633:
---
Fixed in
[790dc0f|https://gitbox.ap
[
https://issues.apache.org/jira/browse/SUREFIRE-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833768#comment-16833768
]
Dejan Stojadinović edited comment on SUREFIRE-1494 at 5/25/19 2:39 PM:
-
dejan2609 opened a new pull request #233: [SUREFIRE-1494] default provider for
JUnit4 integration tests is chaged (from 'surefire-junit4' to
'surefire-junit47')
URL: https://github.com/apache/maven-surefire/pull/233
Note: this is work in progress.
FYI @Tibor17
[
https://issues.apache.org/jira/browse/MACR-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise updated MACR-49:
Description:
Upgraded:
* maven-archiver 3.4.0
* plexus-archiver 4.1.0
* plexus-utils 3.2.0
[
https://issues.apache.org/jira/browse/MACR-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MACR-49.
---
Resolution: Fixed
Done in
[36ea9e52b1077134a8889a8525571d58ba99fbbf|https://gitbox.apache.org/r
[
https://issues.apache.org/jira/browse/MACR-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848210#comment-16848210
]
Hudson commented on MACR-49:
Build succeeded in Jenkins: Maven TLP » maven-acr-plugin » master #
[
https://issues.apache.org/jira/browse/MNG-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848203#comment-16848203
]
Hudson commented on MNG-6633:
-
Build unstable in Jenkins: Maven TLP » maven » master #209
See
asfgit closed pull request #243: [MNG-6633] - Reduce memory usage of excludes
URL: https://github.com/apache/maven/pull/243
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/MNG-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848192#comment-16848192
]
Hudson commented on MNG-6633:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-6633 #4
See
rnveach opened a new pull request #16: Remove window line endings from files
URL: https://github.com/apache/maven-checkstyle-plugin/pull/16
`mvn verify` and `mvn -Prun-its clean verify` passed.
This is an automated message fro
[
https://issues.apache.org/jira/browse/MACR-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise reassigned MACR-49:
---
Assignee: Karl Heinz Marbaise
> Upgrade plexus-archiver/maven-archiver/plexus-utils
> -
Karl Heinz Marbaise created MACR-49:
---
Summary: Upgrade plexus-archiver/maven-archiver/plexus-utils
Key: MACR-49
URL: https://issues.apache.org/jira/browse/MACR-49
Project: Maven ACR Plugin
michael-o commented on issue #243: [MNG-6633] - Reduce memory usage of excludes
URL: https://github.com/apache/maven/pull/243#issuecomment-495913632
@slachiewicz If this class has not been changed in this PR, then don't touch
it. Focus on that modified parts only.
-
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848165#comment-16848165
]
richard edited comment on MCHECKSTYLE-376 at 5/25/19 12:09 PM:
---
slachiewicz commented on issue #243: [MNG-6633] - Reduce memory usage of
excludes
URL: https://github.com/apache/maven/pull/243#issuecomment-495912627
I would also need to fix checkstyle issues (license header).
Propably we should also do the same with this class:
https://github.co
[
https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848166#comment-16848166
]
Hudson commented on MNG-6573:
-
Build succeeded in Jenkins: Maven TLP » maven-acr-plugin » maste
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848165#comment-16848165
]
richard commented on MCHECKSTYLE-376:
-
I had my own problems with line endings i
slachiewicz commented on issue #243: [MNG-6633] - Reduce memory usage of
excludes
URL: https://github.com/apache/maven/pull/243#issuecomment-495909386
Thanks for the reminder. I will make a merge in the next hour.
This is an
head-thrash commented on issue #22: [MSHADE-321] - Always respect
'createDependencyReducedPom' flag
URL: https://github.com/apache/maven-shade-plugin/pull/22#issuecomment-495909403
@eolivelli added IT test
This is an automate
michael-o commented on issue #243: [MNG-6633] - Reduce memory usage of excludes
URL: https://github.com/apache/maven/pull/243#issuecomment-495908563
Can we finally merge it, we have agreed to accept this change. @slachiewicz
you have assinged the ticket to yourself. Do you want to continue?
khmarbaise merged pull request #7: (doc) - fix some typos
URL: https://github.com/apache/maven-deploy-plugin/pull/7
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848147#comment-16848147
]
Hudson commented on MNG-6573:
-
Build unstable in Jenkins: Maven TLP » maven » MNG-6169/MNG-6556
[
https://issues.apache.org/jira/browse/MNG-6556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6556:
Description:
This affects:
||groupId||artifactId||[previous
version|https://maven.apache.org/ref/3.5
eolivelli commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any
dependencies
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/5#issuecomment-495887501
@famod this is interesting.
What about adding the dependency to the checkstyle plugin?
Cc @romani @rnveach
---
pzygielo opened a new pull request #7: (doc) - fix some typos
URL: https://github.com/apache/maven-deploy-plugin/pull/7
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have
54 matches
Mail list logo
