rnveach edited a comment on issue #16: Remove window line endings from files URL: https://github.com/apache/maven-checkstyle-plugin/pull/16#issuecomment-495939990 @eolivelli Sorry for the confusion and not giving enough details in my first post. I thought this would have been clearer. This is in response to MCHECKSTYLE-376 but is not a fix. This is why I didn't put the issue number in the commit message. None of the files in MCHECKSTYLE-376 were modified in this PR. I was just merely making all line endings the same in the repo. So the issue still remains for MCHECKSTYLE-376. Like I amended in the issue, I looked at the raw files reported and I saw nothing wrong, so I believe the issue to be how it is cloned. > Will Windows users be happy with this change? > Windows users should be fine thanks to Git autocrlf. I just recommend documenting this somewhere so it is clear that it is required for windows users. As this PR demonstrates, there are no checks to ensure future files remain with 1 line ending.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
