[GitHub] Tibor17 commented on issue #218: [SUREFIRE-1004] Support full gavtc format for dependenciesToScan

2019-01-26 Thread GitBox
Tibor17 commented on issue #218: [SUREFIRE-1004] Support full gavtc format for dependenciesToScan URL: https://github.com/apache/maven-surefire/pull/218#issuecomment-457895925 @rehevkor5 If `PatternIncludesArtifactFilter` is applicable in this PR and improves the code then yes please g

[jira] [Updated] (SUREFIRE-1004) Enhance pattern/wildcard capabilities for dependenciesToScan to GAVT

2019-01-26 Thread Tibor Digana (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1004: --- Fix Version/s: 3.0.0-M5 > Enhance pattern/wildcard capabilities for dependenciesToScan to

[GitHub] Tibor17 commented on issue #218: [SUREFIRE-1004] Support full gavtc format for dependenciesToScan

2019-01-26 Thread GitBox
Tibor17 commented on issue #218: [SUREFIRE-1004] Support full gavtc format for dependenciesToScan URL: https://github.com/apache/maven-surefire/pull/218#issuecomment-457895184 @rehevkor5 Thank you that you rebased these commits. This is really a good feature. You have saved our time.

[jira] [Updated] (SUREFIRE-1004) Enhance pattern/wildcard capabilities for dependenciesToScan to GAVT

2019-01-26 Thread Tibor Digana (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1004: --- Fix Version/s: (was: 3.0.0-M5) 3.0.0-M4 > Enhance pattern/wildcard

[GitHub] Tibor17 edited a comment on issue #214: Junit5 displayname

2019-01-26 Thread GitBox
Tibor17 edited a comment on issue #214: Junit5 displayname URL: https://github.com/apache/maven-surefire/pull/214#issuecomment-457893606 @eolivelli Additionally, I have fixed missing system properties and missing execution time in JUnit5 Provider. Before both were empty and the xml r

[GitHub] Tibor17 commented on issue #214: Junit5 displayname

2019-01-26 Thread GitBox
Tibor17 commented on issue #214: Junit5 displayname URL: https://github.com/apache/maven-surefire/pull/214#issuecomment-457893606 @eolivelli Additionally, I have fixed missing system properties and missing execution time. Before both were empty and the xml reporter calculated executi

[jira] [Commented] (MPOM-216) Update java minimum version to 7

2019-01-26 Thread Robert Wertman (JIRA)
[ https://issues.apache.org/jira/browse/MPOM-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753288#comment-16753288 ] Robert Wertman commented on MPOM-216: - I believe I've created the proper update for thi

[jira] [Updated] (MPOM-216) Update java minimum version to 7

2019-01-26 Thread Robert Wertman (JIRA)
[ https://issues.apache.org/jira/browse/MPOM-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Wertman updated MPOM-216: Attachment: MPOM-216-maven-parent.patch > Update java minimum version to 7 >

[jira] [Created] (MJAVADOC-571) javadoc:aggregate triggers Javadoc error for test-only modules

2019-01-26 Thread Gili (JIRA)
Gili created MJAVADOC-571: - Summary: javadoc:aggregate triggers Javadoc error for test-only modules Key: MJAVADOC-571 URL: https://issues.apache.org/jira/browse/MJAVADOC-571 Project: Maven Javadoc Plugin

[jira] [Updated] (MJAVADOC-571) javadoc:aggregate triggers Javadoc error for test-only modules

2019-01-26 Thread Gili (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gili updated MJAVADOC-571: -- Attachment: testcase.zip > javadoc:aggregate triggers Javadoc error for test-only modules > -

[jira] [Updated] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules

2019-01-26 Thread Gili (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gili updated MJAVADOC-569: -- Attachment: export-to-testcase.zip > javadoc:aggregate fails with 'error: package org.w3c.dom is not visible'

[jira] [Commented] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules

2019-01-26 Thread Gili (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753251#comment-16753251 ] Gili commented on MJAVADOC-569: --- export-to-testcase.zip also exposes another bug. * Run

[jira] [Commented] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules

2019-01-26 Thread Gili (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753250#comment-16753250 ] Gili commented on MJAVADOC-569: --- I got it working (export-to-testcase.zip) but I think it

[jira] [Commented] (MSHARED-787) Add optional buildEnvironment information to the manifest

2019-01-26 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753232#comment-16753232 ] Michael Osipov commented on MSHARED-787: The value of {{Build-Tool}} will be rep

[jira] [Commented] (MSHARED-796) use java.specification.version instead of java.version in Build-Jdk manifest entry

2019-01-26 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753210#comment-16753210 ] Michael Osipov commented on MSHARED-796: [~hboutemy], while picking up MSHARED-7

[jira] [Comment Edited] (MSHARED-796) use java.specification.version instead of java.version in Build-Jdk manifest entry

2019-01-26 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753210#comment-16753210 ] Michael Osipov edited comment on MSHARED-796 at 1/26/19 10:48 PM:

[GitHub] eolivelli commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files

2019-01-26 Thread GitBox
eolivelli commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files URL: https://github.com/apache/maven-enforcer/pull/45#issuecomment-457868823 CI is green. As @khmarbaise already added comments I would like to have his opinion before committing. thanks

[jira] [Commented] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules

2019-01-26 Thread Gili (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753197#comment-16753197 ] Gili commented on MJAVADOC-569: --- Actually, I'm not sure that this issue is fully resolved

[jira] [Commented] (MSHARED-781) Upgrade to Plexus Archiver 4.1.0

2019-01-26 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753187#comment-16753187 ] Hudson commented on MSHARED-781: Build succeeded in Jenkins: Maven TLP » maven-archiver

[jira] [Closed] (MSHARED-781) Upgrade to Plexus Archiver 4.1.0

2019-01-26 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSHARED-781. -- Resolution: Fixed Fixed with [d4ea60cb9dfc7e51a81ffcb215add1d3b459ced5|https://gitbox.apache.

[jira] [Updated] (MSHARED-781) Upgrade to Plexus Archiver 4.1.0

2019-01-26 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSHARED-781: --- Summary: Upgrade to Plexus Archiver 4.1.0 (was: Upgrade plexus-archiver 4.1.0) > Upgrade t

[jira] [Commented] (WAGON-545) Connection reset while downloading artefacts in cloud environment (Azure)

2019-01-26 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/WAGON-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753182#comment-16753182 ] Michael Osipov commented on WAGON-545: -- [~cdomsch], looked in to the new log. For the

[GitHub] belingueres commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion

2019-01-26 Thread GitBox
belingueres commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion URL: https://github.com/apache/maven/pull/234#discussion_r251212314 ## File path: maven-artifact/src/main/java/org/apache/maven/artifa

[jira] [Commented] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules

2019-01-26 Thread Gili (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753179#comment-16753179 ] Gili commented on MJAVADOC-569: --- PR for review: https://github.com/apache/maven-javadoc-p

[jira] [Commented] (MJAVADOC-570) --add-modules expects comma-separated arguments

2019-01-26 Thread Gili (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753180#comment-16753180 ] Gili commented on MJAVADOC-570: --- Added PR for review: https://github.com/apache/maven-jav

[GitHub] cowwoc opened a new pull request #19: Avoid converting separator characters into newline.

2019-01-26 Thread GitBox
cowwoc opened a new pull request #19: Avoid converting separator characters into newline. URL: https://github.com/apache/maven-javadoc-plugin/pull/19 Updated testCustomConfiguration() because JDK 11.0.2 behaves the same as JDK 12. --

[GitHub] cowwoc opened a new pull request #18: Added example of --add-modules to aggregate FAQ.

2019-01-26 Thread GitBox
cowwoc opened a new pull request #18: Added example of --add-modules to aggregate FAQ. URL: https://github.com/apache/maven-javadoc-plugin/pull/18 This is an automated message from the Apache Git Service. To respond to the m

[jira] [Commented] (WAGON-545) Connection reset while downloading artefacts in cloud environment (Azure)

2019-01-26 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/WAGON-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753175#comment-16753175 ] Michael Osipov commented on WAGON-545: -- [~olegk], please have a look at connection 27

[jira] [Commented] (WAGON-545) Connection reset while downloading artefacts in cloud environment (Azure)

2019-01-26 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/WAGON-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753176#comment-16753176 ] Michael Osipov commented on WAGON-545: -- [~cdomsch], if you look into the HttpClient c

[jira] [Commented] (SUREFIRE-1620) Replaced deprecated component ArtifactFactory with RepositorySystem

2019-01-26 Thread Sylwester Lachiewicz (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753170#comment-16753170 ] Sylwester Lachiewicz commented on SUREFIRE-1620: Unfortunately, we hav

[jira] [Updated] (MJAVADOC-570) --add-modules expects comma-separated arguments

2019-01-26 Thread Gili (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gili updated MJAVADOC-570: -- Description: It's quicker for me to explain this problem that produce a minimal testcase for it. In Abstract

[GitHub] michael-o commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion

2019-01-26 Thread GitBox
michael-o commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion URL: https://github.com/apache/maven/pull/234#discussion_r251211456 ## File path: maven-artifact/src/main/java/org/apache/maven/artifact

[jira] [Updated] (MJAVADOC-570) --add-modules expects comma-separated arguments

2019-01-26 Thread Gili (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gili updated MJAVADOC-570: -- Description: It's quicker for me to explain this problem that produce a minimal testcase for it. In Abstract

[jira] [Comment Edited] (MJAVADOC-570) --add-modules expects comma-separated arguments

2019-01-26 Thread Gili (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753161#comment-16753161 ] Gili edited comment on MJAVADOC-570 at 1/26/19 7:52 PM: It look

[GitHub] belingueres commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion

2019-01-26 Thread GitBox
belingueres commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion URL: https://github.com/apache/maven/pull/234#discussion_r251210661 ## File path: maven-artifact/src/main/java/org/apache/maven/artifa

[jira] [Comment Edited] (MJAVADOC-570) --add-modules expects comma-separated arguments

2019-01-26 Thread Gili (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753161#comment-16753161 ] Gili edited comment on MJAVADOC-570 at 1/26/19 7:49 PM: Taking

[jira] [Commented] (MJAVADOC-570) --add-modules expects comma-separated arguments

2019-01-26 Thread Gili (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753161#comment-16753161 ] Gili commented on MJAVADOC-570: --- This a look at the code, this seems to affect everything

[jira] [Updated] (MJAVADOC-570) --add-modules expects comma-separated arguments

2019-01-26 Thread Gili (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gili updated MJAVADOC-570: -- Description: It's quicker for me to explain this problem that produce a minimal testcase for it. In Abstract

[jira] [Updated] (MNG-6561) New RepositorySystem implementation as replacement of deprecated from maven-compat

2019-01-26 Thread Sylwester Lachiewicz (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-6561: -- Description: Create component that will replace org.apache.maven.repository.RepositorySys

[jira] [Updated] (MNG-6561) New RepositorySystem implementation as replacement of deprecated from maven-compat

2019-01-26 Thread Sylwester Lachiewicz (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-6561: -- Summary: New RepositorySystem implementation as replacement of deprecated from maven-comp

[jira] [Updated] (MNG-6561) New RepositorySystem implementation as replacement of deprecated from maven-compat

2019-01-26 Thread Sylwester Lachiewicz (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-6561: -- Description: Create a component that will replace org.apache.maven.repository.Repository

[jira] [Created] (MJAVADOC-570) --add-modules expects comma-separated arguments

2019-01-26 Thread Gili (JIRA)
Gili created MJAVADOC-570: - Summary: --add-modules expects comma-separated arguments Key: MJAVADOC-570 URL: https://issues.apache.org/jira/browse/MJAVADOC-570 Project: Maven Javadoc Plugin Issue Type

[jira] [Comment Edited] (MJAVADOC-568) javadoc:jar fails when project has Automatic-Module-Name and (implicit) uses offlinelinks with element-list

2019-01-26 Thread Gili (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753157#comment-16753157 ] Gili edited comment on MJAVADOC-568 at 1/26/19 7:25 PM: That's

[jira] [Commented] (MJAVADOC-568) javadoc:jar fails when project has Automatic-Module-Name and (implicit) uses offlinelinks with element-list

2019-01-26 Thread Gili (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753157#comment-16753157 ] Gili commented on MJAVADOC-568: ---   That's a good catch for the MANIFEST.MF file. Can you

[GitHub] rfscholte commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion

2019-01-26 Thread GitBox
rfscholte commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion URL: https://github.com/apache/maven/pull/234#discussion_r251208546 ## File path: maven-artifact/src/main/java/org/apache/maven/artifact

[jira] [Commented] (MNG-6579) Externalize org.apache.maven.repository.internal.MavenRepositorySystemUtils

2019-01-26 Thread Robert Scholte (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753149#comment-16753149 ] Robert Scholte commented on MNG-6579: - I'd like to have a concrete example, because my

[GitHub] rfscholte commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion

2019-01-26 Thread GitBox
rfscholte commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion URL: https://github.com/apache/maven/pull/234#discussion_r251208540 ## File path: maven-artifact/src/main/java/org/apache/maven/artifact

[GitHub] rfscholte commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion

2019-01-26 Thread GitBox
rfscholte commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion URL: https://github.com/apache/maven/pull/234#discussion_r251208504 ## File path: maven-artifact/src/main/java/org/apache/maven/artifact

[GitHub] michael-o commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion

2019-01-26 Thread GitBox
michael-o commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion URL: https://github.com/apache/maven/pull/234#discussion_r251208278 ## File path: maven-artifact/src/main/java/org/apache/maven/artifact

[GitHub] michael-o commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion

2019-01-26 Thread GitBox
michael-o commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion URL: https://github.com/apache/maven/pull/234#discussion_r251208321 ## File path: maven-artifact/src/main/java/org/apache/maven/artifact

[GitHub] michael-o commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion

2019-01-26 Thread GitBox
michael-o commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion URL: https://github.com/apache/maven/pull/234#discussion_r251208223 ## File path: maven-artifact/src/main/java/org/apache/maven/artifact

[jira] [Updated] (MNG-6579) Externalize org.apache.maven.repository.internal.MavenRepositorySystemUtils

2019-01-26 Thread Sylwester Lachiewicz (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-6579: -- Fix Version/s: 3.x / Backlog > Externalize org.apache.maven.repository.internal.MavenRepo

[GitHub] slachiewicz opened a new pull request #235: [MNG-6573] Use Maven 3.6.0 for CI

2019-01-26 Thread GitBox
slachiewicz opened a new pull request #235: [MNG-6573] Use Maven 3.6.0 for CI URL: https://github.com/apache/maven/pull/235 This is an automated message from the Apache Git Service. To respond to the message, please log on Gi

[jira] [Moved] (MNG-6579) Externalize org.apache.maven.repository.internal.MavenRepositorySystemUtils

2019-01-26 Thread Karl Heinz Marbaise (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise moved MRESOLVER-49 to MNG-6579: --- Component/s: (was: resolver) Key: MNG-6579 (wa

[jira] [Updated] (MRESOLVER-53) Document runtime exceptions

2019-01-26 Thread Sylwester Lachiewicz (JIRA)
[ https://issues.apache.org/jira/browse/MRESOLVER-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MRESOLVER-53: -- Labels: up-for-grabs (was: ) > Document runtime exceptions > ---

[GitHub] rfscholte commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion

2019-01-26 Thread GitBox
rfscholte commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion URL: https://github.com/apache/maven/pull/234#discussion_r251204755 ## File path: maven-artifact/src/main/java/org/apache/maven/artifact

[GitHub] rfscholte commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion

2019-01-26 Thread GitBox
rfscholte commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion URL: https://github.com/apache/maven/pull/234#discussion_r251204786 ## File path: maven-artifact/src/test/java/org/apache/maven/artifact

[GitHub] rfscholte commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion

2019-01-26 Thread GitBox
rfscholte commented on a change in pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion URL: https://github.com/apache/maven/pull/234#discussion_r251204755 ## File path: maven-artifact/src/main/java/org/apache/maven/artifact

[jira] [Updated] (MNG-6558) ToolchainsBuildingResult event is not sent on EventSpy

2019-01-26 Thread Sylwester Lachiewicz (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-6558: -- Fix Version/s: 3.6.x-candidate > ToolchainsBuildingResult event is not sent on EventSpy >

[jira] [Updated] (MNG-5995) Maven itself cannot run without maven-compat

2019-01-26 Thread Sylwester Lachiewicz (JIRA)
[ https://issues.apache.org/jira/browse/MNG-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-5995: -- Fix Version/s: (was: 3.6.x-candidate) 3.6.1 > Maven itself cannot

[jira] [Commented] (MJAVADOC-568) javadoc:jar fails when project has Automatic-Module-Name and (implicit) uses offlinelinks with element-list

2019-01-26 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753125#comment-16753125 ] Hudson commented on MJAVADOC-568: - Build succeeded in Jenkins: Maven TLP » maven-javado

[jira] [Updated] (MNG-6561) Remove usage of deprecated maven-compat module - RepositorySystem

2019-01-26 Thread Sylwester Lachiewicz (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-6561: -- Fix Version/s: 3.6.x-candidate > Remove usage of deprecated maven-compat module - Reposit

[jira] [Closed] (MNG-5995) Maven itself cannot run without maven-compat

2019-01-26 Thread Sylwester Lachiewicz (JIRA)
[ https://issues.apache.org/jira/browse/MNG-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MNG-5995. - Resolution: Fixed > Maven itself cannot run without maven-compat >

[GitHub] slachiewicz closed pull request #185: [MNG-5995] Remove dependency to maven-compat

2019-01-26 Thread GitBox
slachiewicz closed pull request #185: [MNG-5995] Remove dependency to maven-compat URL: https://github.com/apache/maven/pull/185 This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (MNG-5995) Maven itself cannot run without maven-compat

2019-01-26 Thread Sylwester Lachiewicz (JIRA)
[ https://issues.apache.org/jira/browse/MNG-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753120#comment-16753120 ] Sylwester Lachiewicz commented on MNG-5995: --- Fixed in  [bb3ec5da71d26d105972392f0

[jira] [Closed] (MJAVADOC-568) javadoc:jar fails when project has Automatic-Module-Name and (implicit) uses offlinelinks with element-list

2019-01-26 Thread Robert Scholte (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MJAVADOC-568. --- Resolution: Fixed Assignee: Robert Scholte Fixed in [8e7b265b35109566428ee32f8cb

[jira] [Commented] (MNG-5995) Maven itself cannot run without maven-compat

2019-01-26 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MNG-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753111#comment-16753111 ] Hudson commented on MNG-5995: - Build succeeded in Jenkins: Maven TLP » maven » master #144 See

[jira] [Commented] (MENFORCER-277) Upgrade maven-dependency-tree to 3.x

2019-01-26 Thread Gabriel Belingueres (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753110#comment-16753110 ] Gabriel Belingueres commented on MENFORCER-277: --- Not ready yet. I'm in t

[jira] [Commented] (MNG-5995) Maven itself cannot run without maven-compat

2019-01-26 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MNG-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753106#comment-16753106 ] Hudson commented on MNG-5995: - Build succeeded in Jenkins: Maven TLP » maven » maven36x #4 See

[jira] [Updated] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?

2019-01-26 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated MENFORCER-324: -- Fix Version/s: 3.0.0 > Shouldn't we use System.lineSeparator() instead of \n ? > ---

[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?

2019-01-26 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753093#comment-16753093 ] Hudson commented on MENFORCER-324: -- Build succeeded in Jenkins: Maven TLP » maven-enf

[GitHub] eolivelli commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files

2019-01-26 Thread GitBox
eolivelli commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files URL: https://github.com/apache/maven-enforcer/pull/45#issuecomment-457835584 see CI results https://builds.apache.org/job/maven-box/job/maven-enforcer/job/MENFORCER-319/ I have squashed a

[jira] [Resolved] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?

2019-01-26 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli resolved MENFORCER-324. --- Resolution: Fixed > Shouldn't we use System.lineSeparator() instead of \n ? >

[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?

2019-01-26 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753091#comment-16753091 ] Enrico Olivelli commented on MENFORCER-324: --- merged as 7e2a57ba338000c62c226

[jira] [Assigned] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?

2019-01-26 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli reassigned MENFORCER-324: - Assignee: Enrico Olivelli > Shouldn't we use System.lineSeparator() instead o

[GitHub] eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?

2019-01-26 Thread GitBox
eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-457835240 merged as 7e2a57ba338000c62c22690e070796d7e870179e thank you @jsoref ---

[jira] [Created] (SUREFIRE-1630) sonarqube reports 0% coverage with maven-surefire-plugin versions later than 2.20

2019-01-26 Thread Steinar Bang (JIRA)
Steinar Bang created SUREFIRE-1630: -- Summary: sonarqube reports 0% coverage with maven-surefire-plugin versions later than 2.20 Key: SUREFIRE-1630 URL: https://issues.apache.org/jira/browse/SUREFIRE-1630

[jira] [Commented] (MENFORCER-277) Upgrade maven-dependency-tree to 3.x

2019-01-26 Thread Robert Scholte (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753088#comment-16753088 ] Robert Scholte commented on MENFORCER-277: -- IIRC there are still broken ITs a

[jira] [Commented] (SUREFIRE-1630) sonarqube reports 0% coverage with maven-surefire-plugin versions later than 2.20

2019-01-26 Thread Steinar Bang (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753086#comment-16753086 ] Steinar Bang commented on SUREFIRE-1630: The simplest way to test this behavio

[jira] [Commented] (MENFORCER-277) Upgrade maven-dependency-tree to 3.x

2019-01-26 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753054#comment-16753054 ] Enrico Olivelli commented on MENFORCER-277: --- [~rfscholte] [~belingueres] wha

[jira] [Assigned] (MENFORCER-314) DependencyConvergence fails sporadically with a null message

2019-01-26 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli reassigned MENFORCER-314: - Assignee: Enrico Olivelli > DependencyConvergence fails sporadically with a n

[GitHub] eolivelli commented on issue #43: [MENFORCER-314] - Warn if EnforcerRuleException has no message

2019-01-26 Thread GitBox
eolivelli commented on issue #43: [MENFORCER-314] - Warn if EnforcerRuleException has no message URL: https://github.com/apache/maven-enforcer/pull/43#issuecomment-457833763 @famod I prefer this one. Can you add a simple integration test ? This way in the future we would not add regress

[jira] [Commented] (MJAVADOC-568) javadoc:jar fails when project has Automatic-Module-Name and (implicit) uses offlinelinks with element-list

2019-01-26 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753045#comment-16753045 ] Hudson commented on MJAVADOC-568: - Build succeeded in Jenkins: Maven TLP » maven-javado

[jira] [Commented] (SUREFIRE-1629) Plugin crashes if tests are forked and JPMS error occurs

2019-01-26 Thread Gili (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753048#comment-16753048 ] Gili commented on SUREFIRE-1629: I've attached a testcase. Run "mvn clean test" to rep

[jira] [Updated] (SUREFIRE-1629) Plugin crashes if tests are forked and JPMS error occurs

2019-01-26 Thread Gili (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gili updated SUREFIRE-1629: --- Attachment: testcase.zip > Plugin crashes if tests are forked and JPMS error occurs >

[jira] [Updated] (SUREFIRE-1629) Plugin crashes if tests are forked and JPMS error occurs

2019-01-26 Thread Gili (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gili updated SUREFIRE-1629: --- Summary: Plugin crashes if tests are forked and JPMS error occurs (was: Improve error message for JPMS lo

[GitHub] eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?

2019-01-26 Thread GitBox
eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-457832530 Last run of CI, then merging https://builds.apache.org/job/maven-box/job/maven-enforcer/job/MENFORCER-324/ --

[jira] [Updated] (MJAVADOC-568) javadoc:jar fails when project has Automatic-Module-Name and (implicit) uses offlinelinks with element-list

2019-01-26 Thread Robert Scholte (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MJAVADOC-568: Summary: javadoc:jar fails when project has Automatic-Module-Name and (implicit) uses off

[GitHub] eolivelli commented on issue #3: [MSCRIPTING-1] Squashed all commits from MSCRIPTING-1 branch

2019-01-26 Thread GitBox
eolivelli commented on issue #3: [MSCRIPTING-1] Squashed all commits from MSCRIPTING-1 branch URL: https://github.com/apache/maven-scripting-plugin/pull/3#issuecomment-457822302 I hope we will be able to merge this soon. Sorry for this taking so long ---

[jira] [Issue Comment Deleted] (MNG-6240) Duplicate components in plugin extension realm when plugin depends on maven-aether-resolver

2019-01-26 Thread Robert Scholte (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MNG-6240: Comment: was deleted (was: SUCCESS: Integrated in Jenkins build maven-3.x #1658 (See [https://builds

[jira] [Comment Edited] (MNG-6240) Duplicate components in plugin extension realm when plugin depends on maven-aether-resolver

2019-01-26 Thread Robert Scholte (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049441#comment-16049441 ] Robert Scholte edited comment on MNG-6240 at 1/26/19 10:57 AM: --

[GitHub] rpopov opened a new pull request #3: [MSCRIPTING-1] Squashed all commits from MSCRIPTING-1 branch

2019-01-26 Thread GitBox
rpopov opened a new pull request #3: [MSCRIPTING-1] Squashed all commits from MSCRIPTING-1 branch URL: https://github.com/apache/maven-scripting-plugin/pull/3 [MSCRIPTING-1] Squashed all commits from MSCRIPTING-1 branch - see the [corresponding pull request](https://github.com/apache/mave

[GitHub] belingueres opened a new pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion

2019-01-26 Thread GitBox
belingueres opened a new pull request #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion URL: https://github.com/apache/maven/pull/234 - Added class IntItem and LongItem for handling numbers lower than 2^31 and 2^63. - Renamed IntegerItem