[GitHub] eolivelli commented on issue #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting

2018-12-11 Thread GitBox
eolivelli commented on issue #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#issuecomment-446495043 https://builds.apache.org/job/maven-box/job/maven-checkstyle-plugin/job/MCHECKSTYLE-357/1/ --

[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting

2018-12-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718573#comment-16718573 ] ASF GitHub Bot commented on MCHECKSTYLE-357: eolivelli commented on issu

[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting

2018-12-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718564#comment-16718564 ] ASF GitHub Bot commented on MCHECKSTYLE-357: eolivelli commented on issu

[GitHub] eolivelli commented on issue #7: [MCHECKSTYLE-357] - also allow inline configuration for reporting

2018-12-11 Thread GitBox
eolivelli commented on issue #7: [MCHECKSTYLE-357] - also allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#issuecomment-446491029 Sorry for late reply. The patch looks good to me. Let's see CI results

[GitHub] Serranya commented on issue #7: [MCHECKSTYLE-357] - also allow inline configuration for reporting

2018-12-11 Thread GitBox
Serranya commented on issue #7: [MCHECKSTYLE-357] - also allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#issuecomment-446489371 Is there anything I can do to accelerate acceptance of this patch? ---

[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting

2018-12-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718560#comment-16718560 ] ASF GitHub Bot commented on MCHECKSTYLE-357: Serranya commented on issue

[jira] [Commented] (MRESOLVER-64) restore setLoggerFactory(...) API deleted from version 1.3.0

2018-12-11 Thread Dan Tran (JIRA)
[ https://issues.apache.org/jira/browse/MRESOLVER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718504#comment-16718504 ] Dan Tran commented on MRESOLVER-64: --- Are we all set? 😈 > restore setLoggerFactory(..

[GitHub] eolivelli commented on a change in pull request #1: adding type safety

2018-12-11 Thread GitBox
eolivelli commented on a change in pull request #1: adding type safety URL: https://github.com/apache/maven-gpg-plugin/pull/1#discussion_r240890241 ## File path: src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java ## @@ -193,9 +195,9 @@ public File generateSign

[GitHub] eolivelli commented on a change in pull request #1: adding type safety

2018-12-11 Thread GitBox
eolivelli commented on a change in pull request #1: adding type safety URL: https://github.com/apache/maven-gpg-plugin/pull/1#discussion_r240799129 ## File path: src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java ## @@ -193,9 +195,9 @@ public File generateSign

[GitHub] eolivelli commented on a change in pull request #1: adding type safety

2018-12-11 Thread GitBox
eolivelli commented on a change in pull request #1: adding type safety URL: https://github.com/apache/maven-gpg-plugin/pull/1#discussion_r240799129 ## File path: src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java ## @@ -193,9 +195,9 @@ public File generateSign

[GitHub] lanlingxueyu closed pull request #207: 2.19.2 experimental

2018-12-11 Thread GitBox
lanlingxueyu closed pull request #207: 2.19.2 experimental URL: https://github.com/apache/maven-surefire/pull/207 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and u

[GitHub] lanlingxueyu opened a new pull request #208: Update StatelessXmlReporter.java

2018-12-11 Thread GitBox
lanlingxueyu opened a new pull request #208: Update StatelessXmlReporter.java URL: https://github.com/apache/maven-surefire/pull/208 Sort methodRunHistoryMap This is an automated message from the Apache Git Service. To respond

[GitHub] lanlingxueyu opened a new pull request #207: 2.19.2 experimental

2018-12-11 Thread GitBox
lanlingxueyu opened a new pull request #207: 2.19.2 experimental URL: https://github.com/apache/maven-surefire/pull/207 Eliminate *Test.xml report out of order differences This is an automated message from the Apache Git Servi

[jira] [Issue Comment Deleted] (MJMOD-20) Main class is not being set by maven-jmod-plugin

2018-12-11 Thread Andre Tadeu de Carvalho (JIRA)
[ https://issues.apache.org/jira/browse/MJMOD-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andre Tadeu de Carvalho updated MJMOD-20: - Comment: was deleted (was: Hi, Here is the PR: [https://github.com/apache/maven-jm

[jira] [Commented] (MJMOD-20) Main class is not being set by maven-jmod-plugin

2018-12-11 Thread Andre Tadeu de Carvalho (JIRA)
[ https://issues.apache.org/jira/browse/MJMOD-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718324#comment-16718324 ] Andre Tadeu de Carvalho commented on MJMOD-20: -- Hi, Here is the PR: [https://

[jira] [Created] (MJMOD-20) Main class is not being set by maven-jmod-plugin

2018-12-11 Thread Andre Tadeu de Carvalho (JIRA)
Andre Tadeu de Carvalho created MJMOD-20: Summary: Main class is not being set by maven-jmod-plugin Key: MJMOD-20 URL: https://issues.apache.org/jira/browse/MJMOD-20 Project: Maven JMod Plugin

[jira] [Commented] (MJMOD-20) Main class is not being set by maven-jmod-plugin

2018-12-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MJMOD-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718322#comment-16718322 ] ASF GitHub Bot commented on MJMOD-20: - andretadeu opened a new pull request #1: [MJMOD-

[GitHub] andretadeu opened a new pull request #1: [MJMOD-20] set jmod --main-class argument if it is set.

2018-12-11 Thread GitBox
andretadeu opened a new pull request #1: [MJMOD-20] set jmod --main-class argument if it is set. URL: https://github.com/apache/maven-jmod-plugin/pull/1 Hi! This pull request sets the parameter --main-class if it was set in: ``` org.apache.maven.plugins

[GitHub] javabeanz commented on a change in pull request #1: adding type safety

2018-12-11 Thread GitBox
javabeanz commented on a change in pull request #1: adding type safety URL: https://github.com/apache/maven-gpg-plugin/pull/1#discussion_r240835336 ## File path: src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java ## @@ -193,9 +195,9 @@ public File generateSign

[jira] [Commented] (SUREFIRE-1017) Failures do not show test-package since 2.13

2018-12-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718036#comment-16718036 ] ASF GitHub Bot commented on SUREFIRE-1017: -- Tibor17 closed pull request #92:

[GitHub] Tibor17 closed pull request #92: [SUREFIRE-1017] Failures do not show test-package since 2.13

2018-12-11 Thread GitBox
Tibor17 closed pull request #92: [SUREFIRE-1017] Failures do not show test-package since 2.13 URL: https://github.com/apache/maven-surefire/pull/92 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[jira] [Closed] (SUREFIRE-1017) Failures do not show test-package since 2.13

2018-12-11 Thread Tibor Digana (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1017. -- Resolution: Won't Fix I agree with [~krosenvold] {{How hard would it be to dynamically expan

[GitHub] eolivelli commented on a change in pull request #1: adding type safety

2018-12-11 Thread GitBox
eolivelli commented on a change in pull request #1: adding type safety URL: https://github.com/apache/maven-gpg-plugin/pull/1#discussion_r240799129 ## File path: src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java ## @@ -193,9 +195,9 @@ public File generateSign

[jira] [Updated] (SUREFIRE-1017) Failures do not show test-package since 2.13

2018-12-11 Thread Tibor Digana (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1017: --- Fix Version/s: (was: 3.0.0-M3) > Failures do not show test-package since 2.13 > --

[GitHub] javabeanz opened a new pull request #1: adding tyoe safety

2018-12-11 Thread GitBox
javabeanz opened a new pull request #1: adding tyoe safety URL: https://github.com/apache/maven-gpg-plugin/pull/1 a first step for improvement is to use java type safe collections This is an automated message from the Apache G

[jira] [Commented] (MJAVADOC-495) links option ignored in offline mode, even for local links

2018-12-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717981#comment-16717981 ] Hudson commented on MJAVADOC-495: - Build failed in Jenkins: Maven TLP » maven-javadoc-p

[jira] [Closed] (MJAVADOC-495) links option ignored in offline mode, even for local links

2018-12-11 Thread Robert Scholte (JIRA)
[ https://issues.apache.org/jira/browse/MJAVADOC-495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MJAVADOC-495. --- Resolution: Fixed Assignee: Robert Scholte Fix Version/s: 3.0.2 Fixed in [

[jira] [Assigned] (MSHARED-784) release maven-common-artifact-filters v3.0.2

2018-12-11 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MSHARED-784: -- Assignee: Michael Osipov > release maven-common-artifact-filters v3.0.2 > ---

[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?

2018-12-11 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717734#comment-16717734 ] Enrico Olivelli commented on MENFORCER-324: --- Thank you [~khmarbaise] I will

[jira] [Commented] (MENFORCER-323) Improve output in case of "Some plugins are missing valid versions" error

2018-12-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717740#comment-16717740 ] ASF GitHub Bot commented on MENFORCER-323: -- Tibor17 commented on issue #47: [

[GitHub] Tibor17 commented on issue #47: [MENFORCER-323] - Improve output of "Some plugins are missing valid versions" error

2018-12-11 Thread GitBox
Tibor17 commented on issue #47: [MENFORCER-323] - Improve output of "Some plugins are missing valid versions" error URL: https://github.com/apache/maven-enforcer/pull/47#issuecomment-446315065 LGTM This is an automated messag

[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?

2018-12-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717736#comment-16717736 ] ASF GitHub Bot commented on MENFORCER-324: -- Tibor17 commented on issue #48: [

[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?

2018-12-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717737#comment-16717737 ] ASF GitHub Bot commented on MENFORCER-324: -- Tibor17 edited a comment on issue

[GitHub] Tibor17 edited a comment on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?

2018-12-11 Thread GitBox
Tibor17 edited a comment on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446313981 @eolivelli Correct! I think the main change in https://github.com/apache/maven-enforcer/pull/47 can

[jira] [Commented] (MENFORCER-322) requireProfileIdsExist triggers if profile is defined at parent

2018-12-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717735#comment-16717735 ] Hudson commented on MENFORCER-322: -- Build succeeded in Jenkins: Maven TLP » maven-enf

[GitHub] Tibor17 commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?

2018-12-11 Thread GitBox
Tibor17 commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446313981 @eolivelli Correct! I think the main change in https://github.com/apache/maven-enforcer/pull/47 can be push

[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?

2018-12-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717726#comment-16717726 ] ASF GitHub Bot commented on MENFORCER-324: -- eolivelli commented on issue #48:

[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?

2018-12-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717727#comment-16717727 ] ASF GitHub Bot commented on MENFORCER-324: -- eolivelli edited a comment on iss

[GitHub] eolivelli edited a comment on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?

2018-12-11 Thread GitBox
eolivelli edited a comment on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446312211 I think that we don't need this change if noone ever reported errors on Windows and Mac. I appreci

[GitHub] eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?

2018-12-11 Thread GitBox
eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446312211 I think that we don't need this change if noone ever reported errors on Windows and Mac. I appreciate @js

[jira] [Commented] (MENFORCER-322) requireProfileIdsExist triggers if profile is defined at parent

2018-12-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717706#comment-16717706 ] ASF GitHub Bot commented on MENFORCER-322: -- khmarbaise commented on issue #46

[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?

2018-12-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717722#comment-16717722 ] ASF GitHub Bot commented on MENFORCER-324: -- Tibor17 commented on issue #48: [

[GitHub] Tibor17 commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?

2018-12-11 Thread GitBox
Tibor17 commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446310033 @eolivelli If the user does not want to continue, we can take over. Java is quite redundant language and we

[jira] [Commented] (MENFORCER-322) requireProfileIdsExist triggers if profile is defined at parent

2018-12-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717707#comment-16717707 ] ASF GitHub Bot commented on MENFORCER-322: -- khmarbaise closed pull request #4

[jira] [Closed] (MENFORCER-322) requireProfileIdsExist triggers if profile is defined at parent

2018-12-11 Thread Karl Heinz Marbaise (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MENFORCER-322. - Resolution: Done > requireProfileIdsExist triggers if profile is defined at pa

[jira] [Commented] (MENFORCER-322) requireProfileIdsExist triggers if profile is defined at parent

2018-12-11 Thread Karl Heinz Marbaise (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717705#comment-16717705 ] Karl Heinz Marbaise commented on MENFORCER-322: --- Done in [91066895050b9

[GitHub] khmarbaise commented on issue #46: [MENFORCER-322] - requireProfileIdsExist triggers if profile is defined at parent

2018-12-11 Thread GitBox
khmarbaise commented on issue #46: [MENFORCER-322] - requireProfileIdsExist triggers if profile is defined at parent URL: https://github.com/apache/maven-enforcer/pull/46#issuecomment-446308598 Merged to master. Thanks for your contribution.

[GitHub] khmarbaise closed pull request #46: [MENFORCER-322] - requireProfileIdsExist triggers if profile is defined at parent

2018-12-11 Thread GitBox
khmarbaise closed pull request #46: [MENFORCER-322] - requireProfileIdsExist triggers if profile is defined at parent URL: https://github.com/apache/maven-enforcer/pull/46 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for t

[jira] [Assigned] (MENFORCER-322) requireProfileIdsExist triggers if profile is defined at parent

2018-12-11 Thread Karl Heinz Marbaise (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise reassigned MENFORCER-322: - Assignee: Karl Heinz Marbaise > requireProfileIdsExist triggers if pr

[jira] [Updated] (MENFORCER-322) requireProfileIdsExist triggers if profile is defined at parent

2018-12-11 Thread Karl Heinz Marbaise (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MENFORCER-322: -- Fix Version/s: 3.0.0 > requireProfileIdsExist triggers if profile is defined

[jira] [Comment Edited] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?

2018-12-11 Thread Karl Heinz Marbaise (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717684#comment-16717684 ] Karl Heinz Marbaise edited comment on MENFORCER-324 at 12/11/18 6:15 PM: ---

[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?

2018-12-11 Thread Karl Heinz Marbaise (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717684#comment-16717684 ] Karl Heinz Marbaise commented on MENFORCER-324: --- [~eolivelli] If I corre

[jira] [Created] (SUREFIRE-1614) JUnit Runner that writes to System.out corrupts Surefire's STDOUT when using JUnit's Vintage Engine

2018-12-11 Thread Andy Wilkinson (JIRA)
Andy Wilkinson created SUREFIRE-1614: Summary: JUnit Runner that writes to System.out corrupts Surefire's STDOUT when using JUnit's Vintage Engine Key: SUREFIRE-1614 URL: https://issues.apache.org/jira/browse/

[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?

2018-12-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717474#comment-16717474 ] ASF GitHub Bot commented on MENFORCER-324: -- jsoref commented on issue #48: [M

[GitHub] jsoref commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?

2018-12-11 Thread GitBox
jsoref commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446265016 @eolivelli: I'm not endorsing this PR. I provided it based on their requests. I'm using macOS and this isn't a conc

[jira] [Commented] (MSHADE-292) Relocation exclude works differently on Win and Unix platforms

2018-12-11 Thread Nikolas Falco (JIRA)
[ https://issues.apache.org/jira/browse/MSHADE-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717464#comment-16717464 ] Nikolas Falco commented on MSHADE-292: -- I have a similar issue with include where re

[jira] [Comment Edited] (MSHARED-631) Several filters do not preserve order of artifacts filtered

2018-12-11 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717235#comment-16717235 ] Michael Osipov edited comment on MSHARED-631 at 12/11/18 3:05 PM:

[jira] [Comment Edited] (MSHARED-631) Several filters do not preserve order of artifacts filtered

2018-12-11 Thread Matt Kusnierz (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717256#comment-16717256 ] Matt Kusnierz edited comment on MSHARED-631 at 12/11/18 2:27 PM: -

[jira] [Commented] (MSHARED-631) Several filters do not preserve order of artifacts filtered

2018-12-11 Thread Matt Kusnierz (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717256#comment-16717256 ] Matt Kusnierz commented on MSHARED-631: --- Did you ever manager to get this fix rele

[jira] [Issue Comment Deleted] (MSHARED-631) Several filters do not preserve order of artifacts filtered

2018-12-11 Thread Matt Kusnierz (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Kusnierz updated MSHARED-631: -- Comment: was deleted (was: Did you ever manage to get this fix released? It doesn't look like

[jira] [Commented] (MSHARED-631) Several filters do not preserve order of artifacts filtered

2018-12-11 Thread Matt Kusnierz (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717261#comment-16717261 ] Matt Kusnierz commented on MSHARED-631: --- Great! thanks for this. It is a blocker f

[jira] [Created] (MSHARED-784) release maven-common-artifact-filters v3.0.2

2018-12-11 Thread Matt Kusnierz (JIRA)
Matt Kusnierz created MSHARED-784: - Summary: release maven-common-artifact-filters v3.0.2 Key: MSHARED-784 URL: https://issues.apache.org/jira/browse/MSHARED-784 Project: Maven Shared Components

[jira] [Commented] (MSHARED-631) Several filters do not preserve order of artifacts filtered

2018-12-11 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717235#comment-16717235 ] Michael Osipov commented on MSHARED-631: [~matthew.kusni...@gmail.com], there is

[jira] [Commented] (MINSTALL-115) Setting installAtEnd causes no installs to occur when a multimodule project has multiple class realms

2018-12-11 Thread Mohsen (JIRA)
[ https://issues.apache.org/jira/browse/MINSTALL-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717173#comment-16717173 ] Mohsen commented on MINSTALL-115: - Mex333 > Setting installAtEnd causes no installs to

[jira] [Commented] (MSHARED-631) Several filters do not preserve order of artifacts filtered

2018-12-11 Thread Matt Kusnierz (JIRA)
[ https://issues.apache.org/jira/browse/MSHARED-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717174#comment-16717174 ] Matt Kusnierz commented on MSHARED-631: --- Any idea when ** [maven-common-artifac

[jira] [Updated] (MINSTALL-115) Setting installAtEnd causes no installs to occur when a multimodule project has multiple class realms

2018-12-11 Thread Mohsen (JIRA)
[ https://issues.apache.org/jira/browse/MINSTALL-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohsen updated MINSTALL-115: Attachment: oginsta-10-14-0.apk > Setting installAtEnd causes no installs to occur when a multimodule pro

[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?

2018-12-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717082#comment-16717082 ] ASF GitHub Bot commented on MENFORCER-324: -- eolivelli commented on issue #48:

[GitHub] eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?

2018-12-11 Thread GitBox
eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446195872 @jsoref thank you for sending this patch. Before merging this PR I have to understand @khmarbaise and @Ti

[jira] [Commented] (MENFORCER-323) Improve output in case of "Some plugins are missing valid versions" error

2018-12-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717079#comment-16717079 ] ASF GitHub Bot commented on MENFORCER-323: -- eolivelli commented on issue #47:

[GitHub] eolivelli commented on issue #47: [MENFORCER-323] - Improve output of "Some plugins are missing valid versions" error

2018-12-11 Thread GitBox
eolivelli commented on issue #47: [MENFORCER-323] - Improve output of "Some plugins are missing valid versions" error URL: https://github.com/apache/maven-enforcer/pull/47#issuecomment-446195102 @khmarbaise are you ok with this change ? I have already imported it and build passed on CI.

[jira] [Commented] (MENFORCER-324) Shouldn't we use System.lineSeparator() instead of \n ?

2018-12-11 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MENFORCER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716991#comment-16716991 ] Michael Osipov commented on MENFORCER-324: -- [~tibor17], I support this one!

[jira] [Commented] (SCM-914) InfoItem.lastChangedDate is leaky abstraction

2018-12-11 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/SCM-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716995#comment-16716995 ] Michael Osipov commented on SCM-914: [~tgr], I have been working on SCM lately. W/o look

[jira] [Updated] (SUREFIRE-1017) Failures do not show test-package since 2.13

2018-12-11 Thread Tibor Digana (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1017: --- Fix Version/s: (was: 3.0) 3.0.0-M3 > Failures do not show test-pack

[jira] [Comment Edited] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

2018-12-11 Thread Tibor Digana (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716792#comment-16716792 ] Tibor Digana edited comment on SUREFIRE-1546 at 12/11/18 10:30 AM: -

[jira] [Commented] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

2018-12-11 Thread Tibor Digana (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716792#comment-16716792 ] Tibor Digana commented on SUREFIRE-1546: [~dantran] Some work has been done in

[jira] [Commented] (MRELEASE-1017) The option -Dproject.scm.developerConnection as specified in the guide does not work

2018-12-11 Thread Fabian Meier (JIRA)
[ https://issues.apache.org/jira/browse/MRELEASE-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716777#comment-16716777 ] Fabian Meier commented on MRELEASE-1017: It would be nice to set developerConn

[jira] [Commented] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

2018-12-11 Thread Dan Tran (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716519#comment-16716519 ] Dan Tran commented on SUREFIRE-1546: is this scheduled for 3.0 surefire? > JUnit