javabeanz commented on a change in pull request #1: adding type safety
URL: https://github.com/apache/maven-gpg-plugin/pull/1#discussion_r240835336
##########
File path: src/main/java/org/apache/maven/plugin/gpg/AbstractGpgSigner.java
##########
@@ -193,9 +195,9 @@ public File generateSignatureForArtifact( File file )
signature = new File( signatureDirectory, file.getName() +
SIGNATURE_EXTENSION );
}
- if ( signature.exists() )
+ if ( signature.exists() && signature.delete() )
Review comment:
I also have added some changes to reduce complexity, as suggested by
SonarQube. Some methods have very high complexity, those are still under
development. What is "a soste separate patch" ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
