[GitHub] [lucene-solr] uschindler edited a comment on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build

uschindler edited a comment on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build URL: https://github.com/apache/lucene-solr/pull/1242#issuecomment-584631168 Hi @mocobeta, what's the problem with the source folder? Here it is: https://docs.gradle.org/current/dsl/org

[GitHub] [lucene-solr] uschindler commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build

uschindler commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build URL: https://github.com/apache/lucene-solr/pull/1242#issuecomment-584635945 In short: We should split this PR: - ECJ only task: new name `sourceLint`, defined for each sourceSet separately, de

[GitHub] [lucene-solr] uschindler edited a comment on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build

uschindler edited a comment on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build URL: https://github.com/apache/lucene-solr/pull/1242#issuecomment-584635945 In short: We should split this PR: - ECJ only task: new name `sourceLint`, defined for each sourceSet separat

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

ErickErickson commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377627813 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/createLevAutomata.py ###

[GitHub] [lucene-solr] mocobeta commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build

mocobeta commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build URL: https://github.com/apache/lucene-solr/pull/1242#issuecomment-584671311 > I'd rewrite the whole thing - should I work on it? (I don't have much time, but spending too much time here in explaini

[GitHub] [lucene-solr] dweiss commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build

dweiss commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build URL: https://github.com/apache/lucene-solr/pull/1242#issuecomment-584679461 Don't close the PR, Tomoko. I agree with Uwe that it should be split but what you did is a good start. I'll try to write up

[GitHub] [lucene-solr] ErickErickson commented on issue #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

ErickErickson commented on issue #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#issuecomment-584684502 New PR momentarily. This is an automated message from

[GitHub] [lucene-solr] ErickErickson closed pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

ErickErickson closed pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] ErickErickson opened a new pull request #1251: LUCENE-9134: Port ant-regenerate tasks to Gradle build (util and packed)

ErickErickson opened a new pull request #1251: LUCENE-9134: Port ant-regenerate tasks to Gradle build (util and packed) URL: https://github.com/apache/lucene-solr/pull/1251 This should be the final patch. It turned out to be a 5 minute task to put the hard-coded path in the Ant build so I

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1251: LUCENE-9134: Port ant-regenerate tasks to Gradle build (util and packed)

ErickErickson commented on a change in pull request #1251: LUCENE-9134: Port ant-regenerate tasks to Gradle build (util and packed) URL: https://github.com/apache/lucene-solr/pull/1251#discussion_r377712392 ## File path: gradle/generation/util.gradle ## @@ -0,0 +1,100 @@ +

[GitHub] [lucene-solr] dsmiley commented on issue #357: [SOLR-12238] Synonym Queries boost

dsmiley commented on issue #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#issuecomment-584817004 @romseygeek can you approve the PR if your comments are addressed? Looks good from my end. I really appreciate your input on use of BoostAttribute

[GitHub] [lucene-solr] ErickErickson merged pull request #1251: LUCENE-9134: Port ant-regenerate tasks to Gradle build (util and packed)

ErickErickson merged pull request #1251: LUCENE-9134: Port ant-regenerate tasks to Gradle build (util and packed) URL: https://github.com/apache/lucene-solr/pull/1251 This is an automated message from the Apache Git Service.

[GitHub] [lucene-solr] sarkaramrit2 commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type

sarkaramrit2 commented on a change in pull request #1167: SOLR-13845: DELETEREPLICA API by count and type URL: https://github.com/apache/lucene-solr/pull/1167#discussion_r378082629 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/DeleteReplicaCmd.java ###

[GitHub] [lucene-solr] iverase opened a new pull request #1252: LUCENE-9218: XYGeoemtries should expose values as floats

iverase opened a new pull request #1252: LUCENE-9218: XYGeoemtries should expose values as floats URL: https://github.com/apache/lucene-solr/pull/1252 Boxing the values to doubles happen when creating component2D objects. Thi

[GitHub] [lucene-solr] iverase commented on issue #1249: LUCENE-9217: Add validation to XYGeometries

iverase commented on issue #1249: LUCENE-9217: Add validation to XYGeometries URL: https://github.com/apache/lucene-solr/pull/1249#issuecomment-585091231 I have opened #1252 that should supersede this one. This is an automate

[GitHub] [lucene-solr] mocobeta commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build

mocobeta commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build URL: https://github.com/apache/lucene-solr/pull/1242#issuecomment-585101615 @dweiss thank you for your comments and the patch in Jira. Let me close this PR for now and open another ones (in

[GitHub] [lucene-solr] mocobeta closed pull request #1242: LUCENE-9201: Port documentation-lint task to Gradle build

mocobeta closed pull request #1242: LUCENE-9201: Port documentation-lint task to Gradle build URL: https://github.com/apache/lucene-solr/pull/1242 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [lucene-solr] dweiss commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build

dweiss commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build URL: https://github.com/apache/lucene-solr/pull/1242#issuecomment-585103020 Ok, sure thing. I'll create a sub-task on this issue and maybe try to push the ecj linter forward so that it is there as an

[GitHub] [lucene-solr] nknize opened a new pull request #1253: LUCENE-9150: Restore support for dynamic PlanetModel in spatial3d

nknize opened a new pull request #1253: LUCENE-9150: Restore support for dynamic PlanetModel in spatial3d URL: https://github.com/apache/lucene-solr/pull/1253 This PR adds dynamic geographic datum support to Geo3D to make lucene a viable option for indexing/searching in different spatial r

[GitHub] [lucene-solr] dsmiley commented on issue #357: [SOLR-12238] Synonym Queries boost

dsmiley commented on issue #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#issuecomment-585341721 Personally I'm fine with backporting this although QueryBuilder is not labelled as experimental so I wonder if we are "allowed" to change the API li

[GitHub] [lucene-solr] noblepaul opened a new pull request #1254: SOLR-14259: trying to port to Solr 7.7

noblepaul opened a new pull request #1254: SOLR-14259: trying to port to Solr 7.7 URL: https://github.com/apache/lucene-solr/pull/1254 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [lucene-solr] janhoy opened a new pull request #1255: SOLR-14216 Exclude Healthcheck from auth (do not merge)

janhoy opened a new pull request #1255: SOLR-14216 Exclude Healthcheck from auth (do not merge) URL: https://github.com/apache/lucene-solr/pull/1255 This PR is just to demonstrate how we whitelist paths that should not be authenticated -

[GitHub] [lucene-solr] andywebb1975 removed a comment on issue #1247: SOLR-14252 use double rather than Double to avoid NPE

andywebb1975 removed a comment on issue #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#issuecomment-584087529 The PR really just changes an exception to a warning - it may be papering over another issue. I'm going to try ch

[GitHub] [lucene-solr] andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r377223058 ## File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java ## @@ -9

[GitHub] [lucene-solr] janhoy opened a new pull request #1256: SOLR-10306: Document in Reference Guide how to disable or reduce swapping

janhoy opened a new pull request #1256: SOLR-10306: Document in Reference Guide how to disable or reduce swapping URL: https://github.com/apache/lucene-solr/pull/1256 This is an automated message from the Apache Git Service.

[GitHub] [lucene-solr] alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost

alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#issuecomment-585754884 Documentation has been provided, I had difficulties because of the preCommit (it seems I can't reproduce locally what I get via Github).

[GitHub] [lucene-solr] iverase commented on a change in pull request #1253: LUCENE-9150: Restore support for dynamic PlanetModel in spatial3d

iverase commented on a change in pull request #1253: LUCENE-9150: Restore support for dynamic PlanetModel in spatial3d URL: https://github.com/apache/lucene-solr/pull/1253#discussion_r378913539 ## File path: lucene/spatial3d/src/java/org/apache/lucene/spatial3d/geom/PlanetModel.jav

[GitHub] [lucene-solr] iverase commented on a change in pull request #1253: LUCENE-9150: Restore support for dynamic PlanetModel in spatial3d

iverase commented on a change in pull request #1253: LUCENE-9150: Restore support for dynamic PlanetModel in spatial3d URL: https://github.com/apache/lucene-solr/pull/1253#discussion_r378917756 ## File path: lucene/spatial3d/src/test/org/apache/lucene/spatial3d/geom/Geo3DUtil.java

[GitHub] [lucene-solr] iverase commented on a change in pull request #1253: LUCENE-9150: Restore support for dynamic PlanetModel in spatial3d

iverase commented on a change in pull request #1253: LUCENE-9150: Restore support for dynamic PlanetModel in spatial3d URL: https://github.com/apache/lucene-solr/pull/1253#discussion_r378914442 ## File path: lucene/spatial3d/src/java/org/apache/lucene/spatial3d/geom/PlanetModel.jav

[GitHub] [lucene-solr] iverase commented on a change in pull request #1253: LUCENE-9150: Restore support for dynamic PlanetModel in spatial3d

iverase commented on a change in pull request #1253: LUCENE-9150: Restore support for dynamic PlanetModel in spatial3d URL: https://github.com/apache/lucene-solr/pull/1253#discussion_r378914975 ## File path: lucene/spatial3d/src/test/org/apache/lucene/spatial3d/TestGeo3DPoint.java

[GitHub] [lucene-solr] iverase commented on a change in pull request #1253: LUCENE-9150: Restore support for dynamic PlanetModel in spatial3d

iverase commented on a change in pull request #1253: LUCENE-9150: Restore support for dynamic PlanetModel in spatial3d URL: https://github.com/apache/lucene-solr/pull/1253#discussion_r378909350 ## File path: lucene/spatial3d/src/java/org/apache/lucene/spatial3d/Geo3DDocValuesField.

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

tflobbe commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r379046334 ## File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java ## @@ -51,6 +

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

tflobbe commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r379046621 ## File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java ## @@ -93,18

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

tflobbe commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r379046764 ## File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java ## @@ -114,18

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

tflobbe commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r379047264 ## File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java ## @@ -51,6 +

[GitHub] [lucene-solr] ctargett commented on a change in pull request #1256: SOLR-10306: Document in Reference Guide how to disable or reduce swapping

ctargett commented on a change in pull request #1256: SOLR-10306: Document in Reference Guide how to disable or reduce swapping URL: https://github.com/apache/lucene-solr/pull/1256#discussion_r379129770 ## File path: solr/solr-ref-guide/src/taking-solr-to-production.adoc ##

[GitHub] [lucene-solr] dsmiley opened a new pull request #1257: SOLR-14258: DocList should not extend DocSet

dsmiley opened a new pull request #1257: SOLR-14258: DocList should not extend DocSet URL: https://github.com/apache/lucene-solr/pull/1257 https://issues.apache.org/jira/browse/SOLR-14258 This is an automated message from the

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379307116 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379306326 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379297803 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379305128 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379299380 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379306909 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379298761 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379298212 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379304369 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379304074 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379295432 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379294799 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1252: LUCENE-9218: XYGeometries should expose values as floats

jpountz commented on a change in pull request #1252: LUCENE-9218: XYGeometries should expose values as floats URL: https://github.com/apache/lucene-solr/pull/1252#discussion_r379314365 ## File path: lucene/core/src/java/org/apache/lucene/geo/XYEncodingUtils.java ## @@ -33,

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1252: LUCENE-9218: XYGeometries should expose values as floats

jpountz commented on a change in pull request #1252: LUCENE-9218: XYGeometries should expose values as floats URL: https://github.com/apache/lucene-solr/pull/1252#discussion_r379314539 ## File path: lucene/core/src/java/org/apache/lucene/geo/XYEncodingUtils.java ## @@ -68,

[GitHub] [lucene-solr] jpountz commented on a change in pull request #587: LUCENE-8707: Add LatLonShape and XYShape distance query

jpountz commented on a change in pull request #587: LUCENE-8707: Add LatLonShape and XYShape distance query URL: https://github.com/apache/lucene-solr/pull/587#discussion_r379317415 ## File path: lucene/core/src/java/org/apache/lucene/geo/Circle2D.java ## @@ -0,0 +1,463 @@

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214#discussion_r379320286 ## File path: lucene/core/src/java/org/apache/lucene/search/DefaultExecutionControlPla

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214#discussion_r379322585 ## File path: lucene/core/src/java/org/apache/lucene/search/SliceExecutionControlPlane

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214#discussion_r379320715 ## File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java ###

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214#discussion_r379318977 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.jav

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214#discussion_r379320355 ## File path: lucene/core/src/java/org/apache/lucene/search/DefaultExecutionControlPla

[GitHub] [lucene-solr] jpountz merged pull request #1236: Add back assertions removed by LUCENE-9187.

jpountz merged pull request #1236: Add back assertions removed by LUCENE-9187. URL: https://github.com/apache/lucene-solr/pull/1236 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [lucene-solr] iverase merged pull request #1252: LUCENE-9218: XYGeometries should expose values as floats

iverase merged pull request #1252: LUCENE-9218: XYGeometries should expose values as floats URL: https://github.com/apache/lucene-solr/pull/1252 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [lucene-solr] iverase closed pull request #1249: LUCENE-9217: Add validation to XYGeometries

iverase closed pull request #1249: LUCENE-9217: Add validation to XYGeometries URL: https://github.com/apache/lucene-solr/pull/1249 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [lucene-solr] iverase commented on issue #1249: LUCENE-9217: Add validation to XYGeometries

iverase commented on issue #1249: LUCENE-9217: Add validation to XYGeometries URL: https://github.com/apache/lucene-solr/pull/1249#issuecomment-586204933 fixed in #1252 This is an automated message from the Apache Git Service

[GitHub] [lucene-solr] iverase opened a new pull request #1258: LUCENE-9225: Rectangle should extend LatLonGeometry

iverase opened a new pull request #1258: LUCENE-9225: Rectangle should extend LatLonGeometry URL: https://github.com/apache/lucene-solr/pull/1258 Rectangle now extends LatLonGeometry so it can be used as part of a geometry collection. We need to be careful for Contains and we need to split

[GitHub] [lucene-solr] andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r379397661 ## File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java ## @@ -9

[GitHub] [lucene-solr] andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r379398056 ## File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java ## @@ -5

[GitHub] [lucene-solr] andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r379399436 ## File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java ## @@ -5

[GitHub] [lucene-solr] andywebb1975 commented on issue #1247: SOLR-14252 use double rather than Double to avoid NPE

andywebb1975 commented on issue #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#issuecomment-586263732 Note it's reporter config like the below that triggers the exceptions - the cache metrics include `LocalStatsCache` value

[GitHub] [lucene-solr] iverase commented on a change in pull request #587: LUCENE-8707: Add LatLonShape and XYShape distance query

iverase commented on a change in pull request #587: LUCENE-8707: Add LatLonShape and XYShape distance query URL: https://github.com/apache/lucene-solr/pull/587#discussion_r379411676 ## File path: lucene/core/src/java/org/apache/lucene/geo/Circle2D.java ## @@ -0,0 +1,463 @@

[GitHub] [lucene-solr] alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost

alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#issuecomment-586284506 As I was writing the blog I thought that the Lucene changes would automatically bring the same feature to Elasticsearch, but then I kind

[GitHub] [lucene-solr] janhoy commented on issue #1256: SOLR-10306: Document in Reference Guide how to disable or reduce swapping

janhoy commented on issue #1256: SOLR-10306: Document in Reference Guide how to disable or reduce swapping URL: https://github.com/apache/lucene-solr/pull/1256#issuecomment-586303086 Done some changes. There is probably some sub-par language as well, don't be afraid to shoot me down :) -

[GitHub] [lucene-solr] markharwood commented on a change in pull request #1234: Add compression for Binary doc value fields

markharwood commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379463440 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[GitHub] [lucene-solr] markharwood commented on a change in pull request #1234: Add compression for Binary doc value fields

markharwood commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379463675 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379473860 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[GitHub] [lucene-solr] iverase opened a new pull request #1259: LUCENE-9226: Return CELL_CROSSES_QUERY when point inside the triangle

iverase opened a new pull request #1259: LUCENE-9226: Return CELL_CROSSES_QUERY when point inside the triangle URL: https://github.com/apache/lucene-solr/pull/1259 return the right relation when point side a triangle. This is

[GitHub] [lucene-solr] iverase merged pull request #1259: LUCENE-9226: Return CELL_CROSSES_QUERY when point inside the triangle

iverase merged pull request #1259: LUCENE-9226: Return CELL_CROSSES_QUERY when point inside the triangle URL: https://github.com/apache/lucene-solr/pull/1259 This is an automated message from the Apache Git Service. To respo

[GitHub] [lucene-solr] iverase commented on issue #1259: LUCENE-9226: Return CELL_CROSSES_QUERY when point inside the triangle

iverase commented on issue #1259: LUCENE-9226: Return CELL_CROSSES_QUERY when point inside the triangle URL: https://github.com/apache/lucene-solr/pull/1259#issuecomment-586353925 I push it as it is trivial This is an automat

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

tflobbe commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r379542807 ## File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java ## @@ -51,6 +

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

tflobbe commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r379543081 ## File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java ## @@ -93,18

[GitHub] [lucene-solr] dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader

dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#issuecomment-586399204 FYI tomorrow I'll be on vacation for a week with minimal internet access, so I may not respond much for a bit. Again, I think the issue

[GitHub] [lucene-solr] HoustonPutman opened a new pull request #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param

HoustonPutman opened a new pull request #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param URL: https://github.com/apache/lucene-solr/pull/1260 (cherry picked from commit 325824cd391c8e71f36f17d687f52344e50e9715) Addresses [CVE-2019-0193](https://nvd.nist.

[GitHub] [lucene-solr] HoustonPutman commented on issue #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param

HoustonPutman commented on issue #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param URL: https://github.com/apache/lucene-solr/pull/1260#issuecomment-586434232 I can't `ant precommit`, do to an issue with a missing license in `solr/contrib/clustering/lib/simple-

[GitHub] [lucene-solr] dweiss commented on issue #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param

dweiss commented on issue #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param URL: https://github.com/apache/lucene-solr/pull/1260#issuecomment-586438839 You need to copy this license (and checksum) from master or 8x? -

[GitHub] [lucene-solr] HoustonPutman commented on issue #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param

HoustonPutman commented on issue #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param URL: https://github.com/apache/lucene-solr/pull/1260#issuecomment-586480503 The license file name wasn't updated when the library name was changed in the previous commit. --

[GitHub] [lucene-solr] HoustonPutman commented on issue #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param

HoustonPutman commented on issue #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param URL: https://github.com/apache/lucene-solr/pull/1260#issuecomment-586484779 Ok, so the added tests work, and precommit passes. This should be good to go.

[GitHub] [lucene-solr] athrog opened a new pull request #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil

athrog opened a new pull request #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil URL: https://github.com/apache/lucene-solr/pull/1261 # Description HttpClientUtil.java defines and uses an abstract SchemaRegistryProvider for mapping a protocol to an

[GitHub] [lucene-solr] athrog commented on issue #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil

athrog commented on issue #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil URL: https://github.com/apache/lucene-solr/pull/1261#issuecomment-586520791 FYI @dsmiley This is an automated message from

[GitHub] [lucene-solr] ErickErickson closed pull request #1022: SOLR-13953: Update eviction behavior of cache in Solr Prometheus exporter to allow for larger clusters

ErickErickson closed pull request #1022: SOLR-13953: Update eviction behavior of cache in Solr Prometheus exporter to allow for larger clusters URL: https://github.com/apache/lucene-solr/pull/1022 This is an automated messag

[GitHub] [lucene-solr] ErickErickson commented on issue #1022: SOLR-13953: Update eviction behavior of cache in Solr Prometheus exporter to allow for larger clusters

ErickErickson commented on issue #1022: SOLR-13953: Update eviction behavior of cache in Solr Prometheus exporter to allow for larger clusters URL: https://github.com/apache/lucene-solr/pull/1022#issuecomment-586538447 Forgot to close this when I fixed the JIRA. ---

[GitHub] [lucene-solr] dsmiley commented on issue #1257: SOLR-14258: DocList should not extend DocSet

dsmiley commented on issue #1257: SOLR-14258: DocList should not extend DocSet URL: https://github.com/apache/lucene-solr/pull/1257#issuecomment-586556130 @mkhludnev Thanks for the approval on the first commit about SOLR-14258 (DocList shouldn't implement DocSet). I forged ahead with SOLR-

[GitHub] [lucene-solr] dsmiley commented on issue #1257: SOLR-14258: DocList should not extend DocSet

dsmiley commented on issue #1257: SOLR-14258: DocList should not extend DocSet URL: https://github.com/apache/lucene-solr/pull/1257#issuecomment-586556227 BTW I'm about to step away on vacation for a week with spotty internet access and no computer.

[GitHub] [lucene-solr] janhoy closed pull request #124: fix small issue in solr shell script

janhoy closed pull request #124: fix small issue in solr shell script URL: https://github.com/apache/lucene-solr/pull/124 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [lucene-solr] dweiss closed pull request #829: SOLR-13452: Update the lucene-solr build from Ivy+Ant+Maven (shadow build) to Gradle.

dweiss closed pull request #829: SOLR-13452: Update the lucene-solr build from Ivy+Ant+Maven (shadow build) to Gradle. URL: https://github.com/apache/lucene-solr/pull/829 This is an automated message from the Apache Git Serv

[GitHub] [lucene-solr] dweiss closed pull request #536: LUCENE-8643: Decrease test complexity in the default case. Exclude simple text codec.

dweiss closed pull request #536: LUCENE-8643: Decrease test complexity in the default case. Exclude simple text codec. URL: https://github.com/apache/lucene-solr/pull/536 This is an automated message from the Apache Git Serv

[GitHub] [lucene-solr] dweiss closed pull request #533: LUCENE-8636: TestPointQueries and long execution times

dweiss closed pull request #533: LUCENE-8636: TestPointQueries and long execution times URL: https://github.com/apache/lucene-solr/pull/533 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [lucene-solr] dweiss closed pull request #543: LUCENE-8474: final cleanups and removal of RAMDirectory

dweiss closed pull request #543: LUCENE-8474: final cleanups and removal of RAMDirectory URL: https://github.com/apache/lucene-solr/pull/543 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [lucene-solr] gus-asf commented on issue #976: SOLR-13749: Implement support for joining across collections with multiple shards

gus-asf commented on issue #976: SOLR-13749: Implement support for joining across collections with multiple shards URL: https://github.com/apache/lucene-solr/pull/976#issuecomment-586640936 merged manually This is an automate

[GitHub] [lucene-solr] gus-asf closed pull request #976: SOLR-13749: Implement support for joining across collections with multiple shards

gus-asf closed pull request #976: SOLR-13749: Implement support for joining across collections with multiple shards URL: https://github.com/apache/lucene-solr/pull/976 This is an automated message from the Apache Git Service

[GitHub] [lucene-solr] janhoy closed pull request #1016: SOLR-13662: Test fix & Reference guide for package manager

janhoy closed pull request #1016: SOLR-13662: Test fix & Reference guide for package manager URL: https://github.com/apache/lucene-solr/pull/1016 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [lucene-solr] janhoy closed pull request #500: LUCENE-8517: do not wrap FixedShingleFilter with conditional in TestR…

janhoy closed pull request #500: LUCENE-8517: do not wrap FixedShingleFilter with conditional in TestR… URL: https://github.com/apache/lucene-solr/pull/500 This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene-solr] janhoy closed pull request #529: LUCENE-8617: Use SimpleFSDirectory on non-default FS

janhoy closed pull request #529: LUCENE-8617: Use SimpleFSDirectory on non-default FS URL: https://github.com/apache/lucene-solr/pull/529 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [lucene-solr] janhoy closed pull request #932: SOLR-13829: Stop converting continuous numbers to Longs in Streaming Expressions

janhoy closed pull request #932: SOLR-13829: Stop converting continuous numbers to Longs in Streaming Expressions URL: https://github.com/apache/lucene-solr/pull/932 This is an automated message from the Apache Git Service.

<    1   2   3   4   5   6   7   8   9   10   >